salsify_rubocop 0.48.0 → 0.48.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5e07cf5240f0567f82de5841b7918aced03bbcd1
-  data.tar.gz: 5cf9381c581f64eabf2c9bd1fe5d1dfd08c2e191
+  metadata.gz: 1168006be538d22e3437ab541c048e7b6d16502e
+  data.tar.gz: 1f27eaee901f052080f61c69d6fe10f00e6908e9
 SHA512:
-  metadata.gz: f1f8d75e6ae82ce709e174d327b0008520182f7f9af9ac5d79c1e2fa6df9604c1eeca592ad83502e658ffcffde33d47c77c531f8129c98dbda5e3bb6863f35f0
-  data.tar.gz: 0c093a80290aedf6bee8ba31858b32744b440f7d52d6b4487e0b2734a9ec0f3aeb6414dbdeb6fdc27a23052545e5f5b4fc2bb2d909d72f8cf6c770742b53f67a
+  metadata.gz: b0c8afbcf2b7ff19fa513446155e97bc27182d75244e2652ab52f557123d1539cd160720d659452fded8b9836f5d4eed9945d7f50cab7f79263a5d335dcdcf00
+  data.tar.gz: be74e32b09f5499e75f2bdad040966f7166fb1bbcd00198f25e852596c0a54217e2fc06c880962f4cbff006d46737848322de87b90f516ec1e702297a81b32a6

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # salsify_rubocop
 
+## v0.48.1
+- Add `Salsify/RailsApplicationMailer` cop.
+
 ## v0.48.0
 - Add `Salsify/RspecDotNotSelfDot` cop.
 - Add `Salsify/RailsApplicationSerializer` cop.

data/conf/rubocop_rails50.yml

@@ -7,5 +7,8 @@ AllCops:
 Rails/HttpPositionalArguments:
   Enabled: true
 
+Salsify/RailsApplicationMailer:
+  Enabled: true
+
 Salsify/RailsApplicationRecord:
   Enabled: true

data/config/default.yml

@@ -2,6 +2,10 @@ Salsify/RailsApplicationSerializer:
   Description: 'Serializers must subclass ApplicationSerializer.'
   Enabled: false
 
+Salsify/RailsApplicationMailer:
+  Description: 'Mailers must subclass ApplicationMailer.'
+  Enabled: false
+
 Salsify/RailsApplicationRecord:
   Description: 'Models must subclass ApplicationRecord.'
   Enabled: false

data/lib/rubocop/cop/salsify/rails_application_mailer.rb

@@ -0,0 +1,55 @@
+# encoding: utf-8
+
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Salsify
+      # Check that mailers subclass ApplicationMailer with Rails 5.0
+      #
+      # @example
+      #
+      #  # good
+      #  class Tesla < ApplicationMailer
+      #    ...
+      #  end
+      #
+      #  # bad
+      #  class Yugo < ActionMailer::Base
+      #    ...
+      #  end
+      class RailsApplicationMailer < Cop
+
+        MSG = 'Mailers must subclass ApplicationMailer'.freeze
+        APPLICATION_MAILER = 'ApplicationMailer'.freeze
+        ACTIVE_MAILER_BASE_PATTERN = '(const (const nil :ActionMailer) :Base)'.freeze
+
+        def_node_matcher :mailer_class_definition, <<-PATTERN
+        (class (const _ !:ApplicationMailer) #{ACTIVE_MAILER_BASE_PATTERN} ...)
+        PATTERN
+
+        def_node_matcher :class_new_definition, <<-PATTERN
+        [!^(casgn nil :ApplicationMailer ...) (send (const nil :Class) :new #{ACTIVE_MAILER_BASE_PATTERN})]
+        PATTERN
+
+        def on_class(node)
+          mailer_class_definition(node) do
+            add_offense(node.children[1], :expression, MSG)
+          end
+        end
+
+        def on_send(node)
+          class_new_definition(node) do
+            add_offense(node.children.last, :expression, MSG)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(node.source_range, APPLICATION_MAILER)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/salsify_rubocop.rb

@@ -13,6 +13,7 @@ config = RuboCop::ConfigLoader.merge_with_default(config, path)
 RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, config)
 
 # cops
+require 'rubocop/cop/salsify/rails_application_mailer'
 require 'rubocop/cop/salsify/rails_application_serializer'
 require 'rubocop/cop/salsify/rails_application_record'
 require 'rubocop/cop/salsify/rspec_doc_string'

data/lib/salsify_rubocop/version.rb

@@ -1,3 +1,3 @@
 module SalsifyRubocop
-  VERSION = '0.48.0'.freeze
+  VERSION = '0.48.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: salsify_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.48.0
+  version: 0.48.1
 platform: ruby
 authors:
 - Salsify, Inc
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-04-11 00:00:00.000000000 Z
+date: 2017-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -103,6 +103,7 @@ files:
 - conf/rubocop_rails50.yml
 - conf/rubocop_without_rspec.yml
 - config/default.yml
+- lib/rubocop/cop/salsify/rails_application_mailer.rb
 - lib/rubocop/cop/salsify/rails_application_record.rb
 - lib/rubocop/cop/salsify/rails_application_serializer.rb
 - lib/rubocop/cop/salsify/rspec_doc_string.rb