salsify_rubocop 0.47.0 → 0.47.1.rc0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 54eeb7c8935c758f5c04a6004192c22dda001a96
-  data.tar.gz: ea4c89cf4327a24fa1d8e8dab2ca5c764f87ccb4
+  metadata.gz: 5dcbe21b6de7a233cf330a202722885b87a49a91
+  data.tar.gz: 2da2ae030c4cd422fecab9b16846759800b7e289
 SHA512:
-  metadata.gz: 7b6e358f57155c0af444e5d541d2647c5fa5aae878d074a50fa160a392278c799ec2453db811eca0de802248d3af162dbbd152f8858177b1e7bb656af2ce515d
-  data.tar.gz: bc7f74274cf5f7a729af34b178fa69f414848f6ae66c61426e9ba7f020b03823ab09f1cc51f9f93c9577fdfabc19643afce82b28cd2ccdc3a5d4c6ca0f82b7b9
+  metadata.gz: b12655ea2c8447a16bf5036f7576929b896fdff422d3b77b4274978edea6dd1042cde48da63502860735839642fb69f6fb4646ef00a0ed6ce740263cd6436c40
+  data.tar.gz: c9d2e1785dfded5b97b815456d6fd76a1f7f1edb68827cad7bb5ef7e9b59df1e1dd72379625426597756f8747384155dbf1c00708cb2f027d815642471c97b2f

data/.travis.yml

@@ -1,7 +1,11 @@
 language: ruby
 rvm:
-  - 2.2.4
+  - 2.4.0
   - 2.3.3
+  - 2.2.6
+before_install:
+  # Workaround for https://github.com/sickill/rainbow/issues/48
+  - gem update --system
 script:
   - bundle exec rubocop
   - bundle exec rspec

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # salsify_rubocop
 
+## v0.47.1
+- Add `Salsify/StyleDig` cop to recommend using `#dig` for deeply nested access.
+
 ## v0.47.0
 - Update to `rubocop` v0.47.1 and `rubocop-rspec` v1.10.0.
 - Enable `Bundler/OrderedGems` now that auto-correct is supported.

data/config/default.yml

@@ -18,3 +18,8 @@ Salsify/RspecStringLiterals:
 #  Include:
 #    - 'spec/**/*'
 
+Salsify/StyleDig:
+  Description: 'Recommend `dig` for deeply nested access.'
+  Enabled: true
+  AutoCorrect: false
+

data/lib/rubocop/cop/salsify/rspec_doc_string.rb

@@ -6,8 +6,6 @@ module RuboCop
       # Check that doc strings for example groups and examples use either
       # single-quoted or double-quoted strings based on the enforced style.
       #
-      # This cop is disabled by default.
-      #
       # @example
       #
       #   # When EnforcedStyle is double_quotes

data/lib/rubocop/cop/salsify/style_dig.rb

@@ -0,0 +1,64 @@
+# encoding: utf-8
+
+module RuboCop
+  module Cop
+    module Salsify
+      # Use `dig` for deeply nested access.
+      #
+      # @example
+      #
+      #   # good
+      #   my_hash.dig('foo', 'bar')
+      #   my_array.dig(0, 1)
+      #
+      #   # bad
+      #   my_hash['foo']['bar']
+      #   my_hash['foo'] && my_hash['foo']['bar']
+      #   my_array[0][1]
+
+      class StyleDig < Cop
+        extend TargetRubyVersion
+
+        minimum_target_ruby_version 2.3
+
+        MSG = 'Use `dig` for nested access.'.freeze
+
+        def_node_matcher :nested_access_match, <<-PATTERN
+          (send (send (send _receiver !:[]) :[] _) :[] _)
+        PATTERN
+
+        def on_send(node)
+          nested_access_match(node) do
+            match_node = node
+            # walk to outermost access node
+            match_node = match_node.parent while access_node?(match_node.parent)
+            add_offense(match_node, :expression, MSG)
+          end
+        end
+
+        def autocorrect(node)
+          access_node = node
+          source_args = [access_node.method_args.first.source]
+          while access_node?(access_node.children.first)
+            access_node = access_node.children.first
+            source_args << access_node.method_args.first.source
+          end
+          root_node = access_node.children.first
+
+          lambda do |corrector|
+            range = Parser::Source::Range.new(node.source_range.source_buffer,
+                                              root_node.source_range.end_pos,
+                                              node.source_range.end_pos)
+            corrector.replace(range, ".dig(#{source_args.reverse.join(', ')})")
+          end
+        end
+
+        private
+
+        def access_node?(node)
+          node && node.send_type? && node.method_name == :[]
+        end
+      end
+    end
+  end
+end

data/lib/salsify_rubocop/version.rb

@@ -1,3 +1,3 @@
 module SalsifyRubocop
-  VERSION = '0.47.0'.freeze
+  VERSION = '0.47.1.rc0'.freeze
 end

data/lib/salsify_rubocop.rb

@@ -15,3 +15,4 @@ RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, config)
 # cops
 require 'rubocop/cop/salsify/rspec_doc_string'
 require 'rubocop/cop/salsify/rspec_string_literals'
+require 'rubocop/cop/salsify/style_dig'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: salsify_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.47.0
+  version: 0.47.1.rc0
 platform: ruby
 authors:
 - Salsify, Inc
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-01-20 00:00:00.000000000 Z
+date: 2017-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -104,6 +104,7 @@ files:
 - config/default.yml
 - lib/rubocop/cop/salsify/rspec_doc_string.rb
 - lib/rubocop/cop/salsify/rspec_string_literals.rb
+- lib/rubocop/cop/salsify/style_dig.rb
 - lib/rubocop/rspec/language/each_selector.rb
 - lib/salsify_rubocop.rb
 - lib/salsify_rubocop/version.rb
@@ -124,12 +125,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Shared shared RuboCop configuration