salesflip-jobboersen_integration 0.2.3 → 0.2.4

data/lib/app/lib/contact_extras.rb

@@ -3,8 +3,8 @@ module ContactExtras
     base.class_eval do
       field :tjb_id
       
-      after_create :create_in_tjb
-      after_update :update_in_tjb, :unless => :do_not_update
+      after_create :create_in_tjb, :if => :has_account?
+      after_update :update_in_tjb, :unless => :do_not_update, :if => :has_account?
       
       attr_accessor :do_not_update
     end
@@ -47,5 +47,9 @@ module ContactExtras
     def generate_password
       Array.new(10/2) { rand(256) }.pack('C*').unpack('H*').first
     end
+    
+    def has_account?
+      !account.blank?
+    end
   end
 end

data/lib/jobboersen_integration/engine.rb

@@ -19,7 +19,7 @@ module JobboersenIntegration
       Salesflip::Plugin.register(:jobboersen_integration) do
         name        'JobBoersen Integration'
         author      'Matt Beedle'
-        version     '0.2.3'
+        version     '0.2.4'
         description 'Everything to seemlessly integrate 1000jobboersen.de'
       end
       
@@ -29,9 +29,6 @@ module JobboersenIntegration
       require 'app/lib/user_extras'
       User.send(:include, UserExtras)
       
-      require 'app/lib/contact_extras'
-      Contact.send(:include, ContactExtras)
-      
       require 'app/lib/controller_hooks'
     end
   end

data/test/models/contact.rb

@@ -6,6 +6,7 @@ class Contact
   field :email
   
   referenced_in :user
+  referenced_in :account
   
   validates_presence_of :last_name, :user
 end

data/test/unit/contact_test.rb

@@ -2,8 +2,14 @@ require 'test_helper'
 
 class ContactTest < ActiveSupport::TestCase
   setup do
+    FakeWeb.register_uri(:post,
+      'http://1000jobboersen.de/administration/accounts.xml?auth_token=La9Hbm8SnPJN-F-zUhlp',
+      :body => File.read('test/support/account_create_success.xml'))
+    FakeWeb.register_uri(:post, 'http://1000jobboersen.de/administration/administrators.xml',
+      :body => File.read('test/support/administrator_create_success.xml'))
     Contact.send(:include, ContactExtras)
     @user = User.create :email => 'test@test.com', :tjb_auth_token => 'La9Hbm8SnPJN-F-zUhlp'
+    @account = Account.create :name => 'test account', :user => @user
   end
   
   should 'have tjb_id field' do
@@ -16,74 +22,112 @@ class ContactTest < ActiveSupport::TestCase
   end
   
   context 'creating a new contact (user)' do
-    should 'only send first_name, last_name, email, password and password_confirmation in xml' do
-      contact = Contact.new :first_name => 'Matt', :last_name => 'Beedle',
-        :email => 'mattbeedle@googlemail.com', :password => 'berlin5000',
-        :password_confirmation => 'berlin5000', :another_field => 'asfewaf'
-      assert_match(/first\-name/, contact.tjb_xml)
-      assert_match(/last\-name/, contact.tjb_xml)
-      assert_match(/email/, contact.tjb_xml)
-      assert_match(/password/, contact.tjb_xml)
-      assert_match(/password\-confirmation/, contact.tjb_xml)
-      assert_no_match(/another\-field/, contact.tjb_xml)
-    end
+    context 'when the contact has an associated account' do
+      setup do
+        @contact = Contact.new :first_name => 'Matt', :last_name => 'Beedle',
+          :email => 'mattbeedle@googlemail.com', :password => 'berlin5000',
+          :password_confirmation => 'berlin5000', :another_field => 'asfewaf',
+          :account => @account, :user => @user
+      end
+      
+      should 'only send first_name, last_name, email, password and password_confirmation in xml' do
+        assert_match(/first\-name/, @contact.tjb_xml)
+        assert_match(/last\-name/, @contact.tjb_xml)
+        assert_match(/email/, @contact.tjb_xml)
+        assert_match(/password/, @contact.tjb_xml)
+        assert_match(/password\-confirmation/, @contact.tjb_xml)
+        assert_no_match(/another\-field/, @contact.tjb_xml)
+      end
   
-    should 'set the tjb_id when the contact has been created in 1000jobboersen' do
-      FakeWeb.register_uri(:post,
-        "http://1000jobboersen.de/administration/contacts.xml?auth_token=#{@user.tjb_auth_token}",
-        :body => File.read('test/support/contact_create_success.xml'))
-      contact = Contact.create! :first_name => 'Matt', :last_name => 'Beedle',
-        :email => 'mattbeedle@googlemail.com', :user => @user
-      assert_equal '4b8ead6a24d8f247be001073', contact.tjb_id
-    end
+      should 'set the tjb_id when the contact has been created in 1000jobboersen' do
+        FakeWeb.register_uri(:post,
+          "http://1000jobboersen.de/administration/users.xml?auth_token=#{@user.tjb_auth_token}",
+          :body => File.read('test/support/contact_create_success.xml'))
+        @contact.save!
+        assert_equal '4b8ead6a24d8f247be001073', @contact.tjb_id
+      end
   
-    should 'not blow up when 1000jobboersen returns an error response' do
-      FakeWeb.register_uri(:post,
-        "http://1000jobboersen.de/administration/contacts.xml?auth_token=#{@user.tjb_auth_token}",
-        :status => '500')
-      contact = Contact.create! :first_name => 'Matt', :last_name => 'Beedle',
-        :email => 'mattbeedle@googlemail.com', :user => @user
-      assert !contact.new_record?
+      should 'not blow up when 1000jobboersen returns an error response' do
+        FakeWeb.register_uri(:post,
+          "http://1000jobboersen.de/administration/contacts.xml?auth_token=#{@user.tjb_auth_token}",
+          :status => '500')
+        @contact.save!
+        assert !@contact.new_record?
+      end
+    end
+    
+    context 'when the contact does not have an associated account' do
+      setup do
+        @contact = Contact.new :first_name => 'Matt', :last_name => 'Beedle',
+          :email => 'mattbeedle@googlemail.com', :password => 'berlin5000',
+          :password_confirmation => 'berlin5000', :another_field => 'asfewaf',
+          :user => @user
+      end
+      
+      should 'not attempt to create a user in 1000jb' do
+        FakeWeb.register_uri(:post,
+          "http://1000jobboersen.de/administration/users.xml?auth_token=#{@user.tjb_auth_token}",
+          :body => File.read('test/support/contact_create_success.xml'))
+        @contact.save!
+        assert @contact.tjb_id.blank?
+      end
     end
   end
   
   context 'updating a contact' do
+    setup do
+      @contact = Contact.new :first_name => 'Matt', :last_name => 'Beedle',
+        :email => 'mattbeedle@googlemail.com', :user => @user, :account => @account
+    end
+    
     context 'when the contact exists in 1000jobboersen' do
       setup do
         FakeWeb.register_uri(:post,
-          "http://1000jobboersen.de/administration/contacts.xml?auth_token=#{@user.tjb_auth_token}",
+          "http://1000jobboersen.de/administration/users.xml?auth_token=#{@user.tjb_auth_token}",
           :body => File.read('test/support/contact_create_success.xml'))
       end
     
       should 'not blow up when an error response is returned' do
-        contact = Contact.create! :first_name => 'Matt', :last_name => 'Beedle',
-          :email => 'mattbeedle@googlemail.com', :user => @user
+        @contact.save!
         FakeWeb.register_uri(:put,
-          "http://1000jobboersen.de/administration/users/#{contact.tjb_id}.xml?auth_token=#{@user.tjb_auth_token}",
+          "http://1000jobboersen.de/administration/users/#{@contact.tjb_id}.xml?auth_token=#{@user.tjb_auth_token}",
           :status => '500')
-        contact = Contact.find(contact.id)
-        contact.update_attributes :first_name => 'test'
-        assert contact.valid?
+        @contact = Contact.find(@contact.id)
+        @contact.update_attributes :first_name => 'test'
+        assert @contact.valid?
       end
     end
     
     context 'when the contact does not exist in 1000jobboersen' do
       setup do
         FakeWeb.register_uri(:post,
-          "http://1000jobboersen.de/administration/contacts.xml?auth_token=#{@user.tjb_auth_token}",
+          "http://1000jobboersen.de/administration/users.xml?auth_token=#{@user.tjb_auth_token}",
           :status => '500')
-        @contact = Contact.create! :first_name => 'Matt', :last_name => 'Beedle',
-            :email => 'mattbeedle@googlemail.com', :user => @user
+        @contact.save!
       end
       
       should 'create the contact (user) in 1000jobboersen' do
         FakeWeb.register_uri(:post,
-          "http://1000jobboersen.de/administration/contacts.xml?auth_token=#{@user.tjb_auth_token}",
+          "http://1000jobboersen.de/administration/users.xml?auth_token=#{@user.tjb_auth_token}",
           :body => File.read('test/support/contact_create_success.xml'))
         assert @contact.tjb_id.blank?
         @contact.update_attributes :first_name => 'someone'
         assert_equal '4b8ead6a24d8f247be001073', @contact.tjb_id
       end
+      
+      context 'when the contact does not have an account' do
+        setup do
+          @contact.account = nil
+        end
+        
+        should 'not attempt to create the user in 1000jobboersen' do
+          FakeWeb.register_uri(:post,
+            "http://1000jobboersen.de/administration/users.xml?auth_token=#{@user.tjb_auth_token}",
+            :body => File.read('test/support/contact_create_success.xml'))
+          @contact.save!
+          assert @contact.tjb_id.blank?
+        end
+      end
     end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: salesflip-jobboersen_integration
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 31
   prerelease: false
   segments: 
   - 0
   - 2
-  - 3
-  version: 0.2.3
+  - 4
+  version: 0.2.4
 platform: ruby
 authors: []
 
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-11-01 00:00:00 +01:00
+date: 2010-11-02 00:00:00 +01:00
 default_executable: 
 dependencies: []