salesflip-jobboersen_integration 0.1.0 → 0.1.1

data/lib/app/lib/account_extras.rb

@@ -16,15 +16,15 @@ module AccountExtras
       response = connection.post(
         "/administration/accounts.xml?auth_token=#{self.user.tjb_auth_token}",
           self.to_xml(:only => [:name]))
-      doc = REXML::Document.new(response.body)
-      self.update_attributes :tjb_id => REXML::XPath.first(doc, '//_id').text,
+      attributes = Hash.from_xml(response.body)['account']
+      self.update_attributes :tjb_id => attributes['_id'],
         :do_not_update => true
     rescue
       nil
     end
     
     def update_in_tjb
-      connection.put("/administration/accounts/#{self.id}.xml?auth_token=#{self.user.tjb_auth_token}",
+      connection.put("/administration/accounts/#{self.tjb_id}.xml?auth_token=#{self.user.tjb_auth_token}",
         self.to_xml(:only => [:name]))
     end
     

data/lib/app/lib/contact_extras.rb

@@ -16,15 +16,15 @@ module ContactExtras
     def create_in_tjb
       response = connection.post(
         "/administration/contacts.xml?auth_token=#{self.user.tjb_auth_token}", tjb_xml)
-      doc = REXML::Document.new(response.body)
-      self.update_attributes :tjb_id => REXML::XPath.first(doc, '//_id').text, :do_not_update => true
+      attributes = Hash.from_xml(response.body)['user']
+      self.update_attributes :tjb_id => attributes['_id'], :do_not_update => true
     rescue
       nil
     end
     
     def update_in_tjb
-      response = connection.put(
-        "/administration/contacts/#{self.id}.xml?auth_token=#{self.user.tjb_auth_token}", tjb_xml)
+      connection.put(
+        "/administration/contacts/#{self.tjb_id}.xml?auth_token=#{self.user.tjb_auth_token}", tjb_xml)
     rescue
       nil
     end

data/lib/app/lib/user_extras.rb

@@ -1,5 +1,3 @@
-require 'rexml/document'
-
 module UserExtras
   def self.included( base )
     base.class_eval do
@@ -20,9 +18,9 @@ module UserExtras
       response = connection.post('/administration/administrators.xml',
         self.to_xml(:only => :email))
       if response.code == '200'
-        doc = REXML::Document.new(response.body)
-        self.update_attributes :tjb_id => REXML::XPath.first(doc, '//_id').text,
-          :tjb_auth_token => REXML::XPath.first(doc, '//authentication_token').text,
+        attributes = Hash.from_xml(response.body)['administrator']
+        self.update_attributes :tjb_id => attributes['_id'],
+          :tjb_auth_token => attributes['authentication_token'],
           :do_not_update => true
       end
     rescue
@@ -30,14 +28,15 @@ module UserExtras
     end
     
     def update_in_tjb
-      connection.put("/administration/administrators/#{self.id}.xml",
+      connection.put(
+        "/administration/administrators/#{self.tjb_id}.xml?auth_token=#{self.tjb_auth_token}",
         self.to_xml(:only => :email))
     rescue
       nil
     end
     
     def connection
-      connection = ActiveResource::Connection.new(JobboersenIntegration.jobboersen_uri)
+      ActiveResource::Connection.new(JobboersenIntegration.jobboersen_uri)
     end
   end
 end

data/lib/jobboersen_integration/engine.rb

@@ -19,7 +19,7 @@ module JobboersenIntegration
       Salesflip::Plugin.register(:jobboersen_integration) do
         name        'JobBoersen Integration'
         author      'Matt Beedle'
-        version     '0.4'
+        version     '1.1'
         description 'Everything to seemlessly integrate 1000jobboersen.de'
       end
       

data/test/unit/user_test.rb

@@ -17,17 +17,19 @@ class UserTest < ActiveSupport::TestCase
   should 'have tjb_auth_token field' do
     assert User.fields.map(&:first).include?('tjb_auth_token')
   end
-  
-  context 'when the user does not exist in 1000jobboersen' do
-    setup do
-      FakeWeb.register_uri(:post, 'http://1000jobboersen.de/administration/administrators.xml',
-        :body => File.read('test/support/administrator_create_success.xml'))
-    end
     
-    should 'update the tjb_id when the administrator account has been created in 1000jobboersen' do
-      user = User.create! :email => 'test@test.com'
-      assert_equal '4bcdbfea24d8f22230000011', user.tjb_id
-      assert_equal 'La9Hbm8SnPJN-F-zUhlp', user.tjb_auth_token
-    end
+  should 'update the tjb_id when the administrator account has been created in 1000jobboersen' do
+    FakeWeb.register_uri(:post, 'http://1000jobboersen.de/administration/administrators.xml',
+      :body => File.read('test/support/administrator_create_success.xml'))
+    user = User.create! :email => 'test@test.com'
+    assert_equal '4bcdbfea24d8f22230000011', user.tjb_id
+    assert_equal 'La9Hbm8SnPJN-F-zUhlp', user.tjb_auth_token
+  end
+  
+  should 'not blow up when an error response is returned' do
+    FakeWeb.register_uri(:post, 'http://1000jobboersen.de/administration/administrators.xml',
+      :status => '500')
+    user = User.create! :email => 'test@test.com'
+    assert !user.new_record?
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: salesflip-jobboersen_integration
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: false
   segments: 
   - 0
   - 1
-  - 0
-  version: 0.1.0
+  - 1
+  version: 0.1.1
 platform: ruby
 authors: []