sale 0.2.3 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e907e7903a3616b692d89ffc1be3ea2beabf22868f764c8baf84ab2446236fc0
-  data.tar.gz: f6bd050fdaa7e9fbdc510ae600e22511cbd15d95f1308995dfa3100a39af3a0c
+  metadata.gz: 4f13c7abfb98242baee18eff267f67c01459f7d2fad56568285ec3def45942c0
+  data.tar.gz: '077198da5bad9c310475262f4e73ea1c0426ce687269eec388abeb76cc558508'
 SHA512:
-  metadata.gz: dbf4a7142ad3d143023f4dcee9cb300b837f2ab4939b446947495c5851a8cf50cfaecd54f6921019423de8267ec7ee2b8c6f967a54b710e0e71854e9e4c04739
-  data.tar.gz: cbf2459996e66b35fd08dc4ad8fbcdf30baf2eb707231642871cbecd1c0dcd1a99cd632e42059cdd1f9786f0dd37b59a80c74272104611da35be979df48f057f
+  metadata.gz: 0f8c24cd336eb83672d2159f6b812845ce4464e2d7cbadd1e9452907d17def29e0d0f12a7c969639edfb13f3d706ea11072aec52b5e06a2e05839eaf6592cbd7
+  data.tar.gz: ca341954f9353c658bc328aa0f7ebc57e9f68ca217a1b8e69e84ad25efff91d8ff41639a110a51d25546ed3c91c1dd5b80af16a84f317fdcf759a695c3197cb4

data/.gitignore

@@ -0,0 +1,2 @@
+gems.locked
+pkg

data/lib/sale/entity.rb

@@ -1,3 +1,6 @@
+require 'cgi'
+require 'dagger'
+
 class Entity
   include Enumerable
 
@@ -40,6 +43,10 @@ class Entity
     to_a.size
   end
 
+  def total_entries
+    data['count']
+  end
+
   alias_method :size, :count
 
   def items
@@ -56,19 +63,19 @@ class Entity
   end
 
   def has_prev_page?
-    data['prev']
+    !!data['prev']
   end
 
   def has_next_page?
-    data['next']
+    !!data['next']
   end
 
   def prev_page
-    data['prev'] ? follow_link(data['prev'], @original_params) : nil
+    data['prev'] ? follow_link(fix_link(data['prev']), @original_params) : nil
   end
 
   def next_page
-    data['next'] ? follow_link(data['next'], @original_params) : nil
+    data['next'] ? follow_link(fix_link(data['next']), @original_params) : nil
   end
 
   def method_missing(name, *args)
@@ -97,13 +104,21 @@ class Entity
   #   false
   # end
 
+  def fix_link(href)
+    uri = URI.parse(href)
+    link_params = CGI.parse(uri.query || '').transform_values(&:first)
+    new_params  = maybe_stringify(@original_params || {}).merge(link_params)
+    uri.query   = Dagger::Utils.encode(new_params) if new_params.any?
+    uri.to_s
+  end
+
   def is_hash?(obj)
     obj.is_a?(Hash)
   end
 
   def maybe_stringify(obj)
     return obj unless is_hash?(obj)
-    obj.inject({}) { |memo,(k,v) | memo[k.to_s] = v; memo }
+    obj.inject({}) { |memo,(k,v)| memo[k.to_s] = v; memo }
   end
 
   def follow_link(href, params = nil)

data/lib/sale/invoices.rb

@@ -17,16 +17,23 @@ class Bsale::Invoices
     end
   end
 
-  def create(codeSii:, emissionDate:, expirationDate:, declareSii:, priceListId:, \
+  def create(codeSii: nil, documentTypeId: nil, emissionDate:, expirationDate:, declareSii:, priceListId:, \
     officeId: nil, clientId: nil, client: nil, details: nil, payments: nil)
 
     body = {
-      codeSii: codeSii, # we could also use "documentTypeId"
       declareSii: declareSii,
       emissionDate: emissionDate,
       expirationDate: expirationDate
     }
 
+    if documentTypeId
+      body[:documentTypeId] = documentTypeId
+    elsif codeSii
+      body[:codeSii] = codeSii
+    else
+      raise ArgumentError, "Either codeSii or documentTypeId required"
+    end
+
     body[:officeId] = officeId if officeId
     body[:priceListId] = priceListId if priceListId
 
@@ -35,7 +42,7 @@ class Bsale::Invoices
     elsif client
       body[:client] = client
     elsif [33, 34].include?(codeSii.to_i) # facturas requiren clientId
-      raise 'clientId or client required' 
+      raise 'clientId or client required'
     end
 
     body[:details]  = details  if details

data/sale.gemspec

@@ -3,7 +3,7 @@
 
 Gem::Specification.new do |s|
   s.name        = 'sale'
-  s.version     = '0.2.3'
+  s.version     = '0.3.0'
   s.platform    = Gem::Platform::RUBY
   s.authors     = ['Tomás Pollak']
   s.email       = ['tomas@bootic.net']
@@ -17,7 +17,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency "rspec-mocks"
   s.add_development_dependency "rspec-expectations"
 
-  s.add_runtime_dependency "dagger", "~> 1.3.1"
+  s.add_runtime_dependency "dagger", "~> 1.4.1"
 
   s.files        = `git ls-files`.split("\n")
   s.executables  = `git ls-files`.split("\n").map{|f| f =~ /^bin\/(.*)/ ? $1 : nil}.compact

data/spec/base_spec.rb

@@ -13,7 +13,7 @@ describe 'APIBase' do
   describe '#request' do
     it 'explodes with 401 error if invalid token' do
       expect do
-        resp = subject.get('foo')
+        resp = subject.get('foo.json')
       end.to raise_error(Bsale::InvalidResponseError)
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sale
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.3.0
 platform: ruby
 authors:
 - Tomás Pollak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-24 00:00:00.000000000 Z
+date: 2019-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.1
+        version: 1.4.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.1
+        version: 1.4.1
 description: A wrapper around the Bsale API.
 email:
 - tomas@bootic.net
@@ -87,6 +87,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".gitignore"
 - Rakefile
 - gems.rb
 - lib/sale.rb