safe_target_blank 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 07e478391e0239ab2828da2e031537f96f2178e8
-  data.tar.gz: 4c6c4b332a62fa934ddc79ce236b0b45be4a5b52
+SHA256:
+  metadata.gz: 2e7638db730f7b99a04a6b1faf2cdcaeb725a5b51bf2600aebeb6b1d7fdc71c9
+  data.tar.gz: 3005292cd91831112836e7b194162d6b979bffb97791b8d7b9accad0eaf10278
 SHA512:
-  metadata.gz: 48a8e2f2a9549c1ee38129219e5033c619c8cfff36322d38b31cc82c8132f6c20aaa46f6ef3ed22b2ab1baf292dfd8482ab1e15056ffefa50cdfa03df8c31489
-  data.tar.gz: b119b1329724943f95a2bf9bd8324a48bd6c40e4f2d6f2f8ac98893463539c8ad40b32b22b821965f43c57a7230f9a8eb810f2b7f4e76bfb297eb4644b71ca84
+  metadata.gz: 4d33a4aa5cf89570a8a0656e69b1998728264f94661424ab8a132577e6d406bf831ca648e9b41c80d61a457d1095cffa637fb23437b5e08c00e9e395e172de5a
+  data.tar.gz: 4ad8e6397a57671cde91afe5205eea5ba64ed51e880f5f08b18493b84e26e66676a8a452e45e8ec54e5e665811085348afc4bfdf569aec8834e4b58f9e3f3ffc

data/.gitignore

@@ -9,4 +9,5 @@
 /tmp/
 
 *.gem
+*.gemfile.lock
 .idea

data/.travis.yml

@@ -1,4 +1,7 @@
 language: ruby
+before_install: gem install bundler -v 1.11.2
 rvm:
   - 2.3.1
-before_install: gem install bundler -v 1.11.2
+gemfile:
+  - gemfiles/rails_4.gemfile
+  - gemfiles/rails_5.gemfile

data/Appraisals

@@ -0,0 +1,7 @@
+appraise 'rails-4' do
+  gem 'rails', '4.2.7.1'
+end
+
+appraise 'rails-5' do
+  gem 'rails', '5.0.0.1'
+end

data/README.md

@@ -20,14 +20,14 @@ Add this line to your application's Gemfile:
 Now each time you use the `link_to` helper with `target="_blank"`, `rel="noopener noreferrer"` will be added.
  
 ```ruby
-link_to 'Safe', 'safe.io', taget: :_blank
+link_to 'Safe', 'safe.io', target: :_blank
 #=> '<a target="_blank" rel="noopener noreferrer" href="safe.io">Safe</a>'
 ``` 
 
 You can opt out with `opener` and `referrer` options.
 
 ```ruby
-link_to 'Safe', 'safe.io', taget: :_blank, referrer: true
+link_to 'Safe', 'safe.io', target: :_blank, referrer: true
 #=> '<a target="_blank" rel="noopener" href="safe.io">Safe</a>'
 ``` 
 
@@ -35,14 +35,17 @@ Or disable it globally.
 
 ```ruby
 SafeTargetBlank.opener = true
-link_to 'Safe', 'safe.io', taget: :_blank
+link_to 'Safe', 'safe.io', target: :_blank
 #=> '<a target="_blank" rel="noreferrer" href="safe.io">Safe</a>'
 ``` 
 
 ## Contributing
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+After checking out the repo, run `bin/setup` to install dependencies.
+Then, run `rake` to run the tests.
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/jvenezia/safe_target_blank. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+
+Bug reports and pull requests are welcome on GitHub.
 
 ## License
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/Rakefile

@@ -1,6 +1,11 @@
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
+require 'appraisal'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task default: :spec
+if !ENV['APPRAISAL_INITIALIZED'] && !ENV['TRAVIS']
+  task default: :appraisal
+else
+  task default: :spec
+end

data/bin/setup

@@ -3,4 +3,5 @@ set -euo pipefail
 IFS=$'\n\t'
 set -vx
 
-bundle install
+bundle install
+appraisal install

data/gemfiles/rails_4.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal"
+gem "rails", "4.2.7.1"
+
+gemspec :path => "../"

data/gemfiles/rails_5.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal"
+gem "rails", "5.0.0.1"
+
+gemspec :path => "../"

data/lib/safe_target_blank/url_helper.rb

@@ -19,17 +19,20 @@ module ActionView
         rel = link_to_rel_from_html_options(html_options)
         rel.push('noopener') if !SafeTargetBlank.opener && !link_to_option_enabled?(html_options, 'opener')
         rel.push('noreferrer') if !SafeTargetBlank.referrer && !link_to_option_enabled?(html_options, 'referrer')
-        rel.empty? ? nil : rel.uniq
+        rel.map(&:presence).compact.uniq.join(' ')
       end
 
       def convert_options_to_data_attributes(options, html_options)
         if html_options
           html_options = html_options.stringify_keys
-          html_options['rel'] = link_to_target_blank_default_rel(html_options) if link_to_target_blank?(html_options)
+          if link_to_target_blank?(html_options)
+            rel = link_to_target_blank_default_rel(html_options).presence
+            html_options['rel'] = rel if rel
+          end
         end
 
         original_convert_options_to_data_attributes(options, html_options)
       end
     end
   end
-end
+end

data/lib/safe_target_blank/version.rb

@@ -1,3 +1,3 @@
 module SafeTargetBlank
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

data/safe_target_blank.gemspec

@@ -25,4 +25,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'coveralls', '~> 0.8'
+  spec.add_development_dependency 'appraisal', '~> 2.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: safe_target_blank
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Jeremy Venezia
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-10-12 00:00:00.000000000 Z
+date: 2019-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
 description: Adds noopener and noreferrer to target blank links in a Rails application.
 email:
 - veneziajeremy@gmail.com
@@ -90,13 +104,15 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
-- CODE_OF_CONDUCT.md
+- Appraisals
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - bin/console
 - bin/setup
+- gemfiles/rails_4.gemfile
+- gemfiles/rails_5.gemfile
 - lib/safe_target_blank.rb
 - lib/safe_target_blank/url_helper.rb
 - lib/safe_target_blank/version.rb
@@ -121,7 +137,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.9
 signing_key: 
 specification_version: 4
 summary: Adds noopener and noreferrer to target blank links in a Rails application.

data/CODE_OF_CONDUCT.md

@@ -1,49 +0,0 @@
-# Contributor Code of Conduct
-
-As contributors and maintainers of this project, and in the interest of
-fostering an open and welcoming community, we pledge to respect all people who
-contribute through reporting issues, posting feature requests, updating
-documentation, submitting pull requests or patches, and other activities.
-
-We are committed to making participation in this project a harassment-free
-experience for everyone, regardless of level of experience, gender, gender
-identity and expression, sexual orientation, disability, personal appearance,
-body size, race, ethnicity, age, religion, or nationality.
-
-Examples of unacceptable behavior by participants include:
-
-* The use of sexualized language or imagery
-* Personal attacks
-* Trolling or insulting/derogatory comments
-* Public or private harassment
-* Publishing other's private information, such as physical or electronic
-  addresses, without explicit permission
-* Other unethical or unprofessional conduct
-
-Project maintainers have the right and responsibility to remove, edit, or
-reject comments, commits, code, wiki edits, issues, and other contributions
-that are not aligned to this Code of Conduct, or to ban temporarily or
-permanently any contributor for other behaviors that they deem inappropriate,
-threatening, offensive, or harmful.
-
-By adopting this Code of Conduct, project maintainers commit themselves to
-fairly and consistently applying these principles to every aspect of managing
-this project. Project maintainers who do not follow or enforce the Code of
-Conduct may be permanently removed from the project team.
-
-This code of conduct applies both within project spaces and in public spaces
-when an individual is representing the project or its community.
-
-Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting a project maintainer at veneziajeremy@gmail.com. All
-complaints will be reviewed and investigated and will result in a response that
-is deemed necessary and appropriate to the circumstances. Maintainers are
-obligated to maintain confidentiality with regard to the reporter of an
-incident.
-
-This Code of Conduct is adapted from the [Contributor Covenant][homepage],
-version 1.3.0, available at
-[http://contributor-covenant.org/version/1/3/0/][version]
-
-[homepage]: http://contributor-covenant.org
-[version]: http://contributor-covenant.org/version/1/3/0/