safe_shell 1.0.2 → 1.0.3

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: b3fdb9a174112b5c8ae48551f3b94932c186068b
+  data.tar.gz: 272aaa99838b8b4adafd61d7bb96ee16c1ab6fb9
+SHA512:
+  metadata.gz: 17953a6a491bfce79e6ac3147dd24b6fb8314a223392144181eec5d67bd328f4776aff1255178fe15d4fe6b8a488c6ff97ce261d159bb13cd724c5ab04322a52
+  data.tar.gz: 92a715210c58ea17f7422c2e7457d151258d783461e6c4655e3017c61f1d16d471ef1d91e7e0aae75771aea8665bf96b918f68569c47ba64171f11a9d641501b

data/.gitignore

@@ -19,6 +19,7 @@ rdoc
 pkg/*
 *.gem
 .bundle
+Gemfile.lock
 
 ## PROJECT::SPECIFIC
 tmp/*

data/.travis.yml

@@ -0,0 +1,17 @@
+sudo: false
+cache: bundler
+script: 'bundle exec rake'
+rvm:
+  - 2.0.0
+  - 2.1.0
+  - 2.1.1
+  - 2.1.2
+  - 2.1.3
+  - 2.1.4
+  - 2.1.5
+  - 2.1.6
+  - 2.2.0
+  - 2.2.1
+  - 2.2.2
+  - 2.2.3
+  - jruby-9000

data/{README.rdoc → README.md}

@@ -1,44 +1,64 @@
-= SafeShell
+# SafeShell
 
 SafeShell lets you execute shell commands and get the resulting output, but without the security problems of Ruby's backtick operator.
 
-== Usage
+## Usage
 
-    gem install safe_shell
+Install gem:
 
-    require 'safe_shell'
-    SafeShell.execute("echo", "Hello, world!")
+```
+gem install safe_shell
+```
+
+Use gem:
+
+```
+require 'safe_shell'
+SafeShell.execute("echo", "Hello, world!")
+```
 
 SafeShell sets the $? operator to the process status, in the same manner as the backtick operator.
 
-    # Send stdout and stderr to files:
-    SafeShell.execute("echo", "Hello, world!", :stdout => "output.txt", :stderr => "error.txt")
+```
+# Send stdout and stderr to files:
+SafeShell.execute("echo", "Hello, world!", :stdout => "output.txt", :stderr => "error.txt")
 
-    # Return true if the command exits with a zero status:
-    SafeShell.execute?("echo", "Hello, world!")
+# Return true if the command exits with a zero status:
+SafeShell.execute?("echo", "Hello, world!")
 
-    # Raise an exception if the command exits with a non-zero status:
-    SafeShell.execute!("echo", "Hello, world!")
+# Raise an exception if the command exits with a non-zero status:
+SafeShell.execute!("echo", "Hello, world!")
+```
 
-== Why?
+## Why?
 
 If you use backticks to process a file supplied by a user, a carefully crafted filename could allow execution of an arbitrary command:
 
-    file = ";blah"
-    `echo #{file}`
-    sh: blah: command not found
-    => "\n"
+```
+file = ";blah"
+`echo #{file}`
+sh: blah: command not found
+=> "\n"
+```
 
 SafeShell solves this.
 
-    SafeShell.execute("echo", file)
-    => ";blah\n"
+```
+SafeShell.execute("echo", file)
+=> ";blah\n"
+```
+
+## Compatibility
+
+Tested with Ruby 2.0.0 or newer, but it should be happy on pretty much any Ruby version. Maybe not so much on Windows.
 
-== Compatibility
+## Test
 
-Tested with Ruby 1.8.7, but it should be happy on pretty much any Ruby version. Maybe not so much on Windows.
+```
+bundle exec rake
+````
 
-== Developing
+## Developing
 
 * Fork the project.
 * Make your feature addition or bug fix.
@@ -48,10 +68,10 @@ Tested with Ruby 1.8.7, but it should be happy on pretty much any Ruby version.
   (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull)
 * Send me a pull request. Bonus points for topic branches.
 
-== Status
+## Status
 
 In use on at least one big site, so should be pretty solid. There's not much to it, so I'm not expecting there'll be many releases.
 
-== Copyright
+## Copyright
 
-Copyright (c) 2010 Envato, Ian Leitch, & Pete Yandell. See LICENSE for details.
+Copyright (c) 2010 - 2015 Envato, Ian Leitch, & Pete Yandell. See LICENSE for details.

data/Rakefile

@@ -8,7 +8,7 @@ RSpec::Core::RakeTask.new(:spec)
 task :default => :spec
 
 
-require 'rake/rdoctask'
+require 'rdoc/task'
 Rake::RDocTask.new do |rdoc|
   version = File.exist?('VERSION') ? File.read('VERSION') : ""
 

data/lib/safe_shell/version.rb

@@ -1,3 +1,3 @@
 module SafeShell
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/lib/safe_shell.rb

@@ -6,12 +6,8 @@ module SafeShell
     read_end, write_end = IO.pipe
     new_stdout = opts[:stdout] ? File.open(opts[:stdout], "w+") : write_end
     new_stderr = opts[:stderr] ? File.open(opts[:stderr], "w+") : write_end
-    pid = fork do
-      read_end.close
-      STDOUT.reopen(new_stdout)
-      STDERR.reopen(new_stderr)
-      exec(command, *(args.map { |a| a.to_s }))
-    end
+    opts = {:in => read_end, :out => new_stdout, :err => new_stderr}
+    pid = spawn(command, *(args.map { |a| a.to_s }), opts)
     write_end.close
     output = read_end.read
     Process.waitpid(pid)

data/safe_shell.gemspec

@@ -1,4 +1,3 @@
-# -*- encoding: utf-8 -*-
 $:.push File.expand_path("../lib", __FILE__)
 require "safe_shell/version"
 
@@ -11,14 +10,15 @@ Gem::Specification.new do |s|
   s.homepage    = "http://github.com/envato/safe_shell"
   s.summary     = %q{Safely execute shell commands and get their output.}
   s.description = %q{Execute shell commands and get the resulting output, but without the security problems of Ruby’s backtick operator.}
+  s.license     = "MIT"
 
   s.add_development_dependency "rspec"
 
-  s.rubyforge_project = "safe_shell"
-
   s.files            = `git ls-files`.split("\n")
   s.test_files       = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables      = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths    = ["lib"]
-  s.extra_rdoc_files = ["LICENSE", "README.rdoc"]
+  s.extra_rdoc_files = ["LICENSE", "README.md"]
+
+  s.required_ruby_version = ">= 2.0.0"
 end

data/spec/safe_shell_spec.rb

@@ -3,23 +3,23 @@ require 'safe_shell'
 describe "SafeShell" do
 
   it "should return the output of the command" do
-    SafeShell.execute("echo", "Hello, world!").should == "Hello, world!\n"
+    expect(SafeShell.execute("echo", "Hello, world!")).to eql("Hello, world!\n")
   end
 
   it "should safely handle dangerous characters in command arguments" do
-    SafeShell.execute("echo", ";date").should == ";date\n"
+    expect(SafeShell.execute("echo", ";date")).to eql(";date\n")
   end
 
   it "should set $? to the exit status of the command" do
     SafeShell.execute("test", "a", "=", "a")
-    $?.exitstatus.should == 0
+    expect($?.exitstatus).to eql(0)
 
     SafeShell.execute("test", "a", "=", "b")
-    $?.exitstatus.should == 1
+    expect($?.exitstatus).to eql(1)
   end
 
   it "should handle a Pathname object passed as an argument" do
-    expect { SafeShell.execute("ls", Pathname.new("/tmp")) }.should_not raise_error
+    expect { SafeShell.execute("ls", Pathname.new("/tmp")) }.not_to raise_error
   end
 
   context "output redirection" do
@@ -29,26 +29,26 @@ describe "SafeShell" do
 
     it "should let you redirect stdout to a file" do
       SafeShell.execute("echo", "Hello, world!", :stdout => "tmp/output.txt")
-      File.exists?("tmp/output.txt").should be_true
-      File.read("tmp/output.txt").should == "Hello, world!\n"
+      expect(File.exists?("tmp/output.txt")).to eql(true)
+      expect(File.read("tmp/output.txt")).to eql("Hello, world!\n")
     end
 
     it "should let you redirect stderr to a file" do
       SafeShell.execute("cat", "tmp/nonexistent-file", :stderr => "tmp/output.txt")
-      File.exists?("tmp/output.txt").should be_true
-      File.read("tmp/output.txt").should == "cat: tmp/nonexistent-file: No such file or directory\n"
+      expect(File.exists?("tmp/output.txt")).to eql(true)
+      expect(File.read("tmp/output.txt")).to eql("cat: tmp/nonexistent-file: No such file or directory\n")
     end
   end
 
   context ".execute!" do
     it "returns the output of the command" do
-      SafeShell.execute!("echo", "Hello, world!").should == "Hello, world!\n"
+      expect(SafeShell.execute!("echo", "Hello, world!")).to eql("Hello, world!\n")
     end
 
     it "raises an exception of the command fails" do
       expect {
         SafeShell.execute!("test", "a", "=", "b")
-      }.should raise_error(SafeShell::CommandFailedException)
+      }.to raise_error(SafeShell::CommandFailedException)
     end
   end
 

metadata

@@ -1,56 +1,47 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: safe_shell
-version: !ruby/object:Gem::Version 
-  hash: 19
-  prerelease: 
-  segments: 
-  - 1
-  - 0
-  - 2
-  version: 1.0.2
+version: !ruby/object:Gem::Version
+  version: 1.0.3
 platform: ruby
-authors: 
+authors:
 - Envato
 - Ian Leitch
 - Pete Yandell
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-01-03 00:00:00 +11:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2015-10-30 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: rspec
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id001
-description: "Execute shell commands and get the resulting output, but without the security problems of Ruby\xE2\x80\x99s backtick operator."
-email: 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Execute shell commands and get the resulting output, but without the
+  security problems of Ruby’s backtick operator.
+email:
 - pete@notahat.com
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - LICENSE
-- README.rdoc
-files: 
-- .document
-- .gitignore
+- README.md
+files:
+- ".document"
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
-- Gemfile.lock
 - LICENSE
-- README.rdoc
+- README.md
 - Rakefile
 - lib/safe_shell.rb
 - lib/safe_shell/version.rb
@@ -58,40 +49,30 @@ files:
 - spec/safe_shell_spec.rb
 - spec/spec.opts
 - tmp/.gitkeep
-has_rdoc: true
 homepage: http://github.com/envato/safe_shell
-licenses: []
-
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+    - !ruby/object:Gem::Version
+      version: 2.0.0
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
-rubyforge_project: safe_shell
-rubygems_version: 1.6.2
+rubyforge_project: 
+rubygems_version: 2.4.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Safely execute shell commands and get their output.
-test_files: 
+test_files:
 - spec/safe_shell_spec.rb
 - spec/spec.opts

data/Gemfile.lock

@@ -1,24 +0,0 @@
-PATH
-  remote: .
-  specs:
-    safe_shell (1.0.1)
-
-GEM
-  remote: http://rubygems.org/
-  specs:
-    diff-lcs (1.1.2)
-    rspec (2.5.0)
-      rspec-core (~> 2.5.0)
-      rspec-expectations (~> 2.5.0)
-      rspec-mocks (~> 2.5.0)
-    rspec-core (2.5.1)
-    rspec-expectations (2.5.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.5.0)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  rspec
-  safe_shell!