safe_redirect 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 994d65b4b777046399df62f71dea891f3dee1e5b
-  data.tar.gz: 1d2260242c9dd0c4338b3c3baf45247f2156a32b
+  metadata.gz: 9b628c68916ed992402ee971523c5937b30538de
+  data.tar.gz: c497d1e8882776fe69f94f8d6095567e76d12036
 SHA512:
-  metadata.gz: cd5c9ca9136f6b84935e754d502d9716acf9c0c4cddf4789862fbe6e2c0839ec8590a64fd12f498c7a06234ca3479c42f1237bc0411a39208ecd21a1750a8dd8
-  data.tar.gz: ff2e823f75d81029b5ae4d9648fe77732f70f8e27dd74d51a67302faeb93b1640db62d71c857d87c0b147b1a3bd151c078efff5a4aefc73d6f29072c0b734bec
+  metadata.gz: 10e83cc957953e5ac78ea5e892ca18b01270663b8afbca3805df74880a62071e98ab3c5e4a919da994adadd882d018f45f4210fbde7d830831d6ee5db043d2a6
+  data.tar.gz: 1a2c4f2755aee51acbeee1014a55246568b4711cfde312b6d49b8a91f6e3dc9e4a2c99209016833f9ac1fc11fe61de51742e7140bb3367e6ad278dd81041057a

data/lib/safe_redirect/safe_redirect.rb

@@ -12,7 +12,7 @@ module SafeRedirect
       if safe_domain?(stripped_path)
         stripped_path
       else
-        stripped_path.gsub!(/https?:\/\/[a-z0-9\-\.:]*/i, '')
+        stripped_path.gsub!(/https?:\/\/[a-z0-9\-\.:@]*/i, '')
         stripped_path.gsub!(/^(data:|javascript:|\.|\/\/|@)+/i, '')
         stripped_path
       end
@@ -21,7 +21,8 @@ module SafeRedirect
     end
   end
 
-  def redirect_to(path, options)
+  def redirect_to(path, options={})
     super safe_path(path), options
+  rescue NoMethodError
   end
 end

data/lib/safe_redirect/version.rb

@@ -1,3 +1,3 @@
 module SafeRedirect
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/safe_redirect.gemspec

@@ -12,7 +12,11 @@ Gem::Specification.new do |gem|
   gem.description   = %q{Preventing open redirects in Rails apps}
   gem.summary       = %q{Preventing open redirects in Rails apps}
   gem.homepage      = "https://github.com/sdsdkkk/safe_redirect"
+  gem.licenses      = ['MIT']
+
+  gem.add_development_dependency 'rspec'
 
   gem.files         = `git ls-files`.split($/)
+  gem.test_files    = gem.files.grep(%r{^spec/})
   gem.require_paths = ["lib", "lib/safe_redirect"]
 end

data/spec/lib/safe_redirect/configuration_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+module SafeRedirect
+  describe Configuration do
+    before(:each) do
+      reset_config
+    end
+
+    it "default default_path is '/'" do
+      expect(SafeRedirect.configuration.default_path).to eq('/')
+    end
+
+    it "default domain_whitelists is []" do
+      expect(SafeRedirect.configuration.domain_whitelists).to eq([])
+    end
+
+    it "can update default_path" do
+      SafeRedirect.configure do |config|
+        config.default_path = 'https://www.bukalapak.com'
+      end
+      expect(SafeRedirect.configuration.default_path).to eq('https://www.bukalapak.com')
+    end
+
+    it "can update domain_whitelists" do
+      SafeRedirect.configure do |config|
+        config.domain_whitelists = ['www.bukalapak.com']
+      end
+      expect(SafeRedirect.configuration.domain_whitelists).to eq(['www.bukalapak.com'])
+    end
+  end
+end

data/spec/lib/safe_redirect/safe_redirect_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+module SafeRedirect
+  describe SafeRedirect do
+    class Controller
+      extend SafeRedirect
+    end
+  
+    before(:all) do
+      load_config
+    end
+
+    it "considers https://www.bukalapak.com a safe domain" do
+      expect(Controller.safe_domain?('https://www.bukalapak.com')).to eq(true)
+    end
+
+    it "considers / a safe domain" do
+      expect(Controller.safe_domain?('/')).to eq(true)
+    end
+
+    it "considers // an unsafe domain" do
+      expect(Controller.safe_domain?('//')).to eq(false)
+    end
+
+    it "considers http://www.twitter.com a safe domain" do
+      expect(Controller.safe_domain?('http://www.twitter.com')).to eq(true)
+    end
+
+    it "considers https://www.bukalapak.com@google.com an unsafe domain" do
+      expect(Controller.safe_domain?('https://www.bukalapak.com@google.com')).to eq(false)
+    end
+
+    it "considers https://www.bukalapak.com a safe path" do
+      expect(Controller.safe_path('https://www.bukalapak.com')).to eq('https://www.bukalapak.com')
+    end
+
+    it "considers / a safe path" do
+      expect(Controller.safe_path('/')).to eq('/')
+    end
+
+    it "considers // an unsafe path" do
+      expect(Controller.safe_path('//')).to eq('')
+    end
+
+    it "considers http://www.twitter.com a safe path" do
+      expect(Controller.safe_path('http://www.twitter.com')).to eq('http://www.twitter.com')
+    end
+
+    it "considers https://www.bukalapak.com@google.com an unsafe path" do
+      expect(Controller.safe_path('https://www.bukalapak.com@google.com')).to eq('')
+    end
+
+    it "can use redirect_to method with only the target path" do
+      Controller.redirect_to '/'
+    end
+
+    it "can use redirect_to method with both the target path and the options" do
+      Controller.redirect_to '/', notice: 'Back to home page'
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,23 @@
+require 'rubygems'
+require 'rspec'
+
+require File.join(File.dirname(__FILE__), '..', 'lib', 'safe_redirect')
+
+def reset_config
+  SafeRedirect.reset_config
+end
+
+def load_config
+  SafeRedirect.configure do |config|
+    config.default_path = '/sdsdkkk'
+    config.domain_whitelists = ['www.twitter.com', 'www.bukalapak.com']
+  end
+end
+
+module SafeRedirect
+  class << self
+    def reset_config
+      @configuration = Configuration.new
+    end
+  end
+end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: safe_redirect
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Edwin Tunggawan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-01 00:00:00.000000000 Z
-dependencies: []
+date: 2016-05-03 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Preventing open redirects in Rails apps
 email:
 - vcc.edwint@gmail.com
@@ -25,8 +39,12 @@ files:
 - lib/safe_redirect/safe_redirect.rb
 - lib/safe_redirect/version.rb
 - safe_redirect.gemspec
+- spec/lib/safe_redirect/configuration_spec.rb
+- spec/lib/safe_redirect/safe_redirect_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/sdsdkkk/safe_redirect
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -49,4 +67,7 @@ rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Preventing open redirects in Rails apps
-test_files: []
+test_files:
+- spec/lib/safe_redirect/configuration_spec.rb
+- spec/lib/safe_redirect/safe_redirect_spec.rb
+- spec/spec_helper.rb