safe_pusher 0.2.2 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 6f14a1f7069630411c76a8ec0c1a33f75f3b0d95
-  data.tar.gz: c5b212741108b33951374c339fa888aa1215c94f
+SHA256:
+  metadata.gz: a876c76ac889ebc32081c281e6031204b65692de1bf0efda932028d14aff0afd
+  data.tar.gz: 694782b608d3fd8595f0d6c2da75ef83c3afc6cce5257a7c0491fed149b9980a
 SHA512:
-  metadata.gz: dc2fa8785c5401f0b47db636e874a4cc9a3b0ed3355633ab3c7aa89df5ddd2228e7bd76177bf85a0fdcab5a79003c956ac3099d4b255bdcd0eafde3284e6ea83
-  data.tar.gz: '02567809eba97e24af3b0ee8fac29bc9b407696ac07896cf763d3527582e191629d1a0580e0371377166bf7bda0502d9fb9c6f3f57463bf65faf0c832db06226'
+  metadata.gz: bd8ef453a0adf63245ca38e5ae6cb71511adea87aa8bbc6f97dbb8da690dbe416b236683cd4cb59a7cf4b290c274d388e64edbc3f868d150fb6032cb32cd4585
+  data.tar.gz: 1354cbb01df47f12cbfad8b08fa841377902ce3620641a6dd7071598b068ac4b447a04ab29f88eacc43986687944f3072b63968213fff4cf28e574225ee4d3f3

data/.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,38 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Desktop (please complete the following information):**
+ - OS: [e.g. iOS]
+ - Browser [e.g. chrome, safari]
+ - Version [e.g. 22]
+
+**Smartphone (please complete the following information):**
+ - Device: [e.g. iPhone6]
+ - OS: [e.g. iOS8.1]
+ - Browser [e.g. stock browser, safari]
+ - Version [e.g. 22]
+
+**Additional context**
+Add any other context about the problem here.

data/.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

data/.rubocop.yml

@@ -63,10 +63,11 @@ Documentation:
 # Do not verify the length of the blocks in DSLs.
 Metrics/BlockLength:
   Exclude:
-    - "**/*/spec/**/*"
+    - spec/**/*
     - lib/tasks/**/*
     - app/admin/**/*
     - config/routes.rb
+    - safe_pusher.gemspec
   ExcludedMethods:
     - included
 
@@ -136,27 +137,3 @@ Style/FormatStringToken:
 # Prefer `->` to `lambda`.
 Style/Lambda:
   EnforcedStyle: literal
-
-# Deactivate rule that makes `lambda` mandatory in defavor of `->`
-# when having blocks.
-Style/Lambda:
-  Enabled: false
-
-# Do not verify empty lines around blocks in specs
-Layout/EmptyLinesAroundBlockBody:
-  Exclude:
-    - spec/**/*
-
-# Allow using normal test doubles, since they are useful for mocking.
-# See https://github.com/KissKissBankBank/fashion_police/pull/34
-RSpec/VerifiedDoubles:
-  Enabled: false
-
-# Enable long blocs for Gemspec files
-Metrics/BlockLength:
-  Exclude:
-    - safe_pusher.gemspec
-
-Metrics/BlockLength:
-  Exclude:
-    - spec/**/*

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 This project adheres to [Semantic Versioning](http://semver.org)
 
+## [0.3.0] - 2019-09-30
+Improvement:
+- Reduce RSpec runner verbosity
+- Allow configuring the base branch
+
+Fix:
+ - Add `--version` to the CLI
+
 ## [0.2.2] - 2019-01-05
 Improvements:
  - Removing thor

data/Gemfile

@@ -1,6 +1,6 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in safe_pusher.gemspec
 gemspec

data/README.md

@@ -37,6 +37,7 @@ Create the `safe_pusher.yml` file at the root of your application:
 files_to_skip:
   - file/to/skip_1
   - file/to/skip/2
+base_branch: developement
 app_base_directory: app
 repo_url: https://github.com/williampollet/safe_pusher
 ```
@@ -49,24 +50,50 @@ To see the commands available, type:
 
 To run pronto checks before you push to GitHub run:
 
-    $ safepush lint_push_and_open
+    $ safepush lint push open
 
 or
 
-    $ safepush lpo
+    $ safepush l p o
 
 To run specs and pronto before you push to GitHub run:
 
-    $ safepush test_lint_push_and_open
+    $ safepush test lint push open
 
 or
 
-    $ safepush tlpo
+    $ safepush t l p o
 
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/williampollet/safe_pusher. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
 
+## Development
+
+Setup development:
+
+```sh
+$ bin/setup
+```
+
+Open a console:
+
+```sh
+$ bin/console
+```
+
+Test the CLI:
+
+```sh
+$ ruby -Ilib exe/safepush
+```
+
+Launch specs and lint:
+
+```sh
+$ rake
+```
+
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/Rakefile

@@ -1,5 +1,5 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 # Rspec
 RSpec::Core::RakeTask.new(:spec)
@@ -8,4 +8,4 @@ RSpec::Core::RakeTask.new(:spec)
 require 'rubocop/rake_task'
 RuboCop::RakeTask.new
 
-task :default => %i[spec, rubocop]
+task default: %i[spec rubocop]

data/bin/console

@@ -1,14 +1,14 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "safe_pusher"
+require 'bundler/setup'
+require 'safe_pusher'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
 # (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
+# require 'pry'
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/lib/safe_pusher/cli.rb

@@ -7,6 +7,8 @@ module SafePusher
     end
 
     def start
+      return version if arguments.first == '--version'
+
       unless arguments_valid?
         help
 
@@ -79,6 +81,7 @@ module SafePusher
     def help
       puts "Usage:\n"\
       " help (h) # show this usage message\n"\
+      " --version # print SafePusher version\n"\
       " ##########################################################\n"\
       " # you can use any combination of theese commands \n"\
       " ##########################################################\n"\
@@ -87,5 +90,9 @@ module SafePusher
       " push (p) # push on distant repository\n"\
       ' open (o) # open a pull request on the distant repository'
     end
+
+    def version
+      puts SafePusher::VERSION
+    end
   end
 end

data/lib/safe_pusher/configuration.rb

@@ -5,7 +5,8 @@ module SafePusher
     # The configuration singleton
     attr_accessor :files_to_skip,
                   :app_base_directory,
-                  :repo_url
+                  :repo_url,
+                  :base_branch
 
     def initialize
       application_config =
@@ -15,6 +16,7 @@ module SafePusher
           {}
         end
 
+      @base_branch = application_config['base_branch'] || 'master'
       @files_to_skip = application_config['files_to_skip'] || []
       @app_base_directory = application_config['app_base_directory']
       @repo_url = application_config['repo_url']

data/lib/safe_pusher/pronto_runner.rb

@@ -8,8 +8,8 @@ module SafePusher
       exit_status = $CHILD_STATUS.exitstatus
 
       if exit_status != 0
-        warn 'Pronto found somme errors... '\
-             'Fix them before pushing to master!'.red
+        warn 'Pronto found somme errors… ' \
+             'Fix them before pushing to GitHub!'.red
       else
         puts 'No errors found by pronto, go for next step!'.green
       end
@@ -20,7 +20,11 @@ module SafePusher
     private
 
     def run_pronto
-      system('bin/pronto run --exit-code')
+      system("bin/pronto run --exit-code -c #{base_branch}")
+    end
+
+    def base_branch
+      SafePusher.configuration.base_branch
     end
   end
 end

data/lib/safe_pusher/rspec_runner.rb

@@ -26,7 +26,7 @@ module SafePusher
     def modified_files
       diff = 'git diff --diff-filter=A --diff-filter=M --name-only'
 
-      `#{diff} $(git merge-base #{branch} master) #{branch}`
+      `#{diff} $(git merge-base #{branch} #{base_branch}) #{branch}`
         .split("\n")
         .uniq
     end
@@ -43,8 +43,6 @@ module SafePusher
     end
 
     def search_or_create_spec(file)
-      puts "#{file} has been modified, searching for specs..."
-
       spec_path = file.gsub(
         "#{SafePusher.configuration.app_base_directory}/",
         'spec/',
@@ -52,8 +50,8 @@ module SafePusher
 
       return create_new_spec(spec_path, file) unless File.exist?(spec_path)
 
-      puts "Spec found for #{file}, putting #{spec_path}"\
-           ' in the list of specs to run'
+      puts spec_path
+
       specs_to_execute << spec_path
     end
 
@@ -111,5 +109,9 @@ module SafePusher
     def app_base_directory
       %r{#{SafePusher.configuration.app_base_directory}\/.*\.rb$}
     end
+
+    def base_branch
+      SafePusher.configuration.base_branch
+    end
   end
 end

data/lib/safe_pusher/version.rb

@@ -1,3 +1,3 @@
 module SafePusher
-  VERSION = '0.2.2'.freeze
+  VERSION = '0.3.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: safe_pusher
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.0
 platform: ruby
 authors:
 - William Pollet
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-01-05 00:00:00.000000000 Z
+date: 2019-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -172,6 +172,8 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/ISSUE_TEMPLATE/bug_report.md"
+- ".github/ISSUE_TEMPLATE/feature_request.md"
 - ".gitignore"
 - ".hound.yml"
 - ".rspec"
@@ -214,8 +216,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 3.0.4
 signing_key: 
 specification_version: 4
 summary: a small CLI that lints your code and run your tests before you push