safe_pusher 0.1.3 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aaccf2d4580afb11b6d7f7fa4cb9e8ab9f4ef7d9
-  data.tar.gz: 11d63824b879d801afc5e93d5202890465fc56ce
+  metadata.gz: 6393bd85a974e1d867941ac975e031b5d0385fe5
+  data.tar.gz: 2e4c02a81577f79227015105d139f6063df8a61c
 SHA512:
-  metadata.gz: f53e3e4d17458c4fbedb3baa9027c7be47837aa57f0b8f5fcb3a7bc7433f76d22abccb25cea9570caa4b4a442569bd624285cd3ac7b9ea1316459e8dc6be89bc
-  data.tar.gz: 4daec10f29b4a88d9f85c84b5e4075c3f2eb4d10f7d535d7836640a30991169b379a3ecac7a358b996f7d178e52e20d2b5a1198968f74da21e340e3236e92ec0
+  metadata.gz: ed8d28521ddc648fb3fc160916c9fa2f271e26ffc446469991ac51cc4769b74b4bc709c917578c5b57b67bf9ac38fce0d5013f3f05b176c64a86ec9cf47f8085
+  data.tar.gz: 725bf26b3f3ed256d04cbe6424abcf651727ad2e55d65ddf4583512e71742bcad2ca9c62f64fcb2dd7920d12117f5f0ced052179776c0dc6c7116c662e1bfcb6

data/.hound.yml

@@ -0,0 +1,2 @@
+rubocop:
+  config_file: .rubocop.yml

data/.rubocop.yml

@@ -1,6 +1,141 @@
-inherit_gem:
-  fashion_police:
-    - .rubocop.yml
+require: rubocop-rspec
+
+AllCops:
+  TargetRubyVersion: 2.3
+  DisplayCopNames: true
+
+# Do not sort gems in Gemfile, since we are grouping them by functionality.
+Bundler/OrderedGems:
+  Enabled: false
+
+# Add a comment before each gem in Gemfile.
+Bundler/GemComment:
+  Enabled: true
+
+# Trailing commas are required on multiline method arguments.
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: comma
+
+# Trailing commas are required in multiline arrays.
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+# Trailing commas are required in multiline hashes.
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: comma
+
+# Allow indenting multiline chained operations.
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+# Allow empty lines around blocks in specs.
+Layout/EmptyLinesAroundBlockBody:
+  Exclude:
+    - spec/**/*
+
+# Allow not adding parentheses around blocks in DSLs.
+# E.g.:
+#     expect { … }.to change { … }
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - spec/**/*
+
+# Limit method length (default is 10).
+Metrics/MethodLength:
+  Max: 15
+
+# Limit class length (default is 100).
+Metrics/ClassLength:
+  Max: 200
+
+# Do not require `# frozen_string_literal: true` at the top of every file.
+FrozenStringLiteralComment:
+  Enabled: false
+
+# Allow ASCII comments (e.g "…").
+Style/AsciiComments:
+  Enabled: false
+
+# Do not comment the class we create, since the name should be self explanatory.
+Documentation:
+  Enabled: false
+
+# Do not verify the length of the blocks in DSLs.
+Metrics/BlockLength:
+  Exclude:
+    - "**/*/spec/**/*"
+    - lib/tasks/**/*
+    - app/admin/**/*
+    - config/routes.rb
+  ExcludedMethods:
+    - included
+
+# Allow any number of keyword arguments in methods.
+Metrics/ParameterLists:
+  CountKeywordArgs: false
+
+# Prefer `a_variable_1` to `a_variable1`.
+Naming/VariableNumber:
+  EnforcedStyle: snake_case
+
+# Prefer `== 0`, `< 0`, `> 0` to `zero?`, `negative?` or `positive?`,
+# since they don't exist before Ruby 2.3 or Rails 5 and can be ambiguous.
+Style/NumericPredicate:
+  EnforcedStyle: comparison
+
+# This cop by default assumes that `Rails.root.join('foo', 'bar')` works
+# better under Windows than `Rails.root.join('foo/bar')`.
+Rails/FilePath:
+  EnforcedStyle: slashes
+
+# Do not checks for the use of output safety calls like `html_safe` and `raw`,
+# we know what we are doing.
+Rails/OutputSafety:
+  Enabled: false
+
+# Allow `update_attribute`, we know when to use it.
+Rails/SkipsModelValidations:
+  Enabled: false
+
+# Allow creating tables without timestamps, whe know what we are doing.
+Rails/CreateTableWithTimestamps:
+  Enabled: false
+
+# Allow using `allow_any_instance_of` for stubbing.
+RSpec/AnyInstance:
+  Enabled: false
+
+# Allow `let!` to setup test data in specs.
+RSpec/LetSetup:
+  Enabled: false
+
+# Allow a nesting of up to 5 of describe/context blocks (default is 3).
+RSpec/NestedGroups:
+  Max: 10
+
+# Allow any number of expectations in an example, for performance.
+RSpec/MultipleExpectations:
+  Enabled: false
+
+# Allow using normal test doubles, since they are useful for mocking.
+RSpec/VerifiedDoubles:
+  Enabled: false
+
+# Limit example length (default is 5)
+RSpec/ExampleLength:
+  Max: 10
+
+# Prefer `change { User.count }` to `change(User, :count)`.
+RSpec/ExpectChange:
+  EnforcedStyle: block
+
+# Allow template token "%{foo}" since they are used in translation keys.
+Style/FormatStringToken:
+  EnforcedStyle: template
+
+# Prefer `->` to `lambda`.
+Style/Lambda:
+  EnforcedStyle: literal
 
 # Deactivate rule that makes `lambda` mandatory in defavor of `->`
 # when having blocks.
@@ -17,11 +152,11 @@ Layout/EmptyLinesAroundBlockBody:
 RSpec/VerifiedDoubles:
   Enabled: false
 
-# Allow 5 nesting groups for context
-RSpec/NestedGroups:
-  Max: 5
-
 # Enable long blocs for Gemspec files
 Metrics/BlockLength:
   Exclude:
     - safe_pusher.gemspec
+
+Metrics/BlockLength:
+  Exclude:
+    - spec/**/*

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 This project adheres to [Semantic Versioning](http://semver.org)
 
+## [0.2.0] - 2018-12-31
+Feature:
+ - Improve commands
+
 ## [0.1.3] - 2018-12-20
 Bugfix:
  - Do not take into account deleted files for rspec testing

data/lib/safe_pusher.rb

@@ -13,7 +13,7 @@ module SafePusher
     attr_writer :configuration
 
     def configuration
-      @configuration = Configuration.new
+      @configuration ||= Configuration.new
     end
 
     def configure

data/lib/safe_pusher/cli.rb

@@ -1,56 +1,91 @@
 module SafePusher
   class CLI < Thor
-    desc 'prontorun', 'launch pronto with a return message'
-    def prontorun
+    desc 'test (t)', 'launch the test suite'
+    def test
+      puts '##########################'.yellow
+      puts '## Testing new files... ##'.yellow
+      puts '##########################'.yellow
+
+      results = SafePusher::RspecRunner.new.call
+
+      exit results unless results == 0
+    end
+    map 't' => :test
+
+    desc 'lint (l)', 'launch the linters'
+    def lint
       puts '#######################'.yellow
-      puts '## Running pronto... ##'.yellow
+      puts '## Running linter... ##'.yellow
       puts '#######################'.yellow
 
       results = SafePusher::ProntoRunner.new.call
 
       exit results unless results == 0
     end
+    map 'l' => :lint
 
-    desc 'test', 'launch the test suite with a return message'
-    def test
+    desc 'push (p)', 'push your code on github'
+    def push
       puts '##########################'.yellow
-      puts '## Testing new files... ##'.yellow
+      puts '## Pushing to Github... ##'.yellow
       puts '##########################'.yellow
 
-      results = SafePusher::RspecRunner.new.call
+      results = SafePusher::GithubRunner.new.push
+
+      exit results unless results == 0
+    end
+    map 'p' => :push
+
+    desc 'open (o)', 'open a pull request on github'
+    def open
+      puts '#########################################'.yellow
+      puts '## Opening a pull request on Github... ##'.yellow
+      puts '#########################################'.yellow
+
+      results = SafePusher::GithubRunner.new.open
 
       exit results unless results == 0
     end
+    map 'o' => :open
 
-    desc 'pushandpr', 'push your code on github,'\
-         ' and open a PR if it is the first time'
-    def pushandpr
+    desc 'push_and_open (po)', 'push your code on github,'\
+         ' and open a Pull Request on Github if none is openned'
+    def push_and_open
       puts '##########################'.yellow
       puts '## Pushing to Github... ##'.yellow
       puts '##########################'.yellow
 
-      results = SafePusher::GithubRunner.new.call
+      results = SafePusher::GithubRunner.new.push_and_open
 
       exit results unless results == 0
     end
+    map 'po' => :push_and_open
 
-    desc 'ptest', 'launch the test suite, then pronto if it is successful'
-    def ptest
+    desc 'test_and_lint (tl)',
+         'launch the test suite, then the linters if it is successful'
+    def test_and_lint
       invoke :test
-      invoke :prontorun
+      invoke :lint
     end
+    map 'tl' => :test_and_lint
 
-    desc 'ppush', 'run your favorite linter, then push on github'
-    def ppush
-      invoke :prontorun
-      invoke :pushandpr
+    desc 'lint_push_and_open (lpo)',
+         'lanch the linters, then push on github and open a'\
+         ' Pull Request on Github if none is openned'
+    def lint_push_and_open
+      invoke :lint
+      invoke :push_and_open
     end
+    map 'lpo' => :lint_push_and_open
 
-    desc 'ppushtest', 'run your favorite linters and tests, then push on github'
-    def ppushtest
+    desc 'test_lint_push_and_open (tlpo)',
+         'lanch the linters, launch test suite, then push on github and open'\
+         'a Pull Request if none is openned'
+    def test_lint_push_and_open
       invoke :test
-      invoke :prontorun
-      invoke :pushandpr
+      invoke :lint
+      invoke :push_and_open
     end
+    map 'tlpo' => :test_lint_push_and_open
   end
 end

data/lib/safe_pusher/github_runner.rb

@@ -3,8 +3,8 @@ require 'English'
 
 module SafePusher
   class GithubRunner
-    def call
-      push_on_github
+    def push_and_open
+      push
 
       exit_status = $CHILD_STATUS.exitstatus
 
@@ -15,28 +15,28 @@ module SafePusher
 
         exit_status = $CHILD_STATUS.exitstatus
 
-        open_pull_request_url if exit_status == 0
+        open if exit_status == 0
       end
 
       exit_status
     end
 
-    private
-
-    def push_on_github
+    def push
       system('git push origin')
     end
 
-    def push_and_set_upstream
-      system("git push --set-upstream origin #{branch}")
-    end
-
-    def open_pull_request_url
+    def open
       system(
         "open '#{SafePusher.configuration.repo_url}/pull/new/#{branch}'",
       )
     end
 
+    private
+
+    def push_and_set_upstream
+      system("git push --set-upstream origin #{branch}")
+    end
+
     def branch
       `git rev-parse --symbolic-full-name --abbrev-ref HEAD`.delete("\n")
     end

data/lib/safe_pusher/rspec_runner.rb

@@ -99,7 +99,7 @@ module SafePusher
         return 0
       else
         File.open(spec_path, 'w') {}
-        warn 'spec to write!'.red
+        warn 'A spec needs to be written!'.red
         return 1
       end
     end

data/lib/safe_pusher/version.rb

@@ -1,3 +1,3 @@
 module SafePusher
-  VERSION = '0.1.3'.freeze
+  VERSION = '0.2.0'.freeze
 end

data/safe_pusher.gemspec

@@ -45,4 +45,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rubocop', '~> 0.60'
+  spec.add_development_dependency 'simplecov', '~> 0.16.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: safe_pusher
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.0
 platform: ruby
 authors:
 - William Pollet
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-12-21 00:00:00.000000000 Z
+date: 2018-12-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -122,6 +122,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.60'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.16.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.16.1
 description: 
 email:
 - william.pollet@kisskissbankbank.com
@@ -131,6 +145,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".hound.yml"
 - ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
@@ -172,7 +187,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: a small CLI that lints your code and run your tests before you push