safe_cookies 0.1.1 → 0.1.2

data/lib/safe_cookies.rb

@@ -21,6 +21,8 @@ module SafeCookies
       # The :non_http_only option is analog, use it for storing data you want to access
       # with javascript.
 
+      options = options.dup
+
       @app = app
       @non_secure = (options.delete(:non_secure) || []).map(&:to_s)
       @non_http_only = (options.delete(:non_http_only) || []).map(&:to_s)

data/lib/safe_cookies/version.rb

@@ -1,3 +1,3 @@
 module SafeCookies
-  VERSION = "0.1.1"
+  VERSION = '0.1.2'
 end

data/spec/safe_cookies_spec.rb

@@ -30,7 +30,7 @@ describe SafeCookies::Middleware do
       # second request: do not rewrite cookie again
       subject = described_class.new(app, :foo => 24 * 60 * 60)
       app.should_receive(:call).and_return([ stub, {}, stub ])
-      received_cookies = headers['Set-Cookie'].scan(/[^,;]+=[^,;]+(?=;\s)/i) # extract cookies
+      received_cookies = headers['Set-Cookie'].scan(/[^\n;]+=[^\n;]+(?=;\s)/i) # extract cookies
       env['HTTP_COOKIE'] = received_cookies.join(',')
 
       code, headers, response = subject.call(env)
@@ -42,14 +42,14 @@ describe SafeCookies::Middleware do
     app.should_receive(:call).and_return([ stub, { 'Set-Cookie' => 'neuer_cookie=neuer_cookie_wert'}, stub ])
     
     code, headers, response = subject.call(env)
-    headers['Set-Cookie'].should =~ /neuer_cookie=neuer_cookie_wert;[^\n]* secure/
+    headers['Set-Cookie'].should =~ /neuer_cookie=neuer_cookie_wert;.* secure/
   end
   
   it "should make new cookies http_only" do
     app.should_receive(:call).and_return([ stub, { 'Set-Cookie' => 'neuer_cookie=neuer_cookie_wert'}, stub ])
     
     code, headers, response = subject.call(env)
-    headers['Set-Cookie'].should =~ /neuer_cookie=neuer_cookie_wert;[^\n]* HttpOnly/
+    headers['Set-Cookie'].should =~ /neuer_cookie=neuer_cookie_wert;.* HttpOnly/
   end
   
   it "should not make new cookies secure that are specified as 'non_secure'" do
@@ -85,8 +85,8 @@ describe SafeCookies::Middleware do
     
     code, headers, response = subject.call(env)
     set_cookie = headers['Set-Cookie'].gsub(/,(?=\s\d)/, '') # remove commas in expiry dates to simplify matching below
-    set_cookie.should =~ /filter=cars_only;[^,]* HttpOnly/
-    set_cookie.should_not match(/filter=cars_only;[^,]* secure/)
+    set_cookie.should =~ /filter=cars_only;.* HttpOnly/
+    set_cookie.should_not match(/filter=cars_only;.* secure/)
   end
   
   it "should not make existing cookies http_only that are specified as 'non_http_only'" do
@@ -95,9 +95,9 @@ describe SafeCookies::Middleware do
     env['HTTP_COOKIE'] = 'js_data=json'
     
     code, headers, response = subject.call(env)
-    set_cookie = headers['Set-Cookie'].gsub(/,(?=\s\d)/, '') # remove commas in expiry dates to simplify matching below
-    set_cookie.should =~ /js_data=json;[^,]* secure/
-    set_cookie.should_not match(/js_data=json;[^,]* HttpOnly/)
+    set_cookie = headers['Set-Cookie']
+    set_cookie.should =~ /js_data=json;.* secure/
+    set_cookie.should_not match(/js_data=json;.* HttpOnly/)
   end
   
   it "should not make cookies secure if the request was not secure" do
@@ -110,4 +110,13 @@ describe SafeCookies::Middleware do
     headers['Set-Cookie'].should_not match(/secure/i)
   end
 
+  it 'does not mutate an options hash passed to it' do
+    options = { :cookie1 => 3600, :non_secure => [:cookie2], :non_http_only => [:cookie3] }
+    described_class.new(app, options)
+
+    options[:cookie1].should == 3600
+    options[:non_secure].should == [:cookie2]
+    options[:non_http_only].should == [:cookie3]
+  end
+
 end

metadata

@@ -1,71 +1,75 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: safe_cookies
-version: !ruby/object:Gem::Version
-  version: 0.1.1
+version: !ruby/object:Gem::Version 
+  hash: 31
   prerelease: 
+  segments: 
+  - 0
+  - 1
+  - 2
+  version: 0.1.2
 platform: ruby
-authors:
-- Dominik Schöler
+authors: 
+- "Dominik Sch\xC3\xB6ler"
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-28 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
+
+date: 2013-08-26 00:00:00 +02:00
+default_executable: 
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: rack
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :runtime
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
   name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: timecop
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   type: :development
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: timecop
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id003
 description: Make cookies as `secure` and `HttpOnly` as possible.
-email:
+email: 
 - dominik.schoeler@makandra.de
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - .gitignore
 - Gemfile
 - LICENSE
@@ -76,30 +80,40 @@ files:
 - safe_cookies.gemspec
 - spec/safe_cookies_spec.rb
 - spec/spec_helper.rb
+has_rdoc: true
 homepage: http://www.makandra.de
 licenses: []
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.3.9.5
 signing_key: 
 specification_version: 3
 summary: Make cookies as `secure` and `HttpOnly` as possible.
-test_files:
+test_files: 
 - spec/safe_cookies_spec.rb
 - spec/spec_helper.rb