safe_attributes 1.0.4 → 1.0.5

data/Gemfile

@@ -6,7 +6,14 @@ gem 'activerecord', '~> 3.0.0'
 group :development do
   gem 'jeweler', '>= 1.5.2'
   gem 'rake', '>= 0.8.7'
+  gem 'rdoc'
   gem 'rspec', '>= 2.3.0'
   gem 'rcov'
-  gem 'sqlite3-ruby'
+  platform :ruby do
+    gem 'sqlite3-ruby'
+  end
+  platform :jruby do
+    gem 'activerecord-jdbcsqlite3-adapter'
+    gem 'jruby-openssl'
+  end
 end

data/NEWS.rdoc

@@ -0,0 +1,15 @@
+= Version 1.0.5
+
+* Resolved issues with columns named 'changed' and 'errors'
+
+= Version 1.0.4
+
+* Tested against Ruby 1.9.2, found and fixed an issue with default 
+  bad attribute name list
+* Tested against JRuby 1.5.6, found no issues
+
+= Version 1.0.3
+
+* Added validations support that should work with ActiveModel validators
+  by default
+

data/README.rdoc

@@ -64,8 +64,11 @@ without issue using the recommended approach above.
 
 === Ruby
 
-Both Ruby 1.8.7 and Ruby 1.9.2 have been tested to work with this gem as
-of version 1.0.4 of SafeAttributes.
+This gem has been tested to work with:
+
+* Ruby 1.8.7 
+* Ruby 1.9.2
+* JRuby 1.5.6
 
 === Rails
 Add safe_attributes to your Gemfile.

data/Rakefile

@@ -35,10 +35,11 @@ end
 
 task :default => :spec
 
-require 'rake/rdoctask'
-Rake::RDocTask.new do |rdoc|
+require 'rdoc/task'
+RDoc::Task.new do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
   rdoc.title = "SafeAttributes #{version}"
   rdoc.rdoc_files.include('README*')
+  rdoc.rdoc_files.include('NEWS*')
   rdoc.rdoc_files.include('lib/**/*.rb')
 end

data/VERSION

@@ -1 +1 @@
-1.0.4
+1.0.5

data/lib/safe_attributes.rb

@@ -41,6 +41,15 @@ module SafeAttributes
       return if (bad_attribute_names.include?(method.to_sym))
       super(attr_name)
     end
+
+    def instance_method_already_implemented?(method_name)
+      begin 
+        return super(method_name)
+      rescue ActiveRecord::DangerousAttributeError
+        return true
+      end
+      return false
+    end
   end
 
   module InstanceMethods

data/safe_attributes.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{safe_attributes}
-  s.version = "1.0.4"
+  s.version = "1.0.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Brian Jones"]
-  s.date = %q{2011-02-04}
+  s.date = %q{2011-07-18}
   s.description = %q{Better support for legacy database schemas for ActiveRecord, such as columns named class, or any other name that conflicts with an instance method of ActiveRecord.}
   s.email = %q{cbj@gnu.org}
   s.extra_rdoc_files = [
@@ -21,6 +21,7 @@ Gem::Specification.new do |s|
     ".rspec",
     "Gemfile",
     "LICENSE",
+    "NEWS.rdoc",
     "README.rdoc",
     "Rakefile",
     "VERSION",
@@ -33,15 +34,10 @@ Gem::Specification.new do |s|
   s.homepage = %q{http://github.com/bjones/safe_attributes}
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.7}
+  s.rubygems_version = %q{1.6.2}
   s.summary = %q{Useful for legacy database support, adds support for reserved word column names with ActiveRecord}
-  s.test_files = [
-    "spec/safe_attributes/safe_attributes_spec.rb",
-    "spec/spec_helper.rb"
-  ]
 
   if s.respond_to? :specification_version then
-    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
@@ -49,26 +45,35 @@ Gem::Specification.new do |s|
       s.add_runtime_dependency(%q<activerecord>, ["~> 3.0.0"])
       s.add_development_dependency(%q<jeweler>, [">= 1.5.2"])
       s.add_development_dependency(%q<rake>, [">= 0.8.7"])
+      s.add_development_dependency(%q<rdoc>, [">= 0"])
       s.add_development_dependency(%q<rspec>, [">= 2.3.0"])
       s.add_development_dependency(%q<rcov>, [">= 0"])
       s.add_development_dependency(%q<sqlite3-ruby>, [">= 0"])
+      s.add_development_dependency(%q<activerecord-jdbcsqlite3-adapter>, [">= 0"])
+      s.add_development_dependency(%q<jruby-openssl>, [">= 0"])
     else
       s.add_dependency(%q<activesupport>, ["~> 3.0.0"])
       s.add_dependency(%q<activerecord>, ["~> 3.0.0"])
       s.add_dependency(%q<jeweler>, [">= 1.5.2"])
       s.add_dependency(%q<rake>, [">= 0.8.7"])
+      s.add_dependency(%q<rdoc>, [">= 0"])
       s.add_dependency(%q<rspec>, [">= 2.3.0"])
       s.add_dependency(%q<rcov>, [">= 0"])
       s.add_dependency(%q<sqlite3-ruby>, [">= 0"])
+      s.add_dependency(%q<activerecord-jdbcsqlite3-adapter>, [">= 0"])
+      s.add_dependency(%q<jruby-openssl>, [">= 0"])
     end
   else
     s.add_dependency(%q<activesupport>, ["~> 3.0.0"])
     s.add_dependency(%q<activerecord>, ["~> 3.0.0"])
     s.add_dependency(%q<jeweler>, [">= 1.5.2"])
     s.add_dependency(%q<rake>, [">= 0.8.7"])
+    s.add_dependency(%q<rdoc>, [">= 0"])
     s.add_dependency(%q<rspec>, [">= 2.3.0"])
     s.add_dependency(%q<rcov>, [">= 0"])
     s.add_dependency(%q<sqlite3-ruby>, [">= 0"])
+    s.add_dependency(%q<activerecord-jdbcsqlite3-adapter>, [">= 0"])
+    s.add_dependency(%q<jruby-openssl>, [">= 0"])
   end
 end
 

data/spec/safe_attributes/safe_attributes_spec.rb

@@ -6,6 +6,10 @@ ActiveRecord::Base.connection.create_table(:my_models) do |t|
   t.string :class
   t.string :bad_attribute
   t.string :good_attribute
+  # bad because of changed and changed? in ActiveModel
+  t.string :changed
+  # bad because normally it generates DangerousAttributeError
+  t.string :errors
 end
 
 class MyModel < ActiveRecord::Base
@@ -70,11 +74,23 @@ describe MyModel do
   end
 
   it "can create instance in database with special attribute name" do
-    m = MyModel.create(:class => 'Foo')
+    m = MyModel.create!(:class => 'Foo')
     m = MyModel.find(m.id)
     m[:class].should == 'Foo'
   end
 
+  it "can create instance in database with attribute 'changed'" do
+    m = MyModel.create!(:class => 'Foo', :changed => 'true change')
+    m = MyModel.find(m.id)
+    m[:changed].should == 'true change'
+  end
+
+  it "can create instance in database with attribute 'errors'" do
+    m = MyModel.create!(:class => 'Foo', :errors => 'my errors')
+    m = MyModel.find(m.id)
+    m[:errors].should == 'my errors'
+  end
+
   it "has class attribute" do
     MyModel.new().has_attribute?('class').should be_true
   end
@@ -97,5 +113,16 @@ describe MyModel do
     m = MyModel.new(:class => 'Foo')
     m.valid?.should be_true
   end
+
+  it "changed lists attributes with unsaved changes" do
+    m = MyModel.new(:class => 'Foo')
+    m.changed.size == 1
+  end
+
+  it "changed? returns true if any attribute has unsaved changes" do
+    m = MyModel.new(:class => 'Foo')
+    m.changed?.should be_true
+  end
+
 end
 

metadata

@@ -1,145 +1,142 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: safe_attributes
-version: !ruby/object:Gem::Version 
-  hash: 31
-  prerelease: false
-  segments: 
-  - 1
-  - 0
-  - 4
-  version: 1.0.4
+version: !ruby/object:Gem::Version
+  version: 1.0.5
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - Brian Jones
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-02-04 00:00:00 -05:00
+date: 2011-07-18 00:00:00.000000000 -04:00
 default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  type: :runtime
-  prerelease: false
+dependencies:
+- !ruby/object:Gem::Dependency
   name: activesupport
-  version_requirements: &id001 !ruby/object:Gem::Requirement 
+  requirement: &2155360580 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 3
-        - 0
-        - 0
+      - !ruby/object:Gem::Version
         version: 3.0.0
-  requirement: *id001
-- !ruby/object:Gem::Dependency 
   type: :runtime
   prerelease: false
+  version_requirements: *2155360580
+- !ruby/object:Gem::Dependency
   name: activerecord
-  version_requirements: &id002 !ruby/object:Gem::Requirement 
+  requirement: &2155360040 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 3
-        - 0
-        - 0
+      - !ruby/object:Gem::Version
         version: 3.0.0
-  requirement: *id002
-- !ruby/object:Gem::Dependency 
-  type: :development
+  type: :runtime
   prerelease: false
+  version_requirements: *2155360040
+- !ruby/object:Gem::Dependency
   name: jeweler
-  version_requirements: &id003 !ruby/object:Gem::Requirement 
+  requirement: &2155359460 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 1
-        - 5
-        - 2
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 1.5.2
-  requirement: *id003
-- !ruby/object:Gem::Dependency 
   type: :development
   prerelease: false
+  version_requirements: *2155359460
+- !ruby/object:Gem::Dependency
   name: rake
-  version_requirements: &id004 !ruby/object:Gem::Requirement 
+  requirement: &2155358880 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 49
-        segments: 
-        - 0
-        - 8
-        - 7
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 0.8.7
-  requirement: *id004
-- !ruby/object:Gem::Dependency 
   type: :development
   prerelease: false
+  version_requirements: *2155358880
+- !ruby/object:Gem::Dependency
+  name: rdoc
+  requirement: &2155358300 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *2155358300
+- !ruby/object:Gem::Dependency
   name: rspec
-  version_requirements: &id005 !ruby/object:Gem::Requirement 
+  requirement: &2155357780 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 2
-        - 3
-        - 0
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 2.3.0
-  requirement: *id005
-- !ruby/object:Gem::Dependency 
   type: :development
   prerelease: false
+  version_requirements: *2155357780
+- !ruby/object:Gem::Dependency
   name: rcov
-  version_requirements: &id006 !ruby/object:Gem::Requirement 
+  requirement: &2155351280 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  requirement: *id006
-- !ruby/object:Gem::Dependency 
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
+  version_requirements: *2155351280
+- !ruby/object:Gem::Dependency
   name: sqlite3-ruby
-  version_requirements: &id007 !ruby/object:Gem::Requirement 
+  requirement: &2155350780 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  requirement: *id007
-description: Better support for legacy database schemas for ActiveRecord, such as columns named class, or any other name that conflicts with an instance method of ActiveRecord.
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *2155350780
+- !ruby/object:Gem::Dependency
+  name: activerecord-jdbcsqlite3-adapter
+  requirement: &2155350220 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *2155350220
+- !ruby/object:Gem::Dependency
+  name: jruby-openssl
+  requirement: &2155349680 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *2155349680
+description: Better support for legacy database schemas for ActiveRecord, such as
+  columns named class, or any other name that conflicts with an instance method of
+  ActiveRecord.
 email: cbj@gnu.org
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - LICENSE
 - README.rdoc
-files: 
+files:
 - .document
 - .rspec
 - Gemfile
 - LICENSE
+- NEWS.rdoc
 - README.rdoc
 - Rakefile
 - VERSION
@@ -150,38 +147,32 @@ files:
 - spec/spec_helper.rb
 has_rdoc: true
 homepage: http://github.com/bjones/safe_attributes
-licenses: 
+licenses:
 - MIT
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
       - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+      hash: -237664751269868444
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
-summary: Useful for legacy database support, adds support for reserved word column names with ActiveRecord
-test_files: 
-- spec/safe_attributes/safe_attributes_spec.rb
-- spec/spec_helper.rb
+summary: Useful for legacy database support, adds support for reserved word column
+  names with ActiveRecord
+test_files: []