sa_vat_validation 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 7ee5f5cb79a55957c35c87dbfe44c36eb2cd359a
-  data.tar.gz: 1e866c4dd9ac2c417bf5a6b9b6bcdf8ca86f5ede
+SHA256:
+  metadata.gz: 42162cd0d649690602314d4c7936eacbacc0adfa1d0332fbc47f10bf848d40ee
+  data.tar.gz: 2f27791b1489bd91c45f1b578976b80b824b7e77ab8d7b1b6f64961a682ca4c5
 SHA512:
-  metadata.gz: a9456795c2c75c7704054b1d4331ac53fddacf9817c02e7430693ade0d2b507f92197382d425afbe976dacfa424c7df3a4197b1885401ecb1646b7fc286f0028
-  data.tar.gz: 34954fdd1846fbee916e93d591b8861424a9f214dbdff258adefd89488c7fb8d730d40f83bd37fed899823e4c84f8a03df1838fd0b978a0b33de3875b995d20b
+  metadata.gz: 9088b0d2f574a246ccddc2c996ad2d147f1cbede353ee7b60e6ca94ce664409e578e01d0140080efb56d3913890fb4d0b0365fb7509d60a97a3a3fc8c990bb17
+  data.tar.gz: 34c02e321c98e548791f7aa87479be4ae42d91b9b38465bf64dbd48161cc4beede0b93b7141c73e4dc11f4ac1d22d4c015cfe0cae65aa68b482f36f162ef6de4

data/.gitignore

@@ -3,4 +3,3 @@
 pkg/*
 test/*
 bin/*
-*.gemspec

data/Gemfile.lock

@@ -1,21 +1,17 @@
 PATH
   remote: .
   specs:
-    sa_vat_validation (0.1.2)
+    sa_vat_validation (0.2.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (4.2.1)
-      i18n (~> 0.7)
-      json (~> 1.7, >= 1.7.7)
-      minitest (~> 5.1)
-      thread_safe (~> 0.3, >= 0.3.4)
-      tzinfo (~> 1.1)
+    coderay (1.1.3)
     diff-lcs (1.2.5)
-    i18n (0.7.0)
-    json (1.8.2)
-    minitest (5.7.0)
+    method_source (1.0.0)
+    pry (0.14.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
     rake (10.4.2)
     rspec (3.2.0)
       rspec-core (~> 3.2.0)
@@ -30,19 +26,16 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.2.0)
     rspec-support (3.2.2)
-    thread_safe (0.3.5)
-    tzinfo (1.2.2)
-      thread_safe (~> 0.1)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  activesupport (~> 4.2)
   bundler (~> 1.10)
+  pry (~> 0.14.1)
   rake (~> 10.0)
   rspec (~> 3.2)
   sa_vat_validation!
 
 BUNDLED WITH
-   1.10.1
+   1.16.2

data/lib/sa_vat_validation/version.rb

@@ -1,3 +1,3 @@
 module SaVatValidation
-  VERSION = "0.1.2"
+  VERSION = "0.2.0".freeze
 end

data/lib/sa_vat_validation.rb

@@ -1,21 +1,5 @@
 require "sa_vat_validation/version"
-require 'active_support/core_ext/string'
 
-class Fixnum
-  def last_digit
-    self.to_s.last.to_i
-  end
-
-  def first_digit
-    self.to_s.first.to_i 
-  end
-end
-
-class String
-  def is_numeric?
-    Float self rescue false
-  end
-end
 
 module SaVatValidation
   def self.valid?(vat_number)
@@ -23,34 +7,48 @@ module SaVatValidation
 
     # As per SARS
     # A VAT Number is a unique number, which comprises of 10 digits and starts with the number 4
-    return false unless digits.first.to_i == 4
-    return false unless digits.size == 10 && vat_number.to_s.is_numeric?
+    return false unless digits.first == 4
+    return false unless digits.size  == 10 && vat_number.to_s.is_numeric?
 
     check_digit = digits.pop
+    sum         = 0
 
-    sum = 0
     digits.each_with_index do |digit, i|
       if i.even?
         result = digit * 2
-        if result >= 10
-          result = result.first_digit + result.last_digit
-        end
+        result = first_digit(result) + last_digit(result) if result >= 10
+
         sum += result
       else
-        sum += digit.to_i
+        sum += digit
       end
     end
-    if sum.last_digit.zero?
-      calculated_digit = sum.last_digit
-    else
-      calculated_digit = 10 - sum.last_digit
-    end
 
-    return check_digit == calculated_digit
+    calculated_digit = last_digit(sum).zero? ? last_digit(sum) : 10 - last_digit(sum)
+
+    check_digit == calculated_digit
+  end
+
+  def self.last_digit(a)
+    a.to_s.chars.last.to_i
+  end
+
+  def self.first_digit(a)
+    a.to_s.chars.first.to_i
+  end
+end
+
+class String
+  def valid_sa_vat_number?
+    SaVatValidation::valid?(self)
+  end
+
+  def is_numeric?
+    Float self rescue false
   end
 end
 
-class Object
+class Numeric
   def valid_sa_vat_number?
     SaVatValidation::valid?(self)
   end

data/sa_vat_validation.gemspec

@@ -0,0 +1,27 @@
+# coding: utf-8
+
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'sa_vat_validation/version'
+
+Gem::Specification.new do |spec|
+  spec.name          = "sa_vat_validation"
+  spec.version       = SaVatValidation::VERSION
+  spec.authors       = ["Gary Greyling"]
+  spec.email         = ["greyling.gary@gmail.com"]
+  spec.description   = "SA VAT number validation"
+  spec.summary       = "SA VAT number validation"
+  spec.homepage      = ""
+  spec.license       = "MIT"
+
+  spec.files         = `git ls-files`.split($/)
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.require_paths = ["lib"]
+
+  # spec.add_development_dependency "activesupport", "~> 4.2"
+  spec.add_development_dependency "bundler", "~> 1.10"
+  spec.add_development_dependency "pry",     "~> 0.14.1"
+  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rspec", "~> 3.2"
+end

data/spec/sa_vat_validation_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+describe SaVatValidation do
+  it 'has a version number' do
+    expect(SaVatValidation::VERSION).not_to be nil
+  end
+
+  context 'validates a South African VAT number' do
+    it "should validate '4111111110' as true" do
+      expect(described_class).to be_valid(4111111110)
+    end
+
+    it "should validate '0000000000' as false" do
+      expect(described_class).not_to be_valid(0000000000)
+    end
+
+    it "should validate a non number 'kjabndfojb' as false" do
+      expect(described_class).not_to be_valid("kjabndfojb")
+    end
+  end
+
+  context "monkey patching" do
+    describe "String" do
+      context "when valid" do
+        subject { "4111111110" }
+
+        it { is_expected.to be_valid_sa_vat_number }
+      end
+
+      context "when invalid" do
+        subject { "0000000000" }
+
+        it { is_expected.not_to be_valid_sa_vat_number }
+      end
+    end
+
+    describe "Numeric" do
+      context "when valid" do
+        subject { 4111111110 }
+
+        it { is_expected.to be_valid_sa_vat_number }
+      end
+
+      context "when invalid" do
+        subject { 0000000000 }
+
+        it { is_expected.not_to be_valid_sa_vat_number }
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,4 @@
+$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+
+require 'sa_vat_validation'
+require 'pry'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sa_vat_validation
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Gary Greyling
-autorequire: 
-bindir: exe
+autorequire:
+bindir: bin
 cert_chain: []
-date: 2015-06-08 00:00:00.000000000 Z
+date: 2022-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -25,51 +25,50 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.10'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 0.14.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 0.14.1
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '10.0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
-description: This gem is used to validate a South African VAT number based on the
-  current rules and regulations
+        version: '3.2'
+description: SA VAT number validation
 email:
-- greyling.gary@gmail.co.za
+- greyling.gary@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -84,11 +83,14 @@ files:
 - Rakefile
 - lib/sa_vat_validation.rb
 - lib/sa_vat_validation/version.rb
-homepage: http://github.com/mpowered/sa_vat_validation
+- sa_vat_validation.gemspec
+- spec/sa_vat_validation_spec.rb
+- spec/spec_helper.rb
+homepage: ''
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -103,9 +105,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
-summary: Validation of South African VAT numbers
-test_files: []
+summary: SA VAT number validation
+test_files:
+- spec/sa_vat_validation_spec.rb
+- spec/spec_helper.rb