rvista 0.5.6 → 0.6.0

data/CHANGELOG

@@ -0,0 +1,33 @@
+v0.6.0 (20th May 2009)
+- Ruby 1.9 compat. No behaviour changes
+
+v0.5.6 (13th November 2008)
+- Cap field lengths in invoices to the max allowed by the spec
+- Remove decimal points from monetary values
+  - all prices should be specified in cents
+
+v0.5.5 (15th October 2008)
+- Ensure RVista::POA#to_s includes total ordered qty in the footer
+
+v0.5.4 (7th October 2008)
+- Fix calculation of footer totals in RVista::Invoice#to_s
+
+v0.5.3 (4th July 2008)
+- Add RVista::POA#status_text
+
+v0.5.2 (2nd July 2008)
+- Add support for retrieving invoice totals
+
+v0.5.1 (12th November 2007)
+* Added RVista::Message and PO::LineItem classes for backwards compatability with =< v0.2. A deprecation warning will be printed to stderr.
+
+v0.5 (12th October 2007)
+* added support for Vista purchase order acks (POAs)
+* added support for Vista invoices
+* ****WARNING**** API CHANGE: renamed RVista::Message to the more sensible RVista::PO
+
+v0.2 (19th November 2006)
+* added support for converting a RVista::Message object to a string
+
+v0.1.0 (17th October 2006)
+* Initial Release

data/Rakefile

@@ -5,7 +5,7 @@ require 'rake/testtask'
 require "rake/gempackagetask"
 require "rubygems"
 
-PKG_VERSION = "0.5.6"
+PKG_VERSION = "0.6.0"
 PKG_NAME = "rvista"
 PKG_FILE_NAME = "#{PKG_NAME}-#{PKG_VERSION}"
 
@@ -31,6 +31,7 @@ desc "Create documentation"
 Rake::RDocTask.new("doc") do |rdoc|
   rdoc.title = "RVista"
   rdoc.rdoc_dir = 'doc/html'
+  rdoc.rdoc_files.include('CHANGELOG')
   rdoc.rdoc_files.include('README')
   rdoc.rdoc_files.include('COPYING')
   rdoc.rdoc_files.include('LICENSE')
@@ -47,10 +48,9 @@ spec = Gem::Specification.new do |spec|
   spec.require_path = "lib"
   spec.test_files = Dir[ "test/test_*.rb" ]
   spec.has_rdoc = true
-  spec.extra_rdoc_files = %w{README COPYING LICENSE}
+  spec.extra_rdoc_files = %w{README COPYING LICENSE CHANGELOG}
   spec.rdoc_options << '--title' << 'rvista Documentation' <<
                        '--main'  << 'README' << '-q'
-  spec.add_dependency('fastercsv', '>= 1.2.1')
   spec.author = "James Healy"
   spec.email = "jimmy@deefa.com"
   spec.description = <<END_DESC

data/lib/rvista.rb

@@ -1,3 +1,25 @@
+# coding: utf-8
+
+require 'rubygems'
+
+# faster csv is distributed with ruby 1.9 as "CSV", so we only
+# need to load the gem on ruby < 1.9
+#
+# This shim borrowed from Gregory Brown
+# http://ruport.blogspot.com/2008/03/fastercsv-api-shim-for-19.html
+#
+if RUBY_VERSION > "1.9"
+  require "csv"
+  unless defined? FasterCSV
+    class Object
+      FCSV = FasterCSV = CSV
+      alias_method :FasterCSV, :CSV
+    end
+  end
+else
+  require "fastercsv"
+end
+
 
 require File.dirname(__FILE__) + '/rvista/errors'
 require File.dirname(__FILE__) + '/rvista/invoice'

data/lib/rvista/errors.rb

@@ -1,3 +1,4 @@
+# coding: utf-8
 
 module RVista
 

data/lib/rvista/invoice.rb

@@ -1,5 +1,4 @@
-require 'rubygems'
-require 'fastercsv'
+# coding: utf-8
 
 module RVista
 
@@ -16,7 +15,7 @@ module RVista
       @items = []
     end
 
-    # reads a vista invoice file into memory. input should be a string 
+    # reads a vista invoice file into memory. input should be a string
     # that specifies the file path
     def self.load_from_file(input)
       raise InvalidFileError, 'Invalid file' unless File.exist?(input)
@@ -44,13 +43,13 @@ module RVista
       msg << "#{doc_date.to_s[0,8]},"
       msg << "#{delivery_location.to_s[0,10]},"
       msg << "#{currency.to_s[0,4]}\n"
-      
+
       total_value = BigDecimal.new("0")
       total_qty   = BigDecimal.new("0")
       total_gst   = BigDecimal.new("0")
 
       # message line items
-      @items.each do |item| 
+      @items.each do |item|
         msg << item.to_s << "\n"
         total_value += item.nett_value + item.gst
         total_qty   += item.qty
@@ -90,7 +89,7 @@ module RVista
       msg.currency    = data[0][8]
 
       # load each lineitem into the message
-      data[1,data.size - 2].each do |row| 
+      data[1,data.size - 2].each do |row|
         raise InvalidLineItemError, 'Invalid line detected' unless row[0].eql?("D")
         item = InvoiceLineItem.load_from_array(row)
         msg.items << item
@@ -98,6 +97,7 @@ module RVista
 
       raise InvalidFileError, 'Last line isn\'t a footer' unless data[-1][0].eql?("S")
       raise InvalidFileError, 'Line item count doesn\'t match footer' unless data[-1][1].to_i.eql?(msg.items.size)
+
       msg.total_value = BigDecimal.new(data[-1][2])
       msg.total_qty   = BigDecimal.new(data[-1][3])
       msg.total_gst   = BigDecimal.new(data[-1][4])

data/lib/rvista/invoice_line_item.rb

@@ -1,3 +1,5 @@
+# coding: utf-8
+
 require 'bigdecimal'
 
 module RVista

data/lib/rvista/po.rb

@@ -1,5 +1,4 @@
-require 'rubygems'
-require 'fastercsv'
+# coding: utf-8
 
 module RVista
 

data/lib/rvista/po_line_item.rb

@@ -1,3 +1,5 @@
+# coding: utf-8
+
 require 'bigdecimal'
 
 module RVista

data/lib/rvista/poa.rb

@@ -1,5 +1,4 @@
-require 'rubygems'
-require 'fastercsv'
+# coding: utf-8
 
 module RVista
 

data/lib/rvista/poa_line_item.rb

@@ -1,3 +1,5 @@
+# coding: utf-8
+
 require 'bigdecimal'
 
 module RVista
@@ -15,7 +17,7 @@ module RVista
     STATUS = {
       1 => "Shipped as ordered",
       2 => "Title substituted",
-      6 => "Out of stock – reprinting",
+      6 => "Out of stock - reprinting",
       7 => "Back ordered",
       9 => "Part supply",
       10 => "Part back ordered",

data/test/data/invoice/valid.txt

@@ -1,4 +1,4 @@
 H,1111111,2222222,IN,Invoice,5678,071011,1111111,
-D,1,1234,EN,9781857230765,Eye of the World,2,EA,5.00,40.00,4.50,Y,10.00,6.00,9.50,1.00,F
-D,2,1234,EN,9780744590104,Eye of the Wolf,3,EA,5.00,40.00,4.50,Y,15.00,9.00,9.50,1.50,F
-S,2,25.00,5,2.50
+D,1,1234,EN,9781857230765,Eye of the World,2,EA,500,4000,450,Y,1000,600,1000,100,F
+D,2,1234,EN,9780744590104,Eye of the Wolf,3,EA,500,4000,450,Y,1500,900,1000,100,F
+S,2,2200,5,200

data/test/unit/invoice_line_item_test.rb

@@ -2,7 +2,6 @@ $LOAD_PATH.unshift(File.dirname(__FILE__) + '/../../lib')
 
 require 'test/unit'
 require 'rvista'
-require 'fastercsv'
 
 class InvoiceLineItemTest < Test::Unit::TestCase
 

data/test/unit/invoice_test.rb

@@ -16,9 +16,9 @@ class InvoiceTest < Test::Unit::TestCase
     msg = RVista::Invoice.load_from_file(VALID)
     assert_kind_of RVista::Invoice, msg
     assert_equal msg.items.size, 2
-    assert_equal msg.total_value, BigDecimal.new("25.00")
+    assert_equal msg.total_value, BigDecimal.new("2200")
     assert_equal msg.total_qty, BigDecimal.new("5")
-    assert_equal msg.total_gst, BigDecimal.new("2.50")
+    assert_equal msg.total_gst, BigDecimal.new("200")
 
     validate_msg(msg)
   end
@@ -28,14 +28,14 @@ class InvoiceTest < Test::Unit::TestCase
     msg = RVista::Invoice.load_from_string(File.read(VALID))
     assert_kind_of RVista::Invoice, msg
     assert_equal msg.items.size, 2
-    
+
     validate_msg(msg)
   end
 
   # ensure the load_from_file method throws the correct exceptions
   # when it encounters a problem
   def test_product_validation
-    
+
     assert_raise(RVista::InvalidFileError) {
       msg = RVista::Invoice.load_from_file(INVALID_MISSING_HEADER)
     }
@@ -43,7 +43,7 @@ class InvoiceTest < Test::Unit::TestCase
     assert_raise(RVista::InvalidFileError) {
       msg = RVista::Invoice.load_from_file(INVALID_MISSING_FOOTER)
     }
-    
+
     assert_raise(RVista::InvalidLineItemError) {
       msg = RVista::Invoice.load_from_file(INVALID_LINE)
     }

data/test/unit/line_item_test.rb

@@ -2,7 +2,6 @@ $LOAD_PATH.unshift(File.dirname(__FILE__) + '/../../lib')
 
 require 'test/unit'
 require 'rvista'
-require 'fastercsv'
 
 class POLineItemTest < Test::Unit::TestCase
 

data/test/unit/poa_line_item_test.rb

@@ -2,7 +2,6 @@ $LOAD_PATH.unshift(File.dirname(__FILE__) + '/../../lib')
 
 require 'test/unit'
 require 'rvista'
-require 'fastercsv'
 
 class POALineItemTest < Test::Unit::TestCase
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rvista
 version: !ruby/object:Gem::Version 
-  version: 0.5.6
+  version: 0.6.0
 platform: ruby
 authors: 
 - James Healy
@@ -9,19 +9,10 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-11-13 00:00:00 +11:00
+date: 2009-05-21 00:00:00 +10:00
 default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  name: fastercsv
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: 1.2.1
-    version: 
+dependencies: []
+
 description: rvista is a small library for reading Vista HDS order files.
 email: jimmy@deefa.com
 executables: []
@@ -32,6 +23,7 @@ extra_rdoc_files:
 - README
 - COPYING
 - LICENSE
+- CHANGELOG
 files: 
 - lib/rvista.rb
 - lib/rvista
@@ -71,6 +63,7 @@ files:
 - README
 - COPYING
 - LICENSE
+- CHANGELOG
 has_rdoc: true
 homepage: 
 post_install_message: 
@@ -97,7 +90,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.2.0
+rubygems_version: 1.3.1
 signing_key: 
 specification_version: 2
 summary: A small library for reading Vista HDS ecommerce files