rutl 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 91f41b74e68fe36acb46dd525f7f375f18d3939d5a7fc15c1972ff443af6125e
-  data.tar.gz: 1a2d184998b8f3f18532ece3f353059cbd616e8f7a419c4331c8dfc10fc40d59
+  metadata.gz: 44ba7a05dd473a09ac45ecafc02d9e11f0a74e26d0e8eb5909e315226066e0ca
+  data.tar.gz: 6a272e4fc1afb2d1111b90604ceb3443cc89fd49c703ff417ab56fd9f609573b
 SHA512:
-  metadata.gz: 4a91637e9662ede93d7991261f44dde9299d0b04482ab25ce8d952fc2f16e4df210452c120642f816a373f4c565287ee16aa57033d0d3c609b23a07f5a9cd17f
-  data.tar.gz: 93a535c70dbd92121f461bbcea341c3dea2c9d23ac33ae6f5bdcd2658efe1dacf3feb048012412577d6a5726ecf5ca3ce535b76524a48789f92dffebcdf6e8ac
+  metadata.gz: 58227d7b2a1dd426ced4d42a826081ad71b638b6f212a16c5905ef57d0fb28ea4689b0240233dbfbb8d42701460c3bf91354cb088414693047836dcf30fb56ce
+  data.tar.gz: c4acf6148162ef28b3f7704ea6885a6acd81b9bfb0dbff26fb87a6294f943fa5a1e6bcdeb3aaa8668bf597fa0d452620a90587aadf6cd71ea3b4670f5f3281a1

data/.gitignore

@@ -1,9 +1,10 @@
-/.bundle/
-/.yardoc
-/Gemfile.lock
-/_yardoc/
-/coverage/
-/doc/
-/pkg/
-/spec/reports/
-/tmp/
+/.bundle/
+/.yardoc
+/debug.log
+/Gemfile.lock
+/_yardoc/
+/coverage/
+/doc/
+/pkg/
+/spec/reports/
+/tmp/

data/.rubocop.yml

@@ -6,7 +6,7 @@ require: rubocop-rspec
 # There are also a bunch of warnigs spewed about the RSpec cops listed
 # in the todo file so it looks like we're not playing well with rubocop-rspec
 # either.
-# Check this in for now and TODO: figure this out tomorrow.
+# Check this in for now and TODO: figure this out.
 require: drewcoo-cops
 
 AllCops:

data/.rubocop_todo.yml

@@ -1,45 +1,20 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-05-26 12:34:26 -0700 using RuboCop version 0.56.0.
+# on 2018-06-03 15:06:48 -0700 using RuboCop version 0.56.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-Metrics/AbcSize:
-  Max: 16
-
 # Offense count: 3
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 48
+  Max: 74
 
-# Offense count: 4
+# Offense count: 3
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
-  Max: 19
-
-# Offense count: 1
-Naming/AccessorMethodName:
-  Exclude:
-    - 'lib/rutl/interface/null_interface.rb'
-
-# Offense count: 1
-RSpec/ExampleLength:
-  Exclude:
-    - 'spec/chrome_interface_spec.rb'
-
-# Offense count: 2
-RSpec/ExpectActual:
-  Exclude:
-    - 'spec/null_interface_spec.rb'
-    - 'spec/rutl_spec.rb'
-
-# Offense count: 1
-RSpec/MultipleExpectations:
-  Exclude:
-    - 'spec/chrome_interface_spec.rb'
+  Max: 13
 
 # Offense count: 4
 # Cop supports --auto-correct.
@@ -50,39 +25,34 @@ Style/BracesAroundHashParameters:
     - 'spec/pages/internet_login_page.rb'
     - 'spec/pages/page1.rb'
 
-# Offense count: 1
+# Offense count: 3
 Style/ClassVars:
   Exclude:
     - 'lib/rutl/base_page.rb'
+    - 'lib/rutl/driver/null_driver_page_element.rb'
 
 # Offense count: 4
-Style/MethodMissingSuper:
-  Exclude:
-    - 'lib/rutl/base_page.rb'
-    - 'lib/rutl/browser.rb'
-    - 'lib/rutl/interface/base_interface.rb'
-    - 'spec/spec_helper.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/PerlBackrefs:
+# Configuration parameters: AllowedVariables.
+Style/GlobalVars:
   Exclude:
     - 'lib/rutl/browser.rb'
+    - 'lib/rutl/interface/elements/base_element.rb'
+    - 'lib/rutl/interface/elements/element_context.rb'
+    - 'lib/rutl/interface/null_interface.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, explicit
-Style/RescueStandardError:
+Style/IfUnlessModifier:
   Exclude:
-    - 'lib/rutl/utilities.rb'
+    - 'lib/rutl/interface/elements/element_context.rb'
 
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: AllowIfMethodIsEmpty.
-Style/SingleLineMethods:
+# Offense count: 4
+Style/MethodMissingSuper:
   Exclude:
     - 'lib/rutl/base_page.rb'
+    - 'lib/rutl/browser.rb'
+    - 'lib/rutl/interface/base_interface.rb'
+    - 'spec/spec_helper.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
@@ -91,3 +61,9 @@ Style/SingleLineMethods:
 Style/TrivialAccessors:
   Exclude:
     - 'lib/rutl/base_page.rb'
+
+# Offense count: 15
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 223

data/README.md

@@ -4,6 +4,7 @@
 [![CircleCI](https://circleci.com/gh/drewcoo/rutl.svg?style=shield)](https://circleci.com/gh/drewcoo/rutl)
 [![Coverage Status](https://coveralls.io/repos/github/drewcoo/rutl/badge.svg?branch=master)](https://coveralls.io/github/drewcoo/rutl?branch=master)
 [![Gem Version](https://badge.fury.io/rb/rutl.svg)](https://badge.fury.io/rb/rutl)
+[![Codacy Badge](https://api.codacy.com/project/badge/Grade/f95d69f6bdd149e697cf63e842f71600)](https://www.codacy.com/app/drewcoo/rutl?utm_source=github.com&utm_medium=referral&utm_content=drewcoo/rutl&utm_campaign=Badge_Grade)
 
 This is the Ruby Ui Test Library, or RUTL. Not to be confused with [The Rutles](https://www.rutles.org/).
 

data/Rakefile

@@ -1,6 +1,17 @@
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
-RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new
 
-task default: :spec
+task :fast_first do
+  Rake::Task['spec'].invoke('fast')
+  Rake::Task['spec'].reenable
+  Rake::Task['spec'].invoke('slow')
+end
+
+RSpec::Core::RakeTask.new(:spec, :tag) do |t, args|
+  t.rspec_opts = ["--tag #{args[:tag]}"]
+end
+
+task default: :fast_first

data/lib/rutl/base_page.rb

@@ -9,73 +9,68 @@ class BasePage
   # BUGBUG: Kludgy. What do I really want to do here?
   # Make it easy to define a page's default url and
   # also matchers for page urls for pages with variable urls?
-  def self.url; @url; end
-
-  def url; self.class.url; end
+  def self.url
+    @url
+  end
 
-  @@children = []
-  def self.children; @@children; end
+  def url
+    self.class.url
+  end
 
-  attr_accessor :driver
+  @@loaded_pages = []
 
-  # TODO: DO I REALLY WANT TO PASS IN DRIVER LIKE THAT?
-  def initialize
-    # Call a class's layout method the first time it's loaded
-    # and put the class name in a list of children, which is a
-    # list of all actual page objects in this case.
-    return if @@children.include?(self.class)
+  def initialize(interface)
+    @interface = interface
+    # Dirty trick because we're loading all of page classes from files and then
+    # initializing them, calling their layout methods to do magic.
+    # The base_page class knows what pages are loaded.
+    return if @@loaded_pages.include?(self.class)
     layout
-    @@children << self.class
+    @@loaded_pages << self.class
   end
 
-  def loaded?
-    @url = @driver.current_url
+  # Written by Browser and only used internally.
+  attr_writer :interface
+
+  def loaded?(driver)
+    url == driver.current_url
   end
 
-  # BUGBUG: This creates a new element instance whenever it's called.
-  # Because of that we can't keep state in any element objects.
-  # Is that actually a good thing, maybe?
+  # Dynamically add a method, :<name> (or :<name>= if setter)
+  # to the current class where that method creates an instance
+  # of klass.
+  # context is an ElementContext
+  def add_method(context:, klass:, name:, setter: false)
+    name = "#{name}_#{klass.downcase}"
+    constant = Module.const_get(klass.capitalize)
+    self.class.class_exec do
+      if setter
+        define_method("#{name}=") do |value|
+          constant.new(context, value)
+        end
+      else
+        define_method(name) do
+          constant.new(context)
+        end
+      end
+    end
+  end
 
+  # This creates a new element instance whenever it's called.
+  # Because of that we can't keep state in any element objects.
+  # That seems like a good thing, actually.
   # Called by layout method on pages.
   def method_missing(element, *args, &_block)
-    name, selector, rest = args
-    name = "#{name}_#{element.downcase}"
-
+    name, selectors, rest = args
+    context = ElementContext.new(destinations: rest,
+                                 interface: @interface,
+                                 selectors: selectors)
     case element
     when /button/, /checkbox/, /link/
-      # self.class.class_exec do
-      #   define_method(name) do
-      #     Module.const_get(element.capitalize).new(selector, rest)
-      #   end
-      # end
-      self.class.class_exec do
-        foo = Module.const_get(element.capitalize).new(selector, rest)
-        define_method(name) do
-          foo
-        end
-      end
+      add_method(name: name, context: context, klass: element)
     when /text/
-      self.class.class_exec do
-        # foo = Module.const_get(element.capitalize).new(selector, rest)
-        # define_method("_#{name}") do
-        #   foo.get
-        # end
-        define_method(name) do
-          Module.const_get(element.capitalize).new(selector, rest)
-        end
-        # define_method(name.to_s) do
-        #   foo.get
-        # end
-        # define_method((name + '=').to_s) do
-        #   foo.set
-        # end
-        # foo.define_method(:get) do
-        #   foo.get
-        # end
-        # foo.define_method(:set) do
-        #   foo.set
-        # end
-      end
+      add_method(name: name, context: context, klass: element)
+      add_method(name: name, context: context, klass: element, setter: true)
     else
       # TODO: replace with a super call. This is useful for debugging for now.
       raise "#{element} NOT FOUND WITH ARGS #{args}!!!"
@@ -93,7 +88,7 @@ class BasePage
     else
       # I think it's good to raise but change the message.
       raise 'Drew, you hit this most often when checking current page ' \
-            'rather than current page class'
+            "rather than current page class:\n\n #{args}"
       # I think I want to raise instead of returningn false.
     end
   end

data/lib/rutl/browser.rb

@@ -9,26 +9,30 @@ require 'rutl/base_page'
 class Browser
   include Utilities
 
-  def initialize(interface_type: :none, page_object_dir: 'spec/pages')
-    @pages = load_pages(page_object_dir: page_object_dir)
-    load_interface(type: interface_type)
+  attr_reader :interface
+
+  def initialize(interface_type:, page_object_dir: 'spec/pages')
+    # This is kind of evil. Figure out how to ditch the $ variable.
+    $browser = self
+    @interface = nil
+    @interface = load_interface(interface_type)
+    @interface.pages = load_pages(dir: page_object_dir)
   end
 
-  def load_interface(type: :none)
-    pages = @pages
+  def load_interface(type)
     require "rutl/interface/#{type}_interface"
     klass = "#{type.to_s.capitalize}Interface"
-    @interface = Object.const_get(klass).new(pages: pages)
-    @interface.interface = @interface
+    Object.const_get(klass).new
   end
 
   # Ugly. Requires files for page objects. Returns array of class names to load.
-  def require_pages(page_object_dir: 'spec/pages')
+  def require_pages(dir: 'spec/pages')
     names = []
-    Dir["#{page_object_dir}/*"].each do |file|
+    Dir["#{dir}/*"].each do |file|
       require "rutl/../../#{file}"
       File.open(file).each do |line|
-        names << $1 if line =~ /class (.*) < BasePage/
+        bingo = line.match(/class (.*) < BasePage/)
+        names << bingo[1] if bingo && bingo[1]
       end
     end
     names
@@ -36,26 +40,19 @@ class Browser
 
   def load_pages(*)
     pages = []
-    names = require_pages
-    names.each do |klass|
+    require_pages.each do |klass|
       # Don't have @interface set yet.
       # That would have been the param to new, :interface.
-      pages << Object.const_get(klass).new
+      pages << Object.const_get(klass).new(@interface)
     end
     pages
   end
 
   def method_missing(method, *args, &block)
-    result = if args.empty?
-               @interface.send(method)
-             else
-               @interface.send(method, *args, &block)
-             end
-    if result.class == Array && (result[0].class.ancestors.include?(BasePage) ||
-                                 result[0].class == Exception)
-      wait_for_transition(result)
+    if args.empty?
+      @interface.send(method)
     else
-      result
+      @interface.send(method, *args, &block)
     end
   end
 

data/lib/rutl/driver/null_driver.rb

@@ -4,31 +4,35 @@ require 'rutl/driver/null_driver_page_element'
 # This is at a peer level to the webdrivers but it's for a fake brwoser.
 #
 class NullDriver
-  attr_accessor :interface
+  attr_accessor :context
+
+  def initialize(context)
+    raise 'no context' unless context.is_a?(ElementContext)
+    @context = context
+  end
 
   def find_element(type, location)
     # Return a new one of these so that it can be clicked ar written
     # to or whatever.
-    element = NullDriverPageElement.new(type, location)
-    element.interface = @interface
-    element
+    context = ElementContext.new(interface: @context.interface)
+    NullDriverPageElement.new(context, type, location)
   end
 
   # Cheap way to handle browser.navigate.to(url)
   # TODO: Until I care about the url and then I should ????
   def navigate
-    result = NullDriver.new
-    result.interface = @interface
-    result
+    context = ElementContext.new(interface: @context.interface)
+    NullDriver.new(context)
   end
 
   def to(url)
-    result = @interface.find_page(url)
-    @interface.set_current_page result
+    result = @context.interface.find_page(url)
+    @context.interface.current_page = result
     result.url
   end
 
   def quit
-    'quit'
+    # Clean out the @@variables.
+    NullDriverPageElement.clear_variables
   end
 end

data/lib/rutl/driver/null_driver_page_element.rb

@@ -1,40 +1,51 @@
+require 'rutl/interface/elements/element_context'
+
 #
 # This fakes all page elements when used with the null driver.
 # It's a dirty way to avoid modeling all of what a driver talks to.
 #
 class NullDriverPageElement
-  attr_accessor :string
-  attr_reader :selector_type, :selector
+  attr_accessor :context
 
-  attr_accessor :interface
-  attr_accessor :destinations
+  def self.clear_variables
+    @@variables = {}
+  end
 
-  def initialize(selector_type, selector)
-    # :css, selector
-    @selector_type = selector_type
-    @selector = selector
+  def initialize(context, _type, location)
+    @@variables ||= {}
+    @context = context
+    @location = location
   end
 
+  # @@string is a class variable because this framework creates new instances
+  # of each element every time it accesses them. This is good behavior by
+  # default because pages could change underneath us.
+  # For text fields in the null browser, though, we want to preserve the values
+  # across calls, letting us write and then read.
   def send_keys(string)
-    @string = string
+    init = @@variables[@location] || ''
+    @@variables[@location] = init + string
   end
 
   def attribute(attr)
     case attr.to_sym
     when :value
-      @string
+      @@variables[@location]
     else
       raise ArgumentError, "Attribute unknown: #{attr}"
     end
   end
 
-  # Return simple strings for checks against the NullDriver instead of
-  # having to use some heavyweight UI.
   def clear
-    'clear'
+    @@variables[@location] = ''
+  end
+
+  def this_css
+    self
   end
 
   def click
-    'click'
+    # nop
+    # Called by ClickToChangeStateMixin like Selenium driver.click
   end
 end

data/lib/rutl/interface/base_interface.rb

@@ -7,46 +7,27 @@ require 'rutl/utilities'
 class BaseInterface
   include Utilities
 
-  def current_url
-    current_page.url
-  end
-
-  attr_reader :pages
   attr_accessor :driver
-  attr_accessor :interface
+  attr_accessor :pages
 
-  def initialize(pages:)
-    @pages = pages
-    raise 'Child classes must implement @driver.' unless defined? @driver
-    @pages.each { |p| p.driver = @driver }
+  def initialize
+    raise 'Child interface class must set @driver.' if @driver.nil?
   end
 
-  def goto(input)
-    # TODO: KLUDGY. Fix. Modifier if usage bombs here. *shrug*
-    @driver.interface = @interface if @interface.class.to_s == 'NullInterface'
-    input = find_page(input) unless input.methods.include?(:url)
-
-    @driver.navigate.to input.url
+  def goto(page)
+    @driver.navigate.to find_page(page).url
   end
 
   def current_page
-    raise 'OVERRIDE IN CHILDREN'
+    raise 'define in child classes'
   end
 
   def method_missing(method, *args, &block)
-    result = if args.empty?
-               current_page.send(method)
-             else
-               current_page.send(method, *args, &block)
-             end
-    raise interface.to_s if interface.nil?
-    raise result.to_s unless defined? result # result.interface
-    begin
-      result.interface = interface
-    rescue NoMethodError
-      raise NoMethodError, "METHOD NOT FOUND: #{method}"
+    if args.empty?
+      current_page.send(method)
+    else
+      current_page.send(method, *args, &block)
     end
-    result
   end
 
   # TODO: Is this needed? I not only find the page but also make sure the
@@ -54,21 +35,18 @@ class BaseInterface
   def find_state(target_states)
     target_states.each do |state|
       next unless state.url == current_page.url
-      page = find_page(state, true)
-      return page if page.loaded?
+      page = find_page(state)
+      return page if page.loaded?(@driver)
     end
-    raise current_page.to_s if current_page.class == InternetLoggedInPage
     false
   end
 
-  def find_page(page, raise_on_fail = false)
+  def find_page(page)
     @pages.each do |p|
-      # page is a Page class
       return p if page?(page) && p.class == page
-      # or a String, possibly URL
       return p if String == page.class && page == p.url
     end
-    raise "Page \"#{page}\" not found in pages #{@pages}" if raise_on_fail
+    raise "Page \"#{page}\" not found in pages #{@pages}"
   end
 
   def wait_for_transition(target_states)
@@ -86,6 +64,7 @@ class BaseInterface
 
   def quit
     @driver.quit
-    @pages = []
+    # Maybe I'm reusing pages from @pages?
+    # @pages = []
   end
 end

data/lib/rutl/interface/chrome_interface.rb

@@ -4,10 +4,8 @@ require 'rutl/interface/base_interface'
 #
 # Small interface for Chrome browser.
 #
-# TODO: Probably the current_page() implementation should move up to base.
-#
 class ChromeInterface < BaseInterface
-  def initialize(pages:)
+  def initialize
     @logged_in = true
     options = Selenium::WebDriver::Chrome::Options.new
     options.add_argument('--ignore-certificate-errors')
@@ -25,7 +23,7 @@ class ChromeInterface < BaseInterface
 
   def current_page
     url = @driver.current_url
-    page = find_page(url, true)
+    page = find_page(url)
     raise "PAGE NOT FOUND: #{url}, PAGES: #{@pages}" unless page
     page
   end

data/lib/rutl/interface/elements/base_element.rb

@@ -2,27 +2,23 @@
 # Page elements. Base class.
 #
 class BaseElement
-  attr_accessor :interface
-  def driver
-    @interface.driver
-  end
-  attr_accessor :selectors
-  attr_accessor :destinations
-
-  def initialize(selectors = {}, destinations = [])
-    @selectors = selectors
-    @destinations = destinations
-  end
+  attr_accessor :context
 
-  def find_css(selectors)
-    result = driver.find_element(:css, selectors[:css])
-    return result unless NullDriver == result.class
-    result.destinations = @destinations
-    result.interface = @interface
-    result
+  def initialize(element_context)
+    raise element_context.to_s unless element_context.is_a? ElementContext
+    @context = element_context
+    # Not sure why, but I'm seeing Chrome fail becase the context interface
+    # passed in isn't the same as the browser's interface.
+    # This only happens with click test cases, before the click, and
+    # only if that case isn't run first.
+    # The context we're passed is also an instance from as ChromeInterface,
+    # but a different instance.
+    #
+    # Here's the kludge workaround line:
+    @context.interface = $browser.interface
   end
 
   def this_css
-    find_css(@selectors)
+    @context.find_element(:css)
   end
 end

data/lib/rutl/interface/elements/click_to_change_state_mixin.rb

@@ -6,8 +6,9 @@
 module ClickToChangeStateMixin
   def click
     this_css.click
-    interface.wait_for_transition(@destinations)
-    # TODO: Return what?
-    @destinations
+
+    # TODO: Is this part of the instance-stamping problem???
+    # returns the page it found
+    @context.interface.wait_for_transition(@context.destinations)
   end
 end

data/lib/rutl/interface/elements/element_context.rb

@@ -0,0 +1,29 @@
+#
+# The context passed around to all elements.
+# What they need to know outside of themselves to function.
+#
+class ElementContext
+  attr_accessor :destinations
+  attr_accessor :interface
+  attr_accessor :selectors
+
+  def initialize(destinations: nil, interface: nil, selectors: [])
+    unless destinations.nil? || destinations.class == Array
+      # Should check each destination to make sure it's a Page or a _____, too.
+      raise 'destination must be an Array of destinations or nil.'
+    end
+    @destinations = destinations || []
+    unless interface.nil? || interface.class.ancestors.include?(BaseInterface)
+      raise "#{interface.class}: #{interface} must be a *Interface class."
+    end
+    @interface = interface
+    @selectors = selectors
+  end
+
+  def find_element(type)
+    # @interface.driver.find_element(type, @selectors[type])
+    # Should be this, but apparently @interface.driver is being overwritten
+    # (or not written to) and it doesn't work. Using $browser does. :-(
+    $browser.interface.driver.find_element(type, @selectors[type])
+  end
+end

data/lib/rutl/interface/elements/string_reader_writer_mixin.rb

@@ -0,0 +1,66 @@
+#
+# Implement String stuff in a mixin.
+# TODO: Not finished yet. Must be able to
+#
+module StringReaderWriterMixin
+  # Override BaseElement's normal initialize method.
+  def initialize(element_context, input_value = nil)
+    raise element_context.to_s unless element_context.is_a? ElementContext
+    @context = element_context
+    set input_value unless input_value.nil?
+  end
+
+  # I could cut set() and only foo_text= if I change this.
+  # The problem I'm running into is not having the driver in
+  # base element to do this_css calls. So I have to change the way
+  # drivers are passed into everything or initially have them everywhere,
+  # which means rewriting chosen drivers or changing page load.
+  # Ick.
+  def set(string)
+    clear
+    this_css.send_keys(string)
+  end
+  alias text= set
+  alias value= set
+
+  def get
+    this_css.attribute(:value)
+  end
+  alias text get
+  alias value get
+  alias to_s get
+
+  def clear
+    this_css.clear
+    get
+  end
+
+  def eql?(other)
+    other == get
+  end
+  alias == eql?
+
+  def send_keys(string)
+    this_css.send_keys(string)
+    get
+  end
+
+  def method_missing(method, *args, &block)
+    # RuboCop complains unless I fall back to super here
+    # even though that's pretty meaningless. Oh, well, it's harmless.
+    super unless get.respond_to?(method)
+    if args.empty?
+      get.send(method)
+    else
+      get.send(method, *args, &block)
+    end
+  end
+
+  def respond_to_missing?(method, flag)
+    get.respond_to?(method, flag)
+  end
+
+  #
+  # TODO: Fall through to String methods?
+  #
+end

data/lib/rutl/interface/elements/text.rb

@@ -1,30 +1,10 @@
 require 'rutl/interface/elements/base_element'
+require 'rutl/interface/elements/string_reader_writer_mixin.rb'
 
 #
 # I'm using the text element for all text-like things. Passowrds, too.
+# TODO: Also have a reader only class with StringReaderMixin for labels?
 #
 class Text < BaseElement
-  def initialize(selectors = {}, destinations = [])
-    super
-  end
-
-  def clear
-    this_css.clear
-  end
-
-  def text
-    get
-  end
-
-  def get
-    this_css.attribute(:value)
-  end
-
-  def text=(string)
-    set(string)
-  end
-
-  def set(string)
-    this_css.send_keys(string)
-  end
+  include StringReaderWriterMixin
 end

data/lib/rutl/interface/elements.rb

@@ -2,3 +2,4 @@ require 'rutl/interface/elements/button'
 require 'rutl/interface/elements/checkbox'
 require 'rutl/interface/elements/link'
 require 'rutl/interface/elements/text'
+require 'rutl/interface/elements/element_context'

data/lib/rutl/interface/firefox_interface.rb

@@ -4,10 +4,8 @@ require 'rutl/interface/base_interface'
 #
 # Small interface for Chrome browser.
 #
-# TODO: Probably the current_page() implementation should move up to base.
-#
 class FirefoxInterface < BaseInterface
-  def initialize(pages:)
+  def initialize
     @logged_in = true
     options = Selenium::WebDriver::Firefox::Options.new
     options.add_argument('--ignore-certificate-errors')
@@ -20,7 +18,7 @@ class FirefoxInterface < BaseInterface
 
   def current_page
     url = @driver.current_url
-    page = find_page(url, true)
+    page = find_page(url)
     raise "PAGE NOT FOUND: #{url}, PAGES: #{@pages}" unless page
     page
   end

data/lib/rutl/interface/null_interface.rb

@@ -4,26 +4,28 @@ require 'rutl/interface/base_interface'
 # Interface-level code for fake browser.
 #
 class NullInterface < BaseInterface
-  @variables = []
-  attr_accessor :variables
-
-  def initialize(pages:)
-    @driver = NullDriver.new
-    @driver.interface = @interface
+  def initialize
+    context = ElementContext.new(destinations: nil,
+                                 interface: self,
+                                 selectors: [])
+    @driver = NullDriver.new(context)
     super
   end
 
-  def set_current_page(page)
-    @current_page = page
-  end
+  # The null driver needs to talk to the null interface.
+  # Other driver/interface relations are not like this.
+  attr_writer :current_page
 
   def current_page
     # Default to @pages.first if not set?
-    # A browser can alwasy check its current URL but the null driver can't.
-    @current_page || @pages.first
+    # A browser can always check its current URL but the null driver can't.
+    @current_page ||= @pages.first
   end
 
   def wait_for_transition(destinations)
-    @current_page = find_page(destinations.first)
+    # TODO: Setting @current page didn't do it beacause that set
+    # context.interface.current_page and we wanted this in the browser.
+    @current_page = destinations.first.new(self)
+    $browser.current_page = @current_page
   end
 end

data/lib/rutl/utilities.rb

@@ -34,7 +34,8 @@ module Utilities
 
   def page?(checkme)
     checkme.ancestors.include?(BasePage)
-  rescue # BUGBUG: Didn't have time to find all the things to rescue yet.
+  rescue NoMethodError
+    # This isn't a even a class. It's no page!
     false
   end
 

data/lib/rutl/version.rb

@@ -1,3 +1,3 @@
 module RUTL
-  VERSION = '0.1.3'.freeze
+  VERSION = '0.1.4'.freeze
 end

data/rutl.gemspec

@@ -30,14 +30,14 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', '~> 1.15'
-  spec.add_development_dependency 'coveralls'
-  spec.add_development_dependency 'drewcoo-cops'
-  spec.add_development_dependency 'gem-release'
+  spec.add_development_dependency 'coveralls', '~> 0.8'
+  spec.add_development_dependency 'drewcoo-cops', '~> 0.1'
+  spec.add_development_dependency 'gem-release', '~> 1.0'
   spec.add_development_dependency 'rake', '~> 12.3'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec_junit_formatter', '~> 0.3'
   spec.add_development_dependency 'rubocop', '~> 0.55'
-  spec.add_development_dependency 'rubocop-rspec'
+  spec.add_development_dependency 'rubocop-rspec', '~> 1.25'
   spec.add_development_dependency 'selenium-webdriver', '~> 3.12'
   spec.add_development_dependency 'webdrivers', '~> 3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rutl
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Drew Cooper
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-05-27 00:00:00.000000000 Z
+date: 2018-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,44 +28,44 @@ dependencies:
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: drewcoo-cops
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.1'
 - !ruby/object:Gem::Dependency
   name: gem-release
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -126,16 +126,16 @@ dependencies:
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.25'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.25'
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
@@ -197,7 +197,9 @@ files:
 - lib/rutl/interface/elements/button.rb
 - lib/rutl/interface/elements/checkbox.rb
 - lib/rutl/interface/elements/click_to_change_state_mixin.rb
+- lib/rutl/interface/elements/element_context.rb
 - lib/rutl/interface/elements/link.rb
+- lib/rutl/interface/elements/string_reader_writer_mixin.rb
 - lib/rutl/interface/elements/text.rb
 - lib/rutl/interface/firefox_interface.rb
 - lib/rutl/interface/null_interface.rb