rutl 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1c070581c3f9fc5a824bcf84d2ca93bfefdb4d1f156886ac89e6e327998d5e8d
-  data.tar.gz: 480622bf3855549371b0fb1ad5d0dc40dddbe5b0bc4a51697ea2b0dea4684ac8
+  metadata.gz: 91f41b74e68fe36acb46dd525f7f375f18d3939d5a7fc15c1972ff443af6125e
+  data.tar.gz: 1a2d184998b8f3f18532ece3f353059cbd616e8f7a419c4331c8dfc10fc40d59
 SHA512:
-  metadata.gz: 6082a406b279d01c73083a3719fe30debc6a45ddfafef13a41241db8e5965eeb4a92e62117acb38b71fc7d7c3b4089d4bf36fe8d42278ab9593dfa39c4d9e90e
-  data.tar.gz: 463eeec53303226112254a190c856a426200d82a03168a287de6f2543a8bf4b8c4dfd49cb703d28b3e228d902646e10ee516db66b4662f7c38bfb925cd91f50f
+  metadata.gz: 4a91637e9662ede93d7991261f44dde9299d0b04482ab25ce8d952fc2f16e4df210452c120642f816a373f4c565287ee16aa57033d0d3c609b23a07f5a9cd17f
+  data.tar.gz: 93a535c70dbd92121f461bbcea341c3dea2c9d23ac33ae6f5bdcd2658efe1dacf3feb048012412577d6a5726ecf5ca3ce535b76524a48789f92dffebcdf6e8ac

data/.circleci/config.yml

@@ -36,7 +36,22 @@ jobs:
             - ./vendor/bundle
           key: v1-dependencies-{{ checksum "Gemfile.lock" }}
 
-      # run tests!
+      - run:
+          name:  Install the latest firefox
+          command: |
+            sudo apt-get remove firefox-mozilla-build &&
+            sudo sh -c "echo 'deb http://ftp.hr.debian.org/debian sid main' >> /etc/apt/sources.list" &&
+            sudo apt-get update &&
+            sudo apt-get remove binutils
+            sudo apt-get install -t sid firefox &&
+            firefox --version
+
+      - run:
+          name: Install geckodriver
+          command: |
+            sudo wget https://github.com/mozilla/geckodriver/releases/download/v0.20.1/geckodriver-v0.20.1-linux64.tar.gz
+            sudo tar xf geckodriver-v0.20.1-linux64.tar.gz -C /usr/local/bin
+
       - run:
           name: run tests
           command: |

data/.rubocop.yml

@@ -1,14 +1,16 @@
+inherit_from: .rubocop_todo.yml
+
+require: rubocop-rspec
+# drewcoo-cops has to go after rubocop-rspec because otherwise it diables
+# drewcoo-cops.
+# There are also a bunch of warnigs spewed about the RSpec cops listed
+# in the todo file so it looks like we're not playing well with rubocop-rspec
+# either.
+# Check this in for now and TODO: figure this out tomorrow.
+require: drewcoo-cops
+
 AllCops:
   DefaultFormatter: progress
   DisplayCopNames: true
   DisplayStyleGuide: true
   ExtraDetails: true
-
-Metrics/BlockLength:
-  Enabled: false
-
-Metrics/MethodLength:
-  Enabled: false
-
-Style/BracesAroundHashParameters:
-  Enabled: false

data/.rubocop_todo.yml

@@ -0,0 +1,93 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-05-26 12:34:26 -0700 using RuboCop version 0.56.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Metrics/AbcSize:
+  Max: 16
+
+# Offense count: 3
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 48
+
+# Offense count: 4
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 19
+
+# Offense count: 1
+Naming/AccessorMethodName:
+  Exclude:
+    - 'lib/rutl/interface/null_interface.rb'
+
+# Offense count: 1
+RSpec/ExampleLength:
+  Exclude:
+    - 'spec/chrome_interface_spec.rb'
+
+# Offense count: 2
+RSpec/ExpectActual:
+  Exclude:
+    - 'spec/null_interface_spec.rb'
+    - 'spec/rutl_spec.rb'
+
+# Offense count: 1
+RSpec/MultipleExpectations:
+  Exclude:
+    - 'spec/chrome_interface_spec.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: braces, no_braces, context_dependent
+Style/BracesAroundHashParameters:
+  Exclude:
+    - 'spec/pages/internet_login_page.rb'
+    - 'spec/pages/page1.rb'
+
+# Offense count: 1
+Style/ClassVars:
+  Exclude:
+    - 'lib/rutl/base_page.rb'
+
+# Offense count: 4
+Style/MethodMissingSuper:
+  Exclude:
+    - 'lib/rutl/base_page.rb'
+    - 'lib/rutl/browser.rb'
+    - 'lib/rutl/interface/base_interface.rb'
+    - 'spec/spec_helper.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/PerlBackrefs:
+  Exclude:
+    - 'lib/rutl/browser.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: implicit, explicit
+Style/RescueStandardError:
+  Exclude:
+    - 'lib/rutl/utilities.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: AllowIfMethodIsEmpty.
+Style/SingleLineMethods:
+  Exclude:
+    - 'lib/rutl/base_page.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
+# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
+Style/TrivialAccessors:
+  Exclude:
+    - 'lib/rutl/base_page.rb'

data/README.md

@@ -5,8 +5,7 @@
 [![Coverage Status](https://coveralls.io/repos/github/drewcoo/rutl/badge.svg?branch=master)](https://coveralls.io/github/drewcoo/rutl?branch=master)
 [![Gem Version](https://badge.fury.io/rb/rutl.svg)](https://badge.fury.io/rb/rutl)
 
-This is the Ruby Ui Test Library, or RUTL. Not to be confused with the Rutles.
-https://www.rutles.org/
+This is the Ruby Ui Test Library, or RUTL. Not to be confused with [The Rutles](https://www.rutles.org/).
 
 Framework goals:
 * Define what's on a page in an easy, flexible way. Easy page objects!
@@ -39,22 +38,22 @@ TODO: Write usage instructions here
 
 ## Roadmap
 Coming up soon in almost no order:
-* Make browser tests work on TravisCI.
 * A test framework should have better tests. Goes with next bullet.
 * Flesh out null interface/driver. Make them do what a real browser does.
-* Make geckodriver work. Geckodriver-helper is failing me.
 * Restructure tests to handle fake browsers and real browsers. Same structure?
-* Make this work with pages in some other location so we can use it as a gem.
-* Make work with TravisCI.
+* Make this work with pages files in some other location so we can use it as a gem.
 * Put more info in this readme.
 * Take screenshots.
 * Diff screenshots. Make this smart so we don't have to be experts.
-* InternetExplorerDriver
+* The webdriver gem should already include InternetExplorerDriver. Maybe run tests on AppVeyor.
 * Other browser drivers? Look at https://github.com/fnando/browser
 * Get this working with Appium:
   * Make TK app to test on desktops and test it.
+    * Can Ruby TK create accesible apps?
   * Make Android example app and get this to work.
+    * Corboba?
   * Same with iPhone.
+    * Same Cordoba test app?
 * Others?
 * Spidering page object maker.
 * Possibly pair the null browser with auto-generated pages for ______?
@@ -66,10 +65,12 @@ Coming up soon in almost no order:
 ## Development
 
 Set everything up:
+
     1. Check out the repo.
     2. `cd` to the repo.
     3. `bundle install`
     4. `bundle exec rake`
+
 Great! You've checked out the code, installed everything and run the tests.
 
 Rubocop. I still have to tweak what I want it to complain about.

data/lib/rutl/interface/base_interface.rb

@@ -12,11 +12,7 @@ class BaseInterface
   end
 
   attr_reader :pages
-
-  # Child classes must implement current_page
-
   attr_accessor :driver
-
   attr_accessor :interface
 
   def initialize(pages:)
@@ -27,7 +23,7 @@ class BaseInterface
 
   def goto(input)
     # TODO: KLUDGY. Fix. Modifier if usage bombs here. *shrug*
-    @driver.interface = @interface if 'NullInterface' == @interface.class.to_s
+    @driver.interface = @interface if @interface.class.to_s == 'NullInterface'
     input = find_page(input) unless input.methods.include?(:url)
 
     @driver.navigate.to input.url
@@ -59,7 +55,7 @@ class BaseInterface
     target_states.each do |state|
       next unless state.url == current_page.url
       page = find_page(state, true)
-      return current_page = page if page.loaded?
+      return page if page.loaded?
     end
     raise current_page.to_s if current_page.class == InternetLoggedInPage
     false

data/lib/rutl/interface/chrome_interface.rb

@@ -14,7 +14,7 @@ class ChromeInterface < BaseInterface
     options.add_argument('--disable-popup-blocking')
     options.add_argument('--disable-translate')
     # Run headless on TravisCI
-    if 'true' == ENV['TRAVIS']
+    if ENV['TRAVIS'] == 'true'
       options.add_argument('--disable-gpu')
       options.add_argument('--headless ')
       options.add_argument('--no-sandbox')

data/lib/rutl/interface/firefox_interface.rb

@@ -13,6 +13,7 @@ class FirefoxInterface < BaseInterface
     options.add_argument('--ignore-certificate-errors')
     options.add_argument('--disable-popup-blocking')
     options.add_argument('--disable-translate')
+    options.add_argument('--headless') if ENV['TRAVIS'] == 'true'
     @driver = Selenium::WebDriver.for :firefox, options: options
     super
   end

data/lib/rutl/interface/null_interface.rb

@@ -4,9 +4,6 @@ require 'rutl/interface/base_interface'
 # Interface-level code for fake browser.
 #
 class NullInterface < BaseInterface
-  # Only the null interface>>
-  attr_reader :current_page
-
   @variables = []
   attr_accessor :variables
 

data/lib/rutl/utilities.rb

@@ -14,7 +14,9 @@ module Utilities
       loop do
         result = lamb.call
         return result if result
+        # rubocop:disable Style/SleepCop
         sleep poll_sleep_time
+        # rubocop:enable Style/SleepCop
       end
     end
   end

data/lib/rutl/version.rb

@@ -1,3 +1,3 @@
 module RUTL
-  VERSION = '0.1.2'.freeze
+  VERSION = '0.1.3'.freeze
 end

data/rutl.gemspec

@@ -15,8 +15,6 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/drewcoo/rutl'
   spec.license       = 'MIT'
 
-  # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
-  # to allow pushing to a single host or delete this section to allow pushing to any host.
   if spec.respond_to?(:metadata)
     spec.metadata['allowed_push_host'] = 'https://rubygems.org/gems/rutl'
   else
@@ -24,23 +22,22 @@ Gem::Specification.new do |spec|
       'public gem pushes.'
   end
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.bindir = 'exe'
+  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', '~> 1.15'
-  if ENV['CIRCLECI'].nil?
-    spec.add_development_dependency 'chromedriver-helper', '~> 1.2'
-  end
-  spec.add_development_dependency 'coveralls' #@, require: false
-  #spec.add_development_dependency 'geckodriver-helper', '~>  0.20'
+  spec.add_development_dependency 'coveralls'
+  spec.add_development_dependency 'drewcoo-cops'
   spec.add_development_dependency 'gem-release'
   spec.add_development_dependency 'rake', '~> 12.3'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec_junit_formatter', '~> 0.3'
   spec.add_development_dependency 'rubocop', '~> 0.55'
+  spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency 'selenium-webdriver', '~> 3.12'
+  spec.add_development_dependency 'webdrivers', '~> 3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rutl
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Drew Cooper
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-05-23 00:00:00.000000000 Z
+date: 2018-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -25,21 +25,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.15'
 - !ruby/object:Gem::Dependency
-  name: chromedriver-helper
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: drewcoo-cops
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -122,6 +122,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.55'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
@@ -136,6 +150,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.12'
+- !ruby/object:Gem::Dependency
+  name: webdrivers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 description: DANGER!!! DO NOT USE YET!!! This is a UI library under construction and
   only name-squatting for the moment.
 email:
@@ -149,6 +177,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt