russian-reversal 1.0.4 → 1.0.5

data/lib/russian-reversal.rb

@@ -5,8 +5,9 @@ require 'open-uri'
 require 'nokogiri'
 
 module RussianReversal
-  REGEXP_NONWORD = /[^a-zA-Z-]/
-  VERBS_IGNORED = [ 'be', 'have', ]
+  REGEXP_NONWORD = /[^a-zA-Z -]/
+  VERBS_IGNORED = [ 'be', 'have', 'can', ]
+  NOUNS_IGNORED = [ 'it', 'him', 'her', 'them', 'me', 'you', 'us', 'this', 'that', 'these', 'those', ]
 
   def self.strip( s )
     s.gsub( /\..*$/, '' )
@@ -15,19 +16,25 @@ module RussianReversal
   def self.infinitive_of( verb )
     doc = Nokogiri::HTML( open( "http://www.oxfordadvancedlearnersdictionary.com/dictionary/#{verb}" ) )
     doc.search('div#relatedentries > ul > li').each do |e|
-      pos = e.at('span.pos')
-      if pos && pos.text.gsub( REGEXP_NONWORD, '' ) == 'verb'
-        v = e.at('span').children.first.text.strip
-        if VERBS_IGNORED.include?( v )
-          return nil
-        else
-          return v
+      pos_element = e.at('span.pos')
+      if pos_element
+        pos = pos_element.text.gsub( REGEXP_NONWORD, '' )
+        return  if pos == 'modal verb' || pos == 'auxiliary verb'
+        if pos == 'verb'
+          v = e.at('span').children.first.text.strip
+          if VERBS_IGNORED.include?( v )
+            return
+          else
+            return v
+          end
         end
       end
     end
   end
 
   def self.plural_of( noun )
+    return nil  if NOUNS_IGNORED.include?( noun.downcase )
+
     doc = Nokogiri::HTML( open( "http://www.oxfordadvancedlearnersdictionary.com/dictionary/#{noun}" ) )
 
     plural_marker = doc.at('span.z_il')

data/spec/reverse.rb

@@ -17,9 +17,25 @@ describe 'RussianReversal' do
     RussianReversal.reverse( 'He needs a NotARealEnglishWord' ).should.be.nil
   end
 
-  it "doesn't activate on basic and auxiliary verbs" do
+  it "doesn't activate on basic, auxiliary or modal verbs" do
     RussianReversal.reverse( "There won't be a video." ).should.be.nil
     RussianReversal.reverse( "He has an object." ).should.be.nil
     RussianReversal.reverse( "He was a criminal." ).should.be.nil
+    RussianReversal.reverse( "He might be a criminal." ).should.be.nil
+    RussianReversal.reverse( "He ought to be good." ).should.be.nil
   end
-end
+
+  it "doesn't activate on pronouns or demonstratives" do
+    RussianReversal.reverse( 'They shot him' ).should.be.nil
+    RussianReversal.reverse( 'They shot her' ).should.be.nil
+    RussianReversal.reverse( 'They shot me' ).should.be.nil
+    RussianReversal.reverse( 'They shot you' ).should.be.nil
+    RussianReversal.reverse( 'They shot them' ).should.be.nil
+    RussianReversal.reverse( 'They shot us' ).should.be.nil
+    RussianReversal.reverse( 'They shot it' ).should.be.nil
+    RussianReversal.reverse( 'They shot this' ).should.be.nil
+    RussianReversal.reverse( 'They shot that' ).should.be.nil
+    RussianReversal.reverse( 'They shot these' ).should.be.nil
+    RussianReversal.reverse( 'They shot those' ).should.be.nil
+  end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: russian-reversal
 version: !ruby/object:Gem::Version 
-  hash: 31
+  hash: 29
   prerelease: false
   segments: 
   - 1
   - 0
-  - 4
-  version: 1.0.4
+  - 5
+  version: 1.0.5
 platform: ruby
 authors: 
 - Pistos