russian-reversal 1.0.3 → 1.0.4

data/lib/russian-reversal.rb

@@ -6,6 +6,7 @@ require 'nokogiri'
 
 module RussianReversal
   REGEXP_NONWORD = /[^a-zA-Z-]/
+  VERBS_IGNORED = [ 'be', 'have', ]
 
   def self.strip( s )
     s.gsub( /\..*$/, '' )
@@ -14,8 +15,14 @@ module RussianReversal
   def self.infinitive_of( verb )
     doc = Nokogiri::HTML( open( "http://www.oxfordadvancedlearnersdictionary.com/dictionary/#{verb}" ) )
     doc.search('div#relatedentries > ul > li').each do |e|
-      if e.at('span.pos').text.gsub( REGEXP_NONWORD, '' ) == 'verb'
-        return e.at('span').children.first.text.strip
+      pos = e.at('span.pos')
+      if pos && pos.text.gsub( REGEXP_NONWORD, '' ) == 'verb'
+        v = e.at('span').children.first.text.strip
+        if VERBS_IGNORED.include?( v )
+          return nil
+        else
+          return v
+        end
       end
     end
   end

data/spec/reverse.rb

@@ -11,6 +11,15 @@ describe 'RussianReversal' do
     RussianReversal.reverse( 'The tanks decimated the platoon.' ).should.equal 'platoons decimate'
     RussianReversal.reverse( 'The chef prepared a delicious meal.' ).should.equal 'meals prepare'
     RussianReversal.reverse( 'The hungry lions were devouring a sheep.' ).should.equal 'sheep devour'
-    RussianReversal.reverse( 'he needs a NotARealEnglishWord' ).should.be.nil
+  end
+
+  it 'remains silent on parse failures' do
+    RussianReversal.reverse( 'He needs a NotARealEnglishWord' ).should.be.nil
+  end
+
+  it "doesn't activate on basic and auxiliary verbs" do
+    RussianReversal.reverse( "There won't be a video." ).should.be.nil
+    RussianReversal.reverse( "He has an object." ).should.be.nil
+    RussianReversal.reverse( "He was a criminal." ).should.be.nil
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: russian-reversal
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 31
   prerelease: false
   segments: 
   - 1
   - 0
-  - 3
-  version: 1.0.3
+  - 4
+  version: 1.0.4
 platform: ruby
 authors: 
 - Pistos