ruptr 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2bb54a65cd25733932795a5d3e7b3f414f74c1601bd4dbbb24bf3d39543112ec
-  data.tar.gz: 81459ecd24738d49985cd8557893ef01760483bf5f0a626932e0e5cc1dcaaa99
+  metadata.gz: c1c620a24a46591c8ac0c6f1cd9cd8d8ebb0edc5e3e00a7c6df78c76a5e0d4f0
+  data.tar.gz: ec3a479909a07b44a483143cc603ec83c792a23f4208f051a6849b0f40a9ebf8
 SHA512:
-  metadata.gz: d15c2d9e871e62c547def98b0f7adcccd56f53159523f438b2b2e07f7de7e515364e5954845ed50fd6fb2edc1724d74e5a2360e4c47b8634f3037e466b258593
-  data.tar.gz: db349382ea275b3c2793dc1630dced2bf56f05abc5a467e110c66bbe10cb6b9ea72f4bb9812580079306da3a9527273a5faf054d54b5424e8b273e430a8cf468
+  metadata.gz: 7f5c28f76a6f964d8284a86995f1a855329110ae1adb6569ef09c580eb300ffb98d2fc8f7aa7e4de89f9bbdfdc745c08fdba92a32ffb8b2d80ed866b26fca651
+  data.tar.gz: 1028321f3377a7d8744377a3aa612a9d85ab58af2a5f237bdbb0c9acf36ee0692fff09d7d077da611dd9cea5b126468dde619e82f0812a9f119375056c71fb01

data/lib/ruptr/adapters/assertions.rb

@@ -32,8 +32,8 @@ module Ruptr
       assertions_golden_store.set_trial(assertion_golden_key(k), v)
     end
 
-    def assertion_golden_value_missing(k)
-      warn "golden value missing for key #{k.inspect}"
+    def assertion_golden_value_missing(_k)
+      self.ruptr_ineffective_assertions_count += 1
     end
 
     def assertion_yield_golden_value(k)

data/lib/ruptr/instance.rb

@@ -12,7 +12,7 @@ module Ruptr
 
     # Common methods to let multiple assertions/expectations libraries use a shared assertions
     # counter.  The @_assertions instance variable name was chosen to be compatible with
-    # Test::Unit::Assertions::CoreAssertions which accesses it directly.
+    # Test::Unit::CoreAssertions (gem test-unit-ruby-core) which accesses it directly.
 
     def ruptr_assertions_count
       @_assertions || 0
@@ -22,14 +22,27 @@ module Ruptr
       @_assertions = n
     end
 
+    def ruptr_ineffective_assertions_count
+      @ruptr_ineffective_assertions_count || 0
+    end
+
+    def ruptr_ineffective_assertions_count=(n)
+      @ruptr_ineffective_assertions_count = n
+    end
+
     def ruptr_internal_variable?(name)
-      name == :@_assertions || name == :@ruptr_context
+      name == :@_assertions || name == :@ruptr_ineffective_assertions_count || name == :@ruptr_context
+    end
+
+    private def ruptr_update_context
+      ruptr_context.assertions_count += ruptr_assertions_count
+      ruptr_context.ineffective_assertions_count += ruptr_ineffective_assertions_count
     end
 
     def ruptr_wrap_test_instance
       yield
     ensure
-      ruptr_context.assertions_count += ruptr_assertions_count
+      ruptr_update_context
     end
 
     def inspect = "#<#{self.class}: #{ruptr_context.test_element}>"

data/lib/ruptr/main.rb

@@ -209,10 +209,12 @@ module Ruptr
       @pager_mode && !@output_path && $stdout.tty?
     end
 
+    private def default_pager_cmd = 'LESS=-R less'
+
     private def open_output
       fail if @output_file
       if pager_mode? && (!@pager_only_on_problem || test_suite_problem?)
-        @output_file = IO.popen(ENV['PAGER'] || 'more', 'w',
+        @output_file = IO.popen(ENV['PAGER'] || default_pager_cmd, 'w',
                                 external_encoding: $stdout.external_encoding)
         @output_file_close = true
       else

data/lib/ruptr/plain.rb

@@ -207,7 +207,11 @@ module Ruptr
         a << "#{'%0.6f' % tr.user_time} user" if tr.user_time
         a << "#{'%0.6f' % tr.system_time} system" if tr.system_time
         line("Processor time:  #{a.join(', ')}") unless a.empty?
-        line("Assertion count: #{tr.assertions}") if tr.assertions && !tr.assertions.zero?
+        a = []
+        a << "#{tr.assertions}" unless tr.assertions.zero?
+        a << colorize("#{tr.ineffective_assertions} ineffective", color: :yellow) \
+          unless tr.ineffective_assertions.zero?
+        line("Assertion count: #{a.join(', ')}") unless a.empty?
         newline
       end
 
@@ -276,8 +280,15 @@ module Ruptr
           title = "WARNING ##{@warned_index}"
           @warned_index += 1
           color = :yellow
+        elsif !tr.ineffective_assertions.zero?
+          @total_passed_ineffective_cases += 1 if te.test_case?
+          @total_passed_ineffective_groups += 1 if te.test_group?
+          return unless verbose?(2)
+          title = "INEFFECTIVE ##{@ineffective_index}"
+          @ineffective_index += 1
+          color = :yellow
         else
-          return unless verbose?(3)
+          return unless verbose?(4)
           title = "PASSED ##{@passed_index}"
           @passed_index += 1
           color = :green
@@ -346,7 +357,11 @@ module Ruptr
 
       s = +''
       s << "Ran #{@total_test_cases} test cases"
-      s << " with #{@total_assertions} assertions" unless @total_assertions.zero?
+      a = []
+      a << "#{@total_assertions} assertions" unless @total_assertions.zero?
+      a << colorize("#{@total_ineffective_assertions} ineffective assertions", color: :yellow) \
+        unless @total_ineffective_assertions.zero?
+      s << " with #{a.join(' and ')}" unless a.empty?
       s << ": "
 
       s << colorize("#{@total_passed_cases} passed",
@@ -394,15 +409,18 @@ module Ruptr
       @heading_count = 0
       @unknown_index = @failed_index = @blocked_index =
                          @skipped_index = @pending_index =
-                           @passed_index = @warned_index = 1
+                           @passed_index = @warned_index =
+                             @ineffective_index = 1
       @total_test_cases = @total_test_groups = 0
       @total_failed_cases = @total_blocked_cases =
         @total_skipped_cases = @total_skipped_pending_cases =
-          @total_passed_cases = @total_passed_warned_cases = 0
+          @total_passed_cases = @total_passed_warned_cases =
+            @total_passed_ineffective_cases = 0
       @total_failed_groups = @total_blocked_groups =
         @total_skipped_groups = @total_skipped_pending_groups =
-          @total_passed_groups = @total_passed_warned_groups = 0
-      @total_assertions = 0
+          @total_passed_groups = @total_passed_warned_groups =
+            @total_passed_ineffective_groups = 0
+      @total_assertions = @total_ineffective_assertions = 0
     end
 
     def finish_plan(fields)
@@ -419,6 +437,7 @@ module Ruptr
       @total_test_cases += 1 if te.test_case?
       @total_test_groups += 1 if te.test_group?
       @total_assertions += tr.assertions
+      @total_ineffective_assertions += tr.ineffective_assertions
       render_element(te, tr)
     end
   end

data/lib/ruptr/report.rb

@@ -9,23 +9,26 @@ module Ruptr
     def initialize
       @results = {}
       @failed = false
-      @total_assertions = 0
+      @total_assertions = @total_ineffective_assertions = 0
       @total_test_cases = 0
       @total_test_cases_by_status = Hash.new(0)
       @total_test_groups = 0
       @total_test_groups_by_status = Hash.new(0)
     end
 
-    attr_reader :total_assertions,
+    attr_reader :total_assertions, :total_ineffective_assertions,
                 :total_test_cases,
                 :total_test_groups
 
     def failed? = @failed
     def passed? = !failed?
 
+    def total_test_cases_by_status(status) = @total_test_cases_by_status[status]
+    def total_test_groups_by_status(status) = @total_test_groups_by_status[status]
+
     TestResult::VALID_STATUSES.each do |status|
-      define_method(:"total_#{status}_test_cases") { @total_test_cases_by_status[status] }
-      define_method(:"total_#{status}_test_groups") { @total_test_groups_by_status[status] }
+      define_method(:"total_#{status}_test_cases") { total_test_cases_by_status(status) }
+      define_method(:"total_#{status}_test_groups") { total_test_groups_by_status(status) }
     end
 
     def each_test_element_result(klass = TestElement, &)
@@ -60,7 +63,8 @@ module Ruptr
       else
         raise ArgumentError
       end
-      @total_assertions += tr.assertions || 0
+      @total_assertions += tr.assertions
+      @total_ineffective_assertions += tr.ineffective_assertions
       @failed ||= tr.failed?
       @results[te] = tr
     end

data/lib/ruptr/result.rb

@@ -10,20 +10,27 @@ module Ruptr
     VALID_STATUSES = %i[passed skipped failed blocked].freeze
 
     def initialize(status,
-                   assertions: 0, user_time: nil, system_time: nil, exception: nil,
+                   exception: nil,
+                   assertions: 0, ineffective_assertions: 0,
+                   user_time: nil, system_time: nil,
                    captured_stdout: nil, captured_stderr: nil)
       raise ArgumentError unless VALID_STATUSES.include?(status)
       raise ArgumentError if exception && status == :passed
       @status = status
+      @exception = exception
       @assertions = assertions
-      @captured_stdout = captured_stdout
-      @captured_stderr = captured_stderr
+      @ineffective_assertions = ineffective_assertions
       @user_time = user_time
       @system_time = system_time
-      @exception = exception
+      @captured_stdout = captured_stdout
+      @captured_stderr = captured_stderr
     end
 
-    attr_reader :status, :assertions, :user_time, :system_time, :exception, :captured_stdout, :captured_stderr
+    attr_reader :status,
+                :exception,
+                :assertions, :ineffective_assertions,
+                :user_time, :system_time,
+                :captured_stdout, :captured_stderr
 
     def passed? = @status == :passed
     def skipped? = @status == :skipped

data/lib/ruptr/runner.rb

@@ -14,11 +14,11 @@ module Ruptr
       @runner = runner
       @test_element = test_element
       @parent = parent
-      @assertions_count = 0
+      @assertions_count = @ineffective_assertions_count = 0
     end
 
     attr_reader :runner, :test_element, :parent
-    attr_accessor :assertions_count
+    attr_accessor :assertions_count, :ineffective_assertions_count
   end
 
   class TestElement
@@ -47,26 +47,28 @@ module Ruptr
         end
       end
       assertions = context.assertions_count
+      ineffective_assertions = context.ineffective_assertions_count
       TestResult.new(status,
-                     user_time:, system_time:, assertions:, exception:,
+                     exception:,
+                     assertions:, ineffective_assertions:,
+                     user_time:, system_time:,
                      captured_stdout:, captured_stderr:)
     end
   end
 
   class TestCase
     def run_result(runner, group_context)
+      return TestResult.new(:skipped) unless runnable?
       context = Context.new(runner, self, group_context)
       make_result(context) { run_context(context) }
     end
   end
 
   class TestGroup
-    def must_wrap? = block?
-
     def wrap_result(runner, parent_context)
       context = Context.new(runner, self, parent_context)
       make_result(context) do
-        if must_wrap?
+        if wrappable?
           wrap_context(context) { yield context }
         else
           yield context
@@ -187,7 +189,7 @@ module Ruptr
             batched_cases << tc
           end
           tg.each_test_subgroup do |tg|
-            if tg.must_wrap?
+            if tg.wrappable?
               pending_groups << tg
             else
               @sink.submit_group(tg) do

data/lib/ruptr/suite.rb

@@ -62,6 +62,8 @@ module Ruptr
   class TestCase < TestElement
     def test_case? = true
 
+    def runnable? = block?
+
     def run_context(context) = @block.call(context)
   end
 
@@ -74,6 +76,8 @@ module Ruptr
 
     def test_group? = true
 
+    def wrappable? = block?
+
     def wrap_context(context, &) = @block.call(context, &)
 
     def each_test_case(&) = @test_cases.each(&)

data/lib/ruptr/testunit.rb

@@ -67,6 +67,8 @@ module Ruptr
 
           assertions_module = def_module(:Assertions) do
             include(Adapters::RuptrAssertions)
+            # NOTE: Gem test-unit-ruby-core's "core_assertions" library will define some methods
+            # directly in Test::Unit::Assertions.
           end
 
           def_class(:TestCase) do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ruptr
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Mathieu
 bindir: bin
 cert_chain: []
-date: 2025-02-22 00:00:00.000000000 Z
+date: 2025-02-25 00:00:00.000000000 Z
 dependencies: []
 email: sigsys@gmail.com
 executables:
@@ -53,6 +53,7 @@ files:
 - lib/ruptr/timing_cache.rb
 - lib/ruptr/tty_colors.rb
 - lib/ruptr/utils.rb
+homepage: https://github.com/Math2/ruptr
 licenses:
 - MIT
 metadata: {}