runger_style 5.17.0 → 5.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb6defe797f70ab9b1335060521e1f49e4cf509c30ac7bf3139e04a0a3e8cae5
-  data.tar.gz: 95c757a383b153f087aaff78b4514043a9029b491e2fec26942991fb318d8331
+  metadata.gz: d8102a9e67c0aacf7a402f6a985b0994bade06372295bb168600812755503156
+  data.tar.gz: 68ae43f161e34dfdccc6bce2b35d151782088911b3aa7494e4e467d0c8396de4
 SHA512:
-  metadata.gz: 04c29fd64211c7dca6756bfe470a6ce0b0fd5d3f584f0ed437d3410771cd16e1f5f8bf25804d9c1483af833065e2290ff04d185071832be10c0efaf174dad972
-  data.tar.gz: cc4ed34f1d5a1366305c9e3b8018dd109e3f80d556980db9c10721fbea985e47d5b47ebb2d1576b53d2c113089a579ab58b95f219f9dc151d43ece979986886d
+  metadata.gz: f46b144fba27601f8cefc14c210534ca8df8c8da8530e2da753d6ee948369558311f6d8de39a72e2d4f0ef995ad458f5fb2f028f9b1db4954444514c9abce6b1
+  data.tar.gz: 48c8b7c8e7831fa2932511c0a83b6015f44374afb8cea158594c276c5470e65e97e10a3ac002ed16f90229333990f5f87bf5fe20891778feadad415a6c29eb55

data/CHANGELOG.md

@@ -1,6 +1,9 @@
 ## Unreleased
 [no unreleased changes yet]
 
+## v5.18.0 (2026-08-22)
+- [default] Add `RungerStyle/ParenthesesAroundMultilineCondition` to require parentheses around multiline `if`, `unless`, and `elsif` conditions, except for multiline block conditions and parenthesized receivers.
+
 ## v5.17.0 (2026-08-21)
 - [default] Add report-only `RungerStyle/NoReturn` to forbid explicit `return` statements.
 

data/Gemfile.lock

@@ -10,7 +10,7 @@ GIT
 PATH
   remote: .
   specs:
-    runger_style (5.17.0)
+    runger_style (5.18.0)
       prism (>= 0.24.0)
       rubocop (>= 1.72.0)
 
@@ -235,7 +235,7 @@ CHECKSUMS
   ruby-progressbar (1.13.0) sha256=80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33
   runger_byebug (11.4.0) sha256=569e22ba2215f57e7f69e145fcb63be401e29fcd312f7936d813e12d0c7bbee6
   runger_release_assistant (4.3.1) sha256=3246c925240739eb12b9e6b9526a77ea00fcf0a0941441ff5ffacefb7e3e4d83
-  runger_style (5.17.0)
+  runger_style (5.18.0)
   securerandom (0.4.1) sha256=cc5193d414a4341b6e225f0cb4446aceca8e50d5e1888743fac16987638ea0b1
   slop (4.10.1) sha256=844322b5ffcf17ed4815fdb173b04a20dd82b4fd93e3744c88c8fafea696d9c7
   tsort (0.2.0) sha256=9650a793f6859a43b6641671278f79cfead60ac714148aabe4e3f0060480089f

data/lib/runger_style/cops/default/multiline_method_arguments_line_breaks.rb

@@ -12,9 +12,11 @@ module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
         # When a method call uses keyword arguments without braces,
         # the parser produces a single hash node. In that case, inspect its pairs.
         arguments =
-          if node.arguments.one? &&
+          if (
+            node.arguments.one? &&
               node.arguments.first.hash_type? &&
               !node.arguments.first.braces?
+          )
             node.arguments.first.pairs
           else
             node.arguments

data/lib/runger_style/cops/default/parentheses_around_multiline_condition.rb

@@ -0,0 +1,134 @@
+# frozen_string_literal: true
+
+module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
+  class ParenthesesAroundMultilineCondition < ::RuboCop::Cop::Base
+    extend ::RuboCop::Cop::AutoCorrector
+    include ::RuboCop::Cop::RangeHelp
+
+    MSG = 'Wrap multiline `%<keyword>s` conditions in parentheses.'
+
+    def on_if(node)
+      if offense?(node)
+        add_offense(node.loc.keyword, message: format(MSG, keyword: node.keyword)) do |corrector|
+          autocorrect(corrector, node)
+        end
+      end
+    end
+
+    private
+
+    def offense?(node)
+      multiline_conditional?(node) &&
+        !permitted_multiline_condition?(node) &&
+        !correctly_parenthesized?(node)
+    end
+
+    def correctly_parenthesized?(node)
+      inner_condition = parenthesized_condition(node.condition)
+
+      if inner_condition
+        condition_starts_on_next_line?(node, inner_condition) &&
+          closing_parenthesis_on_own_line?(node.condition, inner_condition)
+      end
+    end
+
+    def multiline_conditional?(node)
+      !node.modifier_form? && !node.ternary? && node.condition.multiline?
+    end
+
+    def permitted_multiline_condition?(node)
+      condition = node.condition
+
+      condition.any_block_type? || multiline_parenthesized_receiver?(condition)
+    end
+
+    def multiline_parenthesized_receiver?(condition)
+      if condition.send_type? || condition.csend_type?
+        receiver = condition.receiver
+        receiver&.begin_type? && receiver.multiline?
+      end
+    end
+
+    def autocorrect(corrector, node)
+      condition = node.condition
+      inner_condition = parenthesized_condition(condition)
+      condition_start =
+        if inner_condition
+          inner_condition.source_range.begin_pos
+        else
+          condition.source_range.begin_pos
+        end
+
+      if inner_condition
+        if !condition_starts_on_next_line?(node, inner_condition)
+          corrector.replace(
+            range_between(node.loc.keyword.end_pos, condition_start),
+            " (\n#{condition_indentation(node)}",
+          )
+        end
+
+        if !closing_parenthesis_on_own_line?(condition, inner_condition)
+          corrector.replace(
+            range_between(inner_condition.source_range.end_pos, condition.loc.end.end_pos),
+            "\n#{base_indentation(node)})",
+          )
+        end
+      else
+        corrector.replace(
+          range_between(node.loc.keyword.end_pos, condition_start),
+          " (\n#{condition_indentation(node)}",
+        )
+
+        condition_end = condition_end_position(condition)
+        corrector.insert_after(
+          range_between(condition_end, condition_end),
+          "\n#{base_indentation(node)})",
+        )
+      end
+    end
+
+    def condition_starts_on_next_line?(node, inner_condition)
+      inner_condition.first_line > node.loc.keyword.line
+    end
+
+    def closing_parenthesis_on_own_line?(condition, inner_condition)
+      condition.loc.end.line > inner_condition.source_range.last_line
+    end
+
+    def parenthesized_condition(condition)
+      if (
+        condition.begin_type? &&
+          condition.children.one? &&
+          condition.loc.begin &&
+          condition.loc.end
+      )
+        condition.children.first
+      end
+    end
+
+    def condition_end_position(condition)
+      end_position = condition.source_range.end_pos
+      last_line = condition.source_range.last_line
+
+      processed_source.comments.each do |comment|
+        if comment.location.line == last_line && comment.source_range.begin_pos >= end_position
+          end_position = comment.source_range.end_pos
+        end
+      end
+
+      end_position
+    end
+
+    def base_indentation(node)
+      node.loc.keyword.source_line[/\A[ \t]*/]
+    end
+
+    def condition_indentation(node)
+      base_indentation(node) + (' ' * indentation_width)
+    end
+
+    def indentation_width
+      config.for_cop('Layout/IndentationWidth')['Width'] || 2
+    end
+  end
+end

data/lib/runger_style/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RungerStyle
-  VERSION = '5.17.0'
+  VERSION = '5.18.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: runger_style
 version: !ruby/object:Gem::Version
-  version: 5.17.0
+  version: 5.18.0
 platform: ruby
 authors:
 - David Runger
@@ -77,6 +77,7 @@ files:
 - lib/runger_style/cops/default/multiline_hash_value_indentation.rb
 - lib/runger_style/cops/default/multiline_method_arguments_line_breaks.rb
 - lib/runger_style/cops/default/no_return.rb
+- lib/runger_style/cops/default/parentheses_around_multiline_condition.rb
 - lib/runger_style/cops/default/require_all_custom_cops.rb
 - lib/runger_style/cops/default/require_all_monkeypatches.rb
 - lib/runger_style/version.rb