runger_style 5.14.1 → 5.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f8fa813e7e66d6f099e6aa3623b31ecfcdc95ad9bb260c3f299693ac1f001650
-  data.tar.gz: d585cd781729a54a18eab40472bb342f745f9abcf61412990ba92a978ae01acb
+  metadata.gz: b261788e883af277fc7cc22ce3c029aafbe7fd94300b10acb7f64b89d74d2b3c
+  data.tar.gz: 90c37f8193b959a0bec4d69ec93988018d887714fc55e6bedc37fda9fe9cabe4
 SHA512:
-  metadata.gz: a1711347475f37d672ef378ed04997b87bd9aed104ca5a4e1496e3f3bfb5077bb8b2c2226a3e1e7d3c01299c8c5e9b65fcfa9a44a5d7a8579bf8796faea65b9e
-  data.tar.gz: 90b80a50c67a5678714d98eef424a24fbf1e69b25fbd66ce0d1f2faeebc873aa4dd208ec65b94c34b7add62eeb5b4732e1c1d0a2209999ce41dd72c51cda02dd
+  metadata.gz: 487ec712ac16381556f82fb6350bae553b7889b21ec25034e47ca599181d96d056a71e9911b9709f0fb2867064a1ab24568dd04a64cf70df95909344324cdb2f
+  data.tar.gz: bd4ef0b1a88b48e26c0d43dd4cf28168000b98c78e68ddb0ed6bbd367a9f3d9187b25a1b0298053a578f859f871c50156d1d4887d29df66574552f49e14d691b

data/CHANGELOG.md

@@ -1,6 +1,9 @@
 ## Unreleased
 [no unreleased changes yet]
 
+## v5.15.0 (2026-08-20)
+- [default] Add `RungerStyle/IfUnlessModifier` to prohibit trailing `if` and `unless` conditions.
+
 ## v5.14.1 (2026-08-13)
 - [default] Enforce fixed continuation indentation for parenthesis-free macro calls.
 

data/Gemfile.lock

@@ -10,7 +10,7 @@ GIT
 PATH
   remote: .
   specs:
-    runger_style (5.14.1)
+    runger_style (5.15.0)
       prism (>= 0.24.0)
       rubocop (>= 1.72.0)
 
@@ -69,10 +69,10 @@ GEM
       method_source (~> 1.0)
       reline (>= 0.6.0)
     racc (1.8.1)
-    rack (3.2.6)
+    rack (3.2.7)
     rainbow (3.1.1)
     rake (13.4.2)
-    rbs (4.1.2)
+    rbs (4.1.3)
       logger
       prism (>= 1.6.0)
       tsort
@@ -119,15 +119,15 @@ GEM
     rubocop-factory_bot (2.28.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-performance (1.26.1)
+    rubocop-performance (1.27.0)
       lint_roller (~> 1.1)
-      rubocop (>= 1.75.0, < 2.0)
+      rubocop (>= 1.89.0, < 2.0)
       rubocop-ast (>= 1.47.1, < 2.0)
-    rubocop-rails (2.36.0)
+    rubocop-rails (2.37.0)
       activesupport (>= 4.2.0)
       lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.75.0, < 2.0)
+      rubocop (>= 1.89.0, < 2.0)
       rubocop-ast (>= 1.44.0, < 2.0)
     rubocop-rake (0.7.1)
       lint_roller (~> 1.1)
@@ -210,10 +210,10 @@ CHECKSUMS
   pry (0.16.0) sha256=d76c69065698ed1f85e717bd33d7942c38a50868f6b0673c636192b3d1b6054e
   pry-byebug (3.10.1)
   racc (1.8.1) sha256=4a7f6929691dbec8b5209a0b373bc2614882b55fc5d2e447a21aaa691303d62f
-  rack (3.2.6) sha256=5ed78e1f73b2e25679bec7d45ee2d4483cc4146eb1be0264fc4d94cb5ef212c2
+  rack (3.2.7) sha256=93e13e1c24f93556671d85d2d79fa228c3485815c50d7e2f265b5330c6528fb7
   rainbow (3.1.1) sha256=039491aa3a89f42efa1d6dec2fc4e62ede96eb6acd95e52f1ad581182b79bc6a
   rake (13.4.2) sha256=cb825b2bd5f1f8e91ca37bddb4b9aaf345551b4731da62949be002fa89283701
-  rbs (4.1.2) sha256=050eb1d8b508f1233bed929c0f2c7052302f7adf295230d9cb314e9024078f48
+  rbs (4.1.3) sha256=0c4474a9751cdc14364bfad0b3e53678323bbdc2c31683b0445932867dbab8c4
   rdoc (8.0.0) sha256=03bf8c08a9639658855a0cfd77c0abca8325c227693f7f33f82957811348c469
   readline (0.0.4) sha256=6138eef17be2b98298b672c3ea63bf9cb5158d401324f26e1e84f235879c1d6a
   regexp_parser (2.12.0) sha256=35a916a1d63190ab5c9009457136ae5f3c0c7512d60291d0d1378ba18ce08ebb
@@ -227,15 +227,15 @@ CHECKSUMS
   rubocop-ast (1.50.0) sha256=b9ca88300da0803ee222ad20cdb30494c0a784eed06fdc35d254b06d662788db
   rubocop-capybara (3.0.0) sha256=7a64655238acda7f8f3c87e37ac825a64c615a79c17c253f1a28270dc3768c4b
   rubocop-factory_bot (2.28.0) sha256=4b17fc02124444173317e131759d195b0d762844a71a29fe8139c1105d92f0cb
-  rubocop-performance (1.26.1) sha256=cd19b936ff196df85829d264b522fd4f98b6c89ad271fa52744a8c11b8f71834
-  rubocop-rails (2.36.0) sha256=105a5f5b0001ff2ef28a3af90da50862464e0775e8d0016d599079c0ca408bdb
+  rubocop-performance (1.27.0) sha256=eeeb1374d062a368ee1c787b70eb0b0cc4b184cb1f8565f424760946146d61ce
+  rubocop-rails (2.37.0) sha256=6e1645add5060e0328f8ddda0d820f55697c591394398bf14bb9dccb62f14b7e
   rubocop-rake (0.7.1) sha256=3797f2b6810c3e9df7376c26d5f44f3475eda59eb1adc38e6f62ecf027cbae4d
   rubocop-rspec (3.10.2) sha256=0b3e2ecc592cd10ecbf0095bb58d1e357905276e069643523cc19eb7495f65e2
   rubocop-rspec_rails (2.32.0) sha256=4a0d641c72f6ebb957534f539d9d0a62c47abd8ce0d0aeee1ef4701e892a9100
   ruby-progressbar (1.13.0) sha256=80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33
   runger_byebug (11.4.0) sha256=569e22ba2215f57e7f69e145fcb63be401e29fcd312f7936d813e12d0c7bbee6
   runger_release_assistant (4.3.1) sha256=3246c925240739eb12b9e6b9526a77ea00fcf0a0941441ff5ffacefb7e3e4d83
-  runger_style (5.14.1)
+  runger_style (5.15.0)
   securerandom (0.4.1) sha256=cc5193d414a4341b6e225f0cb4446aceca8e50d5e1888743fac16987638ea0b1
   slop (4.10.1) sha256=844322b5ffcf17ed4815fdb173b04a20dd82b4fd93e3744c88c8fafea696d9c7
   tsort (0.2.0) sha256=9650a793f6859a43b6641671278f79cfead60ac714148aabe4e3f0060480089f

data/lib/runger_style/cops/default/first_argument_indentation.rb

@@ -3,9 +3,9 @@
 module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
   class FirstArgumentIndentation < ::RuboCop::Cop::Layout::FirstArgumentIndentation
     def on_send(node)
-      return if memoizing?(node)
-
-      super
+      unless memoizing?(node)
+        super
+      end
     end
 
     private

data/lib/runger_style/cops/default/if_unless_modifier.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+module RungerStyle # rubocop:disable Style/ClassAndModuleChildren
+  class IfUnlessModifier < ::RuboCop::Cop::Base
+    extend ::RuboCop::Cop::AutoCorrector
+    include ::RuboCop::Cop::RangeHelp
+
+    MSG = 'Use a multiline conditional instead of a trailing `%<keyword>s` condition.'
+
+    def on_if(node)
+      if node.modifier_form?
+        comment = trailing_comment(node)
+
+        add_offense(node.loc.keyword, message: format(MSG, keyword: node.keyword)) do |corrector|
+          corrector.replace(node, replacement(node, comment))
+
+          if comment
+            corrector.remove(trailing_comment_range(node, comment))
+          end
+        end
+      end
+    end
+
+    private
+
+    def replacement(node, comment)
+      indentation = node.source_range.source_line[/^\s*/]
+
+      <<~RUBY.chomp
+        #{node.keyword} #{node.condition.source}#{comment_suffix(comment)}
+        #{indented_body(node, indentation)}
+        #{indentation}end
+      RUBY
+    end
+
+    def indented_body(node, indentation)
+      node.body.source.lines.map.with_index do |line, index|
+        index.zero? ? "#{indentation}  #{line}" : "  #{line}"
+      end.join
+    end
+
+    def trailing_comment(node)
+      processed_source.comments.find do |comment|
+        comment.location.line == node.last_line &&
+          comment.source_range.begin_pos >= node.source_range.end_pos
+      end
+    end
+
+    def comment_suffix(comment)
+      if comment
+        " #{comment.source}"
+      else
+        ''
+      end
+    end
+
+    def trailing_comment_range(node, comment)
+      range_between(node.source_range.end_pos, comment.source_range.end_pos)
+    end
+  end
+end

data/lib/runger_style/cops/default/monkeypatches/multiline_element_line_breaks.rb

@@ -4,16 +4,16 @@ module RungerStyle::MultilineElementLineBreaksPatches
   private
 
   def check_line_breaks(node, children, ignore_last: false)
-    return if single_line?(node, children, ignore_last:)
-
-    last_seen_line = -1
-    children.each do |child|
-      if last_seen_line >= child.first_line
-        add_offense(child) do |corrector|
-          RuboCop::Cop::EmptyLineCorrector.insert_before(corrector, child)
+    unless single_line?(node, children, ignore_last:)
+      last_seen_line = -1
+      children.each do |child|
+        if last_seen_line >= child.first_line
+          add_offense(child) do |corrector|
+            RuboCop::Cop::EmptyLineCorrector.insert_before(corrector, child)
+          end
+        else
+          last_seen_line = child.last_line
         end
-      else
-        last_seen_line = child.last_line
       end
     end
   end

data/lib/runger_style/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RungerStyle
-  VERSION = '5.14.1'
+  VERSION = '5.15.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: runger_style
 version: !ruby/object:Gem::Version
-  version: 5.14.1
+  version: 5.15.0
 platform: ruby
 authors:
 - David Runger
@@ -70,6 +70,7 @@ files:
 - lib/runger_style/cops/capybara/require_all_custom_cops.rb
 - lib/runger_style/cops/default/argument_alignment.rb
 - lib/runger_style/cops/default/first_argument_indentation.rb
+- lib/runger_style/cops/default/if_unless_modifier.rb
 - lib/runger_style/cops/default/monkeypatches/multiline_element_line_breaks.rb
 - lib/runger_style/cops/default/monkeypatches/multiline_expression_indentation.rb
 - lib/runger_style/cops/default/multiline_hash_value_indentation.rb