runeterra_cards 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4b69727cd16ea8ffd2f32512a4a24182986f5e034697df5e2c65c263d6cb5de3
-  data.tar.gz: 23788bbbb28132316e2196bccbeb963cc275cba06c58f4e7b65611e1ab2f85be
+  metadata.gz: a1e0528d970e63dfad42a4f65e907f76cc966bc5da298de031bb8b0903870ebe
+  data.tar.gz: 4546f417aeea04a3dd767d959603670235a8fe0f382e4a6a15a61fe726d09e49
 SHA512:
-  metadata.gz: bb9a9cb799052f642e211e039473be974e58dd818acdafda4cf0595544929d73368a5bcc213d020f4d31124d50b08379436dbd8ccc0ce22e15cc95ef2aabe4a3
-  data.tar.gz: 135faf1d286264dc9a888b97a301be51c57301ca02be62f5b97998d23ac69c3cc5b4a748c216145dd05c047e26b756d49bc727a75e0477cf52565da9bf01ce47
+  metadata.gz: 6fe77c6a6ca5c0f7c40c2f75678737f44ac4a6d3d5f120ffd2b55228462e1ebdb3963a1cdfc965d0569e252c5df7b7b9721f8b52810eb7f5fabb3fd9372719cf
+  data.tar.gz: 7686da5bfecde6a4322cff7989f25c3668c776e4185870231f39cfb998ac72c99d44c24d8383234189c6f876cbdd12d4ba283bf049b0e9982815b22fbf4575ea

data/doc/CHANGELOG.md

@@ -4,6 +4,18 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.6.1] - 2022-04-30
+### Added
+
+- Documented which versions of Ruby are officially supported:
+  - Ruby: 2.6, 2.7, 3.0, 3.1
+  - JRuby: 9.3
+  - TruffleRuby: 20, 21, 22
+
+### Fixed
+
+- Various scenarios where invalid deck codes would produce unhelpful exceptions now raise a `DeckCodeParseError` instead.
+
 ## [0.6.0] - 2021-08-25
 ### Added
 - Support for the Bandle City faction.

data/doc/README.md

@@ -9,15 +9,23 @@ This library makes it easy to decode Legends of Runeterra deck codes, load Data
 Add the following to your `Gemfile`:
 
 ```
-gem 'runeterra_cards', '~> 0.6.0'
+gem 'runeterra_cards', '~> 0.6.1'
 ```
 
 Or, if you're building a Gem, your `.gemspec`:
 
 ```
-  spec.add_dependency 'runeterra_cards', '~> 0.6.0'
+  spec.add_dependency 'runeterra_cards', '~> 0.6.1'
 ```
 
+### Ruby version support
+
+* Ruby: 2.6, 2.7, 3.0, 3.1
+* JRuby: 9.3 only
+* TruffleRuby: 20, 21, 22
+
+Note that only Linux and Windows are included in automated testing, although other platforms are expected to work. Also note that truffleruby compatibility is not tested on Windows.
+
 ## Updates & Versioning
 
 This library will conform to [semantic versioning](https://semver.org/) once it hits 1.0. In the meantime, you can rely on the minor version (Y in x.Y.z) being bumped for backwards-incompatible changes.

data/lib/runeterra_cards/card_set.rb

@@ -29,7 +29,7 @@ module RuneterraCards
       remaining_cards =
         cards.each_with_object({}) do |(code, count), result|
           new_count = count - other.count_for_card_code(code)
-          result[code] = new_count unless new_count.equal?(0)
+          result[code] = new_count unless new_count.eql?(0)
         end
 
       CardSet.new(remaining_cards)
@@ -68,7 +68,7 @@ module RuneterraCards
 
       raise UnrecognizedVersionError.new(SUPPORTED_VERSION, version) unless version <= SUPPORTED_VERSION
 
-      raise unless format.equal? 1
+      raise unless format.eql? 1
 
       int_array = unpack_big_endian_varint(binary_data[1..])
       cards = assemble_card_list(int_array)
@@ -105,11 +105,11 @@ module RuneterraCards
     # @return [Array<Card>]
     def self.assemble_card_list(array)
       3.downto(1).flat_map do |number_of_copies|
-        set_faction_combination_count = array.shift
+        set_faction_combination_count = shift_and_check(array)
         set_faction_combination_count.times.flat_map do
-          number_of_cards, set, faction = array.shift(3)
+          number_of_cards, set, faction = shift_and_check(array, 3)
 
-          array.shift(number_of_cards).map do |card_number|
+          shift_and_check(array, number_of_cards).map do |card_number|
             cac = Card.new(set: set, faction_number: faction, card_number: card_number)
             [cac.code, number_of_copies]
           end
@@ -119,6 +119,26 @@ module RuneterraCards
 
     private_class_method :assemble_card_list
 
+    # Like Array#shift but checks that the number of items requested was
+    #   actually retrieved, errors otherwise.
+    # @param [Array<T>] array Array to shift one or more values from
+    # @param [Integer] count Number of items to shift from the array (default 1)
+    # @return [Array<T>,T]
+    # @raise [DeckCodeParseError]
+    def self.shift_and_check(array, count=nil)
+      if count
+        raise DeckCodeParseError if array.length < count
+
+        array.shift(count)
+      else
+        raise DeckCodeParseError if array.empty?
+
+        array.shift
+      end
+    end
+
+    private_class_method :shift_and_check
+
     # @param [String] binary
     # @return [Enumerable<Fixnum>]
     def self.unpack_big_endian_varint(binary)

data/lib/runeterra_cards/cost.rb

@@ -55,10 +55,10 @@ module RuneterraCards
     # The number of shards needed. I.e. the equivalent amount of shards for all these wildcards.
     # @return [Fixnum] shards
     def shards
-      common * 100 +
-        rare * 300 +
-        epic * 1200 +
-        champion * 3000
+      (common * 100) +
+        (rare * 300) +
+        (epic * 1200) +
+        (champion * 3000)
     end
 
     # Whether this Cost is equal to another. Equality means exactly the same number of each wildcard, not just the
@@ -66,10 +66,10 @@ module RuneterraCards
     # @param [Cost] other an object that response to {#common}, {#rare}, {#epic}, and {#champion}.
     # @return [Boolean] equal?
     def ==(other)
-      common.equal?(other.common) &&
-        rare.equal?(other.rare) &&
-        epic.equal?(other.epic) &&
-        champion.equal?(other.champion)
+      common.eql?(other.common) &&
+        rare.eql?(other.rare) &&
+        epic.eql?(other.epic) &&
+        champion.eql?(other.champion)
     end
 
     # Subtracts another Cost from this one. Subtraction is performed by subtracting each wildcard type individually,

data/lib/runeterra_cards/version.rb

@@ -2,6 +2,6 @@
 
 module RuneterraCards
   # The version of this library
-  VERSION = '0.6.0'
+  VERSION = '0.6.1'
   public_constant :VERSION
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: runeterra_cards
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - James "zofrex" Sanderson
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-25 00:00:00.000000000 Z
+date: 2022-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: base32
@@ -24,34 +24,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.3.2
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: deep-cover
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.7'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -156,14 +128,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.1
+        version: 0.15.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.1
+        version: 0.15.2
 - !ruby/object:Gem::Dependency
   name: rubocop-packaging
   requirement: !ruby/object:Gem::Requirement
@@ -234,6 +206,7 @@ metadata:
   changelog_uri: https://www.rubydoc.info/gems/runeterra_cards/file/doc/CHANGELOG.md
   source_code_uri: https://github.com/zofrex/runeterra_cards
   documentation_uri: https://www.rubydoc.info/gems/runeterra_cards/
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -249,7 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Legends of Runeterra deck code decoder & Data Dragon card data loader.