runeterra_cards 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 464996b724ae43c17f2725e24aaf616324b1ffbfa945c4ebf1158ebfe250cbab
-  data.tar.gz: e9c571d14c48ef39c5d25594ac7fbacafcd566b318887c1f49e31283cf5a9d00
+  metadata.gz: 13de26db2b79d60bca9fce39d36d3d82fcaaa19fbcdae3dc2c6f34c785253d91
+  data.tar.gz: 061a9c9e56f751fc2451166af0e9b27f415c4b9293b1ac1d0dc58df714a46a6b
 SHA512:
-  metadata.gz: c5cf637f8898ed29afde28ced8036dc3806e5da4d1c03db12cb7d97e4be101dd7252466470f30b9edd709a290c8d8755e62c401d663c34cd945e8a7ea281fbba
-  data.tar.gz: df8cf13cdaaffdbbc985e17f406f66d7611c90c841a5df726d8d4f799bac0ce2dd2e64fe6a4144a44d9ce1e522e1e98ed7dddd0e9f1fac014ec445b2ba219f6c
+  metadata.gz: cde13398e27b94c917c74efb2cedf4fa82c3af5b8cc7e2da4a19af959176bf24703574170718d17ace331cf20e23b019001150fdd12a90a81688cd2f17f186c3
+  data.tar.gz: 18d73970af5591a2f65ccf9ba4739800d1025f042499416ed5e2ccd6b5ad33797c3b4640bd7b89dd99600b1a4f2a3bc0f641be0499d392ad56385ec53318dc22

data/doc/CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.1] - 2021-02-05
+
+Fixed
+
+- Fixed issue where card numbers > 127 came out extremely wrong, e.g. Aphelios and several other of the new cards ([issue #4](https://github.com/zofrex/runeterra_cards/issues/4))
 ## [0.4.0] - 2020-12-08
 ### Added
 - [`CardMetadata` now has a `#cost` attribute representing the mana cost of a card.](https://github.com/zofrex/runeterra_cards/pull/3) (thanks, [nieszkah](https://github.com/alpm)!) Technically this is backwards-compatibility breaking as it makes a new field in metadata json mandatory.

data/doc/README.md

@@ -9,13 +9,13 @@ This library makes it easy to decode Legends of Runeterra deck codes, load Data
 Add the following to your `Gemfile`:
 
 ```
-gem 'runeterra_cards', '~> 0.4.0'
+gem 'runeterra_cards', '~> 0.4.1'
 ```
 
 Or, if you're building a Gem, your `.gemspec`:
 
 ```
-  spec.add_dependency 'runeterra_cards', '~> 0.4.0'
+  spec.add_dependency 'runeterra_cards', '~> 0.4.1'
 ```
 
 ## Updates & Versioning

data/lib/runeterra_cards/card_set.rb

@@ -62,8 +62,9 @@ module RuneterraCards
 
       raise unless format.equal? 1
 
-      int_array = binary_data[1..].unpack('w*')
+      int_array = unpack_uleb128(binary_data[1..])
       cards = assemble_card_list(int_array)
+
       from_card_and_counts(cards)
     end
 
@@ -108,5 +109,19 @@ module RuneterraCards
     end
 
     private_class_method :assemble_card_list
+
+    # @param [String] binary
+    # @return [Enumerable<Fixnum>]
+    def self.unpack_uleb128(binary)
+      binary.each_byte.slice_after { |b| (b & 0b1000_0000).zero? }.map do |int_bytes|
+        acc = 0
+        int_bytes.each_with_index do |byte, index|
+          acc += (byte & 0b0111_1111) << (7 * index)
+        end
+        acc
+      end
+    end
+
+    private_class_method :unpack_uleb128
   end
 end

data/lib/runeterra_cards/errors.rb

@@ -10,7 +10,8 @@ module RuneterraCards
   class Base32Error < DeckCodeParseError
     # Returns a new instance of Base32Error with a helpful error message preloaded.
     def initialize
-      super('Encountered an error while Base32 decoding deck code.' \
+      super(
+        'Encountered an error while Base32 decoding deck code.' \
         ' Probably an invalid deck code, or possibly a bug in the Base32 handling.')
     end
   end
@@ -37,8 +38,9 @@ module RuneterraCards
     # @param [Fixnum] expected The version number we were expecting to see in the deck code.
     # @param [Fixnum] got The version number we actually got.
     def initialize(expected, got)
-      super("Unrecognized deck code version number: #{got}, was expecting: #{expected}. \
-Possibly an invalid deck code, possibly you need to update the deck code library version.")
+      super(
+        "Unrecognized deck code version number: #{got}, was expecting: #{expected}. "\
+        'Possibly an invalid deck code, possibly you need to update the deck code library version.')
       @version = got
     end
   end
@@ -56,7 +58,8 @@ Possibly an invalid deck code, possibly you need to update the deck code library
 
     # @param [Fixnum] faction_number The faction number we encountered and did not recognise.
     def initialize(faction_number)
-      super("Unrecognized faction number '#{faction_number}'."\
+      super(
+        "Unrecognized faction number '#{faction_number}'."\
         ' Possibly you need to update this library to a newer version')
       @faction_number = faction_number
     end

data/lib/runeterra_cards/version.rb

@@ -2,6 +2,6 @@
 
 module RuneterraCards
   # The version of this library
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
   public_constant :VERSION
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: runeterra_cards
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - James "zofrex" Sanderson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-08 00:00:00.000000000 Z
+date: 2021-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: base32