run_loop 2.0.6 → 2.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e713b8074f4a98cc789fe39327c63c675d8483cb
-  data.tar.gz: 98d467c958129c5a33efa0fe654088f38b0b7b0f
+  metadata.gz: 48c1c78396cdf8d493ce6d242d09b2a36884fe5e
+  data.tar.gz: 83cfc779ce7803e4deae06af1bc7a3a55a299310
 SHA512:
-  metadata.gz: 810a32b9c38f9b720129ca06dc8a80cb6d92c4243d8bd7dc4dd62cee55600e19d68f9eb38d7c28643f9ed023d3437e1c9b35beb26a1e9f95a64b8de3a9308a23
-  data.tar.gz: 0963ce5adff45b9aae3b20cc2635000ea69ef166deef85956461c2808abca49a371140d8a42d911a622a4e88547fbd6e90c713ff63befeaf49087b921ecfb56a
+  metadata.gz: 2acc78eed572c025036a5e168b592c0ea00c2ca53cfb8562118a6e603052eccde496fd262ed1c9cb0ab2a1cbefb2d35a306829c8e7725bfc51842c404f172599
+  data.tar.gz: 6d0a90bf5529840121434d05ec23948bd0cc50a1be2fa5bf6616d4748154b479e8e1eff07bc7cf35447610a43805649b4a32e3ee76f987a057052bfbf8f1bf44

data/lib/run_loop.rb

@@ -14,6 +14,7 @@ require 'run_loop/fifo'
 require 'run_loop/core'
 require 'run_loop/version'
 require 'run_loop/plist_buddy'
+require "run_loop/codesign"
 require 'run_loop/app'
 require 'run_loop/ipa'
 require 'run_loop/sim_control'
@@ -30,6 +31,11 @@ require 'run_loop/simctl/plists'
 require 'run_loop/template'
 require "run_loop/locale"
 require "run_loop/language"
+require "run_loop/xcuitest"
+require "run_loop/http/error"
+require "run_loop/http/server"
+require "run_loop/http/request"
+require "run_loop/http/retriable_client"
 
 module RunLoop
 

data/lib/run_loop/app.rb

@@ -95,6 +95,21 @@ Bundle must:
       version
     end
 
+    # @!visibility private
+    def codesign_info
+      RunLoop::Codesign.info(path)
+    end
+
+    # @!visibility private
+    def developer_signed?
+      RunLoop::Codesign.developer?(path)
+    end
+
+    # @!visibility private
+    def distribution_signed?
+      RunLoop::Codesign.distribution?(path)
+    end
+
     # @!visibility private
     # Collects the paths to executables in the bundle.
     def executables

data/lib/run_loop/cli/cli.rb

@@ -4,6 +4,7 @@ require 'run_loop/cli/errors'
 require 'run_loop/cli/instruments'
 require 'run_loop/cli/simctl'
 require "run_loop/cli/locale"
+require "run_loop/cli/codesign"
 
 trap 'SIGINT' do
   puts 'Trapped SIGINT - exiting'
@@ -35,6 +36,9 @@ module RunLoop
       desc "locale", "Tools for interacting with locales"
       subcommand "locale", RunLoop::CLI::Locale
 
+      desc "codesign", "Tools for interacting with codesign"
+      subcommand "codesign", RunLoop::CLI::Codesign
+
     end
   end
 end

data/lib/run_loop/cli/codesign.rb

@@ -0,0 +1,24 @@
+require "thor"
+require "run_loop"
+require "run_loop/cli/errors"
+
+module RunLoop
+  module CLI
+    class Codesign < Thor
+
+      desc "info ARTIFACT", "Print codesign information about ARTIFACT (ipa, app, or library)"
+
+      def info(app_or_ipa)
+        extension = File.extname(app_or_ipa)
+
+        if extension == ".app"
+          puts RunLoop::App.new(app_or_ipa).codesign_info
+        elsif extension == ".ipa"
+          puts RunLoop::Ipa.new(app_or_ipa).codesign_info
+        else
+          puts RunLoop::Codesign.info(app_or_ipa)
+        end
+      end
+    end
+  end
+end

data/lib/run_loop/codesign.rb

@@ -0,0 +1,76 @@
+module RunLoop
+  # @!visibility private
+  # A wrapper around codesign command line tool
+  class Codesign
+
+    # @!visibility private
+    DEV_REGEX = /Authority=iPhone Developer:/
+
+    # @!visibility private
+    APP_STORE_REGEX = /Authority=Apple iPhone OS Application Signing/
+
+    # @!visibility private
+    DISTR_REGEX = /Authority=iPhone Distribution:/
+
+    # @!visibility private
+    NOT_SIGNED_REGEX = /code object is not signed at all/
+
+    # @!visibility private
+    def self.info(path)
+      self.expect_path_exists(path)
+      self.exec(["--display", "--verbose=4", path])
+    end
+
+    # @!visibility private
+    #
+    # True if the asset is signed.
+    def self.signed?(path)
+      info = self.info(path)
+      info[NOT_SIGNED_REGEX, 0] == nil
+    end
+
+    # @!visibility private
+    #
+    # True if the asset is signed with anything other than a dev cert.
+    def self.distribution?(path)
+      info = self.info(path)
+
+      info[NOT_SIGNED_REGEX, 0] == nil &&
+        info[DEV_REGEX, 0] == nil
+    end
+
+    # @!visibility private
+    #
+    # True if the asset is signed with a dev cert
+    def self.developer?(path)
+      info = self.info(path)
+      info[DEV_REGEX, 0] != nil
+    end
+
+    private
+
+    def self.expect_path_exists(path)
+      if !File.exist?(path)
+        raise ArgumentError,
+%Q{There is no file or directory at path:
+
+#{path}
+}
+      end
+    end
+
+    def self.exec(args)
+      if !args.is_a?(Array)
+        raise ArgumentError, "Expected args: '#{args}' to be an Array"
+      end
+
+      xcrun = RunLoop::Xcrun.new
+      cmd = ["codesign"] + args
+      options = {:log_cmd => true}
+      hash = xcrun.exec(cmd, options)
+
+      hash[:out]
+    end
+  end
+end
+

data/lib/run_loop/core_simulator.rb

@@ -500,6 +500,7 @@ $ bundle exec run-loop simctl manage-processes
       end
     end
   end
+
   # Returns the current simulator name.
   #
   # @return [String] A String suitable for searching for a pid, quitting, or
@@ -540,8 +541,6 @@ $ bundle exec run-loop simctl manage-processes
   # @note Will only search for the current Xcode simulator.
   #
   # @return [Integer, nil] The pid as a String or nil if no process is found.
-  #
-  # @todo Convert this to force UTF8
   def running_simulator_pid
     process_name = "MacOS/#{sim_name}"
 

data/lib/run_loop/environment.rb

@@ -28,6 +28,16 @@ module RunLoop
       ENV['XAMARIN_TEST_CLOUD'] == '1'
     end
 
+    # Returns the value of DEVICE_TARGET
+    def self.device_target
+      ENV["DEVICE_TARGET"]
+    end
+
+    # Returns the value of DEVICE_ENDPOINT
+    def self.device_endpoint
+      ENV["DEVICE_ENDPOINT"]
+    end
+
     # Returns the value of TRACE_TEMPLATE; the Instruments template to use
     # during testing.
     def self.trace_template

data/lib/run_loop/http/error.rb

@@ -0,0 +1,15 @@
+module RunLoop
+  module HTTP
+
+    # Raised when there is a problem communicating with the Calabash test
+    # server.
+    class Error < StandardError
+
+    end
+
+    # Raised when there is a problem creating an HTTP request.
+    class RequestError < StandardError
+
+    end
+  end
+end

data/lib/run_loop/http/request.rb

@@ -0,0 +1,44 @@
+module RunLoop
+  module HTTP
+
+    # A representation of an HTTP request that can be passed passed to the HTTP
+    # client as an argument for `get` or `post`.
+    # @!visibility private
+    class Request
+      attr_reader :route, :params
+
+      def initialize(route, params={})
+        @route = route
+        @params = params
+      end
+
+      # Create a new Request from `route` and `parameters`.
+      #
+      # @param [String] route The http route for the new request.
+      # @param [Array, Hash] parameters An Array or Hash of parameters.
+      # @return [Request] A new Request for `route` with `parameters`.
+      # @raise [RequestError] Raises an error if the parameters cannot be
+      #   converted to JSON
+      def self.request(route, parameters)
+        Request.new(route, Request.data(parameters))
+      end
+
+      private
+
+      # Converts `parameters` to JSON.
+      #
+      # @param [Array, Hash] parameters An Array or Hash of parameters.
+      # @return [String] A JSON formatted string that represents the parameters.
+      # @raise [RequestError] Raises an error if the parameters cannot be
+      #   converted to JSON
+      def self.data(parameters)
+        begin
+          JSON.generate(parameters)
+        rescue *[TypeError, JSON::GeneratorError] => e
+          raise RequestError, "#{e}: could not generate JSON from '#{parameters}'"
+        end
+      end
+    end
+  end
+end
+

data/lib/run_loop/http/retriable_client.rb

@@ -0,0 +1,162 @@
+module RunLoop
+  module HTTP
+    require "httpclient"
+
+    # An HTTP client that retries its connection on errors and can time out.
+    # @!visibility private
+    class RetriableClient
+      attr_reader :client
+
+      # @!visibility private
+       RETRY_ON =
+        [
+          # The connection, request, or response timed out
+          #HTTPClient::TimeoutError,
+          # The address is not found. Useful for polling.
+          SocketError,
+          # The proxy could not connect to the server (Android)
+          #  or the server is not running (iOS)
+          HTTPClient::KeepAliveDisconnected,
+           # No proxy has been set up (Android)
+          Errno::ECONNREFUSED,
+          # The server sent a partial response
+          #Errno::ECONNRESET,
+          # Client sent TCP reset (RST) before server has accepted the
+          #  connection requested by client.
+          Errno::ECONNABORTED,
+          # The foreign function call call timed out
+          #Errno::ETIMEDOUT
+        ]
+
+      # @!visibility private
+      HEADER =
+            {
+                  'Content-Type' => 'application/json;charset=utf-8'
+            }
+
+      # Creates a new retriable client.
+      #
+      # This initializer takes multiple options.  If the option is not
+      # documented, it should be considered _private_. You use undocumented
+      # options at your own risk.
+      #
+      # @param [RunLoop::HTTP::Server] server The server to make the HTTP request
+      #  on.
+      # @param [Hash] options Control the retry, timeout, and interval.
+      # @option options [Number] :retries (5) How often to retry.
+      # @option options [Number] :timeout (5) How long to wait for a response
+      #  before timing out.
+      # @option options [Number] :interval (0.5) How long to sleep between
+      #  retries.
+      def initialize(server, options = {})
+        @client = options[:client] || ::HTTPClient.new
+        @server = server
+        @retries = options.fetch(:retries, 5)
+        @timeout = options.fetch(:timeout, 5)
+        @interval = options.fetch(:interval, 0.5)
+        @on_error = {}
+      end
+
+      # @!visibility private
+      def on_error(type, &block)
+        @on_error[type] = block
+      end
+
+      # @!visibility private
+      def change_server(new_server)
+        @server = new_server
+      end
+
+      # Make an HTTP get request.
+      #
+      # This method takes multiple options.  If the option is not documented,
+      # it should be considered _private_.  You use undocumented options at
+      # your own risk.
+      #
+      # @param [RunLoop::HTTP::Request] request The request.
+      # @param [Hash] options Control the retry, timeout, and interval.
+      # @option options [Number] :retries (5) How often to retry.
+      # @option options [Number] :timeout (5) How long to wait for a response
+      #  before timing out.
+      # @option options [Number] :interval (0.5) How long to sleep between
+      #  retries.
+      def get(request, options={})
+        request(request, :get, options)
+      end
+
+      # Make an HTTP post request.
+      #
+      # This method takes multiple options.  If the option is not documented,
+      # it should be considered _private_.  You use undocumented options at
+      # your own risk.
+      #
+      # @param [RunLoop::HTTP::Request] request The request.
+      # @param [Hash] options Control the retry, timeout, and interval.
+      # @option options [Number] :retries (5) How often to retry.
+      # @option options [Number] :timeout (5) How long to wait for a response
+      #  before timing out.
+      # @option options [Number] :interval (0.5) How long to sleep between
+      #  retries.
+      def post(request, options={})
+        request(request, :post, options)
+      end
+
+      private
+
+      def request(request, request_method, options={})
+        retries = options.fetch(:retries, @retries)
+        timeout = options.fetch(:timeout, @timeout)
+        interval = options.fetch(:interval, @interval)
+        header = options.fetch(:header, HEADER)
+
+        RunLoop.log_debug("HTTP: #{@server.endpoint + request.route} #{options}")
+
+        start_time = Time.now
+        last_error = nil
+
+        client = @client.dup
+        client.receive_timeout = timeout
+
+        retries.times do |i|
+          first_try = i == 0
+
+          # Subtract the aggregate time we've spent thus far to make sure we're
+          # not exceeding the request timeout across retries.
+          time_diff = start_time + timeout - Time.now
+
+          if time_diff <= 0
+            raise HTTP::Error, 'Timeout exceeded'
+          end
+
+          client.receive_timeout = [time_diff, client.receive_timeout].min
+
+          begin
+            return client.send(request_method, @server.endpoint + request.route,
+                               request.params, header)
+          rescue *RETRY_ON => e
+            RunLoop.log_debug("Rescued http error: #{e}")
+
+            if first_try
+              if @on_error[e.class]
+                @on_error[e.class].call(@server)
+              end
+            end
+
+            last_error = e
+            sleep interval
+          end
+        end
+
+        # We should raise helpful messages
+        if last_error.is_a?(HTTPClient::KeepAliveDisconnected)
+          raise HTTP::Error, "#{last_error}: It is likely your server has crashed."
+        elsif last_error.is_a?(SocketError)
+          raise HTTP::Error, "#{last_error}: Did your server start and is it on the same network?"
+        end
+
+        raise HTTP::Error, last_error
+      end
+    end
+  end
+end
+

data/lib/run_loop/http/server.rb

@@ -0,0 +1,17 @@
+module RunLoop
+  module HTTP
+
+    # A representation of the RunLoop test server.
+    # @!visibility private
+    class Server
+      attr_reader :endpoint
+
+      # @param [URI] endpoint The endpoint to reach the test server.
+      #   running on the device. The port should be included in the URI.
+      def initialize(endpoint)
+        @endpoint = endpoint
+      end
+    end
+  end
+end
+

data/lib/run_loop/ipa.rb

@@ -51,6 +51,21 @@ module RunLoop
       app.calabash_server_version
     end
 
+    # @!visibility private
+    def codesign_info
+      app.codesign_info
+    end
+
+    # @!visibility private
+    def developer_signed?
+      app.developer_signed?
+    end
+
+    # @!visibility private
+    def distribution_signed?
+      app.distribution_signed?
+    end
+
     private
 
     # @!visibility private

data/lib/run_loop/version.rb

@@ -1,5 +1,5 @@
 module RunLoop
-  VERSION = "2.0.6"
+  VERSION = "2.0.7"
 
   # A model of a software release version that can be used to compare two versions.
   #

data/lib/run_loop/xcode.rb

@@ -216,13 +216,41 @@ module RunLoop
     #```
     #
     # @return [String] path to current developer directory
+    #
+    # @raise [RuntimeError] If path to Xcode.app/Contents/Developer
+    #   cannot be determined.
     def developer_dir
-      @xcode_developer_dir ||=
-            if RunLoop::Environment.developer_dir
-              RunLoop::Environment.developer_dir
-            else
-              xcode_select_path
-            end
+      @xcode_developer_dir ||= lambda do
+        if RunLoop::Environment.developer_dir
+          path = RunLoop::Environment.developer_dir
+        else
+          path = xcode_select_path
+        end
+
+        if !File.directory?(path)
+          raise RuntimeError,
+%Q{Cannot determine the active Xcode.  Expected an Xcode here:
+
+#{path}
+
+Check the value of xcode-select:
+
+# Does this resolve to a valid Xcode.app/Contents/Developer path?
+$ xcode-select --print-path
+
+Is the DEVELOPER_DIR variable set in your environment?  You would
+only use this if you have multiple Xcode's installed.
+
+$ echo $DEVELOPER_DIR
+
+See the man pages for xcrun and xcode-select for details.
+
+$ man xcrun
+$ man xcode-select
+}
+        end
+        path
+      end.call
     end
 
     private

data/lib/run_loop/xcuitest.rb

@@ -0,0 +1,211 @@
+module RunLoop
+
+  # @!visibility private
+  class XCUITest
+
+    # @!visibility private
+    DEFAULTS = {
+      :port => 27753,
+      :simulator_ip => "127.0.0.1"
+    }
+
+    # @!visibility private
+    def self.workspace
+      value = ENV["XCUITEST_WORKSPACE"]
+      if value.nil? || value == ""
+        return nil
+      else
+        value
+      end
+    end
+
+    # @!visibility private
+    def self.log_file
+      path = File.join(XCUITest.dot_dir, "xcuitest.log")
+
+      if !File.exist?(path)
+        FileUtils.touch(path)
+      end
+      path
+    end
+
+    # @!visibility private
+    def initialize(bundle_id)
+      @bundle_id = bundle_id
+    end
+
+    # @!visibility private
+    # TODO: move to Device ?
+    # TODO: needs tests for device case
+    def url
+      if target.simulator?
+        "http://#{DEFAULTS[:simulator_ip]}:#{DEFAULTS[:port]}"
+      else
+        calabash_endpoint = RunLoop::Environment.device_endpoint
+        if calabash_endpoint
+          base = calabash_endpoint.split(":")[0..1].join(":")
+          "http://#{base}:#{DEFAULTS[:port]}"
+        else
+          device_name = target.name.gsub(/[\'\s]/, "")
+          encoding_options = {
+            :invalid           => :replace,  # Replace invalid byte sequences
+            :undef             => :replace,  # Replace anything not defined in ASCII
+            :replace           => ''        # Use a blank for those replacements
+          }
+          encoded = device_name.encode(Encoding.find("ASCII"), encoding_options)
+          "http://#{encoded}.local:27753"
+        end
+      end
+    end
+
+    # @!visibility private
+    def launch_calabus_driver
+
+      driver_url = url
+      server = RunLoop::HTTP::Server.new(driver_url)
+      request = RunLoop::HTTP::Request.new("/shutdown", {})
+      options = {
+         :timeout => 0.5,
+         :retries => 1
+      }
+      client = RunLoop::HTTP::RetriableClient.new(server, options)
+
+      begin
+        response = client.post(request)
+        RunLoop.log_debug("Calabus driver says, \"#{response.body}\"")
+        sleep(2.0)
+      rescue => e
+        RunLoop.log_debug("Driver shutdown raised #{e}")
+      end
+
+      workspace = XCUITest.workspace
+
+      if !workspace || !File.directory?(workspace)
+        raise RuntimeError, "No workspace found"
+      end
+
+      destination = target.udid
+
+      # might be nil
+      if target.simulator?
+        # quits the simulator
+        sim = CoreSimulator.new(target, "")
+        sim.launch_simulator
+      else
+
+      end
+
+      args = [
+        "xcrun",
+        "xcodebuild",
+        "-scheme", "CBXAppStub",
+        "-workspace", workspace,
+        "-config", "Debug",
+        "-destination", "id=#{destination}",
+        "clean",
+        "test"
+      ]
+
+      log_file = XCUITest.log_file
+
+      options = {
+        :out => log_file,
+        :err => log_file
+      }
+
+      command = args.join(" ")
+      RunLoop.log_unix_cmd("#{command} >& #{log_file}")
+
+      pid = Process.spawn(*args, options)
+      Process.detach(pid)
+
+      if target.simulator?
+        target.simulator_wait_for_stable_state
+      end
+
+      RunLoop.log_debug("Waiting for CBX-Runner to build...")
+
+      server = RunLoop::HTTP::Server.new(driver_url)
+      request = RunLoop::HTTP::Request.new("/health", {})
+
+      options = {
+        :timeout => 60,
+        :interval => 0.1,
+        :retries => 600
+      }
+
+      client = RunLoop::HTTP::RetriableClient.new(server, options)
+      response = client.get(request)
+
+      RunLoop.log_debug("Calabus driver says, \"#{response.body}\"")
+      pid.to_i
+    end
+
+    def launch_app
+      server = RunLoop::HTTP::Server.new(url)
+      request = RunLoop::HTTP::Request.request("/session", {:bundleID => bundle_id})
+      client = RunLoop::HTTP::RetriableClient.new(server)
+      response = client.post(request)
+
+      RunLoop.log_debug("Calabus driver says, \"#{response.body}\"")
+    end
+
+    # @!visibility private
+    def target
+      @device ||= lambda do
+        target = RunLoop::Environment.device_target
+
+        if !target
+          target = RunLoop::Core.default_simulator
+        end
+
+        options = {
+          :sim_control => simctl,
+          :instruments => instruments
+        }
+
+        device = RunLoop::Device.device_with_identifier(target, options)
+
+        if !device
+          raise RuntimeError, "Could not find a device"
+        end
+
+        device
+      end.call
+    end
+
+    # @!visibility private
+    def bundle_id
+      @bundle_id
+    end
+
+    private
+
+    # @!visibility private
+    def simctl
+      @simctl ||= RunLoop::SimControl.new
+    end
+
+    # @!visibility private
+    def instruments
+      @instruments ||= RunLoop::Instruments.new
+    end
+
+    # @!visibility private
+    def xcrun
+      RunLoop::Xcrun.new
+    end
+
+    # @!visibility private
+    def self.dot_dir
+      path = File.join(RunLoop::DotDir.directory, "xcuitest")
+
+      if !File.exist?(path)
+        FileUtils.mkdir_p(path)
+      end
+
+      path
+    end
+  end
+end
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: run_loop
 version: !ruby/object:Gem::Version
-  version: 2.0.6
+  version: 2.0.7
 platform: ruby
 authors:
 - Karl Krukow
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-05 00:00:00.000000000 Z
+date: 2016-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -86,6 +86,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.0.2
+- !ruby/object:Gem::Dependency
+  name: httpclient
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
 - !ruby/object:Gem::Dependency
   name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
@@ -274,10 +288,12 @@ files:
 - lib/run_loop/app.rb
 - lib/run_loop/cache/cache.rb
 - lib/run_loop/cli/cli.rb
+- lib/run_loop/cli/codesign.rb
 - lib/run_loop/cli/errors.rb
 - lib/run_loop/cli/instruments.rb
 - lib/run_loop/cli/locale.rb
 - lib/run_loop/cli/simctl.rb
+- lib/run_loop/codesign.rb
 - lib/run_loop/core.rb
 - lib/run_loop/core_simulator.rb
 - lib/run_loop/device.rb
@@ -287,6 +303,10 @@ files:
 - lib/run_loop/environment.rb
 - lib/run_loop/fifo.rb
 - lib/run_loop/host_cache.rb
+- lib/run_loop/http/error.rb
+- lib/run_loop/http/request.rb
+- lib/run_loop/http/retriable_client.rb
+- lib/run_loop/http/server.rb
 - lib/run_loop/instruments.rb
 - lib/run_loop/ipa.rb
 - lib/run_loop/l10n.rb
@@ -308,6 +328,7 @@ files:
 - lib/run_loop/version.rb
 - lib/run_loop/xcode.rb
 - lib/run_loop/xcrun.rb
+- lib/run_loop/xcuitest.rb
 - plists/simctl/com.apple.UIAutomation.plist
 - plists/simctl/com.apple.UIAutomationPlugIn.plist
 - scripts/calabash_script_uia.js
@@ -342,10 +363,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: The bridge between Calabash iOS and Xcode command-line tools like instruments
   and simctl.
 test_files: []
-has_rdoc: