rumale 0.20.2 → 0.20.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5d8c93acbf38fbd07e5df224010abbdd4269a6ce3bbf8112a0eba652a606785d
-  data.tar.gz: e7cb00a802420854835c92f011425f3054bfcc1052bf7b3664da1f95834ef435
+  metadata.gz: aaaacb965c722e93b75b835f21a870580c709b249829476247ad9b7849ee0ff4
+  data.tar.gz: 7de234d16943410e396551e42a7e45d436928e61c54834aab3f3d5d3448b058f
 SHA512:
-  metadata.gz: f95fdd89b84dad02e516ee0479b1cddfb101cb96de897b6e7fa3fba546272a243cff5cfe954cb51942ec1ab23cf3028b183db86b52fab00a35d15be7eee5bf92
-  data.tar.gz: e5f6235e88dd47b9002a2154cabd2c1e64afb6cbb5b0745b411c7e5559351e925c9db8ec332724e301b83215662b3582e79a9e997f0338846514b234dabf1fc3
+  metadata.gz: bd1b318abc92366f00c9e4183948f712e56bc25887f4117b4577ea8673537b2ddc9f91ff2244dfec51a94f9f992c4aff8468aa11553eafcdaa6f38ffd6e7b67d
+  data.tar.gz: 13450117456e31acb930026ae1a0a22ad7608dea0aba410fd8e030891a336948a2269058b9c7dbd79c57328f9a96c246d9d6d1836c37a0f2981f6c10e1869641

data/.rubocop.yml

@@ -20,6 +20,9 @@ Layout/LineLength:
   Max: 145
   IgnoredPatterns: ['(\A|\s)#']
 
+Lint/ConstantDefinitionInBlock:
+  Enabled: false
+
 Lint/MissingSuper:
   Enabled: false
 
@@ -70,6 +73,9 @@ Style/StringConcatenation:
 RSpec/MultipleExpectations:
   Enabled: false
 
+RSpec/MultipleMemoizedHelpers:
+  Max: 25
+
 RSpec/NestedGroups:
   Max: 4
 
@@ -81,3 +87,6 @@ RSpec/InstanceVariable:
 
 RSpec/LeakyConstantDeclaration:
   Enabled: false
+
+Performance/Sum:
+  Enabled: false

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 0.20.3
+- Fix to use automatic solver of PCA in NeighbourhoodComponentAnalysis.
+- Refactor some codes with Rubocop.
+- Update README.
+
 # 0.20.2
 - Add cross-validator class for time-series data.
   - [TimeSeriesSplit](https://yoshoku.github.io/rumale/doc/Rumale/ModelSelection/TimeSeriesSplit.html)

data/Gemfile

@@ -11,3 +11,6 @@ gem 'parallel', '>= 1.17.0'
 gem 'rake', '~> 12.0'
 gem 'rake-compiler', '~> 1.0'
 gem 'rspec', '~> 3.0'
+gem 'rubocop', '~> 0.91'
+gem 'rubocop-performance', '~> 1.8'
+gem 'rubocop-rspec', '~> 1.43'

data/README.md

@@ -228,6 +228,10 @@ When -1 is given to n_jobs parameter, all processors are used.
 estimator = Rumale::Ensemble::RandomForestClassifier.new(n_jobs: -1, random_seed: 1)
 ```
 
+## Novelties
+
+* [Rumale SHOP](https://suzuri.jp/yoshoku)
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/yoshoku/rumale.

data/lib/rumale/clustering/snn.rb

@@ -51,7 +51,7 @@ module Rumale
       # @param x [Numo::DFloat] (shape: [n_samples, n_features]) The samples to be used for cluster analysis.
       #   If the metric is 'precomputed', x must be a square distance matrix (shape: [n_samples, n_samples]).
       # @return [Numo::Int32] (shape: [n_samples]) Predicted cluster label per sample.
-      def fit_predict(x)
+      def fit_predict(x) # rubocop:disable Lint/UselessMethodDefinition
         super
       end
 

data/lib/rumale/evaluation_measure/roc_auc.rb

@@ -75,9 +75,12 @@ module Rumale
         false_pos, true_pos, thresholds = binary_roc_curve(y_true, y_score, pos_label)
 
         if true_pos.size.zero? || false_pos[0] != 0 || true_pos[0] != 0
+          # NOTE: Numo::NArray#insert is not a destructive method.
+          # rubocop:disable Style/RedundantSelfAssignment
           true_pos = true_pos.insert(0, 0)
           false_pos = false_pos.insert(0, 0)
           thresholds = thresholds.insert(0, thresholds[0] + 1)
+          # rubocop:enable Style/RedundantSelfAssignment
         end
 
         tpr = true_pos / true_pos[-1].to_f

data/lib/rumale/metric_learning/neighbourhood_component_analysis.rb

@@ -112,7 +112,7 @@ module Rumale
 
       def init_components(x, n_features, n_components)
         if @params[:init] == 'pca'
-          pca = Rumale::Decomposition::PCA.new(n_components: n_components, solver: 'evd')
+          pca = Rumale::Decomposition::PCA.new(n_components: n_components)
           pca.fit(x).components.flatten.dup
         else
           Rumale::Utils.rand_normal([n_features, n_components], @rng.dup).flatten.dup

data/lib/rumale/pipeline/pipeline.rb

@@ -140,7 +140,7 @@ module Rumale
       def validate_steps(steps)
         steps.keys[0...-1].each do |name|
           transformer = steps[name]
-          next if transformer.nil? || %i[fit transform].all? { |m| transformer.class.method_defined?(m) }
+          next if transformer.nil? || (transformer.class.method_defined?(:fit) && transformer.class.method_defined?(:transform))
 
           raise TypeError,
                 'Class of intermediate step in pipeline should be implemented fit and transform methods: ' \

data/lib/rumale/tree/base_decision_tree.rb

@@ -75,17 +75,10 @@ module Rumale
         node = Node.new(depth: depth, impurity: impurity, n_samples: n_samples)
 
         # terminate growing.
-        unless @params[:max_leaf_nodes].nil?
-          return nil if @n_leaves >= @params[:max_leaf_nodes]
-        end
-
+        return nil if !@params[:max_leaf_nodes].nil? && @n_leaves >= @params[:max_leaf_nodes]
         return nil if n_samples < @params[:min_samples_leaf]
         return put_leaf(node, y) if n_samples == @params[:min_samples_leaf]
-
-        unless @params[:max_depth].nil?
-          return put_leaf(node, y) if depth == @params[:max_depth]
-        end
-
+        return put_leaf(node, y) if !@params[:max_depth].nil? && depth == @params[:max_depth]
         return put_leaf(node, y) if stop_growing?(y)
 
         # calculate optimal parameters.

data/lib/rumale/tree/gradient_tree_regressor.rb

@@ -138,7 +138,7 @@ module Rumale
         nil
       end
 
-      def grow_node(depth, x, y, g, h)
+      def grow_node(depth, x, y, g, h) # rubocop:disable Metrics/AbcSize
         # intialize some variables.
         sum_g = g.sum
         sum_h = h.sum
@@ -146,17 +146,10 @@ module Rumale
         node = Node.new(depth: depth, n_samples: n_samples)
 
         # terminate growing.
-        unless @params[:max_leaf_nodes].nil?
-          return nil if @n_leaves >= @params[:max_leaf_nodes]
-        end
-
+        return nil if !@params[:max_leaf_nodes].nil? && @n_leaves >= @params[:max_leaf_nodes]
         return nil if n_samples < @params[:min_samples_leaf]
         return put_leaf(node, sum_g, sum_h) if n_samples == @params[:min_samples_leaf]
-
-        unless @params[:max_depth].nil?
-          return put_leaf(node, sum_g, sum_h) if depth == @params[:max_depth]
-        end
-
+        return put_leaf(node, sum_g, sum_h) if !@params[:max_depth].nil? && depth == @params[:max_depth]
         return put_leaf(node, sum_g, sum_h) if stop_growing?(y)
 
         # calculate optimal parameters.

data/lib/rumale/version.rb

@@ -3,5 +3,5 @@
 # Rumale is a machine learning library in Ruby.
 module Rumale
   # The version of Rumale you are using.
-  VERSION = '0.20.2'
+  VERSION = '0.20.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rumale
 version: !ruby/object:Gem::Version
-  version: 0.20.2
+  version: 0.20.3
 platform: ruby
 authors:
 - yoshoku
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-09-05 00:00:00.000000000 Z
+date: 2020-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: numo-narray