rulethu_stock_exchange 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0dc271fa578eb41d6b0dd67f8cdc82eddc52a9168e0b8f366e66793ed4304af
-  data.tar.gz: '09806e50ef484e84efc7f05044844dc260c82e69368a24f8689e838ec909e884'
+  metadata.gz: 8e2e09b5387087ac9abfb3fea2dda21cb983328fcefe63233543ba22797ff244
+  data.tar.gz: 0a51aca05580cac8ff1f555b0b31de12ad3c8f1526b147a6f66d01530a8fe36b
 SHA512:
-  metadata.gz: 66394403e7cb1219331e9231c7060f0b9733a1c16f76d4f11c19d58c44f1e95570227836dd9ed168089a66892633c4e2afccb008d43f0c5ab616a32313c9689e
-  data.tar.gz: d8c01ffb3e7ebebeb91e31dd36dfd21e93ae29d7fe875f6fb5734a2a9674417558c0861f99fbbc57744969904194e84518be0baa01395937d9df54ff7a427fc0
+  metadata.gz: cc72e015dd2e3ca7450be928e323d12e48ded2807767fdbf4ed63ac6036834e6998e5bef1dbc1228d048cb5b3c1175a803101adb29b65bbc7b03e20ed5cae3a6
+  data.tar.gz: b8ea28ad59be15ccd1f864e0d6f49b25ec57650a37a5eee2ea08babf110b47d573e2226785b69a16d6c5d30023706c2b374d1d9eb7d2ca95023dee699e80a212

data/README.md

@@ -1,10 +1,10 @@
 # RulethuStockExchange
 
 This gem allows you to scrape stock exchange data from the following exchanges:
-* Zimbabwe Stock Exchange (ZSE)
-* Johannesburg Stock Exchange (JSE)
-* London Stock Exchange (LSE)
 
+- Zimbabwe Stock Exchange (ZSE)
+- Johannesburg Stock Exchange (JSE)
+- London Stock Exchange (LSE)
 
 ## Installation
 
@@ -18,8 +18,12 @@ If bundler is not being used to manage dependencies, install the gem by executin
 
 ## Usage
 
-### Example 1: Scraping Data From London Stock Exchange 
+** Make sure you have firefox browser installed **
+
+### Example 1: Scraping Data From London Stock Exchange
+
 Require the gem
+
 ```ruby
 require 'rulethu_stock_exchange'
 ```
@@ -29,32 +33,39 @@ Get the stock exchange. (Currently available stock exchanges are ZSE, JSE and LS
 ```ruby
 exchange = RulethuStockExchange::Exchanges::LSE
 ```
+
 Create a Scraper passing in the url for the exchangew
+
 ```ruby
 scraper = RulethuStockExchange::Scraper.new exchange[:url]
 ```
 
 Scrape the data passing in a selector
+
 ```ruby
 html = scraper.scrape exchange[:selector]
 ```
 
 Create a parser to parse the data
+
 ```ruby
-parser = RulethuStockExchange::Parser.new html 
+parser = RulethuStockExchange::Parser.new html
 ```
 
 Parse the data
+
 ```ruby
-data = parser.parse() 
+data = parser.parse()
 ```
 
 Write the data to JSON file
+
 ```ruby
 filename = RulethuStockExchange::IO.write_to_json_file data, 'lse'
 ```
 
 Convert the JSON file to CSV
+
 ```ruby
 RulethuStockExchange::IO.json_to_csv filename
 ```

data/lib/rulethu_stock_exchange/io.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
-require 'json'
-require 'csv'
-require 'time'
+require "json"
+require "csv"
+require "time"
 
 module RulethuStockExchange
   class IO
@@ -10,8 +10,8 @@ module RulethuStockExchange
       date = Time.now.strftime("%d-%m-%Y")
       data_dir = Pathname.new("data") / Pathname.new(prefix)
       data_dir.mkpath
-      filename = "#{data_dir}/#{date}-data.json"
-      File.open(filename, 'w') do |f|
+      filename = "#{data_dir}/#{prefix}-#{date}-data.json"
+      File.open(filename, "w") do |f|
         f.write(JSON.dump(data))
       end
       filename
@@ -20,13 +20,13 @@ module RulethuStockExchange
     def self.json_to_csv(json_file)
       puts "\nConverting #{json_file} to CSV"
       data = Object.new
-      File.open(json_file, 'r') do |f|
+      File.open(json_file, "r") do |f|
         data = JSON.parse(f.read)
       end
 
-      filename = json_file.sub(/\.json$/, '.csv')
+      filename = json_file.sub(/\.json$/, ".csv")
 
-      CSV.open(filename, 'w') do |csv|
+      CSV.open(filename, "w") do |csv|
         csv << data.first.keys
         data.each do |row|
           csv << row.values

data/lib/rulethu_stock_exchange/parser.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-require 'selenium-webdriver'
+require "selenium-webdriver"
 
 module RulethuStockExchange
   class Parser
@@ -10,39 +10,39 @@ module RulethuStockExchange
     end
 
     def parse_zse
-      tbody = table.find_element(:tag_name, 'tbody')
-      rows = tbody.find_elements(:tag_name, 'tr')
-      body_data = []
-      puts "\nWriting body data"
+      tbody = table.find_element(:tag_name, "tbody")
+      rows = tbody.find_elements(:tag_name, "tr")
+      data_rows = []
       rows.each do |row|
-        cells = row.find_elements(:tag_name, 'td')
-        cells.each do |cell|
-          body_data << cell.text.strip
-        end
+        text = row.find_elements(:tag_name, "td").first.text.strip
+        data_rows << row unless text.empty?
       end
-      data = body_data.reject(&:empty?)
-      header_data = data[1..4].map { |d| d.gsub("\n", " ") }
-      remaining_data = data[5..]
-      grouped_data = remaining_data.each_slice(4).to_a
-      data = grouped_data.reject { |row| row.first.match?(/^[-+]?\d+(\.\d+)?$/) }
-      data = data[0...-1]
-      output = []
-      data.each do |row|
-        result = {}
-        row.each_with_index do |value, index|
-          result[header_data[index]] = value
+
+      header_data = []
+      rows[0].find_elements(:tag_name, "td").each do |td|
+        text = td.text.strip.gsub("\n", " ") || "#"
+        text = "#" if text.empty?
+        header_data << text
+      end
+
+      data = []
+      data_rows.each do |row|
+        row_data = {}
+        cells = row.find_elements :tag_name, "td"
+        cells.each_with_index do |cell, index|
+          key = header_data[index] || "#"
+          row_data[key] = cell.text.strip
         end
-        output << result
-        print "."
+        data << row_data
       end
-      output
+      data
     end
 
     def parse
       header_data = []
       begin
         thead = table.find_element(:tag_name, "thead")
-        cells = thead.find_element(:tag_name, "tr").find_elements(:tag_name, 'th')
+        cells = thead.find_element(:tag_name, "tr").find_elements(:tag_name, "th")
         puts "Writing header data"
         cells.each do |cell|
           header_data << cell.text
@@ -52,12 +52,12 @@ module RulethuStockExchange
         # Handle missing header gracefully (e.g., log the error)
       end
       tbody = table.find_element(:tag_name, "tbody")
-      rows = tbody.find_elements(:tag_name, 'tr')
+      rows = tbody.find_elements(:tag_name, "tr")
       body_data = []
       puts "\nWriting body data"
       rows.each do |row|
         data = {}
-        cells = row.find_elements(:tag_name, 'td')
+        cells = row.find_elements(:tag_name, "td")
         if header_data.empty?
           header_data = cells.map(&:text)
         end

data/lib/rulethu_stock_exchange/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RulethuStockExchange
-  VERSION = "0.1.6"
+  VERSION = "0.1.7"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rulethu_stock_exchange
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Blessed Sibanda
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-04-11 00:00:00.000000000 Z
+date: 2024-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver