ruleby 0.8.b2 → 0.8.b4

data/lib/core/engine.rb

@@ -187,6 +187,16 @@ module Ruleby
     end
   end
 
+  class Error
+    attr_reader :type, :level, :details
+
+    def initialize(type, level, details={})
+      @type = type
+      @details = details
+      @level = level
+    end
+  end
+
   # This is the core class of the library.  A new rule engine is created by 
   # instantiating it.  Each rule engine has one inference engine, one rule set
   # and one working memory.
@@ -255,7 +265,13 @@ module Ruleby
         end
       end
     end
-    
+
+    def extract_errors
+      e = @root.errors
+      @root.clear_errors
+      e
+    end
+
     def print
       @working_memory.print
       @root.print

data/lib/core/nodes.rb

@@ -10,7 +10,7 @@
 #
 
 module Ruleby
-  module Core 
+  module Core
 
   # This class acts as the root-node of the network.  It contains the logic
   # for building the node-network from a set of rules, and updating it
@@ -23,13 +23,14 @@ module Ruleby
       @atom_nodes = [] 
       @join_nodes = []
       @terminal_nodes = []
+      @bucket = NetworkBucket.new
     end
   
     # This method is invoked when a new rule is added to the system.  The
     # rule is processed and the appropriate nodes are added to the network.
     def assert_rule(rule)
-      terminal_node = TerminalNode.new rule  
-      build_network(rule.pattern, terminal_node)             
+      terminal_node = TerminalNode.new @bucket, rule
+      build_network(rule.pattern, terminal_node)
       @terminal_nodes.push terminal_node
     end    
             
@@ -44,15 +45,23 @@ module Ruleby
     end
         
     # Increments the activation counter.  This is just a pass-thru to the static 
-    # variable in the terminal node
+    # variable in the bucket
     def increment_counter
-      TerminalNode.increment_counter
+      @bucket.increment_counter
     end
     
     # Resets the activation counter.  This is just a pass-thru to the static 
-    # variable in the terminal node
+    # variable in the bucket
     def reset_counter
-      TerminalNode.reset_counter
+      @bucket.reset_counter
+    end
+
+    def errors
+      @bucket.errors
+    end
+
+    def clear_errors
+      @bucket.clear_errors
     end
   
     # When invoked, this method returns a list of all Action|MatchContext pairs 
@@ -170,9 +179,9 @@ module Ruleby
       #   side - if the out_node is a JoinNode, this marks the side 
       def create_join_node(pattern, out_node, side)      
         if (pattern.right_pattern.kind_of?(NotPattern))  
-          join_node = NotNode.new 
+          join_node = NotNode.new(@bucket)
         else
-          join_node = JoinNode.new    
+          join_node = JoinNode.new(@bucket)
         end
         
         @join_nodes.push(join_node)      
@@ -188,49 +197,49 @@ module Ruleby
       
       def create_type_node(pattern)
         if InheritsPattern === pattern
-          node = InheritsNode.new pattern.atoms[0]
+          node = InheritsNode.new(@bucket, pattern.atoms[0])
           @inherit_nodes.each do |inode|
             return inode if inode.shareable? node
           end
           @inherit_nodes << node
           return node
         else
-          return (@type_node ||= TypeNode.new pattern.atoms[0])
+          return (@type_node ||= TypeNode.new(@bucket, pattern.atoms[0]))
         end
       end
       
       def create_bridge_node(pattern)
         if pattern.kind_of?(CollectPattern)
-          CollectNode.new(pattern)
+          CollectNode.new(@bucket, pattern)
         else
-          BridgeNode.new(pattern)
+          BridgeNode.new(@bucket, pattern)
         end
       end
       
       def create_property_node(atom,forked)
-        node = atom.kind_of?(EqualsAtom) ? EqualsNode.new(atom) : PropertyNode.new(atom)
+        node = atom.kind_of?(EqualsAtom) ? EqualsNode.new(@bucket, atom) : PropertyNode.new(@bucket, atom)
         @atom_nodes.each {|n| return n if n.shareable? node} unless forked
         @atom_nodes.push node
         return node
       end
       
       def create_self_reference_node(atom)   
-        node = SelfReferenceNode.new atom
+        node = SelfReferenceNode.new(@bucket, atom)
         @atom_nodes.push node
         return node
       end
       
       def create_reference_node(atom)      
-        node = ReferenceNode.new atom
+        node = ReferenceNode.new(@bucket, atom)
         @atom_nodes.push node
         return node
       end
       
       def create_adapter_node(side)
         if side == :left
-          return LeftAdapterNode.new
+          return LeftAdapterNode.new(@bucket)
         else
-          return RightAdapterNode.new
+          return RightAdapterNode.new(@bucket)
         end
       end
       
@@ -267,7 +276,12 @@ module Ruleby
   
   # Base Node class used by all nodes in the network that do some kind 
   # of matching.
-  class Node < Printable       
+  class Node < Printable
+    def initialize(bucket)
+      super()
+      @bucket = bucket
+    end
+
     # This method determines if all common tags have equal values.  If any 
     # values are not equal then the method returns false.
     def resolve(mr1, mr2)    
@@ -287,7 +301,7 @@ module Ruleby
   # propagating match results.
   class ParentNode < Node    
     attr_reader :child_nodes
-    def initialize()
+    def initialize(bucket)
       super
       @out_nodes = []   
     end   
@@ -307,22 +321,28 @@ module Ruleby
     
     def retract(fact)
       propagate_retract(fact)
-    end    
-    
-    def propagate_retract(fact,out_nodes=@out_nodes)
+    end
+
+    def propagate(propagation_method, object_to_propagate, out_nodes=@out_nodes)
       out_nodes.each do |out_node|
-        out_node.retract(fact)
+        begin
+          out_node.send(propagation_method, object_to_propagate)
+        rescue => e
+          @bucket.add_error Error.new(:unknown, :error, {:type => e.class, :message => e.message})
+        end
       end
     end
     
+    def propagate_retract(fact,out_nodes=@out_nodes)
+      propagate(:retract, fact, out_nodes)
+    end
+    
     def assert(assertable)
       propagate_assert(assertable)
     end
     
     def propagate_assert(assertable,out_nodes=@out_nodes)
-      out_nodes.each do |out_node|
-        out_node.assert(assertable)
-      end
+      propagate(:assert, assertable, out_nodes)
     end
 
     def modify(assertable)
@@ -330,9 +350,7 @@ module Ruleby
     end
 
     def propagate_modify(assertable,out_nodes=@out_nodes)
-      out_nodes.each do |out_node|
-        out_node.modify(assertable)
-      end
+      propagate(:modify, assertable, out_nodes)
     end
   end
   
@@ -341,8 +359,8 @@ module Ruleby
   # up the Alpha network.
   class AtomNode < ParentNode  
     attr_reader:atom    
-    def initialize(atom)
-      super()
+    def initialize(bucket, atom)
+      super(bucket)
       @atom = atom 
     end
     
@@ -363,7 +381,7 @@ module Ruleby
   # that inherits this class does not evaluate each condition, instead it looks
   # up the expected value in the hash, and gets a list of out_nodes.
   class HashedNode < AtomNode
-    def initialize(atom)
+    def initialize(bucket, atom)
       super
       @values = {}
       @values.default = []
@@ -393,10 +411,13 @@ module Ruleby
     
     def assert(fact)     
       k = fact.object.send(@atom.method)
-      propagate_assert fact, @values[k] 
+      propagate_assert fact, @values[k]
     rescue NoMethodError => e
-      # If the method does not exist, it is the same as if it evaluted to 
-      # false, and the network traverse stops
+      @bucket.add_error Error.new(:no_method, :warn, {
+          :object => fact.object.to_s,
+          :method => e.name,
+          :message => e.message
+      })
     end
   end
   
@@ -422,23 +443,28 @@ module Ruleby
   class PropertyNode < AtomNode
     def assert(fact)
       begin
-        val = fact.object.send(@atom.method)   
+        val = fact.object.send(@atom.method)
       rescue NoMethodError => e
-        # If the method does not exist, it is the same as if it evaluted to 
-        # false, and the network traverse stops
+        @bucket.add_error Error.new(:no_method, :warn, {
+            :object => fact.object.to_s,
+            :method => e.name,
+            :message => e.message
+        })
         return
       end
       begin
         super if @atom.proc.call(val)
       rescue Exception => e
-        # There is a bug in Ruby MRI that goes away when we call print.  Even if the following
-        # line of code is never executed at runtime.  The problem does not exist in JRuby
-        print ''
-        raise ProcessInvocationError.new(e), e.message
+        @bucket.add_error Error.new(:proc_call, :error, {
+            :object => fact.object.to_s,
+            :method => @atom.method,
+            :value => val.to_s,
+            :message => e.message
+        })
       end
     end
   end
-  
+
   # This node class is used for matching properties of a fact where the 
   # condition is a simple '=='.  Instead of evaluating the condition, this node
   # will pull from a hash.  This makes it significatly fast when it is shared.
@@ -469,9 +495,14 @@ module Ruleby
           m.variables[@atom.tag] = val 
           return m
         end
-      rescue NoMethodError => e    
-        # If the method does not exist, it is the same as if it evaluted to 
-        # false, and the network traverse stops
+      rescue NoMethodError => e
+        # I'd rather push this up to a high level, but its got to happen down low
+        @bucket.add_error Error.new(:no_method, :warn, {
+            :object => "?",
+            :method => e.name,
+            :args => e.args,
+            :message => e.message
+        })
       end
       return MatchResult.new
     end  
@@ -498,8 +529,8 @@ module Ruleby
   # pattern and atoms above it in the network.  Thus, there is one bridge node
   # for each pattern (assuming they aren't shared).
   class BaseBridgeNode < ParentNode
-    def initialize(pattern)
-      super()
+    def initialize(bucket, pattern)
+      super(bucket)
       @pattern =  pattern
     end
   end
@@ -524,7 +555,7 @@ module Ruleby
   end
 
   class CollectNode < BaseBridgeNode
-    def initialize(pattern)
+    def initialize(bucket, pattern)
       super
       @collection_memory = Fact.new([], :internal)
       @should_modify = false
@@ -581,27 +612,19 @@ module Ruleby
   # This class is used to plug nodes into the left input of a two-input JoinNode
   class LeftAdapterNode < ParentNode
     def propagate_assert(context)
-      @out_nodes.each do |out_node|
-        out_node.assert_left(context)
-      end
+      propagate(:assert_left, context)
     end
     
     def propagate_retract(fact)
-      @out_nodes.each do |out_node|
-        out_node.retract_left(fact)
-      end
+      propagate(:retract_left, fact)
     end
     
     def retract_resolve(match)
-      @out_nodes.each do |o|
-        o.retract_resolve(match)
-      end
+      propagate(:retract_resolve, match)
     end
 
     def modify(context)
-      @out_nodes.each do |out_node|
-        out_node.modify_left(context)
-      end
+      propagate(:modify_left, context)
     end
   end
   
@@ -609,27 +632,19 @@ module Ruleby
   # JoinNode
   class RightAdapterNode < ParentNode    
     def propagate_assert(context)
-      @out_nodes.each do |out_node|
-        out_node.assert_right(context)
-      end
+      propagate(:assert_right, context)
     end
-  
+
     def propagate_retract(fact)
-      @out_nodes.each do |out_node|
-        out_node.retract_right(fact)
-      end
-    end  
-      
+      propagate(:retract_right, fact)
+    end
+
     def retract_resolve(match)
-      @out_nodes.each do |o|
-        o.retract_resolve(match)
-      end
+      propagate(:retract_resolve, match)
     end
 
     def modify(context)
-      @out_nodes.each do |out_node|
-        out_node.modify_right(context)
-      end
+      propagate(:modify_right, context)
     end
   end
 
@@ -641,7 +656,7 @@ module Ruleby
     
     attr:ref_nodes,true
     
-    def initialize
+    def initialize(bucket)
       super
       @left_memory = {}
       @right_memory = {} 
@@ -743,9 +758,7 @@ module Ruleby
       end
       
       def propagate_retract_resolve(match)
-        @out_nodes.each do |o|
-          o.retract_resolve(match)
-        end
+        propagate(:retract_resolve, match)
       end
   end
   
@@ -753,7 +766,7 @@ module Ruleby
   # exist.  It is a two-input node, and thus has some of the properties of the
   # JoinNode.
   class NotNode < JoinNode
-    def initialize
+    def initialize(bucket)
       super
     end
     
@@ -831,10 +844,9 @@ module Ruleby
   # for a rule.  The class is responsible for keeping a memory of the 
   # activations that have been generated by the network.
   class TerminalNode < Node
-    @@counter = 0
-  
-    def initialize(rule)
-      super()
+
+    def initialize(bucket, rule)
+      super(bucket)
       @rule = rule
       @activations = MultiHash.new  
     end
@@ -846,7 +858,7 @@ module Ruleby
 
     def assert(context)
       match = context.match
-      a = Activation.new(@rule.action, match, @@counter)
+      a = Activation.new(@rule.action, match, @bucket.counter)
       @activations.add match.fact_ids, a
     end
 
@@ -883,14 +895,34 @@ module Ruleby
       @activations.delete_if do |activation|
         resolve(activation.match, match)
       end
-    end    
-    
-    def self.increment_counter
-      @@counter = @@counter + 1
     end
-    
-    def self.reset_counter
-      @@counter = 0
+  end
+
+  private
+
+  # an instance of this class hangs on to state that is global to the network
+  class NetworkBucket
+    attr_reader :errors, :counter
+
+    def initialize
+      clear_errors
+      reset_counter
+    end
+
+    def increment_counter
+      @counter += 1
+    end
+
+    def reset_counter
+      @counter = 0
+    end
+
+    def add_error(error)
+      @errors << error
+    end
+
+    def clear_errors
+      @errors = []
     end
   end
 

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
     - 0
     - 8
-    - b2
-  version: 0.8.b2
+    - b4
+  version: 0.8.b4
 platform: ruby
 authors: 
   - Joe Kutner
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-07 00:00:00 -05:00
+date: 2011-04-12 00:00:00 -05:00
 default_executable: 
 dependencies: []