rule-interface 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: df48071317f3e7c2a3658336622f33eeeff83d5f
-  data.tar.gz: cbbed253c8c4b3c89058b319dbca309151ff94c0
+  metadata.gz: 524f8431dd91bd47d798334f77bed731e5525072
+  data.tar.gz: 3c64436cf12b292c4c4da96b13f17f58ecb2a847
 SHA512:
-  metadata.gz: 04730760cc896899e398580baa989e6c9ef1c9cb2eeec8e2c1700237b05418e6d1e99bad914b32021f53813da1235d9f7e65de0c7ec887a3b2a88d4a1428a16d
-  data.tar.gz: beb1f891b323850b2ebdff4158e9de63d896e12113942ce6886975e7b13afb7bec2b3371abcbf40678cb31b790781d6d4a76697dd194dd268fd38cf7febdd8b4
+  metadata.gz: 3fff9269d46e83c0e95ae22418d2c0370f1ff9bb1563b2d19331236f573450460585f0ff5766e7ea0548d00c97b58e083180342eaa6957c0bb1d7434ee4a8990
+  data.tar.gz: eba32c7218cb1e4a5ed1a3807501a5e5fe0afff65932e58995b0f0ab89c5710d274272d6b08b9c67c3853cbdc3722914d8e5f085cfd85705f9a258c991f6db9d

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rule-interface (1.0.0)
+    rule-interface (1.0.2)
       activesupport (~> 3)
       rest-client (~> 1)
 

data/README.md

@@ -20,10 +20,28 @@ Or install it yourself as:
 
     $ gem install rule-interface
 
-## Usage
+## Configuration
+
+ENV variable can be used to configure KIE server details
+
+`KIE_SERVER_USERNAME`, `KIE_SERVER_PASSWORD`, `KIE_SERVER_HOSTNAME`
 
+You can also configure the KIE server details programmatically
+
+```ruby
+RuleInterface::Configuration::kiesever_config = {
+  username: 'blah',
+  password: 'blah',
+  hostname: 'http://url',
+}
 ```
-RuleExecutor.execute!(
+
+All the attribute specified in the above configuration is optional. If specified, it will overwrite ENV configuration for that attribute
+
+## Usage
+
+```ruby
+RuleInterface.execute!(
   data_hash: {
     product: [
       {

data/lib/rule-interface/configuartion.rb

@@ -3,15 +3,31 @@ module RuleInterface
 
     class << self
 
-      #ex - {:username=>"kieserver", :password=>"kieserver1!", :hostname=>"http://rule-engine-..."}
+      # eg: {
+      #     username: 'blah',
+      #     password: 'blah',
+      #     hostname: 'http://url'
+      #}
       def kiesever_config=(config)
+        @cached = false
         @kiesever_config = config
       end
 
       def kiesever_config
-        unless defined? @kiesever_config && @kiesever_config.present?
-          raise Error::CommonError, 'Configuration for rule engine is not yet set'
-        end
+        return @kiesever_config if @cached
+
+        @kiesever_config ||= {}
+
+        @kiesever_config[:username] ||= ENV['KIE_SERVER_USERNAME'].presence
+        @kiesever_config[:password] ||= ENV['KIE_SERVER_PASSWORD'].presence
+        @kiesever_config[:hostname] ||= ENV['KIE_SERVER_HOSTNAME'].presence
+
+        raise Error::ConfigError, 'KIE server username missing' if @kiesever_config[:username].blank?
+        raise Error::ConfigError, 'KIE server password missing' if @kiesever_config[:password].blank?
+        raise Error::ConfigError, 'KIE server hostname missing' if @kiesever_config[:hostname].blank?
+
+        @cached = true
+
         @kiesever_config
       end
 

data/lib/rule-interface/converter.rb

@@ -43,6 +43,10 @@ module RuleInterface
     private
 
     def insert_object(data_object:, object_type:, package:, return_object: true)
+      if return_object && data_object[:id].blank?
+        raise Error::CommonError, "Object must have an id attribute: #{data_object.to_json}"
+      end
+
       data_object = data_object.inject({}) do |m, (k,v)|
         m[k.to_s.camelize(:lower).to_sym] = v; m
       end
@@ -51,7 +55,7 @@ module RuleInterface
       insert_object = {}
       insert_object[:insert] = {}
       insert_object[:insert]['return-object'] = return_object
-      insert_object[:insert]['out-identifier'] = "#{object_type}_#{data_object[:id]}" if return_object
+      insert_object[:insert]['out-identifier'] = "#{object_type}##{data_object[:id]}" if return_object
 
       object = {}
       object_name = "#{package}.#{object_type}"

data/lib/rule-interface/{errors.rb → error.rb}

@@ -4,5 +4,7 @@ module RuleInterface
     class Base < StandardError; end
 
     class CommonError < Base; end
+
+    class ConfigError < Base; end
   end
 end

data/lib/rule-interface/version.rb

@@ -1,3 +1,3 @@
 module RuleInterface
-  VERSION = '1.0.1'.freeze
+  VERSION = '1.0.2'.freeze
 end

data/rule-interface.gemspec

@@ -5,7 +5,6 @@ require 'rule-interface/version'
 Gem::Specification.new do |s|
   s.name          = "rule-interface"
   s.version       = RuleInterface::VERSION
-  s.date          = '2017-11-27'
   s.authors       = ['Ranveer']
   s.email         = ['ranveernitk@gmail.com', 'tech_team@nestaway.com']
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rule-interface
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Ranveer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-27 00:00:00.000000000 Z
+date: 2017-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -132,7 +132,7 @@ files:
 - lib/rule-interface.rb
 - lib/rule-interface/configuartion.rb
 - lib/rule-interface/converter.rb
-- lib/rule-interface/errors.rb
+- lib/rule-interface/error.rb
 - lib/rule-interface/rule_executor.rb
 - lib/rule-interface/version.rb
 - rule-interface.gemspec