rugalytics 0.0.5 → 0.0.6

data/CHANGELOG

@@ -1,3 +1,5 @@
+v0.0.6. fixed report date parsing bug reported by masolino
+
 v0.0.5. report names are now methods that can be called on profile, load_report is deprecated
 
 v0.0.4. fix for HTML and URL changes at Google Analytics site

data/lib/rugalytics/report.rb

@@ -42,9 +42,17 @@ module Rugalytics
     def set_attributes lines
       @base_url = lines[1]
       @report_name = lines[2].chomp(',')
-      dates = lines[3].split(',')
-      @start_date = Date.parse(dates[0])
-      @end_date = Date.parse(dates[1])
+      dates = lines[3].include?('","') ? lines[3].split('","') : lines[3].split(',')
+      @start_date = parse_date(dates[0])
+      @end_date = parse_date(dates[1])
+    end
+
+    def parse_date text
+      begin
+        Date.parse(text)
+      rescue Exception => e
+        raise "#{e}: #{text}"
+      end
     end
 
     def handle_graphs lines

data/lib/rugalytics.rb

@@ -11,7 +11,7 @@ require 'yaml'
 
 # See README for usage documentation.
 module Rugalytics
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 
   FORMAT_PDF = '0' unless defined? FORMAT_PDF
   FORMAT_XML = '1' unless defined? FORMAT_XML

data/rugalytics.gemspec

@@ -1,18 +1,18 @@
 
-# Gem::Specification for Rugalytics-0.0.5
+# Gem::Specification for Rugalytics-0.0.6
 # Originally generated by Echoe
 
 --- !ruby/object:Gem::Specification 
 name: rugalytics
 version: !ruby/object:Gem::Version 
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors: 
 - Rob McKinnon
 autorequire: 
 bindir: bin
 
-date: 2008-08-03 00:00:00 +01:00
+date: 2008-08-04 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 

data/spec/lib/rugalytics/report_spec.rb

@@ -7,7 +7,7 @@ describe Rugalytics::Report do
     describe "when setting report attributes" do
       before :all do
         csv = %Q|# ----------------------------------------
-theyworkforyou.co.nz
+your_site.com
 Top Content,
 26 May 2008,31 May 2008
 # ----------------------------------------|
@@ -15,7 +15,7 @@ Top Content,
       end
 
       it "should set base url from second line of text" do
-        @report.base_url.should == 'theyworkforyou.co.nz'
+        @report.base_url.should == 'your_site.com'
       end
 
       it "should set report name from third line of text" do
@@ -31,9 +31,38 @@ Top Content,
       end
     end
 
+    describe "when setting report dates" do
+      describe "with source date format 'Month Day, Year'" do
+        before :all do
+          csv = %Q|# ----------------------------------------
+your_site.com
+Top Content,
+"July 28, 2008","August 4, 2008"
+# ----------------------------------------|
+          @report = Rugalytics::Report.new(csv)
+        end
+        it "should set start date from fourth line of text" do
+          @report.start_date.should == Date.parse('28 July 2008')
+        end
+        it "should set end date from fourth line of text" do
+          @report.end_date.should == Date.parse('4 August 2008')
+        end
+      end
+      describe "with dates badly formatted" do
+        it 'should raise an exception' do
+          csv = %Q|# ----------------------------------------
+your_site.com
+Top Content,
+random something
+# ----------------------------------------|
+          lambda { Rugalytics::Report.new(csv) }.should raise_error(Exception, 'invalid date: random something')
+        end
+      end
+    end
+
     describe "when creating items from 'Table'" do
       before :all do
-        @base_url = %Q|theyworkforyou.co.nz|
+        @base_url = %Q|your_site.com|
         @attributes = %Q|URL,Page Views,Unique Page Views,Time on Page,Bounce Rate,% Exit,$ Index|
         @values1 = %Q|/,189,157,54.94957983193277,0.4862385392189026,0.37037035822868347,0.0|
         @values2 = %Q|/bills,60,38,54.17307692307692,0.0,0.13333334028720856,0.0|
@@ -65,7 +94,7 @@ Top Content,
 
     describe "when creating items from '.*MiniTableTable'" do
       before :all do
-        @base_url = %Q|theyworkforyou.co.nz|
+        @base_url = %Q|your_site.com|
         @browser_attributes = %Q|Browser,Visits,% visits|
         @browser_values = %Q|Firefox,1529,0.17185568809509277|
         @connection_speed_attributes = %Q|Connection Speed,Visits,% visits|
@@ -108,7 +137,7 @@ Visitors Overview,
         @start = %Q|26 May 2008|
         @end = %Q|31 May 2008|
         @csv = %Q|# ----------------------------------------
-theyworkforyou.co.nz
+your_site.com
 Top Content,
 #{@start},#{@end}
 # ----------------------------------------

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rugalytics
 version: !ruby/object:Gem::Version 
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors: 
 - Rob McKinnon
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-08-03 00:00:00 +01:00
+date: 2008-08-04 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency