rufus-scheduler 3.1.8 → 3.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fe6be00fcf61f4df224dfe810d39b370cd34dc70
-  data.tar.gz: 92527aec3d327a51f57f53bda26e369e247a33bf
+  metadata.gz: 03122e92f3b47a4af3d12b06762f5f4caa604341
+  data.tar.gz: 8db6b1570347d1ffa1871fe9d90163729fbf7516
 SHA512:
-  metadata.gz: 48531b28fdb9af27e37fd8f94188f0144d8542294e039df27c8c0476bfadb8a82f3623cf915e6ff1fe0e114675cd640697a4ad43e50cc9e423e70afe3626f6a9
-  data.tar.gz: 2bdaacf21eec775ce0a76208e8b1a1dc009c77717144d4897d79af8875915585dcf0d565363524dc27932388e12ac1de5c000f9e6775b511fe044d5d14f2b022
+  metadata.gz: 0bf2d0ab22e975dc6832fc651dd415708a998960b4b9503865fe560c9b78284b54ac2b5957d8c912d1415776898e211eb6fe6a56c456613df85f5b4afcf35e0f
+  data.tar.gz: 52b001210ccea2c628e4a95e2bde023725cbb1ce9ee78bd635cfedddafcbed9851abda8eb0edb46e5816ba7ddc80e55dae256588a6caf079f9ebd126d5dbd3c7

data/CHANGELOG.txt

@@ -2,6 +2,12 @@
 = rufus-scheduler CHANGELOG.txt
 
 
+== rufus-scheduler - 3.1.9    released 2015-11-12
+
+- fix potential RuntimeError in CronLine#prev_second,
+  by Alexandru https://github.com/alexandru-calinoiu
+
+
 == rufus-scheduler - 3.1.8    released 2015-11-10
 
 - stop jumping eagerly out of DST, fix for one hour jump when leaving DST

data/CREDITS.txt

@@ -4,6 +4,7 @@
 
 == Contributors
 
+- Calinoiu Alexandru Nicolae (https://github.com/alexandru-calinoiu) CronLine#prev_second fix
 - Alyssa Pohahau (https://github.com/alyssa) out of DST transition specs
 - Claude Vessaz (https://github.com/claudeatsafe) ack #unscheduled_at in #scheduled?
 - 김성식 (https://github.com/kssminus) job id uniqueness effort

data/lib/rufus/scheduler.rb

@@ -39,7 +39,7 @@ module Rufus
     require 'rufus/scheduler/job_array'
     require 'rufus/scheduler/locks'
 
-    VERSION = '3.1.8'
+    VERSION = '3.1.9'
 
     #
     # A common error class for rufus-scheduler

data/lib/rufus/scheduler/cronline.rb

@@ -286,6 +286,8 @@ class Rufus::Scheduler
 
       secs = toa(@seconds)
 
+      return time.sec + 60 - secs.last if time.sec < secs.first
+
       secs.pop while time.sec < secs.last
 
       time.sec - secs.last

data/spec/cronline_spec.rb

@@ -46,6 +46,9 @@ describe Rufus::Scheduler::CronLine do
   def ns(cronline, now)
     Rufus::Scheduler::CronLine.new(cronline).next_second(now)
   end
+  def ps(cronline, now)
+    Rufus::Scheduler::CronLine.new(cronline).prev_second(now)
+  end
 
   def match(line, time)
     expect(cl(line).matches?(time)).to eq(true)
@@ -472,6 +475,26 @@ describe Rufus::Scheduler::CronLine do
     end
   end
 
+  describe '#prev_second' do
+
+    it 'returns the time to the closest previous second' do
+
+      t = local(1970, 1, 1, 1, 1, 42)
+
+      expect(ps('35,44 * * * * *', t)).to eq(7)
+    end
+
+    context 'when time sec is lower then all cron seconds (gh-177)' do
+
+      it 'returns the time to the last second a minute before' do
+
+        t = local(1970, 1, 1, 1, 1, 42)
+
+        expect(ps('43,44 * * * * *', t)).to eq(58)
+      end
+    end
+  end
+
   describe '#previous_time' do
 
     it 'returns the previous time the cron should have triggered' do
@@ -489,6 +512,27 @@ describe Rufus::Scheduler::CronLine do
         pt('* * * * * sun', lo(1970, 1, 1))).to eq(lo(1969, 12, 28, 23, 59, 59))
     end
 
+    it 'jumps to the previous minute if necessary (gh-177)' do
+
+      t = local(1970, 12, 31, 1, 1, 0) # vanilla
+      expect(pt('43,44 * * * * *', t)).to eq(lo(1970, 12, 31, 1, 0, 44))
+
+      t = local(1970, 12, 31, 1, 1, 30) # 30 < 43 <---- here!
+      expect(pt('43,44 * * * * *', t)).to eq(lo(1970, 12, 31, 1, 0, 44))
+
+      t = local(1970, 12, 31, 1, 1, 43) # 43 <= 43 < 44
+      expect(pt('43,44 * * * * *', t)).to eq(lo(1970, 12, 31, 1, 0, 44))
+
+      t = local(1970, 12, 31, 1, 1, 44) # 44 <= 44
+      expect(pt('43,44 * * * * *', t)).to eq(lo(1970, 12, 31, 1, 1, 43))
+
+      t = local(1970, 12, 31, 1, 1, 59) # 44 < 59
+      expect(pt('43,44 * * * * *', t)).to eq(lo(1970, 12, 31, 1, 1, 44))
+
+      t = local(1970, 12, 31, 1, 1, 30) # a bigger jump
+      expect(pt('43,44 10 * * * *', t)).to eq(lo(1970, 12, 31, 0, 10, 44))
+    end
+
     # New York      EST: UTC-5
     # summer (dst)  EDT: UTC-4
 

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: rufus-scheduler
 version: !ruby/object:Gem::Version
-  version: 3.1.8
+  version: 3.1.9
 platform: ruby
 authors:
 - John Mettraux
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-09 00:00:00.000000000 Z
+date: 2015-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.13.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.13.0
 - !ruby/object:Gem::Dependency
   name: chronic
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: tzinfo
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: job scheduler for Ruby (at, cron, in and every jobs).
@@ -73,7 +73,14 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- CHANGELOG.txt
+- CREDITS.txt
+- LICENSE.txt
+- README.md
 - Rakefile
+- TODO.txt
+- lib/rufus-scheduler.rb
+- lib/rufus/scheduler.rb
 - lib/rufus/scheduler/cronline.rb
 - lib/rufus/scheduler/job_array.rb
 - lib/rufus/scheduler/jobs.rb
@@ -81,8 +88,7 @@ files:
 - lib/rufus/scheduler/util.rb
 - lib/rufus/scheduler/zones.rb
 - lib/rufus/scheduler/zotime.rb
-- lib/rufus/scheduler.rb
-- lib/rufus-scheduler.rb
+- rufus-scheduler.gemspec
 - spec/basics_spec.rb
 - spec/cronline_spec.rb
 - spec/error_spec.rb
@@ -108,13 +114,7 @@ files:
 - spec/spec_helper.rb
 - spec/threads_spec.rb
 - spec/zotime_spec.rb
-- rufus-scheduler.gemspec
-- CHANGELOG.txt
-- CREDITS.txt
-- LICENSE.txt
 - t.txt
-- TODO.txt
-- README.md
 homepage: http://github.com/jmettraux/rufus-scheduler
 licenses:
 - MIT
@@ -125,17 +125,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: rufus
-rubygems_version: 2.0.14
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: job scheduler for Ruby (at, cron, in and every jobs)