rufus-cloche 0.1.3 → 0.1.4

data/CHANGELOG.txt

@@ -2,6 +2,11 @@
 = rufus-cloche CHANGELOG.txt
 
 
+== rufus-cloche - 0.1.4    released 2009/12/14
+
+- ArgumentError raised in case of delete(doc) that has no _rev
+
+
 == rufus-cloche - 0.1.3    released 2009/12/10
 
 - added the :limit option to Cloche#get_many

data/lib/rufus/cloche.rb

@@ -57,7 +57,7 @@ module Rufus
       end
     end
 
-    VERSION = '0.1.3'
+    VERSION = '0.1.4'
 
     attr_reader :dir
 
@@ -135,6 +135,10 @@ module Rufus
     #
     def delete (doc)
 
+      drev = doc['_rev']
+
+      raise ArgumentError.new('cannot delete doc without _rev') unless drev
+
       type, key = doc['type'], doc['_id']
 
       lock(type, key) do |f|
@@ -142,7 +146,7 @@ module Rufus
         cur = do_get(f)
 
         return nil unless cur
-        return cur if cur['_rev'] != doc['_rev']
+        return cur if cur['_rev'] != drev
 
         begin
           File.delete(f.path)

data/test/test.rb

@@ -80,7 +80,7 @@ class ClocheTest < Test::Unit::TestCase
 
   def test_delete_missing
 
-    r = @c.delete({ '_id' => 'john', 'type' => 'person', 'eyes' => 'green' })
+    r = @c.delete({ '_id' => 'john', 'type' => 'person', 'eyes' => 'green', '_rev' => 7 })
 
     assert_not_nil r
   end
@@ -99,11 +99,18 @@ class ClocheTest < Test::Unit::TestCase
 
     @c.put({ '_id' => 'john', 'type' => 'person', 'eyes' => 'green' })
 
-    r = @c.delete({ '_id' => 'john', 'type' => 'person', 'eyes' => 'green' })
+    r = @c.delete({ '_id' => 'john', 'type' => 'person', 'eyes' => 'green', '_rev' => 9 })
 
     assert_not_nil r
   end
 
+  def test_delete_without_rev
+
+    assert_raise(ArgumentError) do
+      @c.delete({ '_id' => 'john', 'type' => 'person' })
+    end
+  end
+
   def test_get_many
 
     load_people

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rufus-cloche
 version: !ruby/object:Gem::Version 
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors: 
 - John Mettraux
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-12-10 00:00:00 +09:00
+date: 2009-12-14 00:00:00 +09:00
 default_executable: 
 dependencies: []