ruco 0.0.35 → 0.0.36

data/Readme.md

@@ -25,14 +25,18 @@ Customize
 
     # ~/.ruco.rb
     Ruco.configure do
-      # bind a key, you can use Integers and Symbols
-      # use "ruco --debug-keys foo" to see which keys are possible
-      # or have a look at lib/ruco/keyboard.rb
+      # bind a key
+      # - you can use Integers and Symbols
+      # - use "ruco --debug-keys foo" to see which keys are possible
+      # - have a look at lib/ruco/keyboard.rb
       bind(:"Ctrl+e") do
-        ask('delete ?') do |response|
-          if response or not response
-            editor.move(:to, 0, 0)
-            editor.delete(9999)
+        ask('foo') do |response|
+          if response == 'bar'
+            editor.insert('baz')
+          else
+            editor.move(:to, 0,0)
+            editor.delete(99999)
+            editor.insert('FAIL!')
           end
         end
       end
@@ -40,11 +44,11 @@ Customize
       # bind an existing action
       puts @actions.keys
 
-      bind(:"Ctrl+x", :quit)
-      bind(:"Ctrl+o", :save)
-      bind(:"Ctrl+k", :delete_line)
+      bind :"Ctrl+x", :quit
+      bind :"Ctrl+o", :save
+      bind :"Ctrl+k", :delete_line
 
-      # define a new action and bind it to multiple keys
+      # create reusable actions
       action(:first){ editor.move(:to_column, 0) }
       bind(:"Ctrl+a", :first)
       bind(:home, :first)
@@ -58,7 +62,6 @@ TIPS
 
 TODO
 =====
- - limit possible file size to e.g. 1MB (would hang/be too slow with big files)
  - find next (Alt+n)
  - add selection colors to forms in command_bar
  - session storage (stay at same line/column when reopening)

data/VERSION

@@ -1 +1 @@
-0.0.35
+0.0.36

data/lib/ruco/editor.rb

@@ -12,7 +12,15 @@ module Ruco
 
     def initialize(file, options)
       @file = file
+
+      # check for size (10000 lines * 100 chars should be enough for everybody !?)
+      if File.exist?(@file) and File.size(@file) > (1024 * 1024)
+        raise "#{@file} is larger than 1MB, did you really want to open that with Ruco?"
+      end
+
       content = (File.exist?(@file) ? File.read(@file) : '')
+
+      # check for tabs
       if content.include?("\t")
         if options[:convert_tabs]
           content.tabs_to_spaces!
@@ -20,6 +28,7 @@ module Ruco
           raise "#{@file} contains tabs.\nRuco atm does not support tabs, but will happily convert them to spaces if started with --convert-tabs or -c"
         end
       end
+
       @saved_content = content
       @text_area = EditorArea.new(content, options)
     end

data/ruco.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{ruco}
-  s.version = "0.0.35"
+  s.version = "0.0.36"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Michael Grosser"]

data/spec/ruco/editor_spec.rb

@@ -12,8 +12,11 @@ describe Ruco::Editor do
   end
 
   describe 'convert tabs' do
-    it "reads tab as spaces when option is set" do
+    before do
       write("\t\ta")
+    end
+
+    it "reads tab as spaces when option is set" do
       editor = Ruco::Editor.new(@file, :lines => 3, :columns => 5, :convert_tabs => true)
       editor.view.should == "    a\n\n\n"
     end
@@ -25,6 +28,23 @@ describe Ruco::Editor do
     end
   end
 
+  describe 'huge-files' do
+    it "does not try to open huge files" do
+      write('a'*(1024*1024 + 1))
+      lambda{
+        Ruco::Editor.new(@file, :lines => 3, :columns => 5)
+      }.should raise_error
+    end
+
+    it "opens large files and does not take forever" do
+      write('a'*(1024*1024))
+      Time.benchmark do
+        editor = Ruco::Editor.new(@file, :lines => 3, :columns => 5)
+        editor.view
+      end.should < 1
+    end
+  end
+
   describe :move do
     before do
       write("    \n    \n    ")
@@ -678,7 +698,7 @@ describe Ruco::Editor do
     end
   end
 
-  describe :changes? do
+  describe :modified? do
     it "is unchanged by default" do
       editor.modified?.should == false
     end

data/spec/spec_helper.rb

@@ -13,4 +13,12 @@ class Tempfile
     end
     result
   end
+end
+
+class Time
+  def self.benchmark
+    t = Time.now.to_f
+    yield
+    Time.now.to_f - t
+  end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: ruco
 version: !ruby/object:Gem::Version 
-  hash: 89
+  hash: 87
   prerelease: 
   segments: 
   - 0
   - 0
-  - 35
-  version: 0.0.35
+  - 36
+  version: 0.0.36
 platform: ruby
 authors: 
 - Michael Grosser