rubyredrick-ri_cal 0.7.4 → 0.7.5

data/History.txt

@@ -1,36 +1,43 @@
+=== 0.7.5 - 3 August 2009
+   - fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/19
+      Microsoft ical exports double quote tzid values in parameters, which caused a failure to find VTIMEZONES
+      This exposed an issue with parameter parsing.  Did the simplest thing which could work which was to
+      strip the quotes.  Need to BOLO for other pathological cases showing up in future, which may require
+      smarter parameter parsing.
+
 === 0.7.4 - 21 July 2009
-* fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/17
+   - fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/17
     Problem with Alarm trigger property value
-* fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/18
+   - fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/18
     Problem with exporting components with sub-components
 === 0.7.3 - 13 July 2009
   Added pointers to rdoc in README
 === 0.7.2 - 6 July 2009
   updated to use newest versions of newgem and hoe, in order to make run-code-run work again
 === 0.7.1 - 6 July 2009
-  * fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/15
+   - fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/15
       duration validation issues
-  * fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/16
+   - fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/16
       event finish_time loses timezone info when event has a dtstart and duration
 === 0.7.0 - 29 June 2009
-  * fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/14
+   - fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/14
       component without recurrence properties should enumerate just itself only if it is within the period between starting and before
-  * added the :overlapping option to OccurrenceEnumerator#occurrences - Allows the enumeration of occurrences which are either partiall or completely within a timespan given by a pair of Dates/Times/DateTimes
-  * Fixed some Ruby 1.9 incompatibilities
-  * Added some new rake tasks to run specs under multi-ruby
+   - added the :overlapping option to OccurrenceEnumerator#occurrences - Allows the enumeration of occurrences which are either partiall or completely within a timespan given by a pair of Dates/Times/DateTimes
+   - Fixed some Ruby 1.9 incompatibilities
+   - Added some new rake tasks to run specs under multi-ruby
 === 0.6.3 - 14 June 2009
- * Fixed http://rick_denatale.lighthouseapp.com/projects/30941-ri_cal/tickets/13
+   - Fixed http://rick_denatale.lighthouseapp.com/projects/30941-ri_cal/tickets/13
       tzinfotimezones-with-no-transitions-fail-on-export
 === 0.6.2 - 11 June 2009
- * Fixed http://rick_denatale.lighthouseapp.com/projects/30941-ri_cal/tickets/12
+   - Fixed http://rick_denatale.lighthouseapp.com/projects/30941-ri_cal/tickets/12
       export-failure-for-unbounded-tzinfo-timezone
 === 0.6.1 - 6 June 2009
- * Fixed problem with file which loads activesupport for the rake spec:with_activesupport task, it now
+   - Fixed problem with file which loads activesupport for the rake spec:with_activesupport task, it now
    requires >=2.2 instead of <=2.2 - Thanks to Paul Scott-Murphy for finding this.
 === 0.6.0 - 5 June 2009
  Time for a minor version bump.
- * Improved overall enumeration performance bypassing most of the effects of the poor performance of Ruby's DateTime class.
- * Added a framework for performance monitoring during development.
+   - Improved overall enumeration performance bypassing most of the effects of the poor performance of Ruby's DateTime class.
+   - Added a framework for performance monitoring during development.
    - New performance directory with subdirs for code to be monitored for performance (subjects)
    - New script files: 
         script/benchmark_subject runs a ruby benchmark on one performance subject
@@ -39,61 +46,60 @@
         performance:benchmark runs benchmarks against all subjects in the performance directory and produces a consolidated output file in performance_data/benchmarks.out
         performance:profile runs script/profile_subject against all subjects in the performance directory.
 === 0.5.3 - 1 June, 2009
- * Improved performance of time zone enumeration, TimeZonePeriod now caches occurrences
- * Added a profiling directory which contains ruby programs which benchmark and/or profile performance
+   - Improved performance of time zone enumeration, TimeZonePeriod now caches occurrences
+   - Added a profiling directory which contains ruby programs which benchmark and/or profile performance
 === 0.5.2
- * Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/11
+   - Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/11
    Export folding is not UTF-8 Safe
 === 0.5.1
- * Fixed README to acknowledge release on RubyForge
+   - Fixed README to acknowledge release on RubyForge
 === 0.5.0 rubyforge release candidate Tue May 26 10:26:43 2009 -0400
- * Added OccurrenceEnumerator#zulu_occurrence_range
+   - Added OccurrenceEnumerator#zulu_occurrence_range
 === 0.0.11 Sat May 23 18:24:57 2009 -0400
- * Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/5
- * Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/9
+   - Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/5
+   - Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/9
 === 0.0.10
- * Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/8
+   - Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/8
 === 0.0.9
-  * Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/4
+   - Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/4
     Missing comparison methods in PropertyValue::Date
-  * Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/6
+   - Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/6
     Type of dtstart and dtend (DATE or DATETIME) now preserved on enumeration
 === 0.0.8
-  * Fixed http://rick_denatale.lighthouseapp.com/projects/30941-ri_cal/tickets/1
+   - Fixed http://rick_denatale.lighthouseapp.com/projects/30941-ri_cal/tickets/1
     EXDATE and RDATE now pick up the timezone from DateTime, Time, and TimeWithZone values
-  * Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/2
+   - Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/2
     Missing arithmetic methods in PropertyValue::Date
-  * Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/3
+   - Fixed http://rick_denatale.lighthouseapp.com/projects/30941/tickets/3
        Components with no recurrence rules or rdate properties failed on enumeration, they now
        will enumerate a single occurrence  
 === 0.0.7
- * Fixed a bug relating to properly recognizing ActiveRecord::TimeWithZone
- * DATETIME propertyvalues will now return an instance of TimeWithZone instead of DateTime when
+   - Fixed a bug relating to properly recognizing ActiveRecord::TimeWithZone
+   - DATETIME propertyvalues will now return an instance of TimeWithZone instead of DateTime when
    activesupport is present, and it is appropriate. See the README for details
 === 0.0.6
- * Added rake tasks to run specs with either the tzinfo gem or activesupport (<=2.2)
- * Default rake task now runs both of these
+   - Added rake tasks to run specs with either the tzinfo gem or activesupport (<=2.2)
+   - Default rake task now runs both of these
 === 0.0.5
- * Fixed a bug in occurrence enumeration reported by paulsm on github
+   - Fixed a bug in occurrence enumeration reported by paulsm on github
 === 0.0.4
- * Fixed a bug in imported timezones reported by paulsm on github
+   - Fixed a bug in imported timezones reported by paulsm on github
 === 0.0.3
- * Added tzid method to Ruby Time and DateTime instances, and to ActiveRecord::TimeWithZone if it is defined this method is used to determine the desired
+   - Added tzid method to Ruby Time and DateTime instances, and to ActiveRecord::TimeWithZone if it is defined this method is used to determine the desired
 timezone when an instance of one of these classes is given as the value of a datetime property.  If the tzid is nil then the default tzid is used,
 if it is set to :floating then the property will be a floating time.
- * Removed the ability to pass an array with a tzid string and a date-time since the above made it unnecessary
- * The ruby datetime property returned from the ruby_value method on the DateTime property will return an instance of ::DateTime with:
-   ** The proper utc offset
-   ** The tzid set to the right tzid
- * Made exdate/rdate building possible
- * Added a default_tzid attribute to the Calendar component, if this attribute is not set for a particular calendar it will delegate to the default set 
+   - Removed the ability to pass an array with a tzid string and a date-time since the above made it unnecessary
+   - The ruby datetime property returned from the ruby_value method on the DateTime property will return an instance of ::DateTime with:
+     -- The proper utc offset
+     -- The tzid set to the right tzid
+   - Made exdate/rdate building possible
+   - Added a default_tzid attribute to the Calendar component, if this attribute is not set for a particular calendar it will delegate to the default set 
 for the DateTime property class.
- * Added fix patches from
-   ** http://github.com/kjwierenga/ri_cal
-   ** http://github.com/wesmaldonado/ri_cal
+   - Added fix patches from
+     -- http://github.com/kjwierenga/ri_cal
+     -- http://github.com/wesmaldonado/ri_cal
 
 === 0.0.2
- * Fixed gemspec
+   - Fixed gemspec
 == 0.0.1
-
- * Initial public release
+   - Initial public release

data/lib/ri_cal.rb

@@ -14,7 +14,7 @@ module RiCal
   autoload :OccurrenceEnumerator, "#{my_dir}/ri_cal/occurrence_enumerator.rb"
   
   # :stopdoc:
-  VERSION = '0.7.4'
+  VERSION = '0.7.5'
   LIBPATH = ::File.expand_path(::File.dirname(__FILE__)) + ::File::SEPARATOR
   PATH = ::File.dirname(LIBPATH) + ::File::SEPARATOR
 

data/lib/ri_cal/parser.rb

@@ -24,7 +24,10 @@ module RiCal
         string.split(";").inject({}) { |result, val|
           m = /^(.+)=(.+)$/.match(val)
           raise "Invalid parameter value #{val.inspect}" unless m
-          result[m[1]] = m[2]
+          #TODO - The gsub below is a simplest fix for http://rick_denatale.lighthouseapp.com/projects/30941/tickets/19
+          #       it may need further examination if more pathological cases show up.
+          param_val = m[2].sub(/^\"(.*)\"$/, '\1') 
+          result[m[1]] = param_val
           result 
         }
       else

data/ri_cal.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{ri_cal}
-  s.version = "0.7.4"
+  s.version = "0.7.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["author=Rick DeNatale"]
-  s.date = %q{2009-07-21}
+  s.date = %q{2009-08-03}
   s.default_executable = %q{ri_cal}
   s.description = %q{A new Ruby implementation of RFC2445 iCalendar.
 

data/spec/ri_cal/bugreports_spec.rb

@@ -93,4 +93,45 @@ describe "http://rick_denatale.lighthouseapp.com/projects/30941/tickets/18" do
     
     lambda {event.export}.should_not raise_error
   end
+end
+
+describe "http://rick_denatale.lighthouseapp.com/projects/30941/tickets/19" do
+  before(:each) do
+    cals = RiCal.parse_string(<<-ENDCAL)
+BEGIN:VCALENDAR
+METHOD:REQUEST
+PRODID:Microsoft CDO for Microsoft Exchange
+VERSION:2.0
+BEGIN:VTIMEZONE
+TZID:(GMT-05.00) Eastern Time (US & Canada)
+X-MICROSOFT-CDO-TZID:10
+BEGIN:STANDARD
+DTSTART:16010101T020000
+TZOFFSETFROM:-0400
+TZOFFSETTO:-0500
+RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=11;BYDAY=1SU
+END:STANDARD
+BEGIN:DAYLIGHT
+DTSTART:16010101T020000
+TZOFFSETFROM:-0500
+TZOFFSETTO:-0400
+RRULE:FREQ=YEARLY;WKST=MO;INTERVAL=1;BYMONTH=3;BYDAY=2SU
+END:DAYLIGHT
+END:VTIMEZONE
+BEGIN:VEVENT
+DTSTAMP:20090724T143205Z
+DTSTART;TZID="(GMT-05.00) Eastern Time (US & Canada)":20090804T120000
+SUMMARY:FW: ALL HANDS MEETING
+DTEND;TZID="(GMT-05.00) Eastern Time (US & Canada)":20090804T133000
+DESCRIPTION:Some event
+END:VEVENT
+END:VCALENDAR
+ENDCAL
+    
+    @event = cals.first.events.first
+  end
+  
+  it "not raise an error accessing DTSTART" do
+    lambda {@event.dtstart}.should_not raise_error
+  end
 end

data/spec/ri_cal/parser_spec.rb

@@ -4,6 +4,26 @@ require File.join(File.dirname(__FILE__), %w[.. spec_helper])
 
 describe RiCal::Parser do
   
+  context ".separate_line" do
+    it "should work" do
+      RiCal::Parser.new.separate_line("DTSTART;TZID=America/New_York:20090804T120000").should == {
+        :name => "DTSTART",
+        :params => {"TZID" => "America/New_York"},
+        :value => "20090804T120000"
+        }
+    end
+  end
+  
+  context ".params_and_value" do
+    it "should separate parameters and values" do
+      RiCal::Parser.params_and_value(";TZID=(GMT-05.00) Eastern Time (US & Canada):20090804T120000").should == [{"TZID" => "(GMT-05.00) Eastern Time (US & Canada)"}, "20090804T120000"]
+    end
+    
+    it "should strip surrounding quotes" do
+      RiCal::Parser.params_and_value(";TZID=\"(GMT-05.00) Eastern Time (US & Canada)\":20090804T120000").should == [{"TZID" => "(GMT-05.00) Eastern Time (US & Canada)"}, "20090804T120000"]
+    end
+  end
+  
   def self.describe_property(entity_name, prop_name, params, value, type = RiCal::PropertyValue::Text)
     describe_named_property(entity_name, prop_name, prop_name, params, value, false, type)
   end
@@ -16,6 +36,12 @@ describe RiCal::Parser do
     ruby_value_name = prop_name.tr("-", "_").downcase
     ruby_prop_name = "#{prop_text.tr('-', '_').downcase}_property"
     expected_ruby_value = type.convert(nil, value).ruby_value
+    expected_params = {}
+    params.each do |key, parm_value|
+      # strip surrounding quotes from values
+      expected_params[key] = parm_value.sub(/^\"(.*)\"$/, '\1')
+    end
+    
     describe "#{prop_name} with value of #{value.inspect}" do
       parse_input = params.inject("BEGIN:#{entity_name.upcase}\n#{prop_text.upcase}") { |pi, assoc| "#{pi};#{assoc[0]}=#{assoc[1]}"}
       parse_input = "#{parse_input}:#{value.to_rfc2445_string}\nEND:#{entity_name.upcase}"
@@ -48,7 +74,7 @@ describe RiCal::Parser do
         end
 
         it "should have the right parameters" do
-          params.each do | key, value |
+          expected_params.each do | key, value |
             @prop.params[key].should == value
           end
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rubyredrick-ri_cal
 version: !ruby/object:Gem::Version 
-  version: 0.7.4
+  version: 0.7.5
 platform: ruby
 authors: 
 - author=Rick DeNatale
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-07-21 00:00:00 -07:00
+date: 2009-08-03 00:00:00 -07:00
 default_executable: ri_cal
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -199,6 +199,7 @@ files:
 - tasks/spec.rake
 has_rdoc: false
 homepage: http://ri-cal.rubyforge.org/
+licenses: 
 post_install_message: 
 rdoc_options: 
 - --main
@@ -220,7 +221,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: ri-cal
-rubygems_version: 1.2.0
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: A new Ruby implementation of RFC2445 iCalendar