rubyless 0.8.3 → 0.8.4

data/History.txt

@@ -1,4 +1,9 @@
-== 0.8.3
+== 0.8.4 2011-06-15
+
+* Minor enhancements
+  * Fixed: should clear cache on safe_method declaration.
+
+== 0.8.3 2011-06-15
 
 * Major enhancements
   * Better support for literal Arrays.

data/README.rdoc

@@ -65,6 +65,12 @@ You can look at the tests for an idea of how to declare things. If you have more
 
 http://zenadmin.org/community
 
+== WARNING:
+
+Changing the safe methods during runtime removes the cache for all classes and
+should therefore be avoided in favor of dynamic "safe_method_type" methods for the
+objects/classes concerned.
+
 == REQUIREMENTS:
 
 * parse_tree

data/lib/ruby_less/info.rb

@@ -1,3 +1,3 @@
 module RubyLess
-  VERSION = '0.8.3'
+  VERSION = '0.8.4'
 end

data/lib/ruby_less/safe_class.rb

@@ -6,7 +6,6 @@ module RubyLess
 
     # List of safe methods for a specific class.
     def self.safe_methods_for(klass)
-      # Caching safe_methods_all is bad when modules are dynamically added / removed.
       @@_safe_methods_parsed[klass] ||= build_safe_methods_list(klass)
     end
 
@@ -58,6 +57,9 @@ module RubyLess
 
     # Declare a safe method for a given class ( same as #safe_method)
     def self.safe_method_for(klass, methods_hash)
+      # This is why defining new safe methods during runtime is BAD.
+      @@_safe_methods_parsed = {} # rebuild all cache
+
       defaults = methods_hash.delete(:defaults) || {}
 
       list = (@@_safe_methods[klass] ||= {})
@@ -243,16 +245,20 @@ module RubyLess
       def self.build_safe_methods_list(klass)
         list = SignatureHash.new
         (@@_safe_methods[klass] || {}).map do |signature, return_value|
-          if return_value.kind_of?(Hash)
-            return_value[:class] = parse_class(return_value[:class])
-          elsif return_value.kind_of?(Proc) || return_value.kind_of?(Symbol)
-            # keep
+          if return_value.frozen?
+            # Already parsed, skip
           else
-            return_value = {:class => return_value}
+            if return_value.kind_of?(Hash)
+              return_value[:class] = parse_class(return_value[:class])
+            elsif return_value.kind_of?(Proc) || return_value.kind_of?(Symbol)
+              # keep
+            else
+              return_value = {:class => return_value}
+            end
+            return_value.freeze
           end
-          method = signature.shift
-          signature = [method] + signature.map {|e| parse_class(e)}
-          list[signature] = return_value.freeze
+          signature = [signature.first] + signature[1..-1].map {|e| parse_class(e)}
+          list[signature] = return_value
         end
         list
       end

data/rubyless.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rubyless}
-  s.version = "0.8.3"
+  s.version = "0.8.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Gaspard Bucher"]

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rubyless
 version: !ruby/object:Gem::Version 
-  hash: 57
+  hash: 55
   prerelease: 
   segments: 
   - 0
   - 8
-  - 3
-  version: 0.8.3
+  - 4
+  version: 0.8.4
 platform: ruby
 authors: 
 - Gaspard Bucher