rubykiq 0.0.4 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 696749fd11368ecd5319c9bf317c6b0ac04a14bd
-  data.tar.gz: fbea254bb5f399512e51992fbf0ada9e4e3d6e3f
+  metadata.gz: 949a8300a8a43c43d1105663f865d8cae2616743
+  data.tar.gz: e85504b5f5d8927a3a4ce4dbb9ffd467d95f5fdf
 SHA512:
-  metadata.gz: 00c6ab314e85af8eb6cfc661fb5e22c1e3b5860a4a58cc33555dc717d60fbe2fc071485d79436aad0842dfcf7cb31505b034925d9d0a870e3dd256d6132975f9
-  data.tar.gz: 1f523fa4f43a80f8e7acfce5a3cb2d19b32c0bec3da160de1134744576518625daf47a5a1c3b1230f738e56ba6bc3ced6630c5c799688d96d23898d1a679bafc
+  metadata.gz: 67ecd131870891c2c92cd955e576506c45784c99caf22e93bed4ce771addacafa80de9a45535defa281c4a0570760e99fba03c16f516382a9ba15843b4d68342
+  data.tar.gz: e980fc1dc5d22d6572a33b05787369664bc2eb3f32899992896c100e0803254aee1d514d6bef542ae3d1d184d245093823d7c5be1fd4a429f54a62df07a810dc

data/.gitignore

@@ -2,8 +2,12 @@
 *.rbc
 .bundle
 .config
-coverage
+.yardoc
+Gemfile.lock
 InstalledFiles
+_yardoc
+coverage
+doc/
 lib/bundler/man
 pkg
 rdoc
@@ -11,8 +15,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
-*.lock
-.yardoc
-_yardoc
-doc/
 bin

data/.travis.yml

@@ -1,21 +1,24 @@
 language: ruby
 cache: bundler
+bundler_args: --without development
 rvm:
   - ruby-head
+  - ruby
   - jruby-head
+  - jruby
   - 2.1.0
   - 2.0.0
   - 1.9.3
-  - rbx-19mode
-  - jruby-19mode
-services:
-  - redis-server
+  - rbx-2
 matrix:
   fast_finish: true
   allow_failures:
     - rvm: ruby-head
+    - rvm: ruby
     - rvm: jruby-head
-    - rvm: rbx-19mode
-    - rvm: jruby-19mode
+    - rvm: jruby
+    - rvm: rbx-2
 notifications:
-  email: false
+  email: false
+services:
+  - redis-server

data/Gemfile

@@ -1,22 +1,12 @@
 source 'https://rubygems.org'
 
-gem 'yard'
-gem 'rake', '~> 10.0'
-gem 'hiredis', '>= 0.4.5', require: false
-gem 'em-synchrony', require: false
+gemspec
 
-group :development do
-  gem 'pry'
-  gem 'rubocop'
-  gem 'kramdown', '>= 0.14'
-end
+gem 'hiredis', '>= 0.4.5'
+gem 'em-synchrony'
 
 group :test do
+  gem 'rake', '~> 10.0'
   gem 'rspec'
   gem 'timecop'
-  gem 'simplecov', require: false
-  gem 'coveralls', require: false
-  gem 'fakefs', '~> 0.4.3'
 end
-
-gemspec

data/README.md

@@ -1,13 +1,13 @@
 # Rubykiq
 
-[Sidekiq][sidekiq] agnostic enqueuing using Redis.
+[Sidekiq](http://mperham.github.com/sidekiq) agnostic enqueuing using Redis.
 
 Sidekiq is a fantastic message processing library which has a simple and stable message format. `Rubykiq` aims to be a portable library to push jobs in to Sidekiq with as little overhead as possible whilst having feature parity on `Sidekiq::Client`'s conventions.
 
 ## Installation
 
 ```ruby
-gem 'rubykiq', '~> 0.0.3'
+gem 'rubykiq', '~> 1.0'
 ```
 
 ```ruby
@@ -15,7 +15,7 @@ require 'rubykiq'
 ```
 ## Features / Usage Examples
 
-* [Redis] has support for [alternative drivers](https://github.com/redis/redis-rb#alternate-drivers), Rubykiq is tested with these in mind. (eg `:synchrony`)
+* [Redis](http://redis.io) has support for [alternative drivers](https://github.com/redis/redis-rb#alternate-drivers), Rubykiq is tested with these in mind. (eg `:synchrony`)
 * the `:class` parameter can be the Class or a String of the Class (eg push jobs to Sidekiq from anywhere, not just where Sidekiq has the classes loaded)
 * The `:at` parameter supports `Time`, `Date` and any `Time.parse`-able strings.
 * Pushing multiple and singular jobs has the same interface (simply nest args)
@@ -23,7 +23,6 @@ require 'rubykiq'
 * Easier configuration (IMO)
 
 ```ruby
-
 # will also detect REDIS_URL, REDIS_PROVIDER and REDISTOGO_URL ENV variables
 Rubykiq.url = 'redis://127.0.0.1:6379'
 
@@ -58,7 +57,6 @@ hiredis_client = Rubykiq::Client.new(:driver => :hiredis)
 # create multiple Rubykiq clients with their own namespaces
 foo_client = Rubykiq::Client.new(:namespace => 'foo')
 bar_client = Rubykiq::Client.new(:namespace => 'bar')
-
 ```
 
 ## Caveats
@@ -68,11 +66,10 @@ bar_client = Rubykiq::Client.new(:namespace => 'bar')
 
 ## Build & Dependency Status
 
-[![Gem Version](https://badge.fury.io/rb/rubykiq.png)][gem]
-[![Build Status](https://travis-ci.org/karlfreeman/rubykiq.png)][travis]
-[![Code Quality](https://codeclimate.com/github/karlfreeman/rubykiq.png)][codeclimate]
-[![Coverage Status](https://coveralls.io/repos/karlfreeman/rubykiq/badge.png?branch=master)][coveralls]
-[![Gittip](http://img.shields.io/gittip/karlfreeman.png)][gittip]
+[![Gem Version](http://img.shields.io/gem/v/rubykiq.svg)][gem]
+[![Build Status](http://img.shields.io/travis/karlfreeman/rubykiq.svg)][travis]
+[![Code Quality](http://img.shields.io/codeclimate/github/karlfreeman/rubykiq.svg)][codeclimate]
+[![Gittip](http://img.shields.io/gittip/karlfreeman.svg)][gittip]
 
 ## Supported Redis Drivers
 
@@ -85,11 +82,11 @@ bar_client = Rubykiq::Client.new(:namespace => 'bar')
 This library aims to support and is [tested against][travis] the following Ruby
 implementations:
 
-* Ruby 2.1.0 (drivers: ruby, hiredis, synchrony)
-* Ruby 2.0.0 (drivers: ruby, hiredis, synchrony)
-* Ruby 1.9.3 (drivers: ruby, hiredis, synchrony)
-* [JRuby][jruby] (drivers: ruby)
-* [Rubinius][rubinius] (drivers: ruby)
+- Ruby 2.1.0 (drivers: ruby, hiredis, synchrony)
+- Ruby 2.0.0 (drivers: ruby, hiredis, synchrony)
+- Ruby 1.9.3 (drivers: ruby, hiredis, synchrony)
+- [JRuby][jruby] (drivers: ruby)
+- [Rubinius][rubinius] (drivers: ruby)
 
 # Credits
 
@@ -105,11 +102,7 @@ Cribbed:
 
 [gem]: https://rubygems.org/gems/rubykiq
 [travis]: http://travis-ci.org/karlfreeman/rubykiq
-[coveralls]: https://coveralls.io/r/karlfreeman/rubykiq
 [codeclimate]: https://codeclimate.com/github/karlfreeman/rubykiq
 [gittip]: https://www.gittip.com/karlfreeman
 [jruby]: http://www.jruby.org
 [rubinius]: http://rubini.us
-
-[sidekiq]: http://mperham.github.com/sidekiq
-[redis]: https://github.com/redis/redis-rb

data/Rakefile

@@ -2,16 +2,22 @@ require 'bundler'
 Bundler.setup
 Bundler::GemHelper.install_tasks
 
-require 'yard'
-YARD::Rake::YardocTask.new
-
 require 'rspec/core/rake_task'
 desc 'Run all examples'
 RSpec::Core::RakeTask.new(:spec)
 
-require 'rubocop/rake_task'
-desc 'Run rubocop'
-Rubocop::RakeTask.new(:rubocop)
+begin
+  require 'yard'
+  YARD::Rake::YardocTask.new
+rescue LoadError
+end
+
+begin
+  require 'rubocop/rake_task'
+  desc 'Run rubocop'
+  Rubocop::RakeTask.new(:rubocop)
+rescue LoadError
+end
 
 task default: :spec
 task test: :spec

data/lib/rubykiq/client.rb

@@ -1,7 +1,7 @@
-require 'connection_pool'
-require 'securerandom'
-require 'multi_json'
 require 'time'
+require 'multi_json'
+require 'securerandom'
+require 'connection_pool'
 
 module Rubykiq
   class Client
@@ -14,7 +14,7 @@ module Rubykiq
       :driver,
       :retry,
       :queue
-    ].freeze
+    ]
 
     # A hash of valid options and their default values
     DEFAULT_OPTIONS = {
@@ -25,11 +25,14 @@ module Rubykiq
       driver: :ruby,
       retry: true,
       queue: 'default'
-    }.freeze
+    }
 
     # Bang open the valid options
     attr_accessor(*VALID_OPTIONS_KEYS)
 
+    # allow the connection_pool to be set
+    attr_writer :connection_pool
+
     # Initialize a new Client object
     #
     # @param options [Hash]
@@ -40,10 +43,6 @@ module Rubykiq
       end
     end
 
-    def connection_pool=(val)
-      @connection_pool = val
-    end
-
     # Fetch the ::ConnectionPool of Rubykiq::Connections
     #
     # @return [::ConnectionPool]
@@ -95,7 +94,7 @@ module Rubykiq
 
     # Create a hash of options and their values
     def valid_options
-      VALID_OPTIONS_KEYS.reduce({}) { |o, k| o.merge!(k => send(k)) }
+      VALID_OPTIONS_KEYS.reduce({}) { |a, e| a.merge!(e => send(e)) }
     end
 
     # Create a hash of the default options and their values
@@ -131,7 +130,7 @@ module Rubykiq
         # merge this item's args (eg the nested `arg` array)
         item.merge!(args: args) unless args.empty?
         # normalize this individual item
-        item = normalize_item(item)
+        normalize_item(item)
       end.compact
 
       # if successfully persisted to redis return the size of the jobs

data/lib/rubykiq/version.rb

@@ -1,3 +1,3 @@
 module Rubykiq
-  VERSION = '0.0.4' unless defined?(Rubykiq::VERSION)
+  VERSION = '1.0.0' unless defined?(Rubykiq::VERSION)
 end

data/rubykiq.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/karlfreeman/rubykiq'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
@@ -23,4 +23,11 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'redis-namespace', '>= 1.0'
   spec.add_dependency 'multi_json', '>= 1.0'
   spec.add_dependency 'connection_pool', '>= 1.0'
-end
+
+  spec.add_development_dependency 'bundler', '~> 1.5'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'kramdown', '>= 0.14'
+  spec.add_development_dependency 'rubocop', '~> 0.19'
+  spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'yard'
+end

data/spec/spec_helper.rb

@@ -9,12 +9,7 @@ end
 
 require 'rubykiq'
 
-# used as a stupid mixin class
-class DummyClass
-end
-
 RSpec.configure do |config|
-
   config.expect_with :rspec do |c|
     c.syntax = :expect
   end
@@ -30,5 +25,4 @@ RSpec.configure do |config|
       EM.stop
     end
   end
-
 end

data/spec/support/pry.rb

@@ -1,3 +1,3 @@
-if !ENV['CI'] && defined?(RUBY_ENGINE) && RUBY_ENGINE == 'ruby'
-  require 'pry'
+if defined?(RUBY_ENGINE) && RUBY_ENGINE == 'ruby'
+  require 'pry' unless ENV['CI']
 end

data/spec/unit/client_spec.rb

@@ -4,17 +4,11 @@ require 'em-synchrony'
 
 describe Rubykiq::Client do
 
-  before(:all) do
-    Timecop.freeze
-  end
-
-  after(:all) do
-    Timecop.return
-  end
-
-  let (:ruby_client) { Rubykiq::Client.new(driver: :ruby, namespace: :ruby) }
-  let (:hiredis_client) { Rubykiq::Client.new(driver: :hiredis, namespace: :hiredis) }
-  let (:synchrony_client) { Rubykiq::Client.new(driver: :synchrony, namespace: :synchrony) }
+  before(:all) { Timecop.freeze }
+  after(:all) { Timecop.return }
+  let(:ruby_client) { Rubykiq::Client.new(driver: :ruby, namespace: :ruby) }
+  let(:hiredis_client) { Rubykiq::Client.new(driver: :hiredis, namespace: :hiredis) }
+  let(:synchrony_client) { Rubykiq::Client.new(driver: :synchrony, namespace: :synchrony) }
 
   # eg with a variety of drivers
   [:ruby, :hiredis, :synchrony].each do |driver|
@@ -43,7 +37,7 @@ describe Rubykiq::Client do
             it 'raises an ArgumentError' do
               expect { client.push([]) }.to raise_error(ArgumentError, /Message must be a Hash/)
               expect { client.push('{}') }.to raise_error(ArgumentError, /Message must be a Hash/)
-              expect { client.push(DummyClass.new) }.to raise_error(ArgumentError, /Message must be a Hash/)
+              expect { client.push(Class.new) }.to raise_error(ArgumentError, /Message must be a Hash/)
             end
           end
 
@@ -61,15 +55,15 @@ describe Rubykiq::Client do
 
           context 'with an incorrect class type' do
             it 'raises an ArgumentError' do
-              expect { client.push(class: DummyClass, args: ['foo', 1, { bat: 'bar' }]) }.to raise_error(ArgumentError, /Message class must be a String representation of the class name/)
+              expect { client.push(class: Class, args: ['foo', 1, { bat: 'bar' }]) }.to raise_error(ArgumentError, /Message class must be a String representation of the class name/)
             end
           end
 
         end
 
         # eg singular and batch
-        args = [[{ bat: 'bar' }], [[{ bat: 'bar' }], [{ bat: 'foo' }]]]
-        args.each do |args|
+        arguments = [[{ bat: 'bar' }], [[{ bat: 'bar' }], [{ bat: 'foo' }]]]
+        arguments.each do |args|
 
           context "with args #{args}" do
 

metadata

@@ -1,71 +1,155 @@
 --- !ruby/object:Gem::Specification
 name: rubykiq
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 1.0.0
 platform: ruby
 authors:
 - Karl Freeman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-03 00:00:00.000000000 Z
+date: 2014-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: redis-namespace
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
   name: connection_pool
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: kramdown
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0.14'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.19'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.19'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Sidekiq agnostic enqueuing using Redis
 email:
 - karlfreeman@gmail.com
@@ -73,11 +157,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .document
-- .gitignore
-- .rubocop.yml
-- .travis.yml
-- .yardopts
+- ".document"
+- ".gitignore"
+- ".rubocop.yml"
+- ".travis.yml"
+- ".yardopts"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
@@ -91,7 +175,6 @@ files:
 - rubykiq.gemspec
 - spec/spec_helper.rb
 - spec/support/pry.rb
-- spec/support/simplecov.rb
 - spec/support/timecop.rb
 - spec/unit/client_spec.rb
 - spec/unit/connection_spec.rb
@@ -106,24 +189,23 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: Sidekiq agnostic enqueuing using Redis
 test_files:
 - spec/spec_helper.rb
 - spec/support/pry.rb
-- spec/support/simplecov.rb
 - spec/support/timecop.rb
 - spec/unit/client_spec.rb
 - spec/unit/connection_spec.rb

data/spec/support/simplecov.rb

@@ -1,9 +0,0 @@
-if ENV['CI'] && defined?(RUBY_ENGINE) && RUBY_ENGINE == 'ruby'
-  require 'simplecov'
-  require 'coveralls'
-  Coveralls.wear!
-  SimpleCov.formatter = Coveralls::SimpleCov::Formatter
-  SimpleCov.start do
-    add_filter 'vendor'
-  end
-end