rubyipmi 0.9.2 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1fb4c5a2ee5350e88825085a4d8bc8629c0540a7
-  data.tar.gz: 4e4ecc9f2c3cda0a9bc9d1dc2f95c85f01209abd
+  metadata.gz: 73a317277673e2c70ada368153734878751b0697
+  data.tar.gz: ca3ae9b2f301a9ed9c4327af190912dc16525e73
 SHA512:
-  metadata.gz: 524f30bca98d535eab2ba5ff77a68816f8bcffe6d7c290e2f0024e25f1ccb2c994134fdaba359088d4c9eaec4338f9d8dc64193450c52428573e6fa198f8e5fb
-  data.tar.gz: d6304c667418b10143d7e9b753a2c2dfab367acbd888de03efc12a589a444cacf10d8e486ee136166626f85b37a5f4dbfd03ddba817576629d6baf20ad58dc67
+  metadata.gz: 4b09be14a0edc2c20bc479f4e430311f081daa98601cc064ced0e69b680b8f5c637ecbaf05c505ddf164d7d42ffd9dd7aee8d39f0d03dcf3a36b7b0327257f1a
+  data.tar.gz: c56d4d03854fa96d484c515a6e2ac05d47be8fc7f578846901c08a2807fa893a4454ca775e08ff0d57120329b6272edd9afed05c67efa80c66fcbd4426982b10

data/RELEASE_NOTES.md

@@ -1,3 +1,10 @@
+### 0.9.3
+* normalize the options being passed into the connect method
+
+### 0.9.2
+* fixes an issue where is_provider_installed? should only return a boolean value instead of raising and error
+* fixes a minor style issue where providers_installed? was returning an array when a boolean might have been expected
+
 ### 0.9.1
 * fixes an issue with connection_works? api call when command raises an error
 

data/VERSION

@@ -1 +1 @@
-0.9.2
+0.9.3

data/lib/rubyipmi.rb

@@ -77,6 +77,14 @@ module Rubyipmi
     # use this variable to reduce cmd calls
     installed = false
 
+    # if the user supplied nil, we want to fix this automatically
+    opts = {:driver => 'auto', :timeout => 'default'} if opts.nil?
+
+    # convert all keys to symbols for opts, we can't assume the user will use symbols
+    opts.keys.each do |key|
+      opts[(key.to_sym rescue key) || key] = opts.delete(key)
+    end
+
     # allow the user to specify an options hash instead of the provider
     # in the future I would stop using the provider and use the opts hash instead to get the provider
     # This allows us to be a little more flexible if the user is doesn't supply us what we need.

data/rubyipmi.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: rubyipmi 0.9.2 ruby lib
+# stub: rubyipmi 0.9.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rubyipmi"
-  s.version = "0.9.2"
+  s.version = "0.9.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Corey Osman"]
-  s.date = "2015-03-19"
+  s.date = "2015-04-10"
   s.description = "Provides a library for controlling IPMI devices using pure ruby code"
   s.email = "corey@logicminds.biz"
   s.extra_rdoc_files = [

data/spec/unit/rubyipmi_spec.rb

@@ -5,6 +5,7 @@ describe :Rubyipmi do
 
   before :each do
 
+    allow(Rubyipmi).to receive(:locate_command).with('ipmitool').and_return("#{@path}/ipmitool")
   end
 
   it 'is provider installed should return ipmitool true' do
@@ -27,6 +28,23 @@ describe :Rubyipmi do
     expect(Rubyipmi.is_provider_installed?('bad_provider')).to be_falsey
   end
 
+  it 'converts string to symbols' do
+    user = "ipmiuser"
+    pass = "impipass"
+    host = "ipmihost"
+    provider = "ipmitool"
+    conn = Rubyipmi.connect(user, pass, host, provider, {'driver' => 'lan15'})
+    expect(conn.options).to eq({"H"=>"ipmihost", "U"=>"ipmiuser", "P"=>"impipass", "I"=>"lan"})
+  end
+
+  it 'does not error when converting strings to symbols' do
+    user = "ipmiuser"
+    pass = "impipass"
+    host = "ipmihost"
+    provider = "ipmitool"
+    conn = Rubyipmi.connect(user, pass, host, provider, {:driver => 'lan15'})
+    expect(conn.options).to eq({"H"=>"ipmihost", "U"=>"ipmiuser", "P"=>"impipass", "I"=>"lan"})
+  end
 end
 
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubyipmi
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.3
 platform: ruby
 authors:
 - Corey Osman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-19 00:00:00.000000000 Z
+date: 2015-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec