rubyipmi 0.11.1 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ded5dae3237a5610e1b3d5e1595743be1401636b68b76965d9b1c4bfaa174ac8
-  data.tar.gz: bbfd85a434bfafdeccd6efbcea2dc898032b04b92ceb6c7ebe918f11ac12e4eb
+  metadata.gz: b400cae906782f5f4d2c2812a67e08db4d01ee28c29d098764eb06172aaece4c
+  data.tar.gz: eaf5ef307e3b93d26ca97e38776b5e97781602524fff7a9fa726bea86feb1454
 SHA512:
-  metadata.gz: 60e95d651aa6b3275f91ea531628c33a473eaaf3d3e34c7c60a61d97cbbcbedfa907356138010eae1d0eda3c0a362316f8fb34e472b594edc834bbd78b0bb619
-  data.tar.gz: 1d8bb664adf6c327a238358ace1a90fdff409cbf8b8328d15f7081f1e60f114f55efdfbe754f98f08ce92ea59079ebd970f07834b6c38b14c3300b622e99e84c
+  metadata.gz: 45e700715cfff358dc1409c3521e8a731615a20d31b1f3452b911188fe0e8d85a707367b840ba4a699bab431242edace43ce1ae11018d1cc24394e11e4f61f90
+  data.tar.gz: 47c8628e9e278a755afc369e04a71914eab88607e3945400bdcb940b8a652cac627c1bcb2e7a0ac6677f5e3ed732e8b7ad08e3e3a2ae2d8f2ec0bb54578513e4

data/CONTRIBUTORS.md

@@ -0,0 +1,8 @@
+## Contributors
+Big thank you to our maintainers and contributors.
+
+- Ewoud Kohl van Wijngaarden @ekohl
+- Lukáš Zapletal @lzap
+- Evgeni Golov @evgeni
+- Mateusz Gozdek
+- Brandon Dunne @bdunne

data/Gemfile

@@ -1,13 +1,11 @@
 source "http://rubygems.org"
 
+gemspec
+
 group :development do
-  gem "rspec", "~> 3.1"
-  gem "rdoc", "~> 3.12"
-  gem "bundler", ">= 2.0.0"
-  gem "highline"
-  gem "rake"
-  gem 'coveralls', :require => false
+  gem 'coveralls_reborn', require: false
   gem 'pry'
   gem 'pry-rescue'
-  gem "rubocop", "~> 0.33.0", :require => false
+  gem "rubocop", :require => false
+  gem "reline"
 end

data/RELEASE_NOTES.md

@@ -1,3 +1,14 @@
+## unreleased
+
+### 0.12.0
+ * Add Ruby 3.4 support @ekohl
+ * Update test matrix for other 3.x rubies @ekohl
+ * Remove highline as a runtime dependency + simpify gemspec & Gemfile @ekohl
+ * Use the SPDX license code in gemspec @ekohl
+ * Limit dependency ranges to avoid gemspec warnings @ekohl
+ * Simplify gemspec @ekohl
+ * Adds github actions for testing
+
 ### 0.11.1
  * remove hidden files from gem package
 
@@ -13,7 +24,7 @@ This is a big update with many minor changes and bug fixes.  Thank you for all t
   Adds a missing counter incrementation with the same style as
   in basecommands and make it return current @info in case of a failure,
   so all methods accessing it will just get return nil.
- 
+
 - Leverage Enumerable#each_with_object
 - Add a SensorsMixin to remove duplicate code
 - Enable Rubocop GuardClause and fix complaints
@@ -32,7 +43,7 @@ This is a big update with many minor changes and bug fixes.  Thank you for all t
 - Remove if / else logic and unnecessary return in #validate_status
 - Reword confusing project description
 - Update README.md section on booting to specific devices
-- Update documentation around bootpxe, bootdisk functions 
+- Update documentation around bootpxe, bootdisk functions
 - Remove pry statement from method
 ### 0.10.0
 * gh-26 - make the driver default to lan20

data/VERSION

@@ -1 +1 @@
-0.10.0
+0.12.0

data/lib/rubyipmi/commands/basecommand.rb

@@ -37,9 +37,8 @@ module Rubyipmi
     end
 
     def locate_command(commandname)
-      location = `which #{commandname}`.strip
-      unless $?.success?
-        logger.error("#{commandname} command not found, is #{commandname} installed?") if logger
+      unless location = Rubyipmi.locate_command(commandname)
+        logger&.error("#{commandname} command not found, is #{commandname} installed?")
         raise "#{commandname} command not found, is #{commandname} installed?"
       end
       location
@@ -67,10 +66,10 @@ module Rubyipmi
       logger.debug(makecommand) if logger
       begin
         command = makecommand
-        @lastcall = "#{command}"
-        @result = `#{command} 2>&1`
+        @lastcall = command.to_s
+        @result, @result_err, status = Rubyipmi.capture3(command)
         # sometimes the command tool does not return the correct result, validate it with additional code
-        process_status = validate_status($?)
+        process_status = validate_status(status)
       rescue
         if retrycount < max_retry_count
           find_fix(@result)
@@ -96,7 +95,8 @@ module Rubyipmi
       begin
         fix = ErrorCodes.search(result)
         @options.merge_notify!(fix)
-      rescue
+      rescue e
+        raise e
         Rubyipmi.logger.debug("Could not find fix for error code: \n#{result}") if logger
         raise "Could not find fix for error code: \n#{result}"
       end
@@ -108,7 +108,8 @@ module Rubyipmi
 
     # This method will check if the results are really valid as the exit code can be misleading and incorrect
     def validate_status(exitstatus)
-      raise "Error occurred" unless exitstatus.success?
+      raise "Error occurred" unless exitstatus
+      raise "Error occurred" if exitstatus.is_a?(Process::Status) && exitstatus.success?
 
       true
     end

data/lib/rubyipmi/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rubyipmi
-  VERSION = '0.11.1'.freeze
+  VERSION = '0.12.0'.freeze
 end

data/lib/rubyipmi.rb

@@ -19,6 +19,7 @@
 require 'rubyipmi/ipmitool/connection'
 require 'rubyipmi/freeipmi/connection'
 require 'logger'
+require 'open3'
 
 class NullLogger < Logger
   def initialize(*_args)
@@ -144,11 +145,18 @@ module Rubyipmi
     PRIV_TYPES.include?(type)
   end
 
+  # test-friendly capture3
+  def self.capture3(cmd)
+    return Open3.capture3(cmd)
+  end
+
   # method used to find the command which also makes it easier to mock with
   def self.locate_command(commandname)
-    location = `which #{commandname}`.strip
-    location = nil unless $?.success?
-    location
+    stdout, stderr, status = Open3.capture3("which #{commandname}")
+    logger&.error("Which command returned: #{stderr}") unless status.success?
+
+    return nil unless status.success?
+    stdout
   end
 
   # Return true or false if the provider is available

data/rubyipmi.gemspec

@@ -6,8 +6,6 @@ Gem::Specification.new do |s|
   s.name = "rubyipmi"
   s.version = Rubyipmi::VERSION
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.require_paths = ["lib"]
   s.authors = ["Corey Osman"]
   s.date = "2021-09-29"
   s.description = "Controls IPMI devices via command line wrapper for ipmitool and freeipmi"
@@ -20,15 +18,14 @@ Gem::Specification.new do |s|
     f.match(/^(\.|test|spec|features)/) || f.match(/^*.tar\.gz/)
   end
   s.homepage = "https://github.com/logicminds/rubyipmi"
-  s.licenses = ["LGPLv2.1"]
-  s.rubygems_version = "2.4.5"
+  s.license = "LGPL-2.1-only"
   s.summary = "A ruby wrapper for ipmi command line tools that supports ipmitool and freeipmi"
   s.require_paths = ['lib']
-  s.add_development_dependency(%q<rspec>, ["~> 3.1"])
-  s.add_development_dependency(%q<rdoc>, ["~> 3.12"])
-  s.add_development_dependency(%q<bundler>, [">= 1.1.5"])
-  s.add_development_dependency(%q<highline>, [">= 0"])
-  s.add_development_dependency(%q<rake>, [">= 0"])
-  s.add_dependency(%q<highline>, [">= 0"])
+  s.add_dependency 'observer', '~> 0.1.0'
+  s.add_dependency 'logger'
+  s.add_development_dependency 'rspec'
+  s.add_development_dependency 'rdoc', "~> 6.1"
+  s.add_development_dependency 'bundler', "~> 2.0"
+  s.add_development_dependency 'highline', '>= 1.0', '< 3'
+  s.add_development_dependency 'rake', '~> 13'
 end
-

metadata

@@ -1,99 +1,118 @@
 --- !ruby/object:Gem::Specification
 name: rubyipmi
 version: !ruby/object:Gem::Version
-  version: 0.11.1
+  version: 0.12.0
 platform: ruby
 authors:
 - Corey Osman
-autorequire:
 bindir: bin
 cert_chain: []
 date: 2021-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: observer
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
-  type: :development
+        version: 0.1.0
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: 0.1.0
 - !ruby/object:Gem::Dependency
-  name: rdoc
+  name: logger
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.12'
-  type: :development
+        version: '0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.12'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.5
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.5
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: highline
+  name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '6.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: highline
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
+        version: '1.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '13'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '13'
 description: Controls IPMI devices via command line wrapper for ipmitool and freeipmi
 email: corey@logicminds.biz
 executables: []
@@ -102,6 +121,7 @@ extra_rdoc_files:
 - LICENSE.txt
 - README.md
 files:
+- CONTRIBUTORS.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -140,9 +160,8 @@ files:
 - rubyipmi.gemspec
 homepage: https://github.com/logicminds/rubyipmi
 licenses:
-- LGPLv2.1
+- LGPL-2.1-only
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -157,8 +176,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: A ruby wrapper for ipmi command line tools that supports ipmitool and freeipmi
 test_files: []