rubygems-tasks 0.2.5 → 0.3.0

data/spec/console_spec.rb

@@ -13,15 +13,24 @@ describe Gem::Tasks::Console do
     let(:custom_options)  { %w[-Ivendor -rfoo] }
 
     context "defaults" do
-      it "should run `irb`" do
-        expect(subject).to receive(:run).with('irb',*default_options)
+      context "when the project does not use Bundler" do
+        before do
+          allow(subject.project).to receive(:bundler?).and_return(false)
+        end
+
+        it "must run `irb`" do
+          expect(subject).to receive(:run).with('irb',*default_options)
 
-        subject.console
+          subject.console
+        end
       end
 
-      context "when project.bundler? == true" do
-        it "should use `bundle exec`" do
+      context "when the project does use Bundler" do
+        before do
           allow(subject.project).to receive(:bundler?).and_return(true)
+        end
+
+        it "must use `bundle exec`" do
           expect(subject).to receive(:run).with(
             'bundle', 'exec', 'irb', *default_options
           )
@@ -31,18 +40,27 @@ describe Gem::Tasks::Console do
       end
     end
 
-    context "with custom command" do
-      subject { described_class.new(:command => custom_command) }
+    context "with a custom command" do
+      subject { described_class.new(command: custom_command) }
+
+      context "when the project does not use Bundler" do
+        before do
+          allow(subject.project).to receive(:bundler?).and_return(false)
+        end
 
-      it "should run the custom console" do
-        expect(subject).to receive(:run).with(custom_command,*default_options)
+        it "must run the custom console" do
+          expect(subject).to receive(:run).with(custom_command,*default_options)
 
-        subject.console
+          subject.console
+        end
       end
 
-      context "when project.bundler? == true" do
-        it "should use `bundle exec`" do
+      context "when the project does use Bundler" do
+        before do
           allow(subject.project).to receive(:bundler?).and_return(true)
+        end
+
+        it "must use `bundle exec`" do
           expect(subject).to receive(:run).with(
             'bundle', 'exec', custom_command, *default_options
           )
@@ -53,17 +71,26 @@ describe Gem::Tasks::Console do
     end
 
     context "with custom options" do
-      subject { described_class.new(:options => custom_options) }
+      subject { described_class.new(options: custom_options) }
+
+      context "when the project does not use Bundler" do
+        before do
+          allow(subject.project).to receive(:bundler?).and_return(false)
+        end
 
-      it "should pass custom options to `irb`" do
-        expect(subject).to receive(:run).with('irb', *(default_options + custom_options))
+        it "must pass custom options to `irb`" do
+          expect(subject).to receive(:run).with('irb', *(default_options + custom_options))
 
-        subject.console
+          subject.console
+        end
       end
 
-      context "when project.bundler? == true" do
-        it "should use `bundle exec ...`" do
+      context "when the project does use Bundler" do
+        before do
           allow(subject.project).to receive(:bundler?).and_return(true)
+        end
+
+        it "must use `bundle exec ...`" do
           expect(subject).to receive(:run).with('bundle', 'exec', 'irb', *(default_options + custom_options))
 
           subject.console

data/spec/install_spec.rb

@@ -7,7 +7,11 @@ describe Gem::Tasks::Install do
   describe "#install" do
     let(:path) { 'pkg/foo-1.2.3.gem' }
 
-    it "should use `gem install -q`" do
+    it "must use `gem install -q`" do
+      if defined?(Bundler)
+        expect(Bundler).to receive(:with_original_env).and_yield()
+      end
+
       expect(subject).to receive(:run).with('gem', 'install', '-q', path)
 
       subject.install(path)

data/spec/project_spec.rb

@@ -3,7 +3,7 @@ require 'rubygems/tasks/project'
 
 describe Gem::Tasks::Project do
   let(:rubygems_project_dir) { File.join(PROJECTS_DIR,'rubygems-project') }
-  let(:rubygems_project)     { described_class.new(rubygems_project_dir)   }
+  let(:rubygems_project)     { described_class.new(rubygems_project_dir)  }
 
   let(:rubygems_multi_project_dir) do
     File.join(PROJECTS_DIR,'rubygems-multi-project')
@@ -14,12 +14,12 @@ describe Gem::Tasks::Project do
   end
 
   let(:bundler_project_dir) { File.join(PROJECTS_DIR,'bundler-project') }
-  let(:bundler_project)     { described_class.new(bundler_project_dir)   }
+  let(:bundler_project)     { described_class.new(bundler_project_dir)  }
 
   describe "directories" do
     let(:directory) { rubygems_project_dir }
 
-    it "should map paths to #{described_class} instances" do
+    it "must map paths to #{described_class} instances" do
       project = described_class.directories[directory]
 
       expect(project.root).to eq(directory)
@@ -29,7 +29,7 @@ describe Gem::Tasks::Project do
   describe "#name" do
     subject { rubygems_project }
 
-    it "should use the name of the directory" do
+    it "must use the name of the directory" do
       expect(subject.name).to eq('rubygems-project')
     end
   end
@@ -37,7 +37,7 @@ describe Gem::Tasks::Project do
   describe "#scm" do
     subject { bundler_project }
 
-    it "should detect the SCM used" do
+    it "must detect the SCM used" do
       expect(subject.scm).to eq(:git)
     end
   end
@@ -46,7 +46,7 @@ describe Gem::Tasks::Project do
     context "with single-gemspec project" do
       subject { rubygems_project }
 
-      it "should load the single-gemspec" do
+      it "must load the single-gemspec" do
         expect(subject.gemspecs.values.map(&:name)).to eq(%w[rubygems-project])
       end
     end
@@ -54,7 +54,7 @@ describe Gem::Tasks::Project do
     context "with multi-gemspec project" do
       subject { rubygems_multi_project }
 
-      it "should load all gemspecs" do
+      it "must load all gemspecs" do
         expect(subject.gemspecs.values.map(&:name)).to match_array(%w[
           rubygems-project
           rubygems-project-lite
@@ -67,7 +67,7 @@ describe Gem::Tasks::Project do
     context "with single-gemspec project" do
       subject { rubygems_project }
 
-      it "should match the directory name to the gemspec" do
+      it "must match the directory name to the gemspec" do
         expect(subject.primary_gemspec).to eq(subject.name)
       end
     end
@@ -75,7 +75,7 @@ describe Gem::Tasks::Project do
     context "with multi-gemspec project" do
       subject { rubygems_multi_project }
 
-      it "should pick the first gemspec" do
+      it "must pick the first gemspec" do
         expect(subject.primary_gemspec).to eq('rubygems-project')
       end
     end
@@ -85,11 +85,11 @@ describe Gem::Tasks::Project do
     context "with single-gemspec project" do
       subject { rubygems_project }
 
-      it "should default the directory name to the gemspec" do
+      it "must default the directory name to the gemspec" do
         expect(subject.gemspec.name).to eq(subject.name)
       end
 
-      it "should raise an ArgumentError for unknown gemspec names" do
+      it "must raise an ArgumentError for unknown gemspec names" do
         expect { subject.gemspec('foo') }.to raise_error(ArgumentError)
       end
     end
@@ -97,11 +97,11 @@ describe Gem::Tasks::Project do
     context "with multi-gemspec project" do
       subject { rubygems_multi_project }
 
-      it "should default the first gemspec" do
+      it "must default the first gemspec" do
         expect(subject.gemspec.name).to eq('rubygems-project')
       end
 
-      it "should allow accessing alternate gemspecs" do
+      it "must allow accessing alternate gemspecs" do
         alternate = 'rubygems-project-lite'
 
         expect(subject.gemspec(alternate).name).to eq(alternate)
@@ -112,11 +112,11 @@ describe Gem::Tasks::Project do
   describe "#builds" do
     subject { rubygems_multi_project }
 
-    it "should group builds by gemspec name" do
+    it "must group builds by gemspec name" do
       expect(subject.builds.keys).to be == subject.gemspecs.keys
     end
 
-    it "should map a package format to a pkg/ path" do
+    it "must map a package format to a pkg/ path" do
       packages = subject.builds['rubygems-project']
 
       expect(packages['tar.gz']).to eq('pkg/rubygems-project-1.2.3.tar.gz')
@@ -125,7 +125,7 @@ describe Gem::Tasks::Project do
     context "with single-gemspec project" do
       subject { rubygems_project }
 
-      it "should only have a key for the single-gemspec" do
+      it "must only have a key for the single-gemspec" do
         expect(subject.builds.keys).to eq(%w[rubygems-project])
       end
     end
@@ -133,7 +133,7 @@ describe Gem::Tasks::Project do
     context "with multi-gemspec project" do
       subject { rubygems_multi_project }
 
-      it "should have keys for each gemspec" do
+      it "must have keys for each gemspec" do
         expect(subject.builds.keys).to match_array(%w[
           rubygems-project
           rubygems-project-lite
@@ -146,7 +146,7 @@ describe Gem::Tasks::Project do
     context "with Bundler" do
       subject { bundler_project }
 
-      it "should detect the 'Gemfile' file" do
+      it "must detect the 'Gemfile' file" do
         expect(subject.bundler?).to be_truthy
       end
     end
@@ -154,7 +154,7 @@ describe Gem::Tasks::Project do
     context "without Bundler" do
       subject { rubygems_project }
 
-      it "should be false" do
+      it "must be false" do
         expect(subject.bundler?).to be_falsey
       end
     end

data/spec/push_spec.rb

@@ -10,7 +10,7 @@ describe Gem::Tasks::Push do
     let(:path) { 'pkg/foo-1.2.3.gem' }
 
     context "defaults" do
-      it "should use `gem push`" do
+      it "must use `gem push`" do
         expect(subject).to receive(:run).with('gem', 'push', path)
 
         subject.push(path)
@@ -20,13 +20,25 @@ describe Gem::Tasks::Push do
     context "with custom :host" do
       let(:host) { 'internal.company.com' }
 
-      subject { described_class.new(:host => host) }
+      subject { described_class.new(host: host) }
 
-      it "should include the --host option" do
+      it "must include the --host option" do
         expect(subject).to receive(:run).with('gem', 'push', path, '--host', host)
 
         subject.push(path)
       end
     end
+
+    context "with custom :key" do
+      let(:key) { '098f6bcd4621d373cade4e832627b4f6' }
+
+      subject { described_class.new(key: key) }
+
+      it "should include the --key option" do
+        expect(subject).to receive(:run).with('gem', 'push', path, '--key', key)
+
+        subject.push(path)
+      end
+    end
   end
 end

data/spec/scm/push_spec.rb

@@ -5,8 +5,8 @@ require 'rubygems/tasks/scm/push'
 
 describe Gem::Tasks::SCM::Push do
   describe "#push!" do
-    context "git" do
-      it "should run `git push --tags`" do
+    context "when the project's SCM type is :git" do
+      it "must run `git push --tags`" do
         allow(subject.project).to receive(:scm).and_return(:git)
         expect(subject).to receive(:run).with('git', 'push')
         expect(subject).to receive(:run).with('git', 'push', '--tags')
@@ -15,8 +15,8 @@ describe Gem::Tasks::SCM::Push do
       end
     end
 
-    context "hg" do
-      it "should run `hg push`" do
+    context "when the project's SCM type is :hg" do
+      it "must run `hg push`" do
         allow(subject.project).to receive(:scm).and_return(:hg)
         expect(subject).to receive(:run).with('hg', 'push')
 
@@ -24,8 +24,8 @@ describe Gem::Tasks::SCM::Push do
       end
     end
 
-    context "otherwise" do
-      it "should return true" do
+    context "when the project's SCM type is :svn" do
+      it "must return true" do
         allow(subject.project).to receive(:scm).and_return(:svn)
 
         expect(subject.push!).to eq(true)

data/spec/scm/status_spec.rb

@@ -4,11 +4,11 @@ require 'rake_context'
 require 'rubygems/tasks/scm/status'
 
 describe Gem::Tasks::SCM::Status do
-  describe "#status" do
-    context "git" do
-      include_context "rake"
+  include_context "rake"
 
-      it "should run `git status --untracked-files=no`" do
+  describe "#status" do
+    context "when the project's SCM type is :git" do
+      it "must run `git status --untracked-files=no`" do
         allow(subject.project).to receive(:scm).and_return(:git)
 
         expect(subject).to receive(:run).with(
@@ -19,10 +19,8 @@ describe Gem::Tasks::SCM::Status do
       end
     end
 
-    context "hg" do
-      include_context "rake"
-
-      it "should run `hg status --quiet`" do
+    context "when the project's SCM type is :hg" do
+      it "must run `hg status --quiet`" do
         allow(subject.project).to receive(:scm).and_return(:hg)
 
         expect(subject).to receive(:run).with(
@@ -33,10 +31,8 @@ describe Gem::Tasks::SCM::Status do
       end
     end
 
-    context "svn" do
-      include_context "rake"
-
-      it "should run `svn status --quiet`" do
+    context "when the project's SCM type is :svn" do
+      it "must run `svn status --quiet`" do
         allow(subject.project).to receive(:scm).and_return(:svn)
 
         expect(subject).to receive(:run).with(

data/spec/scm/tag_spec.rb

@@ -4,35 +4,33 @@ require 'rake_context'
 require 'rubygems/tasks/scm/tag'
 
 describe Gem::Tasks::SCM::Tag do
+  include_context "rake"
+
   let(:version) { '1.2.3' }
 
   describe "#version_tag" do
-    context "defaults" do
-      include_context "rake"
-
-      it "should have a 'v' prefix" do
+    context "when #format is #{described_class}::DEFAULT_FORMAT" do
+      it "must have a 'v' prefix" do
         expect(subject.version_tag(version)).to eq("v#{version}")
       end
     end
 
-    context "with format String" do
-      include_context "rake"
-
+    context "when #format is a format String" do
       let(:format) { 'release-%s' }
 
       subject { described_class.new(format: format) }
 
-      it "should apply the format String to the version" do
+      it "must apply the format String to the version" do
         expect(subject.version_tag(version)).to eq("release-#{version}")
       end
     end
 
-    context "with format Proc" do
+    context "when #format is a Proc" do
       let(:format) { proc { |ver| "REL_" + ver.tr('.','_') } }
 
       subject { described_class.new(format: format) }
 
-      it "should call the format Proc with the version" do
+      it "must call the format Proc with the version" do
         expect(subject.version_tag(version)).to eq("REL_1_2_3")
       end
     end
@@ -42,13 +40,11 @@ describe Gem::Tasks::SCM::Tag do
     let(:name)    { "v#{version}"        }
     let(:message) { "Tagging #{name}"    }
 
-    context "git" do
-      context "without signing" do
-        include_context "rake"
-
+    context "when the project's SCM type is :git" do
+      context "but signing is disabled" do
         subject { described_class.new(sign: false) }
 
-        it "should run `git tag`" do
+        it "must run `git tag`" do
           allow(subject.project).to receive(:scm).and_return(:git)
 
           expect(subject).to receive(:run).with(
@@ -59,12 +55,10 @@ describe Gem::Tasks::SCM::Tag do
         end
       end
 
-      context "signing" do
-        include_context "rake"
-
+      context "and signing is enabled" do
         subject { described_class.new(sign: true) }
 
-        it "should run `git tag -s`" do
+        it "must run `git tag -s`" do
           allow(subject.project).to receive(:scm).and_return(:git)
 
           expect(subject).to receive(:run).with(
@@ -76,13 +70,11 @@ describe Gem::Tasks::SCM::Tag do
       end
     end
 
-    context "hg" do
-      context "without signing" do
-        include_context "rake"
-
+    context "when the project's SCM type is :hg" do
+      context "but signing is disabled" do
         subject { described_class.new(sign: false) }
 
-        it "should run `hg tag`" do
+        it "must run `hg tag`" do
           allow(subject.project).to receive(:scm).and_return(:hg)
 
           expect(subject).to receive(:run).with(
@@ -93,12 +85,10 @@ describe Gem::Tasks::SCM::Tag do
         end
       end
 
-      context "with signing" do
-        include_context "rake"
-
+      context "and signing is enabled" do
         subject { described_class.new(sign: true) }
 
-        it "should run `hg sign` then `hg tag`" do
+        it "must run `hg sign` then `hg tag`" do
           allow(subject.project).to receive(:scm).and_return(:hg)
 
           expect(subject).to receive(:run).with(

data/spec/scm_spec.rb

@@ -0,0 +1,72 @@
+require 'spec_helper'
+require 'rake_context'
+
+require 'rubygems/tasks/scm'
+
+describe Gem::Tasks::SCM do
+  include_context "rake"
+
+  describe "#initialize" do
+    context "when given no keyword arguments" do
+      it "must initialize #status by default" do
+        expect(subject.status).to be_a(Gem::Tasks::SCM::Status)
+      end
+
+      it "must initialize #tag by default" do
+        expect(subject.tag).to be_a(Gem::Tasks::SCM::Tag)
+      end
+
+      it "must initialize #push by default" do
+        expect(subject.push).to be_a(Gem::Tasks::SCM::Push)
+      end
+    end
+
+    context "when given `status: true`" do
+      subject { described_class.new(status: true) }
+
+      it "must initialize #status" do
+        expect(subject.status).to be_a(Gem::Tasks::SCM::Status)
+      end
+    end
+
+    context "when given `status: false`" do
+      subject { described_class.new(status: false) }
+
+      it "must not initialize #status" do
+        expect(subject.status).to be(nil)
+      end
+    end
+
+    context "when given `tag: true`" do
+      subject { described_class.new(tag: true) }
+
+      it "must initialize #tag" do
+        expect(subject.tag).to be_a(Gem::Tasks::SCM::Tag)
+      end
+    end
+
+    context "when given `tag: false`" do
+      subject { described_class.new(tag: false) }
+
+      it "must not initialize #tag" do
+        expect(subject.tag).to be(nil)
+      end
+    end
+
+    context "when given `push: true`" do
+      subject { described_class.new(push: true) }
+
+      it "must initialize #push" do
+        expect(subject.push).to be_a(Gem::Tasks::SCM::Push)
+      end
+    end
+
+    context "when given `push: false`" do
+      subject { described_class.new(push: false) }
+
+      it "must not initialize #push" do
+        expect(subject.push).to be(nil)
+      end
+    end
+  end
+end

data/spec/sign/pgp_spec.rb

@@ -9,7 +9,7 @@ describe Gem::Tasks::Sign::PGP do
 
     let(:path) { File.join('pkg','foo-1.2.3.gem') }
 
-    it "should run `gpg --sign --detach-sign --armor ...`" do
+    it "must run `gpg --sign --detach-sign --armor ...`" do
       expect(subject).to receive(:run).with(
         'gpg', '--sign', '--detach-sign', '--armor', path
       )

data/spec/sign_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+require 'rake_context'
+
+require 'rubygems/tasks/sign'
+
+describe Gem::Tasks::Sign do
+  include_context "rake"
+
+  describe "#initialize" do
+    context "when given no keyword arguments" do
+      it "must not initialize #checksum by default" do
+        expect(subject.checksum).to be(nil)
+      end
+
+      it "must not initialize #pgp by default" do
+        expect(subject.pgp).to be(nil)
+      end
+    end
+
+    context "when given `checksum: true`" do
+      subject { described_class.new(checksum: true) }
+
+      it "must initialize #checksum" do
+        expect(subject.checksum).to be_a(Gem::Tasks::Sign::Checksum)
+      end
+    end
+
+    context "when given `checksum: false`" do
+      subject { described_class.new(checksum: false) }
+
+      it "must not initialize #checksum" do
+        expect(subject.checksum).to be(nil)
+      end
+    end
+
+    context "when given `pgp: true`" do
+      subject { described_class.new(pgp: true) }
+
+      it "must initialize #pgp" do
+        expect(subject.pgp).to be_a(Gem::Tasks::Sign::PGP)
+      end
+    end
+
+    context "when given `pgp: false`" do
+      subject { described_class.new(pgp: false) }
+
+      it "must not initialize #pgp" do
+        expect(subject.pgp).to be(nil)
+      end
+    end
+  end
+end