rubyforge 1.0.0 → 1.0.1

data/History.txt

@@ -1,5 +1,10 @@
 == Version History:
 
+=== 1.0.1 / 2008-10-22:
+
+* Fixed multipart form upload so it isn't url escaping the data. DOH.
+  * Affects release_notes and release_changes, but never reported for 5 months.
+
 === 1.0.0 / 2008-05-20:
 
 * Removed HTTPAccess2, thanks to Aaron Patterson. Even tho he's whiny.

data/Rakefile

@@ -8,11 +8,8 @@ rescue LoadError
        please install it via rubygems."
 end
 
-Object.send :remove_const, :RubyForge if defined? RubyForge
-
-$LOAD_PATH << "./lib"
-
-require './lib/rubyforge'
+abort "you _must_ install this gem to release it" if
+  ENV['VERSION'] && ENV['VERSION'] != RubyForge::VERSION
 
 Hoe.new("rubyforge", RubyForge::VERSION) do |rubyforge|
   rubyforge.rubyforge_name = "codeforpeople"
@@ -22,7 +19,6 @@ Hoe.new("rubyforge", RubyForge::VERSION) do |rubyforge|
   rubyforge.developer('Eric Hodel', 'drbrain@segment7.net')
   rubyforge.developer('Ara T Howard', 'ara.t.howard@gmail.com')
 
-
   rubyforge.multiruby_skip << "rubinius"
 end
 

data/lib/rubyforge/client.rb

@@ -14,7 +14,7 @@ class Time
       old_utc(*args)
     end
   end
-end
+end unless Time.respond_to? :old_utc
 
 # clean up "using default DH parameters" warning for https
 class Net::HTTP
@@ -23,7 +23,7 @@ class Net::HTTP
     self.old_use_ssl = flag
     @ssl_context.tmp_dh_callback = proc {}
   end
-end
+end unless Net::HTTP.public_instance_methods.include? "old_use_ssl="
 
 class RubyForge
   class Client
@@ -103,17 +103,17 @@ class RubyForge
         parameter = "--#{boundary}\r\nContent-Disposition: form-data; name=\"" +
             WEBrick::HTTPUtils.escape_form(k.to_s) + "\""
 
-        if v.respond_to?(:path)
+        if v.respond_to? :path
           parameter += "; filename=\"#{File.basename(v.path)}\"\r\n"
           parameter += "Content-Transfer-Encoding: binary\r\n"
           parameter += "Content-Type: text/plain"
         end
         parameter += "\r\n\r\n"
 
-        if v.respond_to?(:path)
+        if v.respond_to? :path
           parameter += v.read
         else
-          parameter += WEBrick::HTTPUtils.escape_form(v.to_s)
+          parameter += v.to_s
         end
 
         parameter

data/lib/rubyforge.rb

@@ -11,7 +11,7 @@ $TESTING = false unless defined? $TESTING
 class RubyForge
 
   # :stopdoc:
-  VERSION     = '1.0.0'
+  VERSION     = '1.0.1'
   HOME        = ENV["HOME"] || ENV["HOMEPATH"] || File::expand_path("~")
   RUBYFORGE_D = File::join HOME, ".rubyforge"
   CONFIG_F    = File::join RUBYFORGE_D, "user-config.yml"
@@ -267,9 +267,11 @@ class RubyForge
     processor_id ||= "Any"
     processor_id = lookup "processor", processor_id
 
-    release_notes = IO::read(release_notes) if release_notes and test(?e, release_notes)
+    release_notes = IO::read(release_notes) if
+      test(?e, release_notes) if release_notes
 
-    release_changes = IO::read(release_changes) if release_changes and test(?e, release_changes)
+    release_changes = IO::read(release_changes) if
+      test(?e, release_changes) if release_changes
 
     preformatted = preformatted ? 1 : 0
 

data/test/test_rubyforge_client.rb

@@ -46,8 +46,8 @@ class TestRubyForgeClient < Test::Unit::TestCase
   end
 
   def test_post_with_params
-    @client.post_content('http://example.com', { :f => 'adsf'})
-    assert_equal('f=adsf', RubyForge::FakeAgent.t_data)
+    @client.post_content('http://example.com', { :f => 'adsf aoeu'})
+    assert_equal('f=adsf+aoeu', RubyForge::FakeAgent.t_data)
 
     @client.post_content('http://example.com', { :a => 'b', :c => 'd' })
     assert_equal('a=b&c=d', RubyForge::FakeAgent.t_data)
@@ -57,18 +57,18 @@ class TestRubyForgeClient < Test::Unit::TestCase
     random = Array::new(8){ "%2.2d" % rand(42) }.join('__')
     boundary = "multipart/form-data; boundary=___#{ random }___"
 
-    request = <<-END
+    expected = <<-END
 --___#{random}___\r
 Content-Disposition: form-data; name="a"\r\n\r
-b\r
+a b c\r
 --___#{random}___--\r
 END
 
     @client.post_content( 'http://example.com',
-                          { :a => 'b' },
+                          { :a => 'a b c' },
                           { 'content-type' => boundary }
                         )
-    assert_equal(request, RubyForge::FakeAgent.t_data)
+    assert_equal(expected, RubyForge::FakeAgent.t_data)
   end
 
   def test_multipart_post_two_params

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rubyforge
 version: !ruby/object:Gem::Version 
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors: 
 - Ryan Davis
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-05-20 00:00:00 -07:00
+date: 2008-10-22 00:00:00 -05:00
 default_executable: 
 dependencies: []
 
@@ -63,7 +63,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: codeforpeople
-rubygems_version: 1.1.1
+rubygems_version: 1.3.0
 signing_key: 
 specification_version: 2
 summary: A script which automates a limited set of rubyforge operations