rubycritic 4.8.1 → 4.9.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (10) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +14 -1
  3. data/README.md +1 -2
  4. data/Rakefile +1 -1
  5. data/lib/rubycritic/analysers/helpers/modules_locator.rb +1 -1
  6. data/lib/rubycritic/commands/compare.rb +4 -0
  7. data/lib/rubycritic/generators/html/view_helpers.rb +4 -1
  8. data/lib/rubycritic/source_control_systems/git/churn.rb +10 -0
  9. data/lib/rubycritic/version.rb +1 -1
  10. metadata +53 -15
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 3947b3bda3c1df0be0e1dd53c54c12444dbb783cf1af0943f1eba708a17a810f
4
- data.tar.gz: 93e1f9a59ffa8418c73fe731984d784af87327d8c371497a89af243eb47c5c87
3
+ metadata.gz: 5e02409fa512f3a1b9449ee32bcaf96a8a0b8de76761252475774fa190ca2059
4
+ data.tar.gz: 928090c08aff3e873916412a2b0ebc947e64495ade84fc60503534e0b531dad4
5
5
  SHA512:
6
- metadata.gz: f33ccecd5a6333af4542fc5f2e5b946d83953b1c8833493523f9f3c6a05fcac6c7547eafda74b5e9d8d3cd6926a86c3350add816076520c35ae781b83160e70e
7
- data.tar.gz: '0589b2472473c73982aa9742738c25ddfb9de3692a43ba200ed0a973a59e87ebead86f07d771562f4d8d8ee729efd0c56421dee62879fa4904830f5c335b492e'
6
+ metadata.gz: de7584c2a57e92752da20be9a561164234347a7e24d0a8ee036cd54ff213a8f096aec0e7f299f0f534bf260a587314488f26bcdbf61639f47456d276aeebd200
7
+ data.tar.gz: 2988c1a400c24ce70b6468cafb7a70459830d9db42d928e714b552b2cfa6c53baf656d6ed92eea63b89a5a678451bce09e23018481c0992ff9ddbb11b8430e13
data/CHANGELOG.md CHANGED
@@ -1,4 +1,16 @@
1
- # main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.8.1...main)
1
+ # main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.9.0...main)
2
+
3
+ # v4.9.0 / 2023-10-18 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.8.1...v4.9.0)
4
+
5
+ * [CHANGE] Bump aruba, cucumber, fakefs, flog, mdl, minitest, and rubocop dependencies (by [@faisal][])
6
+ * [CHANGE] Fix test warning related to `cucumber_opts` declaration (by [@faisal][])
7
+ * [BUGFIX] Stop using long-deprecated MiniTest module name, removed in 5.19.0 (by [@faisal][])
8
+ * [CHANGE] Disable VERBOSE warnings in test stubs (by [@fbuys][])
9
+ * [CHANGE] Add rexml dependency for Ruby 3.0.0+ support (by [@fbuys][])
10
+ * [BUGFIX] Raise error when the same branches are compared (by [@rishijain][])
11
+ * [BUGFIX] Churn score was always 0 when rubycritic was executed from a sub-directory (by [@rishijain][])
12
+ * [BUGFIX] Use overview.html as the fallback path when files does not exist during compare option (by [@rishijain][])
13
+ * [BUGFIX] Use name from the file path instead of fetching name from the parser (by [@rishijain][])
2
14
 
3
15
  # v4.8.1 / 2023-05-17 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.8.0...v4.8.1)
4
16
 
@@ -429,3 +441,4 @@
429
441
  [@faisal]: https://github.com/faisal
430
442
  [@96RadhikaJadhav]: https://github.com/96RadhikaJadhav
431
443
  [@Fito]: https://github.com/Fito
444
+ [@fbuys]: https://github.com/fbuys
data/README.md CHANGED
@@ -2,7 +2,6 @@
2
2
 
3
3
  [![Gem Version](https://badge.fury.io/rb/rubycritic.svg)](http://badge.fury.io/rb/rubycritic)
4
4
  [![Continuous Integration](https://github.com/whitesmith/rubycritic/actions/workflows/main.yml/badge.svg?branch=main)](https://github.com/whitesmith/rubycritic/actions/workflows/main.yml)
5
- [![Build Status](https://travis-ci.org/whitesmith/rubycritic.svg?branch=master)](https://travis-ci.org/whitesmith/rubycritic)
6
5
  [![Code Climate](https://codeclimate.com/github/whitesmith/rubycritic/badges/gpa.svg)](https://codeclimate.com/github/whitesmith/rubycritic)
7
6
 
8
7
  <img src="https://github.com/whitesmith/rubycritic/raw/main/images/logo.png" alt="RubyCritic Icon" align="right">
@@ -236,7 +235,7 @@ See [formatters](docs/formatters.md)
236
235
  RubyCritic is supporting Ruby versions:
237
236
 
238
237
  | Ruby version | Latest RubyCritic version |
239
- | - | - |
238
+ | --- | --- |
240
239
  | 2.4 | [v4.7.0](https://github.com/whitesmith/rubycritic/tree/v4.7.0) |
241
240
  | 2.5 | [v4.7.0](https://github.com/whitesmith/rubycritic/tree/v4.7.0) |
242
241
  | 2.6 | [v4.7.0](https://github.com/whitesmith/rubycritic/tree/v4.7.0) |
data/Rakefile CHANGED
@@ -14,7 +14,7 @@ Rake::TestTask.new do |task|
14
14
  end
15
15
 
16
16
  Cucumber::Rake::Task.new(:features) do |t|
17
- t.cucumber_opts = 'features --format progress --color'
17
+ t.cucumber_opts = %w[features --format progress --color]
18
18
  end
19
19
 
20
20
  RuboCop::RakeTask.new
data/lib/rubycritic/analysers/helpers/modules_locator.rb CHANGED
@@ -9,7 +9,7 @@ module RubyCritic
9
9
  end
10
10
 
11
11
  def first_name
12
- names.first
12
+ name_from_path.first
13
13
  end
14
14
 
15
15
  def names
data/lib/rubycritic/commands/compare.rb CHANGED
@@ -18,6 +18,10 @@ module RubyCritic
18
18
  end
19
19
 
20
20
  def execute
21
+ if Config.send(:base_branch) == Config.send(:feature_branch)
22
+ raise('The branch you are on and are comparing with are the same.
23
+ Please switch to a different branch or choose a different branch to compare.')
24
+ end
21
25
  compare_branches
22
26
  status_reporter.score = Config.feature_branch_score
23
27
  status_reporter
data/lib/rubycritic/generators/html/view_helpers.rb CHANGED
@@ -24,7 +24,10 @@ module RubyCritic
24
24
  end
25
25
 
26
26
  def code_index_path(root_directory, file_name)
27
- file_path("#{File.expand_path(root_directory)}/#{file_name}")
27
+ root_directory_path = File.expand_path(root_directory)
28
+ index_path = "#{root_directory_path}/#{file_name}"
29
+ index_path = "#{root_directory_path}/overview.html" unless File.exist?(index_path)
30
+ file_path(index_path)
28
31
  end
29
32
 
30
33
  private
data/lib/rubycritic/source_control_systems/git/churn.rb CHANGED
@@ -73,6 +73,7 @@ module RubyCritic
73
73
  when /^[RC]/
74
74
  process_rename(*rest)
75
75
  else
76
+ rest = filename_for_subdirectory(rest[0])
76
77
  process_file(*rest)
77
78
  end
78
79
  end
@@ -86,6 +87,15 @@ module RubyCritic
86
87
  process_file(to)
87
88
  end
88
89
 
90
+ def filename_for_subdirectory(filename)
91
+ git_path = Git.git('rev-parse --show-toplevel')
92
+ cd_path = Dir.pwd
93
+ if cd_path.length > git_path.length
94
+ filename = filename.sub(/^#{Regexp.escape("#{File.basename(cd_path)}/")}/, '')
95
+ end
96
+ [filename]
97
+ end
98
+
89
99
  def process_file(filename)
90
100
  record_commit(renames.current(filename), @date)
91
101
  end
data/lib/rubycritic/version.rb CHANGED
@@ -1,5 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  module RubyCritic
4
- VERSION = '4.8.1'.freeze
4
+ VERSION = '4.9.0'.freeze
5
5
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: rubycritic
3
3
  version: !ruby/object:Gem::Version
4
- version: 4.8.1
4
+ version: 4.9.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Guilherme Simoes
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2023-05-17 00:00:00.000000000 Z
11
+ date: 2023-10-18 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: flay
@@ -30,14 +30,14 @@ dependencies:
30
30
  requirements:
31
31
  - - "~>"
32
32
  - !ruby/object:Gem::Version
33
- version: '4.6'
33
+ version: '4.7'
34
34
  type: :runtime
35
35
  prerelease: false
36
36
  version_requirements: !ruby/object:Gem::Requirement
37
37
  requirements:
38
38
  - - "~>"
39
39
  - !ruby/object:Gem::Version
40
- version: '4.6'
40
+ version: '4.7'
41
41
  - !ruby/object:Gem::Dependency
42
42
  name: launchy
43
43
  requirement: !ruby/object:Gem::Requirement
@@ -100,6 +100,20 @@ dependencies:
100
100
  - - "<"
101
101
  - !ruby/object:Gem::Version
102
102
  version: '7.0'
103
+ - !ruby/object:Gem::Dependency
104
+ name: rexml
105
+ requirement: !ruby/object:Gem::Requirement
106
+ requirements:
107
+ - - ">="
108
+ - !ruby/object:Gem::Version
109
+ version: '0'
110
+ type: :runtime
111
+ prerelease: false
112
+ version_requirements: !ruby/object:Gem::Requirement
113
+ requirements:
114
+ - - ">="
115
+ - !ruby/object:Gem::Version
116
+ version: '0'
103
117
  - !ruby/object:Gem::Dependency
104
118
  name: ruby_parser
105
119
  requirement: !ruby/object:Gem::Requirement
@@ -162,14 +176,14 @@ dependencies:
162
176
  requirements:
163
177
  - - "~>"
164
178
  - !ruby/object:Gem::Version
165
- version: 2.1.0
179
+ version: 2.2.0
166
180
  type: :development
167
181
  prerelease: false
168
182
  version_requirements: !ruby/object:Gem::Requirement
169
183
  requirements:
170
184
  - - "~>"
171
185
  - !ruby/object:Gem::Version
172
- version: 2.1.0
186
+ version: 2.2.0
173
187
  - !ruby/object:Gem::Dependency
174
188
  name: bundler
175
189
  requirement: !ruby/object:Gem::Requirement
@@ -210,14 +224,20 @@ dependencies:
210
224
  requirements:
211
225
  - - "~>"
212
226
  - !ruby/object:Gem::Version
213
- version: 8.0.0
227
+ version: 9.0.2
228
+ - - "!="
229
+ - !ruby/object:Gem::Version
230
+ version: 9.0.0
214
231
  type: :development
215
232
  prerelease: false
216
233
  version_requirements: !ruby/object:Gem::Requirement
217
234
  requirements:
218
235
  - - "~>"
219
236
  - !ruby/object:Gem::Version
220
- version: 8.0.0
237
+ version: 9.0.2
238
+ - - "!="
239
+ - !ruby/object:Gem::Version
240
+ version: 9.0.0
221
241
  - !ruby/object:Gem::Dependency
222
242
  name: diff-lcs
223
243
  requirement: !ruby/object:Gem::Requirement
@@ -238,19 +258,22 @@ dependencies:
238
258
  requirements:
239
259
  - - "~>"
240
260
  - !ruby/object:Gem::Version
241
- version: 2.4.0
261
+ version: 2.5.0
242
262
  type: :development
243
263
  prerelease: false
244
264
  version_requirements: !ruby/object:Gem::Requirement
245
265
  requirements:
246
266
  - - "~>"
247
267
  - !ruby/object:Gem::Version
248
- version: 2.4.0
268
+ version: 2.5.0
249
269
  - !ruby/object:Gem::Dependency
250
270
  name: mdl
251
271
  requirement: !ruby/object:Gem::Requirement
252
272
  requirements:
253
273
  - - "~>"
274
+ - !ruby/object:Gem::Version
275
+ version: 0.13.0
276
+ - - ">="
254
277
  - !ruby/object:Gem::Version
255
278
  version: 0.12.0
256
279
  type: :development
@@ -258,12 +281,18 @@ dependencies:
258
281
  version_requirements: !ruby/object:Gem::Requirement
259
282
  requirements:
260
283
  - - "~>"
284
+ - !ruby/object:Gem::Version
285
+ version: 0.13.0
286
+ - - ">="
261
287
  - !ruby/object:Gem::Version
262
288
  version: 0.12.0
263
289
  - !ruby/object:Gem::Dependency
264
290
  name: minitest
265
291
  requirement: !ruby/object:Gem::Requirement
266
292
  requirements:
293
+ - - "~>"
294
+ - !ruby/object:Gem::Version
295
+ version: 5.20.0
267
296
  - - ">="
268
297
  - !ruby/object:Gem::Version
269
298
  version: 5.3.0
@@ -271,6 +300,9 @@ dependencies:
271
300
  prerelease: false
272
301
  version_requirements: !ruby/object:Gem::Requirement
273
302
  requirements:
303
+ - - "~>"
304
+ - !ruby/object:Gem::Version
305
+ version: 5.20.0
274
306
  - - ">="
275
307
  - !ruby/object:Gem::Version
276
308
  version: 5.3.0
@@ -300,14 +332,14 @@ dependencies:
300
332
  requirements:
301
333
  - - "~>"
302
334
  - !ruby/object:Gem::Version
303
- version: 2.0.2
335
+ version: 2.1.0
304
336
  type: :development
305
337
  prerelease: false
306
338
  version_requirements: !ruby/object:Gem::Requirement
307
339
  requirements:
308
340
  - - "~>"
309
341
  - !ruby/object:Gem::Version
310
- version: 2.0.2
342
+ version: 2.1.0
311
343
  - !ruby/object:Gem::Dependency
312
344
  name: rake
313
345
  requirement: !ruby/object:Gem::Requirement
@@ -348,14 +380,20 @@ dependencies:
348
380
  requirements:
349
381
  - - "~>"
350
382
  - !ruby/object:Gem::Version
351
- version: 1.51.0
383
+ version: 1.57.1
384
+ - - ">="
385
+ - !ruby/object:Gem::Version
386
+ version: 1.54.0
352
387
  type: :development
353
388
  prerelease: false
354
389
  version_requirements: !ruby/object:Gem::Requirement
355
390
  requirements:
356
391
  - - "~>"
357
392
  - !ruby/object:Gem::Version
358
- version: 1.51.0
393
+ version: 1.57.1
394
+ - - ">="
395
+ - !ruby/object:Gem::Version
396
+ version: 1.54.0
359
397
  - !ruby/object:Gem::Dependency
360
398
  name: rubocop-minitest
361
399
  requirement: !ruby/object:Gem::Requirement
@@ -541,7 +579,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
541
579
  - !ruby/object:Gem::Version
542
580
  version: '0'
543
581
  requirements: []
544
- rubygems_version: 3.1.6
582
+ rubygems_version: 3.3.7
545
583
  signing_key:
546
584
  specification_version: 4
547
585
  summary: RubyCritic is a Ruby code quality reporter