rubycritic 4.9.2 → 4.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 78f041e961ddd2844538f7fca6622192a8b2a9f64caa540cb8fc4b08f13362e0
-  data.tar.gz: 1bb52128d47548eb1969869552d26e7ef81940c61aa22b85777652f1a53659f1
+  metadata.gz: ffa925049a3ca35743b419abfa744f93b7a4c7f3a5c6ee702703eff959c05177
+  data.tar.gz: 1349a8bf0b72de99e5d7415dc3fd59dbacfe93683a20c5e7c25285243a11f28e
 SHA512:
-  metadata.gz: 202a4ba45550da029562867c284a941c65666c013fbd75dfa2be0443ce2483149f4c2c751584ff90c10242014a8f630750e6413571304b3927faecb093062b8a
-  data.tar.gz: 9e4af57d0f10840698a488da7ce77951ef693c022fa16888bc1387fa73d9e3067eab3cd2ee7a690e4640880940426627b3b3089576c21671c408b7af77a41467
+  metadata.gz: b7487d521e1c7070d3cb30430e8d5ea023a2baad07a69a2d0e540ba28c014d7caef9b9727585b0731775281cde5a31f1f7a20fb46112e4eb86c6938f2b249fe2
+  data.tar.gz: eb343b8c57606946ccc3439275eb829c06cf52c3557f63661c85923a4b1a7babc587ba3bcdabf3297adc69a725ad62fde6c2cc0634890ba24176d89c599e9145

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.9.2...main)
 
+# v4.10.0 / 2025-07-30 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.9.2...v4.10.0)
+
+* [CHANGE] Bump aruba, byebug, cucumber, fakefs, rake, reek dependencies (by [@faisal][])
+* [BUGFIX] Work around issue preventing feature execution on Ruby 3.5.0dev (by [@faisal][])
+* [CHANGE] Add changes or suppress warnings for issues found by newer rubocop (by [@faisal][])
+* [CHANGE] Update CI checkout action to v4 (by [@faisal][])
+* [CHANGE] Run RubyCritic outside of the project without losing the churn value (by [@juanvqz][])
+
 # v4.9.2 / 2025-04-08 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.9.1...v4.9.2)
 
 * [CHANGE] Adds development dependency for gems removed from standard library in Ruby 3.5 -- ostruct, irb, rdoc (by [@faisal][])

data/lib/rubycritic/analysers/attributes.rb

@@ -8,6 +8,7 @@ module RubyCritic
   module Analyser
     class Attributes
       include Colorize
+
       def initialize(analysed_modules)
         @analysed_modules = analysed_modules
       end

data/lib/rubycritic/analysers/churn.rb

@@ -6,6 +6,7 @@ module RubyCritic
   module Analyser
     class Churn
       include Colorize
+
       attr_writer :source_control_system
 
       def initialize(analysed_modules)

data/lib/rubycritic/analysers/complexity.rb

@@ -7,6 +7,7 @@ module RubyCritic
   module Analyser
     class Complexity
       include Colorize
+
       def initialize(analysed_modules)
         @flog = Flog.new
         @analysed_modules = analysed_modules

data/lib/rubycritic/analysers/smells/flay.rb

@@ -8,6 +8,7 @@ module RubyCritic
   module Analyser
     class FlaySmells
       include Colorize
+
       def initialize(analysed_modules)
         @analysed_modules = paths_to_analysed_modules(analysed_modules)
         @flay = Flay.new(@analysed_modules.keys)

data/lib/rubycritic/analysers/smells/flog.rb

@@ -8,6 +8,7 @@ module RubyCritic
   module Analyser
     class FlogSmells
       include Colorize
+
       HIGH_COMPLEXITY_SCORE_THRESHOLD = 25
       VERY_HIGH_COMPLEXITY_SCORE_THRESHOLD = 60
 

data/lib/rubycritic/analysers/smells/reek.rb

@@ -8,6 +8,7 @@ module RubyCritic
   module Analyser
     class ReekSmells
       include Colorize
+
       def initialize(analysed_modules)
         @analysed_modules = analysed_modules
       end

data/lib/rubycritic/cli/options/file.rb

@@ -24,11 +24,11 @@ module RubyCritic
             root: root,
             coverage_path: coverage_path,
             formats: formats,
-            deduplicate_symlinks: deduplicate_symlinks,
+            deduplicate_symlinks: deduplicate_symlinks?,
             paths: paths,
-            suppress_ratings: suppress_ratings,
+            suppress_ratings: suppress_ratings?,
             minimum_score: minimum_score,
-            no_browser: no_browser,
+            no_browser: no_browser?,
             base_branch: base_branch,
             feature_branch: feature_branch,
             threshold_score: threshold_score
@@ -68,16 +68,16 @@ module RubyCritic
           options['threshold_score']
         end
 
-        def deduplicate_symlinks
-          value_for(options['deduplicate_symlinks'])
+        def deduplicate_symlinks?
+          value_for?(options['deduplicate_symlinks'])
         end
 
-        def suppress_ratings
-          value_for(options['suppress_ratings'])
+        def suppress_ratings?
+          value_for?(options['suppress_ratings'])
         end
 
-        def no_browser
-          value_for(options['no_browser'])
+        def no_browser?
+          value_for?(options['no_browser'])
         end
 
         def formats
@@ -96,7 +96,7 @@ module RubyCritic
           options['paths']
         end
 
-        def value_for(value)
+        def value_for?(value)
           value = value.to_s
           value == 'true' unless value.empty?
         end

data/lib/rubycritic/commands/status_reporter.rb

@@ -26,10 +26,10 @@ module RubyCritic
       end
 
       def current_status
-        satisfy_minimum_score_rule ? SUCCESS : SCORE_BELOW_MINIMUM
+        satisfy_minimum_score_rule? ? SUCCESS : SCORE_BELOW_MINIMUM
       end
 
-      def satisfy_minimum_score_rule
+      def satisfy_minimum_score_rule?
         score >= @options[:minimum_score].to_f
       end
 

data/lib/rubycritic/rake_task.rb

@@ -71,7 +71,7 @@ module RubyCritic
 
     def print_starting_up_output
       puts "\n\n!!! Running `#{name}` rake command\n"
-      puts "!!! Inspecting #{paths} #{options.empty? ? '' : "with options #{options}"}\n\n"
+      puts "!!! Inspecting #{paths} #{"with options #{options}" unless options.empty?}\n\n"
     end
 
     def options_as_arguments

data/lib/rubycritic/source_control_systems/git/churn.rb

@@ -20,12 +20,16 @@ module RubyCritic
         end
       end
 
+      # :reek:TooManyInstanceVariables
+      # rubocop:disable Metrics/ClassLength
       class Churn
+        # :reek:TooManyStatements
         def initialize(churn_after: nil, paths: ['.'])
           @churn_after = churn_after
           @paths = Array(paths)
           @date = nil
           @stats = {}
+          @git_root = find_git_root
 
           call
         end
@@ -40,16 +44,32 @@ module RubyCritic
 
         private
 
+        # :reek:DuplicateMethodCall
+        def find_git_root
+          @paths.each do |path|
+            current_path = File.expand_path(path)
+            while current_path != File.dirname(current_path)
+              return current_path if Dir.exist?(File.join(current_path, '.git'))
+
+              current_path = File.dirname(current_path)
+            end
+          end
+          Dir.pwd
+        end
+
         def call
           git_log_commands.each { |log_command| exec_git_command(log_command) }
         end
 
         def exec_git_command(command)
-          Git
-            .git(command)
-            .split("\n")
-            .reject(&:empty?)
-            .each { |line| process_line(line) }
+          # Run git command from the git repository root
+          Dir.chdir(@git_root) do
+            Git
+              .git(command)
+              .split("\n")
+              .reject(&:empty?)
+              .each { |line| process_line(line) }
+          end
         end
 
         def git_log_commands
@@ -57,7 +77,20 @@ module RubyCritic
         end
 
         def git_log_command(path)
-          "log --all --date=iso --follow --format='format:date:%x09%ad' --name-status #{after_clause}#{path}"
+          # Convert absolute paths to relative paths from git root
+          relative_path = make_relative_to_git_root(path)
+          "log --all --date=iso --follow --format='format:date:%x09%ad' --name-status #{after_clause}#{relative_path}"
+        end
+
+        def make_relative_to_git_root(path)
+          absolute_path = File.expand_path(path)
+          if absolute_path.start_with?(@git_root)
+            # Convert to relative path from git root
+            absolute_path[(@git_root.length + 1)..] || '.'
+          else
+            # If path is not within git root, use as is
+            path
+          end
         end
 
         def after_clause
@@ -87,13 +120,18 @@ module RubyCritic
           process_file(to)
         end
 
+        # :reek:DuplicateMethodCall
         def filename_for_subdirectory(filename)
-          git_path = Git.git('rev-parse --show-toplevel')
-          cd_path = Dir.pwd
-          if cd_path.length > git_path.length
-            filename = filename.sub(/^#{Regexp.escape("#{File.basename(cd_path)}/")}/, '')
+          if @git_root == Dir.pwd
+            git_path = Git.git('rev-parse --show-toplevel')
+            cd_path = Dir.pwd
+            if cd_path.length > git_path.length
+              filename = filename.sub(/^#{Regexp.escape("#{File.basename(cd_path)}/")}/, '')
+            end
+            [filename]
+          else
+            filename
           end
-          [filename]
         end
 
         def process_file(filename)
@@ -109,10 +147,32 @@ module RubyCritic
           @renames ||= Renames.new
         end
 
+        # :reek:TooManyStatements
+        # rubocop:disable Metrics/MethodLength
         def stats(path)
+          # Try the path as-is first
+          result = @stats.fetch(path, nil)
+          return result if result
+
+          # If not found, try converting absolute path to relative path from git root
+          absolute_path = File.expand_path(path)
+          if absolute_path.start_with?(@git_root)
+            relative_path = absolute_path[(@git_root.length + 1)..]
+            return @stats.fetch(relative_path, Stats.new(0))
+          end
+
+          # If still not found, try converting relative path to absolute path
+          unless path.start_with?('/')
+            absolute_path = File.expand_path(path, @git_root)
+            return @stats.fetch(absolute_path, Stats.new(0))
+          end
+
+          # Default fallback
           @stats.fetch(path, Stats.new(0))
         end
+        # rubocop:enable Metrics/MethodLength
       end
+      # rubocop:enable Metrics/ClassLength
     end
   end
 end

data/lib/rubycritic/source_control_systems/git.rb

@@ -21,8 +21,28 @@ module RubyCritic
         self.class.git(arg)
       end
 
+      # :reek:DuplicateMethodCall
+      # :reek:NilCheck
       def self.supported?
-        git('branch 2>&1') && $CHILD_STATUS.success?
+        return true if git('branch 2>&1') && $CHILD_STATUS.success?
+
+        return false if Config.paths.nil? || Config.paths.empty?
+
+        Config.paths.any? do |path|
+          absolute_path = File.expand_path(path)
+          check_git_repository?(absolute_path)
+        end
+      end
+
+      # :reek:DuplicateMethodCall
+      def self.check_git_repository?(path)
+        current_path = File.expand_path(path)
+        while current_path != File.dirname(current_path)
+          return true if Dir.exist?(File.join(current_path, '.git'))
+
+          current_path = File.dirname(current_path)
+        end
+        false
       end
 
       def self.to_s
@@ -50,7 +70,7 @@ module RubyCritic
       end
 
       def travel_to_head
-        stash_successful = stash_changes
+        stash_successful = stash_changes?
         yield
       ensure
         travel_to_original_state if stash_successful
@@ -88,7 +108,7 @@ module RubyCritic
 
       private
 
-      def stash_changes
+      def stash_changes?
         stashes_count_before = stashes_count
         git('stash')
         stashes_count_after = stashes_count

data/lib/rubycritic/source_control_systems/perforce.rb

@@ -52,9 +52,11 @@ module RubyCritic
         Time.strptime(perforce_files[Perforce.key_file(path)].last_commit, '%s').strftime('%Y-%m-%d %H:%M:%S %z')
       end
 
+      # rubocop:disable Style/CollectionQuerying
       def revision?
         !perforce_files.values.count(&:opened?).zero?
       end
+      # rubocop:enable Style/CollectionQuerying
 
       def head_reference
         perforce_files.values.map(&:head).max_by(&:to_i)

data/lib/rubycritic/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RubyCritic
-  VERSION = '4.9.2'
+  VERSION = '4.10.0'
 end

metadata

@@ -1,13 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 4.9.2
+  version: 4.10.0
 platform: ruby
 authors:
 - Guilherme Simoes
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-04-09 00:00:00.000000000 Z
+date: 2025-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flay
@@ -85,7 +86,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.4.0
+        version: 6.5.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '7.0'
@@ -95,7 +96,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.4.0
+        version: 6.5.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '7.0'
@@ -175,14 +176,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 2.3.1
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.3.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 2.3.1
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.3.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -203,7 +210,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '12.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
@@ -213,7 +220,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '12.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
@@ -223,7 +230,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 9.2.1
+        version: 10.0.0
     - - "!="
       - !ruby/object:Gem::Version
         version: 9.0.0
@@ -233,7 +240,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 9.2.1
+        version: 10.0.0
     - - "!="
       - !ruby/object:Gem::Version
         version: 9.0.0
@@ -257,14 +264,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: irb
   requirement: !ruby/object:Gem::Requirement
@@ -373,7 +380,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 13.2.0
+        version: 13.3.0
     - - ">="
       - !ruby/object:Gem::Version
         version: 11.0.0
@@ -383,7 +390,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 13.2.0
+        version: 13.3.0
     - - ">="
       - !ruby/object:Gem::Version
         version: 11.0.0
@@ -605,6 +612,7 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -619,7 +627,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.5.22
+signing_key:
 specification_version: 4
 summary: RubyCritic is a Ruby code quality reporter
 test_files: []