rubycritic 4.0.2 → 4.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/CHANGELOG.md +13 -1
- data/lib/rubycritic/cli/options.rb +7 -1
- data/lib/rubycritic/generators/html/assets/stylesheets/application.css +2 -2
- data/lib/rubycritic/generators/html/templates/code_index.html.erb +4 -4
- data/lib/rubycritic/generators/html/templates/layouts/application.html.erb +2 -3
- data/lib/rubycritic/generators/html/templates/overview.html.erb +2 -2
- data/lib/rubycritic/generators/html/templates/smelly_line.html.erb +1 -1
- data/lib/rubycritic/version.rb +1 -1
- metadata +10 -4
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA256:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: 6d28dbb364926311a07893f4d5ee5253a1435c16e992d0c132ecf90c045a141c
|
4
|
+
data.tar.gz: 05b8fd0c896ba749a88278572c9e62557770cebee01ab757286845416992259c
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: bf3b9b8d0ba55fceef78eaf2247efbe753de30b6d3e3a1a946105b3e848d517853ed0b58f4a65ee2caa9eaa1cae4919fb0eb4d021c1ac76bceb29983d1f658b9
|
7
|
+
data.tar.gz: 6c69233b3e52f5022f96c45a06ade7e9402f2d0c2a59fbc3268a2a96804ecc1ef129cbc2313d663b690d309c91d19726fa03c25d3960e242fbceaa14fb660287
|
data/CHANGELOG.md
CHANGED
@@ -1,4 +1,13 @@
|
|
1
|
-
# master [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.0
|
1
|
+
# master [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.1.0...master)
|
2
|
+
|
3
|
+
*
|
4
|
+
|
5
|
+
# master [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.0.2...v4.1.0)
|
6
|
+
|
7
|
+
* [BUGFIX] Assorted fixes in HTML report (by [@jbampton][])
|
8
|
+
* [BUGFIX] Fix duplicate HTML5 DOCTYPE (by [@jbampton][])
|
9
|
+
* [BUGFIX] Config options getting overwritten by nil argv options (by [@nathanbwright][])
|
10
|
+
* [CHANGE] Update Reek dependency to '~> 5.0', '< 6.0' (by [@leksster][])
|
2
11
|
|
3
12
|
# 4.0.2 / 2019-03-14 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.0.1...v4.0.2)
|
4
13
|
|
@@ -277,3 +286,6 @@
|
|
277
286
|
[@AllanSiqueira]: https://github.com/AllanSiqueira
|
278
287
|
[@harman28]: https://github.com/harman28
|
279
288
|
[@lightalloy]: https://github.com/lightalloy
|
289
|
+
[@jbampton]: https://github.com/jbampton
|
290
|
+
[@nathanbwright]: https://github.com/nathanbwright
|
291
|
+
[@leksster]: https://github.com/leksster
|
@@ -19,8 +19,14 @@ module RubyCritic
|
|
19
19
|
self
|
20
20
|
end
|
21
21
|
|
22
|
+
# :reek:NilCheck
|
22
23
|
def to_h
|
23
|
-
file_options.to_h
|
24
|
+
file_hash = file_options.to_h
|
25
|
+
argv_hash = argv_options.to_h
|
26
|
+
|
27
|
+
file_hash.merge(argv_hash) do |_, file_option, argv_option|
|
28
|
+
argv_option.nil? ? file_option : argv_option
|
29
|
+
end
|
24
30
|
end
|
25
31
|
end
|
26
32
|
end
|
@@ -89,7 +89,7 @@ header {
|
|
89
89
|
.Graph_Cards img {margin-top:30px;}
|
90
90
|
.Graph_Cards h4 {color:#A4A4A4;}
|
91
91
|
.Summary_Wrapper {display:inline-block;width:100%;}
|
92
|
-
.Summary_Title {padding
|
92
|
+
.Summary_Title {padding-left:0;}
|
93
93
|
.Summary_Title h3 {padding:10px;position:relative;color:#fff;}
|
94
94
|
.Summary_Title h3:after {
|
95
95
|
content: "";
|
@@ -124,7 +124,7 @@ header {
|
|
124
124
|
.Summary_Content .list-inline {
|
125
125
|
text-align:center;
|
126
126
|
margin-top:10px;
|
127
|
-
|
127
|
+
padding-right:0;
|
128
128
|
}
|
129
129
|
.Summary_Content .list-inline span {color:#A4A4A4}
|
130
130
|
#wrapper.toggled #page-content-wrapper {
|
@@ -21,8 +21,8 @@
|
|
21
21
|
<tbody>
|
22
22
|
<% @analysed_modules.each do |analysed_module| %>
|
23
23
|
<tr>
|
24
|
-
|
25
|
-
|
24
|
+
<% unless Config.suppress_ratings %>
|
25
|
+
<td>
|
26
26
|
<% if Config.build_mode? %>
|
27
27
|
<% master_analysed_module = Config.base_branch_collection.find(analysed_module.pathname) %>
|
28
28
|
<% if master_analysed_module.cost > analysed_module.cost %>
|
@@ -34,8 +34,8 @@
|
|
34
34
|
<% end %>
|
35
35
|
<% end %>
|
36
36
|
<div class="rating <%= analysed_module.rating.to_s.downcase %>"><%= analysed_module.rating %></div>
|
37
|
-
|
38
|
-
|
37
|
+
</td>
|
38
|
+
<% end %>
|
39
39
|
<td>
|
40
40
|
<ul class="nav nav-pills">
|
41
41
|
<li role="presentation" >
|
@@ -1,5 +1,4 @@
|
|
1
1
|
<!DOCTYPE html>
|
2
|
-
<!doctype html>
|
3
2
|
<html xmlns="http://www.w3.org/1999/xhtml">
|
4
3
|
<head>
|
5
4
|
<meta charset="utf-8">
|
@@ -18,7 +17,7 @@
|
|
18
17
|
<body>
|
19
18
|
<header class="navbar navbar-default navbar-fixed-top">
|
20
19
|
<a href="#menu-toggle" class="btn btn-default hidden-lg visible-sm-* hidden-md visible-xs-* pull-left" id="menu-toggle"><i class="fa fa-bars" aria-hidden="true"></i></a>
|
21
|
-
<a href="<%= file_path('overview.html') %>"><img src="<%= image_path('logo.png') %>" title="Ruby Critic Logo" width="55"><span class="logo">RUBYCRITIC</span></a>
|
20
|
+
<a href="<%= file_path('overview.html') %>"><img src="<%= image_path('logo.png') %>" alt="Ruby Critic Logo" title="Ruby Critic Logo" width="55"><span class="logo">RUBYCRITIC</span></a>
|
22
21
|
<% if Config.compare_branches_mode? %>
|
23
22
|
<ul class="nav navbar-nav navbar-right">
|
24
23
|
<a href="<%= @base_path %>"><span class="branch"><%= Config.base_branch %></span></a>
|
@@ -50,7 +49,7 @@
|
|
50
49
|
</div>
|
51
50
|
</div>
|
52
51
|
|
53
|
-
<!--
|
52
|
+
<!-- JavaScripts -->
|
54
53
|
<%= javascript_tag(:'jquery.min') %>
|
55
54
|
<%= javascript_tag(:'jquery.tablesorter.min') %>
|
56
55
|
<%= javascript_tag(:'jquery.scrollTo.min') %>
|
@@ -23,10 +23,10 @@
|
|
23
23
|
<% if Config.source_control_present? %>
|
24
24
|
<div id="churn-vs-complexity-graph-container" class="chart-container"></div>
|
25
25
|
<% else %>
|
26
|
-
<div id="churn-error">We can't show you Churn-vs-Complexity graph because this project does not seem to be under a source code management system like git or perforce at the moment. This doesn't mean that anything is wrong, it just means certain features like this one are not
|
26
|
+
<div id="churn-error">We can't show you Churn-vs-Complexity graph because this project does not seem to be under a source code management system like git or perforce at the moment. This doesn't mean that anything is wrong, it just means certain features like this one are not available.</div>
|
27
27
|
<% end %>
|
28
28
|
|
29
|
-
<script
|
29
|
+
<script>
|
30
30
|
var turbulenceData = <%= @turbulence_data %>;
|
31
31
|
var score = <%= @score %>;
|
32
32
|
</script>
|
data/lib/rubycritic/version.rb
CHANGED
metadata
CHANGED
@@ -1,14 +1,14 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: rubycritic
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version: 4.0
|
4
|
+
version: 4.1.0
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- Guilherme Simoes
|
8
8
|
autorequire:
|
9
9
|
bindir: bin
|
10
10
|
cert_chain: []
|
11
|
-
date: 2019-
|
11
|
+
date: 2019-06-07 00:00:00.000000000 Z
|
12
12
|
dependencies:
|
13
13
|
- !ruby/object:Gem::Dependency
|
14
14
|
name: flay
|
@@ -86,14 +86,20 @@ dependencies:
|
|
86
86
|
requirements:
|
87
87
|
- - "~>"
|
88
88
|
- !ruby/object:Gem::Version
|
89
|
-
version: 5.
|
89
|
+
version: '5.0'
|
90
|
+
- - "<"
|
91
|
+
- !ruby/object:Gem::Version
|
92
|
+
version: '6.0'
|
90
93
|
type: :runtime
|
91
94
|
prerelease: false
|
92
95
|
version_requirements: !ruby/object:Gem::Requirement
|
93
96
|
requirements:
|
94
97
|
- - "~>"
|
95
98
|
- !ruby/object:Gem::Version
|
96
|
-
version: 5.
|
99
|
+
version: '5.0'
|
100
|
+
- - "<"
|
101
|
+
- !ruby/object:Gem::Version
|
102
|
+
version: '6.0'
|
97
103
|
- !ruby/object:Gem::Dependency
|
98
104
|
name: ruby_parser
|
99
105
|
requirement: !ruby/object:Gem::Requirement
|