rubycritic 3.5.0 → 3.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6299ec37fabeb3fb630a70326b39377eee3aa4c4
-  data.tar.gz: c82518cf3a9c6120e109399fb967ede60a38b7bf
+  metadata.gz: bc68d230e7fdaaa4cd295dff2293e5ddf0ea81f4
+  data.tar.gz: d837d86ada9350d0a08b1a984bd24b003b5a49f1
 SHA512:
-  metadata.gz: e9df974efb0abbf35414284b494b4295a8b927d8c5d7c7a688dcb22666dfb7b2d2b183fa0621f1b50a70fe82f5e9376f7d5c5b3022305ce850fdfbd100b5d730
-  data.tar.gz: e57225932ea86556058a25b9f06fe6068457edd1d127abdbdbda126d040dc62a8964eb4bc6abcda4f4b39ba43aa7626078ba81d8cd6e7ff966e4ec10be72a8cc
+  metadata.gz: 78942609220a7083dcd95faa4cb79d4fd4950be9e103dcf5ea7740a84a2301a7f9d1b0f2f2a4349a8b234c93c0de7469e4695b081921697908df2aed456df4e3
+  data.tar.gz: c672a98d1180779fd48d70fa9fbb434889a3cc98e14cddf08f215f139b36d21e4d7d5c5f71243d07782a2157f8000cbbbc3cd40a76f62e7cc6fafbeda8861df0

data/CHANGELOG.md

@@ -1,4 +1,8 @@
-# master [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v3.5.0...master)
+# master [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v3.5.1...master)
+
+# 3.5.1 / 2018-09-05 [(commits)](https://github.com/whitesmith/rubycritic/compare/v3.5.0...v3.5.1)
+
+* [BUGFIX] Fix branches score comparison when threshold is 0 (by [@antoineLeclercq][])
 
 # 3.5.0 / 2018-09-03 [(commits)](https://github.com/whitesmith/rubycritic/compare/v3.4.0...v3.5.0)
 
@@ -244,3 +248,4 @@
 [@joshrpowell]: https://github.com/joshrpowell
 [@HemanthMudalaiah]: https://github.com/HemanthMudalaiah
 [@SuperSandro2000]: https://github.com/SuperSandro2000
+[@antoineLeclercq]: https://github.com/antoineLeclercq

data/lib/rubycritic/commands/compare.rb

@@ -76,7 +76,7 @@ module RubyCritic
       end
 
       def mark_build_fail?
-        Config.threshold_score > 0 && threshold_reached?
+        Config.threshold_score >= 0 && threshold_reached?
       end
 
       def threshold_reached?

data/lib/rubycritic/source_control_systems/git.rb

@@ -52,11 +52,11 @@ module RubyCritic
       end
 
       def self.switch_branch(branch)
-        uncommitted_changes? ? `git checkout #{branch}` : abort('Uncommitted changes are present.')
+        uncommitted_changes? ? abort('Uncommitted changes are present.') : `git checkout #{branch}`
       end
 
       def self.uncommitted_changes?
-        `git ls-files --other --exclude-standard --directory`.empty? && `git status --porcelain`.empty?
+        !`git ls-files --other --exclude-standard --directory`.empty? || !`git status --porcelain`.empty?
       end
 
       def self.modified_files

data/lib/rubycritic/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RubyCritic
-  VERSION = '3.5.0'.freeze
+  VERSION = '3.5.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.5.1
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-03 00:00:00.000000000 Z
+date: 2018-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flay