rubycritic 2.8.0 → 2.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 98d2664f3cdb47e1c19d036b56085e1f62d7f930
-  data.tar.gz: 08a7a743ec2f7891a694bb2e27fb96c905c6ec58
+  metadata.gz: 1dbaa6b17360c86029115d0519f0f0219ca5bc1d
+  data.tar.gz: ae570da462c045f67baa3a18bc7fc68ea4713561
 SHA512:
-  metadata.gz: 993ea1b9d055be63eabcba5a8706fcf1aa8b5f9bd04a6681f1ed79f92fc22503892c6fbeabed3be0e1d80383b91fc25dbccb1ddf51450cdbc82a58e51335bc5d
-  data.tar.gz: 721f4a64f158559101ea871cbfa88474993487861e95f623d01b5667a0cca1c4e39869ee26b6fa97ddfaffd97f848a86e2a61dececf4e564a55b8101998778bc
+  metadata.gz: 623d51c7a505561830c35cdf90cc75a9102a1da66cc050b1e125f7f5cd0cef659b1d146714b186e9a591b72089855c4664e4322b3fdc659b64210458e34a6985
+  data.tar.gz: b22749541a3981cd8109d20cf098c4e7be6ed4e10e03c43fe67dcf024b28546ac4688ba08c739c4e1b9db6d8ca19606e3b7d30c98bf9e577323df2c80916fcec

data/.todo.reek

@@ -77,6 +77,7 @@ DuplicateMethodCall:
   - Parser::AST::Node#module_name
 TooManyStatements:
   exclude:
+  - Rubycritic::RakeTask#initialize
   - Rubycritic::Analyser::Complexity#run
   - Parser::AST::Node#get_module_names
   - Rubycritic::Analyser::FlaySmells#run

data/.travis.yml

@@ -2,7 +2,6 @@ sudo: false
 language: ruby
 
 rvm:
-  - 2.0.0-p648
   - 2.1.8
   - 2.2.4
   - 2.3.0

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# 2.9.0 / 2016-04-12
+
+* [FEATURE] Add links to Flay and Flog code smells documentation (by ragesoss)
+* [FEATURE] Documentation updates (by troessner)
+* [CHANGE] Bump Rubocop to 0.39.0 (by nijikon)
+* [CHANGE] Bump Reek to 4.0.1 (by nijikon)
+* [CHANGE] Drop support for Ruby 2.0 (by nijikon)
+
 # 2.8.0 / 2016-02-29
 
 * [FEATURE] Add link to Reek's code smells documentation (by danielmbarlow)

data/README.md

@@ -108,7 +108,10 @@ Analyzer Configuration
   This means that if you have an existing `Reek` configuration file, you can just put this into your
   project root and `RubyCritic` will respect this configuration.
 * [`flay`](https://github.com/seattlerb/flay): We use `flay`'s default configuration.
-* [`flog`](https://github.com/seattlerb/flog): We use `flog`'s default configuration with a couple of [smaller tweaks](https://github.com/whitesmith/rubycritic/blob/master/lib/rubycritic/analysers/helpers/flog.rb#L5).
+* [`flog`](https://github.com/seattlerb/flog): We use `flog`'s default configuration with a couple of [smaller tweaks](https://github.com/whitesmith/rubycritic/blob/master/lib/rubycritic/analysers/helpers/flog.rb#L5):
+    * `all`: Forces `flog` to report scores on all classes and methods. Without this option `flog` will only give results up to a certain threshold.
+    * `continue`: Makes it so that `flog` does not abort when a ruby file cannot be parsed.
+    * `methods`: Configures `flog` to skip code outside of methods. It prevents `flog` from reporting on the "methods" `private` and `protected`. It also prevents `flog` from reporting on Rails methods like `before_action` and `has_many`.
 
 Alternative Usage Methods
 -------------------------
@@ -161,7 +164,6 @@ Compatibility
 
 RubyCritic is supporting:
 
-* 2.0
 * 2.1
 * 2.2
 * 2.3

data/lib/rubycritic/analysers/smells/flay.rb

@@ -48,6 +48,7 @@ module Rubycritic
           message: "found in #{nodes.size} nodes",
           score: mass,
           type: 'DuplicateCode',
+          analyser: 'flay',
           cost: cost(mass)
         )
       end

data/lib/rubycritic/analysers/smells/flog.rb

@@ -46,6 +46,7 @@ module Rubycritic
           message: "has a flog score of #{score}",
           score: score,
           type: type(score),
+          analyser: 'flog',
           cost: 0
         )
       end

data/lib/rubycritic/analysers/smells/reek.rb

@@ -36,6 +36,7 @@ module Rubycritic
           context: smell.context,
           message: smell.message,
           type: smell.smell_type,
+          analyser: 'reek',
           cost: 0
         )
       end

data/lib/rubycritic/core/smell.rb

@@ -12,6 +12,10 @@ module Rubycritic
     attribute :score
     attribute :status
     attribute :type
+    attribute :analyser
+
+    FLAY_DOCS_URL = 'http://docs.seattlerb.org/flay/'.freeze
+    FLOG_DOCS_URL = 'http://docs.seattlerb.org/flog/'.freeze
 
     def at_location?(other_location)
       locations.any? { |location| location == other_location }
@@ -47,7 +51,16 @@ module Rubycritic
     end
 
     def doc_url
-      "https://github.com/troessner/reek/blob/master/docs/#{dasherized_type}.md"
+      case analyser
+      when 'reek'
+        "https://github.com/troessner/reek/blob/master/docs/#{dasherized_type}.md"
+      when 'flay'
+        FLAY_DOCS_URL
+      when 'flog'
+        FLOG_DOCS_URL
+      else
+        raise "No documentation URL set for analyser '#{analyser}' smells"
+      end
     end
 
     def hash

data/lib/rubycritic/rake_task.rb

@@ -19,7 +19,6 @@ module Rubycritic
   #     task.paths = FileList['lib/**/*.rb', 'spec/**/*.rb']
   #   end
   #
-  # :reek:TooManyStatements: { max_statements: 6 }
   class RakeTask < ::Rake::TaskLib
     # Name of RubyCritic task. Defaults to :rubycritic.
     attr_writer :name

data/lib/rubycritic/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rubycritic
-  VERSION = '2.8.0'.freeze
+  VERSION = '2.9.0'.freeze
 end

data/rubycritic.gemspec

@@ -23,8 +23,8 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'virtus', '~> 1.0'
   spec.add_runtime_dependency 'flay', '2.7.0'
   spec.add_runtime_dependency 'flog', '4.3.2'
-  spec.add_runtime_dependency 'reek', '3.11'
-  spec.add_runtime_dependency 'parser', '~> 2.3'
+  spec.add_runtime_dependency 'reek', '4.0.1'
+  spec.add_runtime_dependency 'parser', '2.3.0.7'
   spec.add_runtime_dependency 'ruby_parser', '~> 3.8'
   spec.add_runtime_dependency 'colorize'
   spec.add_runtime_dependency 'launchy', '2.4.3'
@@ -35,6 +35,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'minitest', '~> 5.3'
   spec.add_development_dependency 'mocha', '~> 1.1'
-  spec.add_development_dependency 'rubocop', '0.37.2'
+  spec.add_development_dependency 'rubocop', '0.39.0'
   spec.add_development_dependency 'pry-byebug'
 end

data/test/lib/rubycritic/core/smell_test.rb

@@ -71,16 +71,33 @@ describe Rubycritic::Smell do
   end
 
   describe '#doc_url' do
-    it 'handles one word type names' do
-      smell = Rubycritic::Smell.new(type: 'Complexity')
+    it 'handles one word type names for reek smells' do
+      smell = Rubycritic::Smell.new(type: 'Complexity', analyser: 'reek')
 
       smell.doc_url.must_equal('https://github.com/troessner/reek/blob/master/docs/Complexity.md')
     end
 
-    it 'handles multiple word type names' do
-      smell = Rubycritic::Smell.new(type: 'TooManyStatements')
+    it 'handles multiple word type names for reek smells' do
+      smell = Rubycritic::Smell.new(type: 'TooManyStatements', analyser: 'reek')
 
       smell.doc_url.must_equal('https://github.com/troessner/reek/blob/master/docs/Too-Many-Statements.md')
     end
+
+    it 'handles flay smells' do
+      smell = Rubycritic::Smell.new(type: 'DuplicateCode', analyser: 'flay')
+
+      smell.doc_url.must_equal('http://docs.seattlerb.org/flay/')
+    end
+
+    it 'handles flog smells' do
+      smell = Rubycritic::Smell.new(type: 'VeryHighComplexity', analyser: 'flog')
+
+      smell.doc_url.must_equal('http://docs.seattlerb.org/flog/')
+    end
+
+    it 'raises an error for unknown analysers' do
+      smell = Rubycritic::Smell.new(type: 'FooSmell', analyser: 'foo')
+      assert_raises { smell.doc_url }
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 2.8.0
+  version: 2.9.0
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-01 00:00:00.000000000 Z
+date: 2016-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -58,28 +58,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: '3.11'
+        version: 4.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: '3.11'
+        version: 4.0.1
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: 2.3.0.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: 2.3.0.7
 - !ruby/object:Gem::Dependency
   name: ruby_parser
   requirement: !ruby/object:Gem::Requirement
@@ -212,14 +212,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.37.2
+        version: 0.39.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.37.2
+        version: 0.39.0
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -454,3 +454,4 @@ test_files:
 - test/samples/reek/smelly.rb
 - test/samples/unparsable.rb
 - test/test_helper.rb
+has_rdoc: