rubycritic 2.7.0 → 2.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 37aff404664ffd96d8f0d92284accb0053c9435a
-  data.tar.gz: 8df0a27080dae7d2bd13372397a1712555cb4a99
+  metadata.gz: 278d628b028a0b49e460e040b155d7b0dea0cb1c
+  data.tar.gz: fdc48430d7343b5ae2f4429ed9586cd78061c311
 SHA512:
-  metadata.gz: d6ae9e3b022d2d015b8d6301c5b657bb9a1e94eb9bde5ecd076a2c2222b2bea3f9855e74d4eaa2af134063496419909856914fcae84724ed264916c2c28f83ba
-  data.tar.gz: 98cb0d06dc64fa6f29324524cca433101b5de689de99cb5698a96b98b17214a7b8299c2dc22a35cbd36a880d4e77b7e342ae5074fa65a6ce44a62e73f6aa662e
+  metadata.gz: 218bd9155097642d30f60a26887520d48c5ba4f33db26663a08d911e779e93cddbcf555db6f17411c65f9d86fd26746d952c90ed6e196c2b63c208bc59c1a4eb
+  data.tar.gz: d9a7cbc8d6089b490bc3b7fbb7bf772a5ce704fd75fd0a44b5bd3c4ec4717d260b900811f127b6dcc02b8cf23a98a5600090c77cd6b8da76dc212f643193647e

data/.gitignore

@@ -16,3 +16,5 @@ test/tmp
 test/version_tmp
 tmp
 .idea/
+.ruby-gemset
+.ruby-version

data/CHANGELOG.md

@@ -1,15 +1,20 @@
-# 2.7.0 / 2015-01-23
+# 2.7.1 / 2016-02-09
+
+* [CHANGE] Bump Reek to 3.10.1 (by Tomasz Pajor)
+* [BUGFIX] Analyse only the files whose paths are specified in the CLI (by Nuno Silva)
+
+# 2.7.0 / 2016-01-23
 
 * [FEATURE] Open html report with browser (by YingRui Lu)
 * [CHANGE] Bump Reek to 3.9.1
 * [CHANGE] Bump Rubocop to 0.36 and internal cleanup (preparing for Ruby 2.3)
 
-# 2.6.0 / 2015-01-21
+# 2.6.0 / 2016-01-21
 
 * [FEATURE] Add a minimum score option to the command line interface (by Roberto Schneider)
 * [CHANGE] Display the class and module names when the file has no methods
 
-# 2.5.0 / 2015-01-16
+# 2.5.0 / 2016-01-16
 
 * [FEATURE] Add a ConsoleReport format (by Josh Bodah)
 

data/lib/rubycritic/commands/base.rb

@@ -9,7 +9,7 @@ module Rubycritic
       end
 
       def execute
-        fail NotImplementedError
+        raise NotImplementedError
       end
     end
   end

data/lib/rubycritic/generators/html/base.rb

@@ -28,13 +28,13 @@ module Rubycritic
         end
 
         def file_name
-          fail NotImplementedError,
-               "The #{self.class} class must implement the #{__method__} method."
+          raise NotImplementedError,
+                "The #{self.class} class must implement the #{__method__} method."
         end
 
         def render
-          fail NotImplementedError,
-               "The #{self.class} class must implement the #{__method__} method."
+          raise NotImplementedError,
+                "The #{self.class} class must implement the #{__method__} method."
         end
 
         private

data/lib/rubycritic/generators/html/view_helpers.rb

@@ -31,13 +31,13 @@ module Rubycritic
     end
 
     def file_directory
-      fail NotImplementedError,
-           "The #{self.class} class must implement the #{__method__} method."
+      raise NotImplementedError,
+            "The #{self.class} class must implement the #{__method__} method."
     end
 
     def root_directory
-      fail NotImplementedError,
-           "The #{self.class} class must implement the #{__method__} method."
+      raise NotImplementedError,
+            "The #{self.class} class must implement the #{__method__} method."
     end
   end
 end

data/lib/rubycritic/revision_comparator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubycritic/serializer'
 require 'rubycritic/analysers_runner'
 require 'rubycritic/smells_status_setter'
@@ -14,28 +16,21 @@ module Rubycritic
 
     def set_statuses(analysed_modules_now)
       if Config.source_control_system.revision?
-        SmellsStatusSetter.set(
-          analysed_modules_before.flat_map(&:smells),
-          analysed_modules_now.flat_map(&:smells)
-        )
+        analysed_modules_before = load_cached_analysed_modules
+        if analysed_modules_before
+          SmellsStatusSetter.set(
+            analysed_modules_before.flat_map(&:smells),
+            analysed_modules_now.flat_map(&:smells)
+          )
+        end
       end
       analysed_modules_now
     end
 
     private
 
-    def analysed_modules_before
-      serializer = Serializer.new(revision_file)
-      if File.file?(revision_file)
-        serializer.load
-      else
-        analysed_modules = nil
-        Config.source_control_system.travel_to_head do
-          analysed_modules = AnalysersRunner.new(@paths).run
-        end
-        serializer.dump(analysed_modules)
-        analysed_modules
-      end
+    def load_cached_analysed_modules
+      Serializer.new(revision_file).load if File.file?(revision_file)
     end
 
     def revision_file

data/lib/rubycritic/source_locator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pathname'
 
 module Rubycritic

data/lib/rubycritic/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Rubycritic
-  VERSION = '2.7.0'.freeze
+  VERSION = '2.7.1'.freeze
 end

data/rubycritic.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'virtus', '~> 1.0'
   spec.add_runtime_dependency 'flay', '2.6.1'
   spec.add_runtime_dependency 'flog', '4.3.2'
-  spec.add_runtime_dependency 'reek', '3.9.1'
+  spec.add_runtime_dependency 'reek', '3.10.1'
   spec.add_runtime_dependency 'parser', '~> 2.3'
   spec.add_runtime_dependency 'colorize'
   spec.add_runtime_dependency 'launchy', '2.4.3'
@@ -33,6 +33,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'cucumber'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'minitest', '~> 5.3'
-  spec.add_development_dependency 'mocha', '~> 1.0'
-  spec.add_development_dependency 'rubocop', '0.36.0'
+  spec.add_development_dependency 'mocha', '~> 1.1'
+  spec.add_development_dependency 'rubocop', '0.37.0'
 end

data/test/lib/rubycritic/generators/console_report_test.rb

@@ -15,7 +15,7 @@ describe Rubycritic::Generator::ConsoleReport do
     end
 
     it 'outputs the report to the stdout' do
-      assert @output.size > 0, 'expected report to be output to stdout'
+      assert !@output.empty?, 'expected report to be output to stdout'
     end
 
     it "starts the report with the module's name" do

data/test/lib/rubycritic/revision_comparator_test.rb

@@ -0,0 +1,64 @@
+require 'test_helper'
+require 'rubycritic/revision_comparator'
+
+describe Rubycritic::RevisionComparator do
+  subject { Rubycritic::RevisionComparator.new([]) }
+
+  describe '#set_statuses' do
+    context 'in a SCS with :revision? == false' do
+      before do
+        Rubycritic::Config.expects(:source_control_system)
+                          .at_least_once
+                          .returns(stub(revision?: false))
+      end
+
+      it 'does not attempt to compare with previous results' do
+        subject.expects(:load_cached_analysed_modules).never
+        result = subject.set_statuses([])
+        result.must_equal([])
+      end
+    end
+
+    context 'in a SCS with :revision? == true' do
+      before do
+        Rubycritic::Config.expects(:source_control_system)
+                          .at_least_once
+                          .returns(stub(revision?: true))
+      end
+
+      context 'without previously cached results' do
+        before do
+          subject.expects(:revision_file).returns('foo')
+          File.expects(:file?).with('foo').returns(false)
+        end
+
+        it 'does not load them' do
+          Rubycritic::Serializer.expects(:new).never
+          subject.set_statuses([])
+        end
+
+        it 'does not invoke Rubycritic::SmellsStatusSetter' do
+          Rubycritic::SmellsStatusSetter.expects(:set).never
+          subject.set_statuses([])
+        end
+      end
+
+      context 'with previously cached results' do
+        before do
+          subject.expects(:revision_file).twice.returns('foo')
+          File.expects(:file?).with('foo').returns(true)
+          Rubycritic::Serializer.expects(:new).with('foo').returns(stub(load: []))
+        end
+
+        it 'loads them' do
+          subject.set_statuses([])
+        end
+
+        it 'invokes Rubycritic::SmellsStatusSetter' do
+          Rubycritic::SmellsStatusSetter.expects(:set).once
+          subject.set_statuses([])
+        end
+      end
+    end
+  end
+end

data/test/test_helper.rb

@@ -1,6 +1,6 @@
 require 'minitest/autorun'
 require 'minitest/pride'
-require 'mocha/setup'
+require 'mocha/mini_test'
 require 'ostruct'
 
 def context(*args, &block)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 2.7.0
+  version: 2.7.1
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-27 00:00:00.000000000 Z
+date: 2016-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.9.1
+        version: 3.10.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.9.1
+        version: 3.10.1
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement
@@ -184,28 +184,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.36.0
+        version: 0.37.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.36.0
+        version: 0.37.0
 description: RubyCritic is a tool that wraps around various static analysis gems to
   provide a quality report of your Ruby code.
 email:
@@ -324,6 +324,7 @@ files:
 - test/lib/rubycritic/generators/console_report_test.rb
 - test/lib/rubycritic/generators/turbulence_test.rb
 - test/lib/rubycritic/generators/view_helpers_test.rb
+- test/lib/rubycritic/revision_comparator_test.rb
 - test/lib/rubycritic/smells_status_setter_test.rb
 - test/lib/rubycritic/source_control_systems/base_test.rb
 - test/lib/rubycritic/source_control_systems/double_test.rb
@@ -370,7 +371,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: RubyCritic is a Ruby code quality reporter
@@ -394,6 +395,7 @@ test_files:
 - test/lib/rubycritic/generators/console_report_test.rb
 - test/lib/rubycritic/generators/turbulence_test.rb
 - test/lib/rubycritic/generators/view_helpers_test.rb
+- test/lib/rubycritic/revision_comparator_test.rb
 - test/lib/rubycritic/smells_status_setter_test.rb
 - test/lib/rubycritic/source_control_systems/base_test.rb
 - test/lib/rubycritic/source_control_systems/double_test.rb
@@ -420,4 +422,3 @@ test_files:
 - test/samples/reek/smelly.rb
 - test/samples/unparsable.rb
 - test/test_helper.rb
-has_rdoc: