rubycritic 1.4.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5e28af528222741e3d805ba162643f4e7b739c56
-  data.tar.gz: 34d5a5bb5c16637c96939d59be91ca3378d9b2fc
+  metadata.gz: 2ae3eb67d4cb24b1c4506ebac139782d2ff137de
+  data.tar.gz: 0ce29c9d94aa3af0c87be1110da41e495a7af7d3
 SHA512:
-  metadata.gz: f0849ed6312b44cae65c95a67e9b48375aa1de23379f3370849182209b8740cb630cf02888cc97ea74fcbe05877a6c3869ed8afdc84f2ff3de586d41a20d4adc
-  data.tar.gz: be6ce3d5f7a7132ca37bfc61d7979be2cefd5e88b11c7e566d71ac9219c1b51002a7d0ee46b89c6a54aeb9dd150aa585a8ccd9d7d3d26d3bc2fbb7e9c2524b92
+  metadata.gz: 4644d18c524776d9db1df62c7102a60130f7116de64cb82a92cfb37d65f9019ddd8bb7cc872cc38e1bf4f72eb8d0e48667994cb0b52386b4caa876b081a514c2
+  data.tar.gz: 4cc7824f83745b032e1bf4f60b69d36bafa423a040880186776d859cfe0833b567d3f1b968d0d83bfdeb85ef18716985f495d784fc63e3f241631949757df59b

data/.rubocop.yml

@@ -535,6 +535,11 @@ Style/WordArray:
 
 ##################### Metrics ##################################
 
+Metrics/AbcSize:
+  # The ABC size is a calculated magnitude, so this number can be a Fixnum or
+  # a Float.
+  Max: 22
+
 Metrics/BlockNesting:
   Max: 2
 

data/.travis.yml

@@ -1,11 +1,15 @@
 language: ruby
 
 rvm:
-  - 1.9.3
-  - 2.0.0
+  - 2.0
   - 2.1
   - 2.2
   - jruby
   - rbx-2
+matrix:
+  allow_failures:
+    - rvm: rbx-2
+    - rvm: jruby
+  fast_finish: true
 
 script: "bundle exec rake"

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 2.0.0 / 2015-11-11
+
+* [CHANGE] Drop support for ruby 1.9
+
 # 1.4.0 / 2015-03-14
 
 * [FEATURE] New report in JSON format. Available by using the new CLI option `-f`

data/CONTRIBUTING.md

@@ -20,7 +20,7 @@ If you want to squash a bug or add a new feature, please:
 
 4. Run the tests with the `rake` command. Make sure that they are still passing.
 
-5. Stage partial-file changesets (`git -p`).
+5. [Stage partial-file changesets] \(`git add -p`).
 
 6. Commit your changes (`git commit`).
 Make exactly as many commits as you need.
@@ -61,6 +61,7 @@ If you are experiencing unexpected behavior and, after having read the documenta
   The more information you provide, the easier it will be to track down the issue and fix it.
   If you have never written a bug report before, or if you want to brush up on your bug reporting skills, read Simon Tatham's essay [How to Report Bugs Effectively].
 
+[Stage partial-file changesets]: http://nuclearsquid.com/writings/git-add/
 [descriptive commit messages]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
 [Create a pull request]: https://help.github.com/articles/creating-a-pull-request
 [hide the sausage making]: http://sethrobertson.github.io/GitBestPractices/#sausage

data/README.md

@@ -12,17 +12,17 @@ This gem provides features such as:
 
 1. An overview of your project:
 
-  ![RubyCritic overview screenshot](http://i.imgur.com/OrOflfj.png)
+  ![RubyCritic overview screenshot](http://i.imgur.com/oiE5O3X.png)
 
 2. An index of the project files with their respective number of smells:
 
-  ![RubyCritic code index screenshot](http://i.imgur.com/0ETNrX7.png)
+  ![RubyCritic code index screenshot](http://i.imgur.com/a0GCn48.png)
 
 3. An index of the smells detected:
 
-  ![RubyCritic smells index screenshot](http://i.imgur.com/5CpPt9v.png)
+  ![RubyCritic smells index screenshot](http://i.imgur.com/PvkFEe3.png)
 
-4. Finally, when analysing code like the following:
+4. When analysing code like the following:
 
   ```ruby
   class Dirty
@@ -36,11 +36,17 @@ This gem provides features such as:
 
   It basically turns something like this:
 
-  ![Reek output screenshot](http://i.imgur.com/tCgZX9I.png)
+  ![Reek output screenshot](http://i.imgur.com/5G2zPIC.png)
 
   Into something like this:
 
-  ![RubyCritic file code screenshot](http://i.imgur.com/KLVrhMm.png)
+  ![RubyCritic file code screenshot](http://i.imgur.com/RNzXewk.png)
+
+5. It uses your source control system (only Git is supported for now) to
+  compare your currently uncommitted changes with your last commit.
+
+  **Warning**: If your code is not as you expect it to be after running
+  RubyCritic, please check your source control system stash.
 
 Getting Started
 ---------------
@@ -90,7 +96,7 @@ $ rubycritic --help
 |--------------------------|-------------------------------------------------------|
 | `-v/--version`           | Displays the current version and exits                |
 | `-p/--path`              | Sets the output directory (tmp/rubycritic by default) |
-| `-m/--mode-ci`           | Uses CI mode (faster, but only analyses last commit)  |
+| `--mode-ci`              | Uses CI mode (faster, but only analyses last commit)  |
 | `--deduplicate-symlinks` | De-duplicate symlinks based on their final target     |
 | `--suppress-ratings`     | Suppress letter ratings                               |
 
@@ -101,6 +107,19 @@ If you're fond of Guard you might like [guard-rubycritic][4]. It automatically a
 
 For continuous integration, you can give [Jenkins CI][5] a spin. With it, you can [easily build your own (poor-man's) Code Climate][6]!
 
+Compatibility
+---------------
+
+RubyCritic is supporting:
+
+* 2.0
+* 2.1
+* 2.2
+
+Note that we do not support Ruby 1.9 anymore.
+
+If you're still on ruby 1.9 you'll have to use the last version of RubyCritic that supports it, which would be [1.4.0](https://github.com/whitesmith/rubycritic/tree/v1.4.0).
+
 Improving RubyCritic
 --------------------
 
@@ -108,7 +127,7 @@ RubyCritic doesn't have to remain a second choice to other code quality analysis
 
 Arguably, the [better_errors gem][7] only got popular after receiving a [(pretty awesome) Pull Request][8] that changed its page design.
 
-Similarly, Pull Requests that improve the look and feel of the gem, that tweak the calculation of ratings or that fix existing issues will be most welcome. This is my first gem, so just commenting on an issue and giving some insight into how something should work will be appreciated. No contribution is too small.
+Similarly, Pull Requests that improve the look and feel of the gem, that tweak the calculation of ratings or that fix existing issues will be most welcome. Just commenting on an issue and giving some insight into how something should work will be appreciated. No contribution is too small.
 
 See RubyCritic's [contributing guidelines](CONTRIBUTING.md) about how to proceed.
 
@@ -117,7 +136,7 @@ Credits
 
 ![Whitesmith](http://i.imgur.com/Si2l3kd.png)
 
-RubyCritic is maintained and funded by [Whitesmith][9]. Tweet your questions or suggestions to [@glitchdout][10] or [@Whitesmithco][11].
+RubyCritic is maintained and funded by [Whitesmith][9]. Tweet your questions or suggestions to [@Whitesmithco][10].
 
 [1]: https://github.com/troessner/reek
 [2]: https://github.com/seattlerb/flay
@@ -128,5 +147,4 @@ RubyCritic is maintained and funded by [Whitesmith][9]. Tweet your questions or
 [7]: https://github.com/charliesome/better_errors
 [8]: https://github.com/charliesome/better_errors/pull/22
 [9]: http://www.whitesmith.co/
-[10]: https://twitter.com/glitchdout
-[11]: https://twitter.com/Whitesmithco
+[10]: https://twitter.com/Whitesmithco

data/lib/rubycritic/analysers/helpers/reek.rb

@@ -7,11 +7,9 @@ module Rubycritic
   class Reek < ::Reek::Examiner
     DEFAULT_CONFIG_FILE = File.expand_path("../config.reek", __FILE__)
 
-    def initialize(paths)
-      config = OpenStruct.new(:options => OpenStruct.new(:config_file => DEFAULT_CONFIG_FILE))
-      ::Reek::Configuration::AppConfiguration.initialize_with(config)
-      super(Array(paths))
+    def initialize(pathname)
+      config = ::Reek::Configuration::AppConfiguration.from_path(DEFAULT_CONFIG_FILE)
+      super(pathname, [], :configuration => config)
     end
   end
-
 end

data/lib/rubycritic/analysers/smells/reek.rb

@@ -18,7 +18,7 @@ module Rubycritic
       private
 
       def add_smells_to(analysed_module)
-        Reek.new(analysed_module.path).smells.each do |smell|
+        Reek.new(analysed_module.pathname).smells.each do |smell|
           analysed_module.smells << create_smell(smell)
         end
       end

data/lib/rubycritic/generators/json/simple.rb

@@ -1,4 +1,5 @@
 require "json"
+require "rubycritic/version"
 
 module Rubycritic
   module Generator

data/lib/rubycritic/version.rb

@@ -1,3 +1,3 @@
 module Rubycritic
-  VERSION = "1.4.0"
+  VERSION = "2.0.0"
 end

data/rubycritic.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
   spec.summary       = "RubyCritic is a Ruby code quality reporter"
   spec.homepage      = "https://github.com/whitesmith/rubycritic"
   spec.license       = "MIT"
-  spec.required_ruby_version = ">= 1.9.3"
+  spec.required_ruby_version = ">= 2.0.0"
 
   spec.files         = `git ls-files`.split("\n")
   spec.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
@@ -21,14 +21,14 @@ Gem::Specification.new do |spec|
   spec.require_path  = "lib"
 
   spec.add_runtime_dependency "virtus", "~> 1.0"
-  spec.add_runtime_dependency "flay", "2.4.0"
-  spec.add_runtime_dependency "flog", "4.2.1"
-  spec.add_runtime_dependency "reek", "1.6.5"
+  spec.add_runtime_dependency "flay", "2.6.1"
+  spec.add_runtime_dependency "flog", "4.3.2"
+  spec.add_runtime_dependency "reek", "3.6.0"
   spec.add_runtime_dependency "parser", ">= 2.2.0", "< 3.0"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "minitest", "~> 5.3"
   spec.add_development_dependency "mocha", "~> 1.0"
-  spec.add_development_dependency "rubocop", "0.28.0"
+  spec.add_development_dependency "rubocop", "0.29.0"
 end

data/test/lib/rubycritic/analysers/smells/reek_test.rb

@@ -4,7 +4,8 @@ require "rubycritic/analysers/smells/reek"
 describe Rubycritic::Analyser::ReekSmells do
   context "when analysing a smelly file" do
     before do
-      @analysed_module = AnalysedModuleDouble.new(:path => "test/samples/reek/smelly.rb", :smells => [])
+      pathname = Pathname.new("test/samples/reek/smelly.rb")
+      @analysed_module = AnalysedModuleDouble.new(:pathname => pathname, :smells => [])
       analysed_modules = [@analysed_module]
       Rubycritic::Analyser::ReekSmells.new(analysed_modules).run
     end
@@ -21,7 +22,8 @@ describe Rubycritic::Analyser::ReekSmells do
 
   context "when analysing a file with smells ignored in config.reek" do
     before do
-      @analysed_module = AnalysedModuleDouble.new(:path => "test/samples/reek/not_smelly.rb", :smells => [])
+      pathname = Pathname.new("test/samples/reek/not_smelly.rb")
+      @analysed_module = AnalysedModuleDouble.new(:pathname => pathname, :smells => [])
       analysed_modules = [@analysed_module]
       Rubycritic::Analyser::ReekSmells.new(analysed_modules).run
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-14 00:00:00.000000000 Z
+date: 2015-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -30,42 +30,42 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 2.6.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 2.6.1
 - !ruby/object:Gem::Dependency
   name: flog
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.2.1
+        version: 4.3.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.2.1
+        version: 4.3.2
 - !ruby/object:Gem::Dependency
   name: reek
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.6.5
+        version: 3.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.6.5
+        version: 3.6.0
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement
@@ -148,14 +148,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.28.0
+        version: 0.29.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.28.0
+        version: 0.29.0
 description: RubyCritic is a tool that wraps around various static analysis gems to
   provide a quality report of your Ruby code.
 email:
@@ -293,7 +293,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -301,7 +301,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: RubyCritic is a Ruby code quality reporter