rubycritic 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fceb73a4e6b94b34fcfc88f846367c0db8abf85d
-  data.tar.gz: b1b3714fe7efd0fbcc178139763c894730689b0d
+  metadata.gz: bac336ae6297b7cfdb084f9ee1fa9949ad558f37
+  data.tar.gz: 943f7a6bf54bd37bdd76a8513c8c8e7ef5b7cfed
 SHA512:
-  metadata.gz: a51d03f7b9c0b888496bc18b1366bd15ae43ab92abca874d57aa2625541ba2434502a284e0bb2d649e703a13cb00023079865ba408f2e3f9412fa51a54f5cbd9
-  data.tar.gz: 77ac17f55cbf455d8bf4419a09bdc75bd8a5db4f69588230979574fcd7a14a35bce36c1c49044676ed9e3c64b6bc148b7b712dc7552187749b8bc178fbbb2ed0
+  metadata.gz: 244083a692cd49119bf6d4e56376b84045bed3562544e5c01b92085cfc113cce96dfee13b87f9889fb62deda74aa16138f80f283e231225d0f7cadfb978cb801
+  data.tar.gz: 0eb796e93bae55f8f4de65c4e0c4c74609d107758964cd3dca4ca40e62cf673dcf357c7c0a2a8527e29eefba634f07d9dd158c55d4244c35cb1410d227edd935

data/.travis.yml

@@ -5,6 +5,6 @@ rvm:
   - 2.0.0
   - 2.1
   - jruby
-  - rbx-2
+  - rbx-2.2.10
 
 script: "bundle exec rake"

data/CONTRIBUTING.md

@@ -10,7 +10,7 @@ RubyCritic is open source and contributions from the community are encouraged! N
 Writing some Code
 -----------------
 
-If you want to squash a bug or add a new feature, follow these guidelines:
+If you want to squash a bug or add a new feature, please:
 
 1. Fork the project.
 
@@ -31,14 +31,14 @@ Each commit should do one thing and one thing only. For example, all whitespace
 8. [Hide the sausage making][3]. Squash, split and reorder commits if necessary (`git rebase -i`).
 For a more in-depth look at interactive rebasing, be sure to check [how to rewrite history][4].
 
-9. Push to the branch to GitHub (`git push origin my-new-feature`).
+9. Push the branch to GitHub (`git push origin my-new-feature`).
 
 10. Create a new [Pull Request][5] and send it to be merged with the master branch.
 
 Improving the Documentation
 ---------------------------
 
-You are encouraged to clarify how something works or to simply fix a typo. Please include `[ci skip]` on a new line in your commit message. This will signal [Travis][2] that running the test suite is not necessary for these changes.
+You are welcome to clarify how something works or simply fix a typo. Please include `[ci skip]` on a new line in each of your commit messages. This will signal [Travis][2] that running the test suite is not necessary for these changes.
 
 Reporting a Bug
 ---------------
@@ -65,4 +65,4 @@ If you are experiencing unexpected behavior and, after having read Rubycritic's
 [3]: http://sethrobertson.github.io/GitBestPractices/#sausage
 [4]: http://git-scm.com/book/en/Git-Tools-Rewriting-History#Changing-Multiple-Commit-Messages
 [5]: https://help.github.com/articles/creating-a-pull-request
-[6]: https://github.com/whitesmith/rubycritic/issues
+[6]: https://github.com/whitesmith/rubycritic/search?type=Issues

data/README.md

@@ -96,23 +96,24 @@ Alternative Usage Methods
 
 If you're fond of Guard you might like [guard-rubycritic][4]. It automatically analyses your Ruby files as they are modified.
 
-For continuous integration, you can give [Jenkins CI][5] a spin. With it, you can easily build your own (poor-man's) Code Climate!
+For continuous integration, you can give [Jenkins CI][5] a spin. With it, you can [easily build your own (poor-man's) Code Climate][6]!
 
 Improving RubyCritic
 --------------------
 
 RubyCritic doesn't have to remain a second choice to other code quality analysis services. Together, we can improve it and continue to build on the great code metric tools that are available in the Ruby ecosystem.
 
-Arguably, the [better_errors gem][6] only got popular after receiving a [(pretty awesome) Pull Request][7] that changed its page design.
+Arguably, the [better_errors gem][7] only got popular after receiving a [(pretty awesome) Pull Request][8] that changed its page design.
 
 Similarly, Pull Requests that improve the look and feel of the gem, that tweak the calculation of ratings or that fix existing issues will be most welcome. This is my first gem, so just commenting on an issue and giving some insight into how something should work will be appreciated. No contribution is too small.
 
-See RubyCritic's [contribution guidelines](CONTRIBUTING.md) about how to proceed.
+See RubyCritic's [contributing guidelines](CONTRIBUTING.md) about how to proceed.
 
 [1]: https://github.com/troessner/reek
 [2]: https://github.com/seattlerb/flay
 [3]: https://github.com/seattlerb/flog
 [4]: https://github.com/whitesmith/guard-rubycritic
 [5]: http://jenkins-ci.org/
-[6]: https://github.com/charliesome/better_errors
-[7]: https://github.com/charliesome/better_errors/pull/22
+[6]: https://github.com/whitesmith/rubycritic/wiki/Building-your-own-Code-Climate
+[7]: https://github.com/charliesome/better_errors
+[8]: https://github.com/charliesome/better_errors/pull/22

data/lib/rubycritic/analysers/stats.rb

@@ -25,6 +25,8 @@ module Rubycritic
 
       def parse_content(content)
         Parser::CurrentRuby.parse(content) || AST::EmptyNode.new
+      rescue Parser::SyntaxError => error
+        AST::EmptyNode.new
       end
     end
 

data/lib/rubycritic/report_generators/overview.rb

@@ -1,5 +1,5 @@
 require "rubycritic/report_generators/base"
-require "rubycritic/turbulence"
+require "rubycritic/report_generators/turbulence"
 
 module Rubycritic
   module Generator

data/lib/rubycritic/version.rb

@@ -1,3 +1,3 @@
 module Rubycritic
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/test/lib/rubycritic/analysers/stats_test.rb

@@ -17,4 +17,14 @@ describe Rubycritic::Analyser::Stats do
       analysed_file.methods_count.must_equal 0
     end
   end
+
+  context "when a file is unparsable" do
+    it "does not blow up" do
+      analysed_file = AnalysedFileDouble.new(:path => "test/samples/stats/unparsable_example.rb")
+      capture_output_streams do
+        Rubycritic::Analyser::Stats.new([analysed_file]).run
+      end
+      analysed_file.methods_count.must_equal 0
+    end
+  end
 end

data/test/lib/rubycritic/{turbulence_test.rb → report_generators/turbulence_test.rb}

@@ -1,5 +1,5 @@
 require "test_helper"
-require "rubycritic/turbulence"
+require "rubycritic/report_generators/turbulence"
 
 describe Rubycritic::Turbulence do
   describe "#data" do

data/test/lib/rubycritic/source_control_systems/source_control_system_test.rb

@@ -16,5 +16,14 @@ describe Rubycritic::SourceControlSystem do
         system.must_be_instance_of Rubycritic::SourceControlSystem::Git
       end
     end
+
+    describe "when no source control system is found" do
+      it "creates a source control system double" do
+        capture_output_streams do
+          system = Rubycritic::SourceControlSystem::Base.create
+          system.must_be_instance_of Rubycritic::SourceControlSystem::Double
+        end
+      end
+    end
   end
 end

data/test/samples/stats/unparsable_example.rb

@@ -0,0 +1,2 @@
+factory :<%= singular_name %> do
+end

data/test/test_helper.rb

@@ -6,3 +6,12 @@ require "ostruct"
 def context(*args, &block)
   describe(*args, &block)
 end
+
+def capture_output_streams
+  $stdout = StringIO.new
+  $stderr = StringIO.new
+  yield
+ensure
+  $stdout = STDOUT
+  $stderr = STDERR
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-13 00:00:00.000000000 Z
+date: 2014-07-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -198,6 +198,7 @@ files:
 - lib/rubycritic/report_generators/templates/overview.html.erb
 - lib/rubycritic/report_generators/templates/smells_index.html.erb
 - lib/rubycritic/report_generators/templates/smelly_line.html.erb
+- lib/rubycritic/report_generators/turbulence.rb
 - lib/rubycritic/report_generators/view_helpers.rb
 - lib/rubycritic/reporters/base.rb
 - lib/rubycritic/reporters/main.rb
@@ -209,7 +210,6 @@ files:
 - lib/rubycritic/source_control_systems/double.rb
 - lib/rubycritic/source_control_systems/git.rb
 - lib/rubycritic/source_locator.rb
-- lib/rubycritic/turbulence.rb
 - lib/rubycritic/version.rb
 - rubycritic.gemspec
 - test/analysers_test_helper.rb
@@ -224,11 +224,11 @@ files:
 - test/lib/rubycritic/core/location_test.rb
 - test/lib/rubycritic/core/smell_test.rb
 - test/lib/rubycritic/core/smells_array_test.rb
+- test/lib/rubycritic/report_generators/turbulence_test.rb
 - test/lib/rubycritic/report_generators/view_helpers_test.rb
 - test/lib/rubycritic/smells_status_setter_test.rb
 - test/lib/rubycritic/source_control_systems/source_control_system_test.rb
 - test/lib/rubycritic/source_locator_test.rb
-- test/lib/rubycritic/turbulence_test.rb
 - test/lib/rubycritic/version_test.rb
 - test/samples/flay/smelly.rb
 - test/samples/flog/complex.rb
@@ -241,6 +241,7 @@ files:
 - test/samples/reek/smelly.rb
 - test/samples/stats/empty_example.rb
 - test/samples/stats/example.rb
+- test/samples/stats/unparsable_example.rb
 - test/test_helper.rb
 homepage: https://github.com/whitesmith/rubycritic
 licenses:
@@ -262,7 +263,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.1
 signing_key: 
 specification_version: 4
 summary: Ruby code smell detector
@@ -279,11 +280,11 @@ test_files:
 - test/lib/rubycritic/core/location_test.rb
 - test/lib/rubycritic/core/smell_test.rb
 - test/lib/rubycritic/core/smells_array_test.rb
+- test/lib/rubycritic/report_generators/turbulence_test.rb
 - test/lib/rubycritic/report_generators/view_helpers_test.rb
 - test/lib/rubycritic/smells_status_setter_test.rb
 - test/lib/rubycritic/source_control_systems/source_control_system_test.rb
 - test/lib/rubycritic/source_locator_test.rb
-- test/lib/rubycritic/turbulence_test.rb
 - test/lib/rubycritic/version_test.rb
 - test/samples/flay/smelly.rb
 - test/samples/flog/complex.rb
@@ -296,4 +297,5 @@ test_files:
 - test/samples/reek/smelly.rb
 - test/samples/stats/empty_example.rb
 - test/samples/stats/example.rb
+- test/samples/stats/unparsable_example.rb
 - test/test_helper.rb