rubycritic 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a776a51f8d90b8d2b65bb2e81f6b4dea87cd63a4
-  data.tar.gz: 4f35ecbef41031dd622513ef120ca1fab15e1e10
+  metadata.gz: cf087d756a9bf0d14b016b82d75b675870614854
+  data.tar.gz: 5c17c62548734bd39a5ca405f764473b96cdd24e
 SHA512:
-  metadata.gz: 078000998ba31e7c53c637dfda9184e8dfcdc90e28750afd88a4c35949f86feb38b785be71a2038d7704d2acd12d9182b905f19cafa00329ae20f99db51f1592
-  data.tar.gz: fff0b984ed7ebe0e120ceb0ed13947eacea027162312e80e84d7dbe9e96b1f998ecd8be4cd9dfd8e3fc659a50a252261a8ec63ba6310b323b42eda3885327d17
+  metadata.gz: d0cfeef76646512463c61140b93959f5de1bc6654bc505005f74f5d560c1e5518d5cda6af6cfbcc18b81285c594aad88ae15fce0cd9ef1c143d56ee49300dc81
+  data.tar.gz: 957ce873afee75b3c4ae67b43d4fd2402bdc3317f7c78f0f2d36d93a0e252eb3d47101a48b83b398df38e887169f1aeafc151231217d2dd580f14316bc6527f9

data/lib/rubycritic.rb

@@ -14,13 +14,12 @@ module Rubycritic
 
     def critique(paths)
       source = SourceLocator.new(paths)
+      smell_adapters = AnalysersRunner.new(source.paths).run
+      smells = SmellsAggregator.new(smell_adapters).smells
       if @source_control_system.has_revision?
-        smelly_pathnames = RevisionComparator.new(source.paths, @source_control_system).compare
-      else
-        smell_adapters = AnalysersRunner.new(source.paths).run
-        smelly_pathnames = SmellsAggregator.new(smell_adapters).smelly_pathnames
+        smells = RevisionComparator.new(smells, @source_control_system).smells
       end
-      Reporter.new(source.pathnames, smelly_pathnames).generate_report
+      Reporter.new(source.pathnames, smells).generate_report
     end
   end
 

data/lib/rubycritic/location.rb

@@ -10,6 +10,10 @@ module Rubycritic
       @line = line
     end
 
+    def file_name
+      @pathname.basename.sub_ext("").to_s
+    end
+
     def to_s
       "#{pathname}:#{line}"
     end

data/lib/rubycritic/report_generators/assets/stylesheets/application.css

@@ -1,8 +1,107 @@
+.group:after {
+  content: '';
+  display: table;
+  clear: both;
+}
+
+html {
+  overflow-y: scroll;
+}
+
+.project-header {
+  padding: 20px 0 20px 60px;
+}
+
+.logo {
+  float: left;
+  margin: 0;
+}
+
+.logo-link {
+  color: black;
+  text-decoration: none;
+}
+
+.project-nav {
+  float: left;
+  margin-left: 100px;
+  line-height: 2.5em;
+}
+
+.project-nav-item {
+  color: black;
+  margin-right: 40px;
+  text-decoration: none;
+}
+
+.code-table,
+.smells-table {
+  width: 100%;
+  border-collapse: collapse;
+}
+
+.code-table th,
+.smells-table th {
+  text-align: left;
+  padding-bottom: 8px;
+  border-bottom: 1px solid silver;
+  font-size: 1.55em;
+  font-weight: normal;
+}
+
+.code-table td,
+.smells-table td {
+  padding-top: 12px;
+  padding-bottom: 12px;
+}
+
+.code-table tr td:first-child,
+.code-table tr th:first-child,
+.smells-table tr td:first-child,
+.smells-table tr th:first-child {
+  padding-left: 60px;
+}
+
+.button {
+  margin: 0;
+  padding: 0.5em 1em;
+  border: 1px solid black;
+  font-size: 0.9em;
+  border-radius: 0.2em;
+  cursor: pointer;
+  transition-property: background-color;
+  -webkit-transition-duration: 0.5s;
+  transition-duration: 0.5s;
+}
+
+.file-header {
+  position: relative;
+  padding: 0 0 10px 60px;
+  border-bottom: 1px solid silver;
+}
+
+.file-name {
+  margin: 0;
+  font-weight: normal;
+}
+
+.smells-toggle-button {
+  position: absolute;
+  right: 64px;
+  top: 22px;
+  border-color: silver;
+  background-color: #EEEBE9;
+}
+
+.smells-toggle-button:hover {
+  background-color: #D1CFCD;
+}
+
 .smells {
   margin: 2px 0 22px 0;
   padding-left: 0;
   border: 1px solid #000;
-  background-color: #DDD;
+  background-color: #EEEBE9;
   white-space: normal;
   list-style-type: disc;
 }

data/lib/rubycritic/report_generators/assets/stylesheets/prettify.custom_theme.css

@@ -57,10 +57,7 @@
 
 /* Specify class=linenums on a pre to get line numbering */
 .prettyprint ol.linenums {
-    margin-top: 0;
-    margin-bottom: 0;
-    background-color: #EEEBE9;
-    padding-left: 66px;
+    padding-left: 60px;
 }
 
 .prettyprint li {

data/lib/rubycritic/report_generators/base_generator.rb

@@ -1,3 +1,4 @@
+require "erb"
 require "rubycritic/report_generators/view_helpers"
 
 module Rubycritic
@@ -5,6 +6,7 @@ module Rubycritic
   class BaseGenerator
     REPORT_DIR = File.expand_path("tmp/rubycritic", Dir.getwd)
     TEMPLATES_DIR = File.expand_path("../templates", __FILE__)
+    LAYOUT_TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "layouts", "application.html.erb")))
 
     include ViewHelpers
 
@@ -17,15 +19,15 @@ module Rubycritic
     end
 
     def file_directory
-      raise NotImplementedError.new("You must implement the file_directory method.")
+      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
     end
 
     def file_name
-      raise NotImplementedError.new("You must implement the file_name method.")
+      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
     end
 
     def render
-      raise NotImplementedError.new("You must implement the render method.")
+      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
     end
 
     def get_binding

data/lib/rubycritic/report_generators/{index_generator.rb → code_index_generator.rb}

@@ -3,9 +3,8 @@ require "rubycritic/report_generators/base_generator"
 
 module Rubycritic
 
-  class IndexGenerator < BaseGenerator
-    INDEX_TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "index.html.erb")))
-    LAYOUT_TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "layouts", "application.html.erb")))
+  class CodeIndexGenerator < BaseGenerator
+    TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "code_index.html.erb")))
 
     def initialize(file_generators)
       @file_generators = file_generators.sort { |a, b| a.analysed_file_name <=> b.analysed_file_name }
@@ -16,11 +15,11 @@ module Rubycritic
     end
 
     def file_name
-      "index.html"
+      "code_index.html"
     end
 
     def render
-      index_body = INDEX_TEMPLATE.result(get_binding)
+      index_body = TEMPLATE.result(get_binding)
       LAYOUT_TEMPLATE.result(get_binding { index_body })
     end
   end

data/lib/rubycritic/report_generators/file_generator.rb

@@ -6,8 +6,7 @@ module Rubycritic
 
   class FileGenerator < BaseGenerator
     LINE_NUMBER_OFFSET = 1
-    FILE_TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "file.html.erb")))
-    LAYOUT_TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "layouts", "application.html.erb")))
+    TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "file.html.erb")))
 
     def initialize(pathname, smells)
       @pathname = pathname
@@ -34,9 +33,13 @@ module Rubycritic
         file_code << LineGenerator.new(line_text, line_smells).render
       end
 
-      file_body = FILE_TEMPLATE.result(get_binding { file_code })
+      file_body = TEMPLATE.result(get_binding { file_code })
       LAYOUT_TEMPLATE.result(get_binding { file_body })
     end
+
+    def file_has_smells?
+      !@smells.empty?
+    end
   end
 
 end

data/lib/rubycritic/report_generators/reporter.rb

@@ -1,6 +1,7 @@
 require "rubycritic/report_generators/base_generator"
 require "rubycritic/report_generators/file_generator"
-require "rubycritic/report_generators/index_generator"
+require "rubycritic/report_generators/code_index_generator"
+require "rubycritic/report_generators/smells_index_generator"
 require "fileutils"
 
 module Rubycritic
@@ -8,9 +9,10 @@ module Rubycritic
   class Reporter
     ASSETS_DIR = File.expand_path("../assets", __FILE__)
 
-    def initialize(source_pathnames, smelly_pathnames)
+    def initialize(source_pathnames, smells)
       @source_pathnames = source_pathnames
-      @smelly_pathnames = smelly_pathnames
+      @smells = smells
+      @smelly_pathnames = pathnames_to_files_with_smells
     end
 
     def generate_report
@@ -21,17 +23,21 @@ module Rubycritic
         end
       end
       FileUtils.cp_r(ASSETS_DIR, BaseGenerator::REPORT_DIR)
-      index_generator.file_href
+      code_index_generator.file_href
     end
 
     private
 
     def generators
-      file_generators + [index_generator]
+      [code_index_generator, smells_index_generator] + file_generators
     end
 
-    def index_generator
-      @index_generator ||= IndexGenerator.new(file_generators)
+    def code_index_generator
+      @code_index_generator ||= CodeIndexGenerator.new(file_generators)
+    end
+
+    def smells_index_generator
+      @smells_index_generator ||= SmellsIndexGenerator.new(@smells)
     end
 
     def file_generators
@@ -40,6 +46,16 @@ module Rubycritic
         FileGenerator.new(file_pathname, file_smells)
       end
     end
+
+    def pathnames_to_files_with_smells
+      pathnames = Hash.new { |hash, key| hash[key] = [] }
+      @smells.each do |smell|
+        smell.pathnames.each do |path|
+          pathnames[path] << smell
+        end
+      end
+      pathnames
+    end
   end
 
 end

data/lib/rubycritic/report_generators/smells_index_generator.rb

@@ -0,0 +1,27 @@
+require "erb"
+require "rubycritic/report_generators/base_generator"
+
+module Rubycritic
+
+  class SmellsIndexGenerator < BaseGenerator
+    TEMPLATE = ERB.new(File.read(File.join(TEMPLATES_DIR, "smells_index.html.erb")))
+
+    def initialize(smells)
+      @smells = smells.sort { |a, b| a.type <=> b.type }
+    end
+
+    def file_directory
+      REPORT_DIR
+    end
+
+    def file_name
+      "smells_index.html"
+    end
+
+    def render
+      index_body = TEMPLATE.result(get_binding)
+      LAYOUT_TEMPLATE.result(get_binding { index_body })
+    end
+  end
+
+end

data/lib/rubycritic/report_generators/templates/{index.html.erb → code_index.html.erb}

@@ -1,4 +1,4 @@
-<table>
+<table class="code-table">
 <thead>
   <tr>
     <th>Name</th>

data/lib/rubycritic/report_generators/templates/file.html.erb

@@ -1,3 +1,9 @@
-<button id="js-toggle-smells">Toggle Smells</button>
+<div class="file-header">
+  <h2 class="file-name"><%= analysed_file_name %></h2>
+
+  <% if file_has_smells? %>
+    <button id="js-toggle-smells" class="smells-toggle-button button">Toggle Smells</button>
+  <% end %>
+</div>
 
 <code class="prettyprint linenums lang-ruby file-code js-file-code"><%= yield %></code>

data/lib/rubycritic/report_generators/templates/layouts/application.html.erb

@@ -1,19 +1,24 @@
 <!DOCTYPE html>
 <html>
-    <head>
-        <meta charset="utf-8">
-        <meta http-equiv="X-UA-Compatible" content="IE=edge">
-        <title>RubyCritic</title>
-        <link href="<%= stylesheet_path(:application) %>" media="screen, projection, print" rel="stylesheet" type="text/css">
-        <link href="<%= stylesheet_path(:'prettify.custom_theme') %>" media="screen, projection, print" rel="stylesheet" type="text/css">
-        <meta name="description" content="">
-        <meta name="viewport" content="width=device-width, initial-scale=1">
-    </head>
-    <body>
-        <h1><a href="<%= index_path %>">RubyCritic</a></h1>
-        <%= yield %>
-        <script src="<%= javascript_path(:'jquery-2.1.0') %>"></script>
-        <script src="<%= javascript_path(:prettify) %>"></script>
-        <script src="<%= javascript_path(:application) %>"></script>
-    </body>
+  <head>
+    <meta charset="utf-8">
+    <meta http-equiv="X-UA-Compatible" content="IE=edge">
+    <title>Ruby Critic</title>
+    <link href="<%= stylesheet_path(:application) %>" media="screen, projection, print" rel="stylesheet" type="text/css">
+    <link href="<%= stylesheet_path(:'prettify.custom_theme') %>" media="screen, projection, print" rel="stylesheet" type="text/css">
+    <meta name="viewport" content="width=device-width, initial-scale=1">
+  </head>
+  <body>
+    <header class="project-header group">
+      <h1 class="logo"><a href="<%= code_index_path %>" class="logo-link">Ruby Critic</a></h1>
+      <nav class="project-nav">
+        <a href="<%= code_index_path %>" class="project-nav-item">Code</a>
+        <a href="<%= smells_index_path %>" class="project-nav-item">Smells</a>
+      </nav>
+    </header>
+    <%= yield %>
+    <script src="<%= javascript_path(:'jquery-2.1.0') %>"></script>
+    <script src="<%= javascript_path(:prettify) %>"></script>
+    <script src="<%= javascript_path(:application) %>"></script>
+  </body>
 </html>

data/lib/rubycritic/report_generators/templates/smells_index.html.erb

@@ -0,0 +1,20 @@
+<table class="smells-table">
+<thead>
+  <tr>
+    <th>Smell</th>
+    <th>Locations</th>
+  </tr>
+</thead>
+<tbody>
+  <% @smells.each do |smell| %>
+    <tr>
+      <td><%= smell.type %></td>
+      <td>
+        <% smell.locations.each do |location| %>
+          <a href="<%= smell_location_path(location) %>"><%= location.file_name %></a>
+        <% end %>
+      </td>
+    </tr>
+  <% end %>
+</tbody>
+</table>

data/lib/rubycritic/report_generators/view_helpers.rb

@@ -18,8 +18,17 @@ module Rubycritic
       File.join(root_directory, "#{pathname.sub_ext('.html')}#L#{location.line}")
     end
 
-    def index_path
-      File.join(root_directory, "index.html")
+    def code_index_path
+      File.join(root_directory, "code_index.html")
+    end
+
+    def smells_index_path
+      File.join(root_directory, "smells_index.html")
+    end
+
+    # Includers must override
+    def root_directory
+      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
     end
   end
 

data/lib/rubycritic/revision_comparator.rb

@@ -1,4 +1,4 @@
-require "rubycritic/smelly_pathnames_serializer"
+require "rubycritic/smells_serializer"
 require "rubycritic/source_locator"
 require "rubycritic/analysers_runner"
 require "rubycritic/smells_aggregator"
@@ -9,40 +9,32 @@ module Rubycritic
   class RevisionComparator
     SNAPSHOTS_DIR = File.expand_path("tmp/rubycritic/snapshots", Dir.getwd)
 
-    def initialize(paths, source_control_system)
-      @paths = paths
+    def initialize(smells, source_control_system)
+      @smells_now = smells
       @source_control_system = source_control_system
     end
 
-    def compare
-      SmellsStatusSetter.new(smelly_pathnames_before, smelly_pathnames_now).smelly_pathnames
+    def smells
+      SmellsStatusSetter.new(smells_before, @smells_now).smells
     end
 
     private
 
-    def smelly_pathnames_before
-      serializer = SmellyPathnamesSerializer.new(revision_file)
+    def smells_before
+      serializer = SmellsSerializer.new(revision_file)
       if File.file?(revision_file)
         serializer.load
       else
-        smelly_pathnames = nil
+        smells = nil
         @source_control_system.travel_to_head do
-          smelly_pathnames = smelly_pathnames(paths_of_tracked_files)
+          smell_adapters = AnalysersRunner.new(paths_of_tracked_files).run
+          smells = SmellsAggregator.new(smell_adapters).smells
         end
-        serializer.dump(smelly_pathnames)
-        smelly_pathnames
+        serializer.dump(smells)
+        smells
       end
     end
 
-    def smelly_pathnames_now
-      smelly_pathnames(@paths)
-    end
-
-    def smelly_pathnames(paths)
-      smell_adapters = AnalysersRunner.new(paths).run
-      SmellsAggregator.new(smell_adapters).smelly_pathnames
-    end
-
     def revision_file
       @revision_file ||= File.join(SNAPSHOTS_DIR, @source_control_system.head_reference)
     end

data/lib/rubycritic/smells_aggregator.rb

@@ -8,22 +8,6 @@ module Rubycritic
     def smells
       @smells ||= @smell_adapters.map(&:smells).flatten.sort
     end
-
-    def smelly_pathnames
-      @smelly_pathnames ||= pathnames_to_files_with_smells
-    end
-
-    private
-
-    def pathnames_to_files_with_smells
-      pathnames = Hash.new { |hash, key| hash[key] = [] }
-      smells.each do |smell|
-        smell.pathnames.each do |path|
-          pathnames[path] << smell
-        end
-      end
-      pathnames
-    end
   end
 
 end

data/lib/rubycritic/{smelly_pathnames_serializer.rb → smells_serializer.rb}

@@ -2,7 +2,7 @@ require "fileutils"
 
 module Rubycritic
 
-  class SmellyPathnamesSerializer
+  class SmellsSerializer
     def initialize(file_name)
       @file_name = file_name
     end
@@ -11,12 +11,10 @@ module Rubycritic
       Marshal.load(File.binread(@file_name))
     end
 
-    def dump(smelly_pathnames)
+    def dump(smells)
       create_file_directory
-      # HACK It's not possible to Marshal procs or lambdas.
-      smelly_pathnames.default = []
       File.open(@file_name, "w+") do |file|
-        Marshal.dump(smelly_pathnames, file)
+        Marshal.dump(smells, file)
       end
     end
 

data/lib/rubycritic/smells_status_setter.rb

@@ -1,20 +1,17 @@
 module Rubycritic
 
   class SmellsStatusSetter
-    def initialize(smelly_pathnames_before, smelly_pathnames_now)
-      @smelly_pathnames_before = smelly_pathnames_before
-      @smelly_pathnames_now = smelly_pathnames_now
+    def initialize(smells_before, smells_now)
+      @smells_before = smells_before || []
+      @smells_now = smells_now
     end
 
-    def smelly_pathnames
-      @smelly_pathnames_now.each do |pathname, smells_now|
-        smells_before = @smelly_pathnames_before[pathname] || []
-        old_smells = smells_now & smells_before
-        set_status(old_smells, :old)
-        new_smells = smells_now - smells_before
-        set_status(new_smells, :new)
-      end
-      @smelly_pathnames_now
+    def smells
+      old_smells = @smells_now & @smells_before
+      set_status(old_smells, :old)
+      new_smells = @smells_now - @smells_before
+      set_status(new_smells, :new)
+      @smells_now
     end
 
     private

data/lib/rubycritic/source_control_systems/source_control_system.rb

@@ -24,16 +24,20 @@ module Rubycritic
       systems.join(", ")
     end
 
+    def self.supported?
+      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
+    end
+
     def has_revision?
-      raise NotImplementedError.new("You must implement the has_revision? method.")
+      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
     end
 
     def head_reference
-      raise NotImplementedError.new("You must implement the head_reference method.")
+      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
     end
 
     def travel_to_head
-      raise NotImplementedError.new("You must implement the travel_to_head method.")
+      raise NotImplementedError.new("The #{self.class} class must implement the #{__method__} method.")
     end
   end
 

data/lib/rubycritic/version.rb

@@ -1,3 +1,3 @@
 module Rubycritic
-  VERSION = "0.0.7"
+  VERSION = "0.0.8"
 end

data/test/lib/rubycritic/location_test.rb

@@ -4,7 +4,7 @@ require "rubycritic/location"
 describe Rubycritic::Location do
   describe "attribute readers" do
     before do
-      @path = "./foo"
+      @path = "./foo.rb"
       @line = 42
       @location = Rubycritic::Location.new(@path, @line)
     end
@@ -16,6 +16,10 @@ describe Rubycritic::Location do
     it "has a line number" do
       @location.line.must_equal @line
     end
+
+    it "has a file name" do
+      @location.file_name.must_equal "foo"
+    end
   end
 
   it "is comparable" do

data/test/lib/rubycritic/smells_aggregator_test.rb

@@ -4,43 +4,28 @@ require "rubycritic/smells_aggregator"
 describe Rubycritic::SmellsAggregator do
   context "when analysing smelly files" do
     before do
-      @location1 = Rubycritic::Location.new("./foo", "42")
-      @location2 = Rubycritic::Location.new("./bar", "23")
-      @location3 = Rubycritic::Location.new("./bar", "16")
-      @smell1 = Rubycritic::Smell.new(:locations => [@location1])
-      @smell2 = Rubycritic::Smell.new(:locations => [@location2, @location3])
-      @smell_adapters = [stub(:smells => [@smell1]), stub(:smells => [@smell2])]
+      smell1 = Rubycritic::Smell.new
+      smell2 = Rubycritic::Smell.new
+      @smells = [smell2, smell1]
+      @smell_adapters = [stub(:smells => [smell1]), stub(:smells => [smell2])]
     end
 
     describe "#smells" do
       it "returns the smells found in those files" do
-        smells = [@smell2, @smell1]
-        Rubycritic::SmellsAggregator.new(@smell_adapters).smells.must_equal smells
-      end
-    end
-
-    describe "#smelly_pathnames" do
-      it "returns the files where smells were found" do
-        smelly_pathnames = {@location1.pathname => [@smell1], @location2.pathname => [@smell2]}
-        Rubycritic::SmellsAggregator.new(@smell_adapters).smelly_pathnames.must_equal smelly_pathnames
+        Rubycritic::SmellsAggregator.new(@smell_adapters).smells.must_equal @smells
       end
     end
   end
 
   context "when analysing files with no smells" do
     before do
-      @smell_adapters = [stub(:smells => [])]
+      @smells = []
+      @smell_adapters = [stub(:smells => @smells)]
     end
 
     describe "#smells" do
       it "returns an empty array" do
-        Rubycritic::SmellsAggregator.new(@smell_adapters).smells.must_equal []
-      end
-    end
-
-    describe "#smelly_pathnames" do
-      it "returns an empty hash" do
-        Rubycritic::SmellsAggregator.new(@smell_adapters).smelly_pathnames.must_equal({})
+        Rubycritic::SmellsAggregator.new(@smell_adapters).smells.must_equal @smells
       end
     end
   end

data/test/lib/rubycritic/smells_status_setter_test.rb

@@ -3,19 +3,19 @@ require "rubycritic/smell"
 require "rubycritic/smells_status_setter"
 
 describe Rubycritic::SmellsStatusSetter do
-  describe "#smelly_pathnames" do
+  describe "#smells" do
     before do
       @smell = Rubycritic::Smell.new(:context => "#bar")
-      @smelly_pathnames = { "file0.rb" => [@smell] }
+      @smells = [@smell]
     end
 
     it "marks old smells" do
-      Rubycritic::SmellsStatusSetter.new(@smelly_pathnames, @smelly_pathnames).smelly_pathnames
+      Rubycritic::SmellsStatusSetter.new(@smells, @smells).smells
       @smell.status.must_equal :old
     end
 
     it "marks new smells" do
-      Rubycritic::SmellsStatusSetter.new({}, @smelly_pathnames).smelly_pathnames
+      Rubycritic::SmellsStatusSetter.new([], @smells).smells
       @smell.status.must_equal :new
     end
   end

data/test/lib/rubycritic/source_control_systems/source_control_system_test.rb

@@ -19,7 +19,8 @@ describe Rubycritic::SourceControlSystem do
 
     describe "when no source control system is found" do
       it "raises an error" do
-        proc { Rubycritic::SourceControlSystem.create }.must_raise RuntimeError
+        error = proc { Rubycritic::SourceControlSystem.create }.must_raise RuntimeError
+        error.message.must_match "Rubycritic requires a Git repository."
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-25 00:00:00.000000000 Z
+date: 2014-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -154,14 +154,16 @@ files:
 - lib/rubycritic/report_generators/assets/stylesheets/application.css
 - lib/rubycritic/report_generators/assets/stylesheets/prettify.custom_theme.css
 - lib/rubycritic/report_generators/base_generator.rb
+- lib/rubycritic/report_generators/code_index_generator.rb
 - lib/rubycritic/report_generators/file_generator.rb
-- lib/rubycritic/report_generators/index_generator.rb
 - lib/rubycritic/report_generators/line_generator.rb
 - lib/rubycritic/report_generators/reporter.rb
+- lib/rubycritic/report_generators/smells_index_generator.rb
+- lib/rubycritic/report_generators/templates/code_index.html.erb
 - lib/rubycritic/report_generators/templates/file.html.erb
-- lib/rubycritic/report_generators/templates/index.html.erb
 - lib/rubycritic/report_generators/templates/layouts/application.html.erb
 - lib/rubycritic/report_generators/templates/line.html.erb
+- lib/rubycritic/report_generators/templates/smells_index.html.erb
 - lib/rubycritic/report_generators/templates/smelly_line.html.erb
 - lib/rubycritic/report_generators/view_helpers.rb
 - lib/rubycritic/revision_comparator.rb
@@ -170,8 +172,8 @@ files:
 - lib/rubycritic/smell_adapters/flog.rb
 - lib/rubycritic/smell_adapters/reek.rb
 - lib/rubycritic/smells_aggregator.rb
+- lib/rubycritic/smells_serializer.rb
 - lib/rubycritic/smells_status_setter.rb
-- lib/rubycritic/smelly_pathnames_serializer.rb
 - lib/rubycritic/source_control_systems/git.rb
 - lib/rubycritic/source_control_systems/source_control_system.rb
 - lib/rubycritic/source_locator.rb