rubycritic 0.0.13 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b4f79955ca6f3dab8dccacc5dca7c2b994db9cc7
-  data.tar.gz: 51bb696eca3c5caa072c1e20a0fb67c1d18c113f
+  metadata.gz: 74b9972ae846d78f2a449e831f4f56d5475349d8
+  data.tar.gz: 737c696e6b0b42393c3b6ddb2a8f6d09f446fed2
 SHA512:
-  metadata.gz: 0794412b39af6196e6d9e70ab55c634744778acf6a9102538ea34a2bbf0aa509fb2f4569437203eb53e0dc770dd73db7095ae2238323e9a10fff1520e30dfb50
-  data.tar.gz: f93087c069037601daa5f19c21d5794d8b176dbcc81b291b8a3f46f5d14a091bce4d75c0dd2d0e9b73cc7d0f4c5aa1568ec93ef7f33a91f2d3839010aeee60f6
+  metadata.gz: b5490faab830e968d3cdef7cdb0f04c1158197c8b738b30f383f9227fbbc102ba17d0276a248007ce7a668d53640cc54410d09c136f3e4ce24d59c1a9c26653e
+  data.tar.gz: d51c2940dc3a15ec3b6551d35c0ee24f6f7e8ed510e3dc74865301ef59e41cf361511e17a6db14e098e45fbdb188cf9524629ad72a35670c1f98d8f1eae05c4b

data/lib/rubycritic/analysers/config.reek

@@ -1,6 +1,8 @@
 ---
 Attribute:
   enabled: false
+DuplicateMethodCall:
+  max_calls: 2
 IrresponsibleModule:
   enabled: false
 NestedIterators:

data/lib/rubycritic/analysers_runner.rb

@@ -27,7 +27,7 @@ module Rubycritic
     end
 
     def aggregate_smells(smell_adapters)
-      smell_adapters.flat_map(&:smells).sort
+      smell_adapters.flat_map(&:smells)
     end
   end
 

data/lib/rubycritic/core/smell.rb

@@ -30,10 +30,6 @@ module Rubycritic
     end
     alias_method :eql?, :==
 
-    def <=>(other)
-      locations <=> other.locations
-    end
-
     def to_s
       "(#{type}) #{context} #{message}"
     end

data/lib/rubycritic/report_generators/assets/javascripts/application.js

@@ -46,9 +46,11 @@ function toggleSmells() {
     $(".js-smells").toggle();
 }
 
-$("#js-code-table").tablesorter({
-    sortList: [[0,0]] // sort on the first column, order asc
-});
+$("#js-index-table")
+    .tablesorter({          // Sort the table
+        sortList: [[0,0]]   // on the first column, in ascending order
+    })
+    .floatThead();          // Make table headers stick to the top when scrolling
 
 $("#js-chart-container").highcharts({
     chart: {

data/lib/rubycritic/report_generators/assets/javascripts/jquery.floatThead-v1.2.7.js

@@ -0,0 +1,754 @@
+// @preserve jQuery.floatThead 1.2.7 - http://mkoryak.github.io/floatThead/ - Copyright (c) 2012 - 2014 Misha Koryak
+// @license MIT
+
+/* @author Misha Koryak
+ * @projectDescription lock a table header in place while scrolling - without breaking styles or events bound to the header
+ *
+ * Dependencies:
+ * jquery 1.9.0 + [required] OR jquery 1.7.0 + jquery UI core
+ *
+ * http://mkoryak.github.io/floatThead/
+ *
+ * Tested on FF13+, Chrome 21+, IE8, IE9, IE10, IE11
+ *
+ */
+(function( $ ) {
+  /**
+   * provides a default config object. You can modify this after including this script if you want to change the init defaults
+   * @type {Object}
+   */
+  $.floatThead = $.floatThead || {};
+  $.floatThead.defaults = {
+    cellTag: 'th:visible', //thead cells are this
+    zIndex: 1001, //zindex of the floating thead (actually a container div)
+    debounceResizeMs: 10,
+    useAbsolutePositioning: true, //if set to NULL - defaults: has scrollContainer=true, doesn't have scrollContainer=false
+    scrollingTop: 0, //String or function($table) - offset from top of window where the header should not pass above
+    scrollingBottom: 0, //String or function($table) - offset from the bottom of the table where the header should stop scrolling
+    scrollContainer: function($table){
+      return $([]); //if the table has horizontal scroll bars then this is the container that has overflow:auto and causes those scroll bars
+    },
+    getSizingRow: function($table, $cols, $fthCells){ // this is only called when using IE,
+      // override it if the first row of the table is going to contain colgroups (any cell spans greater then one col)
+      // it should return a jquery object containing a wrapped set of table cells comprising a row that contains no col spans and is visible
+      return $table.find('tbody tr:visible:first>td');
+    },
+    floatTableClass: 'floatThead-table',
+    floatWrapperClass: 'floatThead-wrapper',
+    floatContainerClass: 'floatThead-container',
+    copyTableClass: true, //copy 'class' attribute from table into the floated table so that the styles match.
+    debug: false //print possible issues (that don't prevent script loading) to console, if console exists.
+  };
+
+  var util = window._;
+
+  //browser stuff
+  var ieVersion = function(){for(var a=3,b=document.createElement("b"),c=b.all||[];a = 1+a,b.innerHTML="<!--[if gt IE "+ a +"]><i><![endif]-->",c[0];);return 4<a?a:document.documentMode}();
+  var isChrome = null;
+  var isChromeCheck = function(){
+    if(ieVersion){
+      return false;
+    }
+    var $table = $("<table><colgroup><col></colgroup><tbody><tr><td style='width:10px'></td></tbody></table>");
+    $('body').append($table);
+    var width = $table.find('col').width();
+    $table.remove();
+    return width == 0;
+  };
+
+  var $window = $(window);
+  var floatTheadCreated = 0;
+
+
+  /**
+   * @param debounceMs
+   * @param cb
+   */
+
+  function windowResize(debounceMs, eventName, cb){
+    if(ieVersion == 8){ //ie8 is crap: https://github.com/mkoryak/floatThead/issues/65
+      var winWidth = $window.width();
+      var debouncedCb = util.debounce(function(){
+        var winWidthNew = $window.width();
+        if(winWidth != winWidthNew){
+          winWidth = winWidthNew;
+          cb();
+        }
+      }, debounceMs);
+      $window.on(eventName, debouncedCb);
+    } else {
+      $window.on(eventName, util.debounce(cb, debounceMs));
+    }
+  }
+
+
+  function debug(str){
+    window.console && window.console && window.console.log && window.console.log(str);
+  }
+
+  /**
+   * try to calculate the scrollbar width for your browser/os
+   * @return {Number}
+   */
+  function scrollbarWidth() {
+    var $div = $( //borrowed from anti-scroll
+      '<div style="width:50px;height:50px;overflow-y:scroll;'
+        + 'position:absolute;top:-200px;left:-200px;"><div style="height:100px;width:100%">'
+        + '</div>'
+    );
+    $('body').append($div);
+    var w1 = $div.innerWidth();
+    var w2 = $('div', $div).innerWidth();
+    $div.remove();
+    return w1 - w2;
+  }
+  /**
+   * Check if a given table has been datatableized (http://datatables.net)
+   * @param $table
+   * @return {Boolean}
+   */
+  function isDatatable($table){
+    if($table.dataTableSettings){
+      for(var i = 0; i < $table.dataTableSettings.length; i++){
+        var table = $table.dataTableSettings[i].nTable;
+        if($table[0] == table){
+          return true;
+        }
+      }
+    }
+    return false;
+  }
+  $.fn.floatThead = function(map){
+    map = map || {};
+    if(!util){ //may have been included after the script? lets try to grab it again.
+      util = window._ || $.floatThead._;
+      if(!util){
+        throw new Error("jquery.floatThead-slim.js requires underscore. You should use the non-lite version since you do not have underscore.");
+      }
+    }
+
+    if(ieVersion < 8){
+      return this; //no more crappy browser support.
+    }
+
+    if(isChrome == null){ //make sure this is done only once no matter how many times you call the plugin fn
+      isChrome = isChromeCheck(); //need to call this after dom ready, and now it is.
+      if(isChrome){
+        //because chrome cant read <col> width, these elements are used for sizing the table. Need to create new elements because they must be unstyled by user's css.
+        document.createElement('fthtr'); //tr
+        document.createElement('fthtd'); //td
+        document.createElement('fthfoot'); //tfoot
+      }
+    }
+    if(util.isString(map)){
+      var command = map;
+      var ret = this;
+      this.filter('table').each(function(){
+        var obj = $(this).data('floatThead-attached');
+        if(obj && util.isFunction(obj[command])){
+          var r = obj[command]();
+          if(typeof r !== 'undefined'){
+            ret = r;
+          }
+        }
+      });
+      return ret;
+    }
+    var opts = $.extend({}, $.floatThead.defaults || {}, map);
+
+    $.each(map, function(key, val){
+      if((!(key in $.floatThead.defaults)) && opts.debug){
+        debug("jQuery.floatThead: used ["+key+"] key to init plugin, but that param is not an option for the plugin. Valid options are: "+ (util.keys($.floatThead.defaults)).join(', '));
+      }
+    });
+
+    this.filter(':not(.'+opts.floatTableClass+')').each(function(){
+      var floatTheadId = floatTheadCreated;
+      var $table = $(this);
+      if($table.data('floatThead-attached')){
+        return true; //continue the each loop
+      }
+      if(!$table.is('table')){
+        throw new Error('jQuery.floatThead must be run on a table element. ex: $("table").floatThead();');
+      }
+      var $header = $table.find('thead:first');
+      var $tbody = $table.find('tbody:first');
+      if($header.length == 0){
+        throw new Error('jQuery.floatThead must be run on a table that contains a <thead> element');
+      }
+      var headerFloated = false;
+      var scrollingTop, scrollingBottom;
+      var scrollbarOffset = {vertical: 0, horizontal: 0};
+      var scWidth = scrollbarWidth();
+      var lastColumnCount = 0; //used by columnNum()
+      var $scrollContainer = opts.scrollContainer($table) || $([]); //guard against returned nulls
+
+      var useAbsolutePositioning = opts.useAbsolutePositioning;
+      if(useAbsolutePositioning == null){ //defaults: locked=true, !locked=false
+        useAbsolutePositioning = opts.scrollContainer($table).length;
+      }
+      var $caption = $table.find("caption");
+      var haveCaption = $caption.length == 1;
+      if(haveCaption){
+        var captionAlignTop = ($caption.css("caption-side") || $caption.attr("align") || "top") === "top";
+      }
+
+      var $fthGrp = $('<fthfoot style="display:table-footer-group;"/>');
+
+      var locked = $scrollContainer.length > 0;
+      var wrappedContainer = false; //used with absolute positioning enabled. did we need to wrap the scrollContainer/table with a relative div?
+      var $wrapper = $([]); //used when absolute positioning enabled - wraps the table and the float container
+      var absoluteToFixedOnScroll = ieVersion <= 9 && !locked && useAbsolutePositioning; //on ie using absolute positioning doesnt look good with window scrolling, so we change positon to fixed on scroll, and then change it back to absolute when done.
+      var $floatTable = $("<table/>");
+      var $floatColGroup = $("<colgroup/>");
+      var $tableColGroup = $table.find('colgroup:first');
+      var existingColGroup = true;
+      if($tableColGroup.length == 0){
+        $tableColGroup = $("<colgroup/>");
+        existingColGroup = false;
+      }
+      var $fthRow = $('<fthrow style="display:table-row;height:0;"/>'); //created unstyled elements
+      var $floatContainer = $('<div style="overflow: hidden;"></div>');
+      var $newHeader = $("<thead/>");
+      var $sizerRow = $('<tr class="size-row"/>');
+      var $sizerCells = $([]);
+      var $tableCells = $([]); //used for sizing - either $sizerCells or $tableColGroup cols. $tableColGroup cols are only created in chrome for borderCollapse:collapse because of a chrome bug.
+      var $headerCells = $([]);
+      var $fthCells = $([]); //created elements
+
+      $newHeader.append($sizerRow);
+      $table.prepend($tableColGroup);
+      if(isChrome){
+        $fthGrp.append($fthRow);
+        $table.append($fthGrp);
+      }
+
+      $floatTable.append($floatColGroup);
+      $floatContainer.append($floatTable);
+      if(opts.copyTableClass){
+        $floatTable.attr('class', $table.attr('class'));
+      }
+      $floatTable.attr({ //copy over some deprecated table attributes that people still like to use. Good thing poeple dont use colgroups...
+        'cellpadding': $table.attr('cellpadding'),
+        'cellspacing': $table.attr('cellspacing'),
+        'border': $table.attr('border')
+      });
+
+      $floatTable.addClass(opts.floatTableClass).css('margin', 0); //must have no margins or you wont be able to click on things under floating table
+
+      if(useAbsolutePositioning){
+        var makeRelative = function($container, alwaysWrap){
+          var positionCss = $container.css('position');
+          var relativeToScrollContainer = (positionCss == "relative" || positionCss == "absolute");
+          if(!relativeToScrollContainer || alwaysWrap){
+            var css = {"paddingLeft": $container.css('paddingLeft'), "paddingRight": $container.css('paddingRight')};
+            $floatContainer.css(css);
+            $container = $container.wrap("<div class='"+opts.floatWrapperClass+"' style='position: relative; clear:both;'></div>").parent();
+            wrappedContainer = true;
+          }
+          return $container;
+        };
+        if(locked){
+          $wrapper = makeRelative($scrollContainer, true);
+          $wrapper.append($floatContainer);
+        } else {
+          $wrapper = makeRelative($table);
+          $table.after($floatContainer);
+        }
+      } else {
+        $table.after($floatContainer);
+      }
+
+
+      $floatContainer.css({
+        position: useAbsolutePositioning ? 'absolute' : 'fixed',
+        marginTop: 0,
+        top:  useAbsolutePositioning ? 0 : 'auto',
+        zIndex: opts.zIndex
+      });
+      $floatContainer.addClass(opts.floatContainerClass);
+      updateScrollingOffsets();
+
+      var layoutFixed = {'table-layout': 'fixed'};
+      var layoutAuto = {'table-layout': $table.css('tableLayout') || 'auto'};
+      var originalTableWidth = $table[0].style.width || ""; //setting this to auto is bad: #70
+
+      function eventName(name){
+        return name+'.fth-'+floatTheadId+'.floatTHead'
+      }
+
+      function setHeaderHeight(){
+        var headerHeight = 0;
+        $header.find("tr").each(function(){
+          headerHeight += $(this).outerHeight(true);
+        });
+        $sizerRow.outerHeight(headerHeight);
+        $sizerCells.outerHeight(headerHeight);
+      }
+
+
+      function setFloatWidth(){
+        var tableWidth = $table.outerWidth();
+        var width = $scrollContainer.width() || tableWidth;
+        $floatContainer.width(width - scrollbarOffset.vertical);
+        if(locked){
+          var percent = 100 * tableWidth / (width - scrollbarOffset.vertical);
+          $floatTable.css('width', percent+'%');
+        } else {
+          $floatTable.outerWidth(tableWidth);
+        }
+      }
+
+      function updateScrollingOffsets(){
+        scrollingTop = (util.isFunction(opts.scrollingTop) ? opts.scrollingTop($table) : opts.scrollingTop) || 0;
+        scrollingBottom = (util.isFunction(opts.scrollingBottom) ? opts.scrollingBottom($table) : opts.scrollingBottom) || 0;
+      }
+
+      /**
+       * get the number of columns and also rebuild resizer rows if the count is different then the last count
+       */
+      function columnNum(){
+        var count, $headerColumns;
+        if(existingColGroup){
+          count = $tableColGroup.find('col').length;
+        } else {
+          $headerColumns = $header.find('tr:first>'+opts.cellTag);
+          count = 0;
+          $headerColumns.each(function(){
+            count += parseInt(($(this).attr('colspan') || 1), 10);
+          });
+        }
+        if(count != lastColumnCount){
+          lastColumnCount = count;
+          var cells = [], cols = [], psuedo = [];
+          for(var x = 0; x < count; x++){
+            cells.push('<th class="floatThead-col"/>');
+            cols.push('<col/>');
+            psuedo.push("<fthtd style='display:table-cell;height:0;width:auto;'/>");
+          }
+
+          cols = cols.join('');
+          cells = cells.join('');
+
+          if(isChrome){
+            psuedo = psuedo.join('');
+            $fthRow.html(psuedo);
+            $fthCells = $fthRow.find('fthtd');
+          }
+
+          $sizerRow.html(cells);
+          $sizerCells = $sizerRow.find("th");
+          if(!existingColGroup){
+            $tableColGroup.html(cols);
+          }
+          $tableCells = $tableColGroup.find('col');
+          $floatColGroup.html(cols);
+          $headerCells = $floatColGroup.find("col");
+
+        }
+        return count;
+      }
+
+      function refloat(){ //make the thing float
+        if(!headerFloated){
+          headerFloated = true;
+          if(useAbsolutePositioning){ //#53, #56
+            var tableWidth = $table.width();
+            var wrapperWidth = $wrapper.width();
+            if(tableWidth > wrapperWidth){
+              $table.css('minWidth', tableWidth);
+            }
+          }
+          $table.css(layoutFixed);
+          $floatTable.css(layoutFixed);
+          $floatTable.append($header); //append because colgroup must go first in chrome
+          $tbody.before($newHeader);
+          setHeaderHeight();
+        }
+      }
+      function unfloat(){ //put the header back into the table
+        if(headerFloated){
+          headerFloated = false;
+          if(useAbsolutePositioning){ //#53, #56
+            $table.width(originalTableWidth);
+          }
+          $newHeader.detach();
+          $table.prepend($header);
+          $table.css(layoutAuto);
+          $floatTable.css(layoutAuto);
+        }
+      }
+      function changePositioning(isAbsolute){
+        if(useAbsolutePositioning != isAbsolute){
+          useAbsolutePositioning = isAbsolute;
+          $floatContainer.css({
+            position: useAbsolutePositioning ? 'absolute' : 'fixed'
+          });
+        }
+      }
+      function getSizingRow($table, $cols, $fthCells, ieVersion){
+        if(isChrome){
+          return $fthCells;
+        } else if(ieVersion) {
+          return opts.getSizingRow($table, $cols, $fthCells);
+        } else {
+          return $cols;
+        }
+      }
+
+      /**
+       * returns a function that updates the floating header's cell widths.
+       * @return {Function}
+       */
+      function reflow(){
+        var i;
+        var numCols = columnNum(); //if the tables columns change dynamically since last time (datatables) we need to rebuild the sizer rows and get new count
+        return function(){
+          var $rowCells = getSizingRow($table, $tableCells, $fthCells, ieVersion);
+          if($rowCells.length == numCols && numCols > 0){
+            if(!existingColGroup){
+              for(i=0; i < numCols; i++){
+                $tableCells.eq(i).css('width', '');
+              }
+            }
+            unfloat();
+            for(i=0; i < numCols; i++){
+              var _rowcell = $rowCells.get(i);
+              var rowWidth = _rowcell.offsetWidth;
+              $headerCells.eq(i).width(rowWidth);
+              $tableCells.eq(i).width(rowWidth);
+            }
+            refloat();
+          } else {
+            $floatTable.append($header);
+            $table.css(layoutAuto);
+            $floatTable.css(layoutAuto);
+            setHeaderHeight();
+          }
+        };
+      }
+
+      /**
+       * first performs initial calculations that we expect to not change when the table, window, or scrolling container are scrolled.
+       * returns a function that calculates the floating container's top and left coords. takes into account if we are using page scrolling or inner scrolling
+       * @return {Function}
+       */
+      function calculateFloatContainerPosFn(){
+        var scrollingContainerTop = $scrollContainer.scrollTop();
+
+        //this floatEnd calc was moved out of the returned function because we assume the table height doesnt change (otherwise we must reinit by calling calculateFloatContainerPosFn)
+        var floatEnd;
+        var tableContainerGap = 0;
+        var captionHeight = haveCaption ? $caption.outerHeight(true) : 0;
+        var captionScrollOffset = captionAlignTop ? captionHeight : -captionHeight;
+
+        var floatContainerHeight = $floatContainer.height();
+        var tableOffset = $table.offset();
+        if(locked){
+          var containerOffset = $scrollContainer.offset();
+          tableContainerGap = tableOffset.top - containerOffset.top + scrollingContainerTop;
+          if(haveCaption && captionAlignTop){
+            tableContainerGap += captionHeight;
+          }
+        } else {
+          floatEnd = tableOffset.top - scrollingTop - floatContainerHeight + scrollingBottom + scrollbarOffset.horizontal;
+        }
+        var windowTop = $window.scrollTop();
+        var windowLeft = $window.scrollLeft();
+        var scrollContainerLeft =  $scrollContainer.scrollLeft();
+        scrollingContainerTop = $scrollContainer.scrollTop();
+
+
+
+        return function(eventType){
+          if(eventType == 'windowScroll'){
+            windowTop = $window.scrollTop();
+            windowLeft = $window.scrollLeft();
+          } else if(eventType == 'containerScroll'){
+            scrollingContainerTop = $scrollContainer.scrollTop();
+            scrollContainerLeft =  $scrollContainer.scrollLeft();
+          } else if(eventType != 'init') {
+            windowTop = $window.scrollTop();
+            windowLeft = $window.scrollLeft();
+            scrollingContainerTop = $scrollContainer.scrollTop();
+            scrollContainerLeft =  $scrollContainer.scrollLeft();
+          }
+          if(isChrome && (windowTop < 0 || windowLeft < 0)){ //chrome overscroll effect at the top of the page - breaks fixed positioned floated headers
+            return;
+          }
+
+          if(absoluteToFixedOnScroll){
+            if(eventType == 'windowScrollDone'){
+              changePositioning(true); //change to absolute
+            } else {
+              changePositioning(false); //change to fixed
+            }
+          } else if(eventType == 'windowScrollDone'){
+            return null; //event is fired when they stop scrolling. ignore it if not 'absoluteToFixedOnScroll'
+          }
+
+          tableOffset = $table.offset();
+          if(haveCaption && captionAlignTop){
+            tableOffset.top += captionHeight;
+          }
+          var top, left, tableHeight;
+
+          if(locked && useAbsolutePositioning){ //inner scrolling, absolute positioning
+            if (tableContainerGap >= scrollingContainerTop) {
+              var gap = tableContainerGap - scrollingContainerTop;
+              gap = gap > 0 ? gap : 0;
+              top = gap;
+            } else {
+              top = wrappedContainer ? 0 : scrollingContainerTop;
+              //headers stop at the top of the viewport
+            }
+            left = 0;
+          } else if(!locked && useAbsolutePositioning) { //window scrolling, absolute positioning
+            tableHeight = $table.outerHeight();
+            if(windowTop > floatEnd + tableHeight + captionScrollOffset){
+              top = tableHeight - floatContainerHeight + captionScrollOffset; //scrolled past table
+            } else if (tableOffset.top > windowTop + scrollingTop) {
+              top = 0; //scrolling to table
+              unfloat();
+            } else {
+              top = scrollingTop + windowTop - tableOffset.top + tableContainerGap + (captionAlignTop ? captionHeight : 0);
+              refloat(); //scrolling within table. header floated
+            }
+            left =  0;
+          } else if(locked && !useAbsolutePositioning){ //inner scrolling, fixed positioning
+            if (tableContainerGap > scrollingContainerTop) {
+              top = tableOffset.top - windowTop;
+              unfloat();
+            } else {
+              top = tableOffset.top + scrollingContainerTop  - windowTop - tableContainerGap;
+              refloat();
+              //headers stop at the top of the viewport
+            }
+            left = tableOffset.left + scrollContainerLeft - windowLeft;
+          } else if(!locked && !useAbsolutePositioning) { //window scrolling, fixed positioning
+            tableHeight = $table.outerHeight();
+            if(windowTop > floatEnd + tableHeight + captionScrollOffset){
+              top = tableHeight + scrollingTop - windowTop + floatEnd + captionScrollOffset;
+              //scrolled past the bottom of the table
+            } else if (tableOffset.top > windowTop + scrollingTop) {
+              top = tableOffset.top - windowTop;
+              refloat();
+              //scrolled past the top of the table
+            } else {
+              //scrolling within the table
+              top = scrollingTop;
+            }
+            left = tableOffset.left - windowLeft;
+          }
+          return {top: top, left: left};
+        };
+      }
+      /**
+       * returns a function that caches old floating container position and only updates css when the position changes
+       * @return {Function}
+       */
+      function repositionFloatContainerFn(){
+        var oldTop = null;
+        var oldLeft = null;
+        var oldScrollLeft = null;
+        return function(pos, setWidth, setHeight){
+          if(pos != null && (oldTop != pos.top || oldLeft != pos.left)){
+            $floatContainer.css({
+              top: pos.top,
+              left: pos.left
+            });
+            oldTop = pos.top;
+            oldLeft = pos.left;
+          }
+          if(setWidth){
+            setFloatWidth();
+          }
+          if(setHeight){
+            setHeaderHeight();
+          }
+          var scrollLeft = $scrollContainer.scrollLeft();
+          if(oldScrollLeft != scrollLeft){
+            $floatContainer.scrollLeft(scrollLeft);
+            oldScrollLeft = scrollLeft;
+          }
+        }
+      }
+
+      /**
+       * checks if THIS table has scrollbars, and finds their widths
+       */
+      function calculateScrollBarSize(){ //this should happen after the floating table has been positioned
+        if($scrollContainer.length){
+          scrollbarOffset.horizontal = $scrollContainer.width() < $table.width() ? scWidth : 0;
+          scrollbarOffset.vertical =  $scrollContainer.height() < $table.height() ? scWidth: 0;
+        }
+      }
+      //finish up. create all calculation functions and bind them to events
+      calculateScrollBarSize();
+
+      var flow;
+
+      var ensureReflow = function(){
+        flow = reflow();
+        flow();
+      };
+
+      ensureReflow();
+
+      var calculateFloatContainerPos = calculateFloatContainerPosFn();
+      var repositionFloatContainer = repositionFloatContainerFn();
+
+      repositionFloatContainer(calculateFloatContainerPos('init'), true); //this must come after reflow because reflow changes scrollLeft back to 0 when it rips out the thead
+
+      var windowScrollDoneEvent = util.debounce(function(){
+        repositionFloatContainer(calculateFloatContainerPos('windowScrollDone'), false);
+      }, 300);
+
+      var windowScrollEvent = function(){
+        repositionFloatContainer(calculateFloatContainerPos('windowScroll'), false);
+        windowScrollDoneEvent();
+      };
+      var containerScrollEvent = function(){
+        repositionFloatContainer(calculateFloatContainerPos('containerScroll'), false);
+      };
+
+
+      var windowResizeEvent = function(){
+        updateScrollingOffsets();
+        calculateScrollBarSize();
+        ensureReflow();
+        calculateFloatContainerPos = calculateFloatContainerPosFn();
+        repositionFloatContainer = repositionFloatContainerFn();
+        repositionFloatContainer(calculateFloatContainerPos('resize'), true, true);
+      };
+      var reflowEvent = util.debounce(function(){
+        calculateScrollBarSize();
+        updateScrollingOffsets();
+        ensureReflow();
+        calculateFloatContainerPos = calculateFloatContainerPosFn();
+        repositionFloatContainer(calculateFloatContainerPos('reflow'), true);
+      }, 1);
+      if(locked){ //internal scrolling
+        if(useAbsolutePositioning){
+          $scrollContainer.on(eventName('scroll'), containerScrollEvent);
+        } else {
+          $scrollContainer.on(eventName('scroll'), containerScrollEvent);
+          $window.on(eventName('scroll'), windowScrollEvent);
+        }
+      } else { //window scrolling
+        $window.on(eventName('scroll'), windowScrollEvent);
+      }
+
+      $window.on(eventName('load'), reflowEvent); //for tables with images
+
+      windowResize(opts.debounceResizeMs, eventName('resize'), windowResizeEvent);
+      $table.on('reflow', reflowEvent);
+      if(isDatatable($table)){
+        $table
+          .on('filter', reflowEvent)
+          .on('sort',   reflowEvent)
+          .on('page',   reflowEvent);
+      }
+
+      //attach some useful functions to the table.
+      $table.data('floatThead-attached', {
+        destroy: function(){
+          var ns = '.fth-'+floatTheadId;
+          unfloat();
+          $table.css(layoutAuto);
+          $tableColGroup.remove();
+          isChrome && $fthGrp.remove();
+          if($newHeader.parent().length){ //only if its in the dom
+            $newHeader.replaceWith($header);
+          }
+          $table.off('reflow');
+          $scrollContainer.off(ns);
+          if (wrappedContainer) {
+            $scrollContainer.unwrap();
+          }
+          $floatContainer.remove();
+          $table.data('floatThead-attached', false);
+
+          $window.off(ns);
+        },
+        reflow: function(){
+          reflowEvent();
+        },
+        setHeaderHeight: function(){
+          setHeaderHeight();
+        },
+        getFloatContainer: function(){
+          return $floatContainer;
+        },
+        getRowGroups: function(){
+          if(headerFloated){
+            return $floatContainer.find("thead").add($table.find("tbody,tfoot"));
+          } else {
+            return $table.find("thead,tbody,tfoot");
+          }
+        }
+      });
+      floatTheadCreated++;
+    });
+    return this;
+  };
+})(jQuery);
+/* jQuery.floatThead.utils - http://mkoryak.github.io/floatThead/ - Copyright (c) 2012 - 2014 Misha Koryak
+ * License: MIT
+ *
+ * This file is required if you do not use underscore in your project and you want to use floatThead.
+ * It contains functions from underscore that the plugin uses.
+ *
+ * YOU DON'T NEED TO INCLUDE THIS IF YOU ALREADY INCLUDE UNDERSCORE!
+ *
+ */
+
+(function(){
+
+  $.floatThead = $.floatThead || {};
+
+  $.floatThead._  = window._ || (function(){
+    var that = {};
+    var hasOwnProperty = Object.prototype.hasOwnProperty, isThings = ['Arguments', 'Function', 'String', 'Number', 'Date', 'RegExp'];
+    that.has = function(obj, key) {
+      return hasOwnProperty.call(obj, key);
+    };
+    that.keys = function(obj) {
+      if (obj !== Object(obj)) throw new TypeError('Invalid object');
+      var keys = [];
+      for (var key in obj) if (that.has(obj, key)) keys.push(key);
+      return keys;
+    };
+    $.each(isThings, function(){
+      var name = this;
+      that['is' + name] = function(obj) {
+        return Object.prototype.toString.call(obj) == '[object ' + name + ']';
+      };
+    });
+    that.debounce = function(func, wait, immediate) {
+      var timeout, args, context, timestamp, result;
+      return function() {
+        context = this;
+        args = arguments;
+        timestamp = new Date();
+        var later = function() {
+          var last = (new Date()) - timestamp;
+          if (last < wait) {
+            timeout = setTimeout(later, wait - last);
+          } else {
+            timeout = null;
+            if (!immediate) result = func.apply(context, args);
+          }
+        };
+        var callNow = immediate && !timeout;
+        if (!timeout) {
+          timeout = setTimeout(later, wait);
+        }
+        if (callNow) result = func.apply(context, args);
+        return result;
+      };
+    };
+    return that;
+  })();
+})();
+

data/lib/rubycritic/report_generators/assets/stylesheets/application.css

@@ -39,17 +39,25 @@ html {
   margin: 0 auto;
 }
 
-.analysis-index-table {
+.index-table {
   width: 100%;
   border-collapse: collapse;
+  table-layout: fixed;
 }
 
-.analysis-index-table th {
+.index-table th {
   text-align: left;
   padding: 8px 10px;
   border-bottom: 1px solid silver;
   font-size: 1.55em;
   font-weight: normal;
+  background-color: white;
+}
+
+.sortable-table .headerSortUp,
+.sortable-table .headerSortDown {
+  border: 1px solid silver;
+  border-bottom: 0;
 }
 
 .sortable-table th:hover {
@@ -57,14 +65,22 @@ html {
   cursor: pointer;
 }
 
-.analysis-index-table td {
+.index-table td {
   padding: 12px 10px;
 }
 
-.analysis-index-table .first-cell {
+.index-table .first-cell {
   padding-left: 60px;
 }
 
+.index-table .last-cell {
+  padding-right: 60px;
+}
+
+.index-table .numeric-cell {
+  text-align: right;
+}
+
 .button {
   margin: 0;
   padding: 0.5em 1em;

data/lib/rubycritic/report_generators/code_index.rb

@@ -19,10 +19,6 @@ module Rubycritic
         index_body = TEMPLATE.result(get_binding)
         LAYOUT_TEMPLATE.result(get_binding { index_body })
       end
-
-      def file_path(pathname)
-        File.join(root_directory, pathname.sub_ext(".html"))
-      end
     end
 
   end

data/lib/rubycritic/report_generators/templates/code_index.html.erb

@@ -1,8 +1,10 @@
-<table id="js-code-table" class="analysis-index-table sortable-table">
+<table id="js-index-table" class="index-table sortable-table">
 <thead>
   <tr>
     <th class="first-cell">Name</th>
-    <th>Smells</th>
+    <th class="numeric-cell" title="Number of times a file has changed">Churn</th>
+    <th class="numeric-cell" title="Overall amount of code in a file">Complexity</th>
+    <th class="numeric-cell last-cell">Smells</th>
   </tr>
 </thead>
 <tbody>
@@ -11,7 +13,9 @@
       <td class="first-cell">
         <a href="<%= file_path(analysed_file.pathname) %>"><%= analysed_file.name %></a>
       </td>
-      <td><%= analysed_file.smells.length %></td>
+      <td class="numeric-cell"><%= analysed_file.churn %></td>
+      <td class="numeric-cell"><%= analysed_file.complexity %></td>
+      <td class="numeric-cell last-cell"><%= analysed_file.smells.length %></td>
     </tr>
   <% end %>
 </tbody>

data/lib/rubycritic/report_generators/templates/layouts/application.html.erb

@@ -10,16 +10,17 @@
   </head>
   <body>
     <header class="project-header group">
-      <h1 class="logo"><a href="<%= overview_path %>" class="logo-link">RubyCritic</a></h1>
+      <h1 class="logo"><a href="<%= file_path('overview') %>" class="logo-link">RubyCritic</a></h1>
       <nav class="project-nav">
-        <a href="<%= overview_path %>" class="project-nav-item">Overview</a>
-        <a href="<%= code_index_path %>" class="project-nav-item">Code</a>
-        <a href="<%= smells_index_path %>" class="project-nav-item">Smells</a>
+        <a href="<%= file_path('overview') %>" class="project-nav-item">Overview</a>
+        <a href="<%= file_path('code_index') %>" class="project-nav-item">Code</a>
+        <a href="<%= file_path('smells_index') %>" class="project-nav-item">Smells</a>
       </nav>
     </header>
     <%= yield %>
     <script src="<%= javascript_path(:'jquery-2.1.0') %>"></script>
     <script src="<%= javascript_path(:'jquery.tablesorter-2.0') %>"></script>
+    <script src="<%= javascript_path(:'jquery.floatThead-v1.2.7') %>"></script>
     <script src="<%= javascript_path(:'highcharts.src-4.0.1') %>"></script>
     <script src="<%= javascript_path(:'jquery.scrollTo-1.4.11') %>"></script>
     <script src="<%= javascript_path(:'prettify-4-Mar-2013') %>"></script>

data/lib/rubycritic/report_generators/templates/smells_index.html.erb

@@ -1,15 +1,15 @@
-<table id="js-code-table" class="analysis-index-table sortable-table">
+<table id="js-index-table" class="index-table sortable-table">
 <thead>
   <tr>
     <th class="first-cell">Smell</th>
-    <th>Locations</th>
+    <th class="last-cell">Locations</th>
   </tr>
 </thead>
 <tbody>
   <% @smells.each do |smell| %>
     <tr>
       <td class="first-cell"><%= smell.type %></td>
-      <td>
+      <td class="last-cell">
         <% smell.locations.each do |location| %>
           <a href="<%= smell_location_path(location) %>"><%= location.file_name %></a>
         <% end %>

data/lib/rubycritic/report_generators/view_helpers.rb

@@ -1,3 +1,5 @@
+require "pathname"
+
 module Rubycritic
 
   module ViewHelpers
@@ -13,21 +15,12 @@ module Rubycritic
       File.join(root_directory, "assets", file)
     end
 
-    def smell_location_path(location)
-      pathname = location.pathname
-      File.join(root_directory, "#{pathname.sub_ext('.html')}#L#{location.line}")
-    end
-
-    def overview_path
-      File.join(root_directory, "overview.html")
+    def file_path(file)
+      File.join(root_directory, Pathname(file).sub_ext(".html"))
     end
 
-    def code_index_path
-      File.join(root_directory, "code_index.html")
-    end
-
-    def smells_index_path
-      File.join(root_directory, "smells_index.html")
+    def smell_location_path(location)
+      File.join(root_directory, "#{location.pathname.sub_ext('.html')}#L#{location.line}")
     end
 
     def root_directory

data/lib/rubycritic/reporters/base.rb

@@ -0,0 +1,24 @@
+require "fileutils"
+
+module Rubycritic
+  module Reporter
+
+    class Base
+      ASSETS_DIR = File.expand_path("../../report_generators/assets", __FILE__)
+
+      def create_directories_and_files(generators)
+        Array(generators).each do |generator|
+          FileUtils.mkdir_p(generator.file_directory)
+          File.open(generator.file_pathname, "w+") do |file|
+            file.write(generator.render)
+          end
+        end
+      end
+
+      def copy_assets_to_report_directory
+        FileUtils.cp_r(ASSETS_DIR, ::Rubycritic.configuration.root)
+      end
+    end
+
+  end
+end

data/lib/rubycritic/reporters/main.rb

@@ -1,28 +1,21 @@
+require "rubycritic/reporters/base"
 require "rubycritic/report_generators/overview"
 require "rubycritic/report_generators/smells_index"
 require "rubycritic/report_generators/code_index"
 require "rubycritic/report_generators/code_file"
-require "fileutils"
 
 module Rubycritic
   module Reporter
 
-    class Main
-      ASSETS_DIR = File.expand_path("../../report_generators/assets", __FILE__)
-
+    class Main < Base
       def initialize(analysed_files, smells)
         @analysed_files = analysed_files
         @smells = smells
       end
 
       def generate_report
-        generators.each do |generator|
-          FileUtils.mkdir_p(generator.file_directory)
-          File.open(generator.file_pathname, "w+") do |file|
-            file.write(generator.render)
-          end
-        end
-        FileUtils.cp_r(ASSETS_DIR, ::Rubycritic.configuration.root)
+        create_directories_and_files(generators)
+        copy_assets_to_report_directory
         overview_generator.file_href
       end
 

data/lib/rubycritic/reporters/mini.rb

@@ -1,23 +1,18 @@
+require "rubycritic/reporters/base"
 require "rubycritic/report_generators/code_file"
-require "fileutils"
 
 module Rubycritic
   module Reporter
 
-    class Mini
-      ASSETS_DIR = File.expand_path("../../report_generators/assets", __FILE__)
-
+    class Mini < Base
       def initialize(analysed_file)
         @analysed_file = analysed_file
       end
 
       def generate_report
         file_generator = Generator::CodeFile.new(@analysed_file)
-        FileUtils.mkdir_p(file_generator.file_directory)
-        File.open(file_generator.file_pathname, "w+") do |file|
-          file.write(file_generator.render)
-        end
-        FileUtils.cp_r(ASSETS_DIR, ::Rubycritic.configuration.root)
+        create_directories_and_files(file_generator)
+        copy_assets_to_report_directory
         file_generator.file_href
       end
     end

data/lib/rubycritic/version.rb

@@ -1,3 +1,3 @@
 module Rubycritic
-  VERSION = "0.0.13"
+  VERSION = "0.0.14"
 end

data/test/samples/reek/not_smelly.rb

@@ -20,4 +20,16 @@ class Perfume
     do_something
     do_something
   end
+
+  def allow_up_to_two_duplicate_method_calls
+    respond_to do |format|
+      if success
+        format.html { redirect_to some_path }
+        format.js { head :ok }
+      else
+        format.html { redirect_to :back, status: :bad_request }
+        format.js { render status: :bad_request }
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubycritic
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - Guilherme Simoes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-15 00:00:00.000000000 Z
+date: 2014-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -163,6 +163,7 @@ files:
 - lib/rubycritic/report_generators/assets/javascripts/application.js
 - lib/rubycritic/report_generators/assets/javascripts/highcharts.src-4.0.1.js
 - lib/rubycritic/report_generators/assets/javascripts/jquery-2.1.0.js
+- lib/rubycritic/report_generators/assets/javascripts/jquery.floatThead-v1.2.7.js
 - lib/rubycritic/report_generators/assets/javascripts/jquery.scrollTo-1.4.11.js
 - lib/rubycritic/report_generators/assets/javascripts/jquery.tablesorter-2.0.js
 - lib/rubycritic/report_generators/assets/javascripts/prettify-4-Mar-2013.js
@@ -182,6 +183,7 @@ files:
 - lib/rubycritic/report_generators/templates/smells_index.html.erb
 - lib/rubycritic/report_generators/templates/smelly_line.html.erb
 - lib/rubycritic/report_generators/view_helpers.rb
+- lib/rubycritic/reporters/base.rb
 - lib/rubycritic/reporters/main.rb
 - lib/rubycritic/reporters/mini.rb
 - lib/rubycritic/revision_comparator.rb