ruby_peter_v 0.0.11 → 0.0.12

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 850938ee947f3ce50fcdcfe4162e4c62374a59b0
+  data.tar.gz: 88b16856fcf2b394c52f641b812dee72dfb3d1ae
+SHA512:
+  metadata.gz: 727a2fab4b29424771d37145b69e34df45ba576baa38fc6aa296a9e0c37d69cd7a2117696ed3b67114638f36a860c26a732a130f366e3a4813ae473792767c80
+  data.tar.gz: d8e1653acbeefd69c46714db994da4a22169dc48f9f68a6c6c02f6aea3fd4b28cae7b67f38ee59fff3333af5d6ced489818a4641a5e113317d8a2fd5b52112cf

data/.ruby-gemset

@@ -0,0 +1 @@
+ruby_peter_v

data/.ruby-version

@@ -0,0 +1 @@
+ruby-2.0.0

data/HISTORY.txt

@@ -48,5 +48,10 @@
 
 * fix truncate_utf8(max_byte_size) to also work on JRuby
 
+0.0.12 (2013-10-16)
+
+* refactor
+* add validation on attribute in SetOnce
+
 TODO
 * Object#assert_keys_in

data/lib/ruby_peter_v/set_once.rb

@@ -3,14 +3,27 @@ class RubyPeterV::SetOnceError < StandardError ; end
 class Object
 
   def set_once(attribute, value)
-    ivar_symbol = :"@#{attribute}"
+    ivar_symbol = ivar_symbol(attribute)
     instance_value = instance_variable_get(ivar_symbol)
-    if (instance_value && instance_value != value)
+    validate_immutable(attribute, instance_value, value)
+    instance_variable_set(ivar_symbol, value)
+  end
+
+private
+
+  def ivar_symbol(attribute)
+    unless attribute.is_a?(Symbol)
+      raise(ArgumentError, 'first argument must be a symbol for the attribute')
+    end
+    :"@#{attribute}"
+  end
+
+  def validate_immutable(attribute, old_value, new_value)
+    if (old_value && old_value != new_value)
       raise(
         RubyPeterV::SetOnceError,
-        "Value of #{attribute} was #{instance_value}, trying to set it to #{value}")
+        "Value of #{attribute} was #{old_value}, trying to set it to #{new_value}")
     end
-    instance_variable_set(:"@#{attribute}", value)
   end
 
 end

data/lib/ruby_peter_v/version.rb

@@ -1,3 +1,3 @@
 module RubyPeterV
-  VERSION = "0.0.11"
+  VERSION = "0.0.12"
 end

data/spec/lib/ruby_peter_v/set_once_spec.rb

@@ -4,6 +4,12 @@ describe "set_once" do
 
   let(:subject) { Object.new }
 
+  it 'raises ArgumentError when the attribute argument is not a symbol' do
+    lambda { subject.set_once(nil, 10) } . should raise_error(
+      ArgumentError,
+      'first argument must be a symbol for the attribute')
+  end
+
   it "can be set when nil" do
     subject.instance_variable_get(:@attr).should be_nil # assert pre-condition
     value = 10

data/spec/lib/ruby_peter_v/truncate_utf8_spec.rb

@@ -3,6 +3,16 @@ require 'spec_helper'
 
 describe 'truncate_utf8' do
 
+  context 'edge cases' do
+    it 'works on empty string' do
+      ''.truncate_utf8(140).should == ''
+    end
+
+    it 'works with max_byte_size = 0 ' do
+      'AA'.truncate_utf8(0).should == ''
+    end
+  end
+
   context 'ASCII only' do
 
     let (:a120) { 'A' * 120 }

metadata

@@ -1,80 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: ruby_peter_v
 version: !ruby/object:Gem::Version
-  prerelease:
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - Peter Vandenabeele
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-08 00:00:00.000000000 Z
+date: 2013-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '2'
-    none: false
-  requirement: !ruby/object:Gem::Requirement
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '2'
-    none: false
-  prerelease: false
-  type: :development
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-    none: false
-  requirement: !ruby/object:Gem::Requirement
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-    none: false
-  prerelease: false
-  type: :development
 - !ruby/object:Gem::Dependency
   name: rb-fsevent
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
-    none: false
-  requirement: !ruby/object:Gem::Requirement
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
-    none: false
-  prerelease: false
-  type: :development
 - !ruby/object:Gem::Dependency
   name: terminal-notifier-guard
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-    none: false
-  requirement: !ruby/object:Gem::Requirement
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-    none: false
-  prerelease: false
-  type: :development
 description: Ruby helpers for @peter_v
 email:
 - peter@vandenabeele.com
@@ -84,7 +75,8 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
-- .rvmrc
+- .ruby-gemset
+- .ruby-version
 - .travis.yml
 - Gemfile
 - Guardfile
@@ -108,7 +100,8 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/petervandenabeele/ruby_peter_v
 licenses: []
-post_install_message:
+metadata: {}
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -117,18 +110,16 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-  none: false
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-  none: false
 requirements: []
-rubyforge_project:
-rubygems_version: 1.8.24
-signing_key:
-specification_version: 3
+rubyforge_project: 
+rubygems_version: 2.0.3
+signing_key: 
+specification_version: 4
 summary: Ruby helpers for @peter_v
 test_files:
 - spec/lib/ruby_peter_v/define_equality_spec.rb

data/.rvmrc

@@ -1 +0,0 @@
-rvm use --create 2.0.0@ruby_peter_v